leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: gadget: inode: switch over to memdup_user()

Browse Source 
This patch fixes the following Coccinelle warning:

drivers/usb/gadget/inode.c:442:8-15: WARNING \
	opportunity for memdup_user

Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Felipe Balbi 2014-03-10 13:30:55 -05:00 committed by Greg Kroah-Hartman
parent f3c7364982
commit 3b74c73f8d
1 changed files with 3 additions and 6 deletions

9
drivers/usb/gadget/inode.c
View File

@ -439,11 +439,9 @@ ep_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
/* FIXME writebehind for O_NONBLOCK and poll(), qlen = 1 */ /* FIXME writebehind for O_NONBLOCK and poll(), qlen = 1 */
value = -ENOMEM; value = -ENOMEM;
kbuf = kmalloc (len, GFP_KERNEL); kbuf = memdup_user(buf, len);
if (!kbuf) if (!kbuf) {
goto free1; value = PTR_ERR(kbuf);
if (copy_from_user (kbuf, buf, len)) {
value = -EFAULT;
goto free1; goto free1;
} }
@ -452,7 +450,6 @@ ep_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
data->name, len, (int) value); data->name, len, (int) value);
free1: free1:
mutex_unlock(&data->lock); mutex_unlock(&data->lock);
kfree (kbuf);
return value; return value;
} }