leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bonding: change bond_create_proc_entry() to return void

Browse Source 
The function bond_create_proc_entry is currently of type int.

Two versions of this function exist:

The one in the ifdef CONFIG_PROC_FS branch always return 0.
The one in the else branch (which is empty) return nothing.

When CONFIG_PROC_FS is undef, this cause the following warning:

drivers/net/bonding/bond_main.c: In function `bond_create_proc_entry':
drivers/net/bonding/bond_main.c:3393: warning: control reaches end of
non-void function

No caller of this function use the returned value.

So change the returned type from int to void and remove the
useless return 0; .

Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Reported-by: Rakib Mullick <rakib.mullick@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Nicolas de Pesloüan 2009-10-13 00:45:06 -07:00 committed by David S. Miller
parent c634263df5
commit 38fc0026da
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/bonding/bond_main.c
View File

@ -3375,7 +3375,7 @@ static const struct file_operations bond_info_fops = {
.release = seq_release, .release = seq_release,
}; };
static int bond_create_proc_entry(struct bonding *bond) static void bond_create_proc_entry(struct bonding *bond)
{ {
struct net_device *bond_dev = bond->dev; struct net_device *bond_dev = bond->dev;
@ -3390,8 +3390,6 @@ static int bond_create_proc_entry(struct bonding *bond)
else else
memcpy(bond->proc_file_name, bond_dev->name, IFNAMSIZ); memcpy(bond->proc_file_name, bond_dev->name, IFNAMSIZ);
} }
return 0;
} }
static void bond_remove_proc_entry(struct bonding *bond) static void bond_remove_proc_entry(struct bonding *bond)
@ -3430,7 +3428,7 @@ static void bond_destroy_proc_dir(void)
#else /* !CONFIG_PROC_FS */ #else /* !CONFIG_PROC_FS */
static int bond_create_proc_entry(struct bonding *bond) static void bond_create_proc_entry(struct bonding *bond)
{ {
} }