leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ASoC: soc-component: add snd_soc_component_close()

Browse Source 
Current ALSA SoC is directly using component->driver->ops->xxx,
thus, it is deep nested, and makes code difficult to read,
and is not good for encapsulation.
This patch adds new snd_soc_component_close() and use it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87ef2d5rnr.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Kuninori Morimoto 2019-07-26 13:50:07 +09:00 committed by Mark Brown
parent ae2f484928
commit 3672beb8ca
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
3 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/sound/soc-component.h
View File

@ -341,5 +341,7 @@ int snd_soc_component_force_enable_pin_unlocked(
/* component driver ops */
int snd_soc_component_open(struct snd_soc_component *component,
struct snd_pcm_substream *substream);
int snd_soc_component_close(struct snd_soc_component *component,
struct snd_pcm_substream *substream);
#endif /* __SOC_COMPONENT_H */

10
sound/soc/soc-component.c
View File

@ -295,3 +295,13 @@ int snd_soc_component_open(struct snd_soc_component *component,
return 0;
}
int snd_soc_component_close(struct snd_soc_component *component,
struct snd_pcm_substream *substream)
{
if (component->driver->ops &&
component->driver->ops->close)
return component->driver->ops->close(substream);
return 0;
}

8
sound/soc/soc-pcm.c
View File

@ -465,6 +465,7 @@ static int soc_pcm_components_close(struct snd_pcm_substream *substream,
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct snd_soc_rtdcom_list *rtdcom;
struct snd_soc_component *component;
int ret = 0;
for_each_rtdcom(rtd, rtdcom) {
component = rtdcom->component;
@ -472,14 +473,11 @@ static int soc_pcm_components_close(struct snd_pcm_substream *substream,
if (component == last)
break;
if (component->driver->ops &&
component->driver->ops->close)
component->driver->ops->close(substream);
ret |= snd_soc_component_close(component, substream);
snd_soc_component_module_put_when_close(component);
}
return 0;
return ret;
}
/*