leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] uvcvideo: Return -EACCES when trying to access a read/write-only control

Browse Source 
The proper return code according to the V4L2 specification is -EACCES,
not -EINVAL.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Laurent Pinchart
2012-08-28 18:38:58 -03:00
committed by Mauro Carvalho Chehab
parent f0ed2ce840
commit 30ecb936cb
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/usb/uvc/uvc_ctrl.c
View File

@@ -927,7 +927,7 @@ static int __uvc_ctrl_get(struct uvc_video_chain *chain,
int ret; int ret;
if ((ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR) == 0) if ((ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR) == 0)
return -EINVAL; return -EACCES;
if (!ctrl->loaded) { if (!ctrl->loaded) {
ret = uvc_query_ctrl(chain->dev, UVC_GET_CUR, ctrl->entity->id, ret = uvc_query_ctrl(chain->dev, UVC_GET_CUR, ctrl->entity->id,
@@ -1435,7 +1435,7 @@ int uvc_ctrl_set(struct uvc_video_chain *chain,
if (ctrl == NULL) if (ctrl == NULL)
return -ENOENT; return -ENOENT;
if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR))
return -EINVAL; return -EACCES;
/* Clamp out of range values. */ /* Clamp out of range values. */
switch (mapping->v4l2_type) { switch (mapping->v4l2_type) {