leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target: Deletion of unnecessary checks before the function call "module_put"

Browse Source 
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Markus Elfring 2014-11-21 10:25:45 +01:00 committed by Nicholas Bellinger
parent e7b7af6e98
commit 2ed37f6c9b
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/target/iscsi/iscsi_target_transport.c
View File

@ -26,8 +26,7 @@ struct iscsit_transport *iscsit_get_transport(int type)
void iscsit_put_transport(struct iscsit_transport *t) void iscsit_put_transport(struct iscsit_transport *t)
{ {
if (t->owner) module_put(t->owner);
module_put(t->owner);
} }
int iscsit_register_transport(struct iscsit_transport *t) int iscsit_register_transport(struct iscsit_transport *t)

6
drivers/target/target_core_hba.c
View File

@ -137,8 +137,7 @@ core_alloc_hba(const char *plugin_name, u32 plugin_dep_id, u32 hba_flags)
return hba; return hba;
out_module_put: out_module_put:
if (hba->transport->owner) module_put(hba->transport->owner);
module_put(hba->transport->owner);
hba->transport = NULL; hba->transport = NULL;
out_free_hba: out_free_hba:
kfree(hba); kfree(hba);
@ -159,8 +158,7 @@ core_delete_hba(struct se_hba *hba)
pr_debug("CORE_HBA[%d] - Detached HBA from Generic Target" pr_debug("CORE_HBA[%d] - Detached HBA from Generic Target"
" Core\n", hba->hba_id); " Core\n", hba->hba_id);
if (hba->transport->owner) module_put(hba->transport->owner);
module_put(hba->transport->owner);
hba->transport = NULL; hba->transport = NULL;
kfree(hba); kfree(hba);