leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mtd: nand: pxa3xx: Use chip->cmdfunc instead of the internal

Browse Source 
Whenever possible, it's always better to use the generic chip->cmdfunc
instead of the internal pxa3xx_nand_cmdfunc().
In this particular case, this will allow to have multiple cmdfunc()
implementations for different SoC variants.

Reviewed-by: Huang Shijie <shijie8@gmail.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Tested-by: Daniel Mack <zonque@gmail.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
This commit is contained in:
Ezequiel Garcia
2013-11-07 12:17:15 -03:00
committed by Brian Norris
parent c7e9c7e71b
commit 2d79ab16f5
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/mtd/nand/pxa3xx_nand.c
View File

@@ -1011,14 +1011,18 @@ static void pxa3xx_nand_free_buff(struct pxa3xx_nand_info *info)
static int pxa3xx_nand_sensing(struct pxa3xx_nand_info *info) static int pxa3xx_nand_sensing(struct pxa3xx_nand_info *info)
{ {
struct mtd_info *mtd; struct mtd_info *mtd;
struct nand_chip *chip;
int ret; int ret;
mtd = info->host[info->cs]->mtd; mtd = info->host[info->cs]->mtd;
chip = mtd->priv;
/* use the common timing to make a try */ /* use the common timing to make a try */
ret = pxa3xx_nand_config_flash(info, &builtin_flash_types[0]); ret = pxa3xx_nand_config_flash(info, &builtin_flash_types[0]);
if (ret) if (ret)
return ret; return ret;
pxa3xx_nand_cmdfunc(mtd, NAND_CMD_RESET, 0, 0); chip->cmdfunc(mtd, NAND_CMD_RESET, 0, 0);
if (info->is_ready) if (info->is_ready)
return 0; return 0;