leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf tools: Move TUI-specific fields into unnamed union

Browse Source 
Since perf diff only supports stdio output, TUI fields are only accessed
from perf report (or perf top).  So add a new unnamed union and move
struct hist_entry_tui and those TUI-specific fields.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1429687101-4360-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Namhyung Kim 2015-04-22 16:18:12 +09:00 committed by Arnaldo Carvalho de Melo
parent a923e2c4b1
commit 2975082165
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tools/perf/util/sort.h
View File

@ -93,18 +93,24 @@ struct hist_entry {
s32 cpu; s32 cpu;
u8 cpumode; u8 cpumode;
struct hist_entry_diff diff;
/* We are added by hists__add_dummy_entry. */ /* We are added by hists__add_dummy_entry. */
bool dummy; bool dummy;
/* XXX These two should move to some tree widget lib */
u16 row_offset;
u16 nr_rows;
bool init_have_children; bool init_have_children;
char level; char level;
u8 filtered; u8 filtered;
union {
/*
* Since perf diff only supports the stdio output, TUI
* fields are only accessed from perf report (or perf
* top). So make it an union to reduce memory usage.
*/
struct hist_entry_diff diff;
struct /* for TUI */ {
u16 row_offset;
u16 nr_rows;
};
};
char *srcline; char *srcline;
struct symbol *parent; struct symbol *parent;
struct rb_root sorted_chain; struct rb_root sorted_chain;