leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

platform/x86: fujitsu-laptop: break up complex loop condition

Browse Source 
The loop condition in acpi_fujitsu_hotkey_release() includes an
assignment, a four-argument function call and a comparison, making it
hard to read.  Separate the assignment from the comparison to improve
readability.

Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Acked-by: Jonathan Woithe <jwoithe@just42.net>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
This commit is contained in:
Michał Kępień 2017-01-11 09:59:32 +01:00 committed by Darren Hart
parent 2451d19d5d
commit 29544f03e5
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/platform/x86/fujitsu-laptop.c
View File

@ -1059,11 +1059,13 @@ static void acpi_fujitsu_hotkey_release(void)
struct input_dev *input = fujitsu_hotkey->input; struct input_dev *input = fujitsu_hotkey->input;
int keycode, status; int keycode, status;
while ((status = kfifo_out_locked(&fujitsu_hotkey->fifo, while (true) {
status = kfifo_out_locked(&fujitsu_hotkey->fifo,
(unsigned char *)&keycode, (unsigned char *)&keycode,
sizeof(keycode), sizeof(keycode),
&fujitsu_hotkey->fifo_lock)) &fujitsu_hotkey->fifo_lock);
== sizeof(keycode)) { if (status != sizeof(keycode))
return;
input_report_key(input, keycode, 0); input_report_key(input, keycode, 0);
input_sync(input); input_sync(input);
vdbg_printk(FUJLAPTOP_DBG_TRACE, vdbg_printk(FUJLAPTOP_DBG_TRACE,