leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/net/irda/irda-usb.c: fix buffer overflow

Browse Source 
Taken from http://bugzilla.kernel.org/show_bug.cgi?id=12397

We're doing an sprintf of an 11-char string into an 11-char buffer. 
Whoops.  It breaks firmware uploading.

Reported-by: Jos-Vicente Gilabert <josevteg@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jos-Vicente Gilabert 2009-01-14 20:55:00 -08:00 committed by David S. Miller
parent 6f70340698
commit 2950e95292
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/irda/irda-usb.c
View File

@ -1073,7 +1073,7 @@ static int stir421x_patch_device(struct irda_usb_cb *self)
{ {
unsigned int i; unsigned int i;
int ret; int ret;
char stir421x_fw_name[11]; char stir421x_fw_name[12];
const struct firmware *fw; const struct firmware *fw;
const unsigned char *fw_version_ptr; /* pointer to version string */ const unsigned char *fw_version_ptr; /* pointer to version string */
unsigned long fw_version = 0; unsigned long fw_version = 0;