leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: msm: tvenc: fix error handling

Browse Source 
Driver init() function should return error code.
Also fix tvenc_clk leak.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Vasiliy Kulikov 2010-11-26 20:06:53 +03:00 committed by Greg Kroah-Hartman
parent 8956110dbb
commit 280740a901
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/msm/tvenc.c
View File

@ -279,12 +279,13 @@ static int __init tvenc_driver_init(void)
if (IS_ERR(tvenc_clk)) { if (IS_ERR(tvenc_clk)) {
printk(KERN_ERR "error: can't get tvenc_clk!\n"); printk(KERN_ERR "error: can't get tvenc_clk!\n");
return IS_ERR(tvenc_clk); return PTR_ERR(tvenc_clk);
} }
if (IS_ERR(tvdac_clk)) { if (IS_ERR(tvdac_clk)) {
printk(KERN_ERR "error: can't get tvdac_clk!\n"); printk(KERN_ERR "error: can't get tvdac_clk!\n");
return IS_ERR(tvdac_clk); clk_put(tvenc_clk);
return PTR_ERR(tvdac_clk);
} }
// pm_qos_add_requirement(PM_QOS_SYSTEM_BUS_FREQ , "tvenc", // pm_qos_add_requirement(PM_QOS_SYSTEM_BUS_FREQ , "tvenc",