leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/cirrus: Remove unnecessary NULL check in bo_unref

Browse Source 
ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Daniel Vetter 2014-04-05 10:09:36 +02:00
parent 4cb8802e28
commit 275c632227
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/cirrus/cirrus_main.c
View File

@ -264,9 +264,7 @@ static void cirrus_bo_unref(struct cirrus_bo **bo)
tbo = &((*bo)->bo); tbo = &((*bo)->bo);
ttm_bo_unref(&tbo); ttm_bo_unref(&tbo);
if (tbo == NULL) *bo = NULL;
*bo = NULL;
} }
void cirrus_gem_free_object(struct drm_gem_object *obj) void cirrus_gem_free_object(struct drm_gem_object *obj)