leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

f2fs: fix to avoid accessing invalid fio in f2fs_allocate_data_block()

Browse Source 
Callers may pass fio parameter with NULL value to f2fs_allocate_data_block(),
so we should make sure accessing fio's field after fio's validation check.

Fixes: f608c38c59 ("f2fs: clean up parameter of f2fs_allocate_data_block()")
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
Chao Yu
2021-04-02 17:22:23 +08:00
committed by Jaegeuk Kim
parent a303b0ac92
commit 25ae837e61
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fs/f2fs/segment.c
View File

@@ -3417,12 +3417,12 @@ void f2fs_allocate_data_block(struct f2fs_sb_info *sbi, struct page *page,
f2fs_inode_chksum_set(sbi, page); f2fs_inode_chksum_set(sbi, page);
} }
if (F2FS_IO_ALIGNED(sbi))
fio->retry = false;
if (fio) { if (fio) {
struct f2fs_bio_info *io; struct f2fs_bio_info *io;
if (F2FS_IO_ALIGNED(sbi))
fio->retry = false;
INIT_LIST_HEAD(&fio->list); INIT_LIST_HEAD(&fio->list);
fio->in_list = true; fio->in_list = true;
io = sbi->write_io[fio->type] + fio->temp; io = sbi->write_io[fio->type] + fio->temp;