leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

batman-adv: checkpatch - else is not generally useful after a break or return

Browse Source 
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
This commit is contained in:
Antonio Quartulli 2014-09-01 14:37:25 +02:00
parent a0e2877505
commit 24820df144
4 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/batman-adv/bitarray.h
View File

@ -29,8 +29,7 @@ static inline int batadv_test_bit(const unsigned long *seq_bits,
diff = last_seqno - curr_seqno; diff = last_seqno - curr_seqno;
if (diff < 0 || diff >= BATADV_TQ_LOCAL_WINDOW_SIZE) if (diff < 0 || diff >= BATADV_TQ_LOCAL_WINDOW_SIZE)
return 0; return 0;
else return test_bit(diff, seq_bits) != 0;
return test_bit(diff, seq_bits) != 0;
} }
/* turn corresponding bit on, so we can remember that we got the packet */ /* turn corresponding bit on, so we can remember that we got the packet */

3
net/batman-adv/fragmentation.h
View File

@ -41,8 +41,7 @@ batadv_frag_check_entry(struct batadv_frag_table_entry *frags_entry)
if (!hlist_empty(&frags_entry->head) && if (!hlist_empty(&frags_entry->head) &&
batadv_has_timed_out(frags_entry->timestamp, BATADV_FRAG_TIMEOUT)) batadv_has_timed_out(frags_entry->timestamp, BATADV_FRAG_TIMEOUT))
return true; return true;
else return false;
return false;
} }
#endif /* _NET_BATMAN_ADV_FRAGMENTATION_H_ */ #endif /* _NET_BATMAN_ADV_FRAGMENTATION_H_ */

3
net/batman-adv/network-coding.c
View File

@ -1212,8 +1212,7 @@ static bool batadv_nc_skb_coding_possible(struct sk_buff *skb,
{ {
if (BATADV_SKB_CB(skb)->decoded && !batadv_compare_eth(dst, src)) if (BATADV_SKB_CB(skb)->decoded && !batadv_compare_eth(dst, src))
return false; return false;
else return true;
return true;
} }
/** /**

5
net/batman-adv/translation-table.c
View File

@ -2769,9 +2769,8 @@ static bool batadv_send_tt_response(struct batadv_priv *bat_priv,
{ {
if (batadv_is_my_mac(bat_priv, req_dst)) if (batadv_is_my_mac(bat_priv, req_dst))
return batadv_send_my_tt_response(bat_priv, tt_data, req_src); return batadv_send_my_tt_response(bat_priv, tt_data, req_src);
else return batadv_send_other_tt_response(bat_priv, tt_data, req_src,
return batadv_send_other_tt_response(bat_priv, tt_data, req_dst);
req_src, req_dst);
} }
static void _batadv_tt_update_changes(struct batadv_priv *bat_priv, static void _batadv_tt_update_changes(struct batadv_priv *bat_priv,