leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

jffs2: Use kzalloc instead of kmalloc/memset

Browse Source 
Use kzalloc rather than duplicating its implementation, which
makes code simple and easy to understand.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
[rw: Fixed printk string]
Signed-off-by: Richard Weinberger <richard@nod.at>
This commit is contained in:
Haowen Bai 2022-04-18 18:18:07 +08:00 committed by Richard Weinberger
parent 42226c9897
commit 22abf318c3
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/jffs2/erase.c
View File

@ -43,9 +43,9 @@ static void jffs2_erase_block(struct jffs2_sb_info *c,
jffs2_dbg(1, "%s(): erase block %#08x (range %#08x-%#08x)\n", jffs2_dbg(1, "%s(): erase block %#08x (range %#08x-%#08x)\n",
__func__, __func__,
jeb->offset, jeb->offset, jeb->offset + c->sector_size); jeb->offset, jeb->offset, jeb->offset + c->sector_size);
instr = kmalloc(sizeof(struct erase_info), GFP_KERNEL); instr = kzalloc(sizeof(struct erase_info), GFP_KERNEL);
if (!instr) { if (!instr) {
pr_warn("kmalloc for struct erase_info in jffs2_erase_block failed. Refiling block for later\n"); pr_warn("kzalloc for struct erase_info in jffs2_erase_block failed. Refiling block for later\n");
mutex_lock(&c->erase_free_sem); mutex_lock(&c->erase_free_sem);
spin_lock(&c->erase_completion_lock); spin_lock(&c->erase_completion_lock);
list_move(&jeb->list, &c->erase_pending_list); list_move(&jeb->list, &c->erase_pending_list);
@ -57,8 +57,6 @@ static void jffs2_erase_block(struct jffs2_sb_info *c,
return; return;
} }
memset(instr, 0, sizeof(*instr));
instr->addr = jeb->offset; instr->addr = jeb->offset;
instr->len = c->sector_size; instr->len = c->sector_size;