leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Audit: only set group mask when something is being watched

Browse Source 
Currently the audit watch group always sets a mask equal to all events it
might care about.  We instead should only set the group mask if we are
actually watching inodes.  This should be a perf win when audit watches are
compiled in.

Signed-off-by: Eric Paris <eparis@redhat.com>
This commit is contained in:
Eric Paris 2009-12-17 21:24:22 -05:00
parent ffab83402f
commit 220d14df0d
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
kernel/audit_watch.c
View File

@ -167,6 +167,8 @@ static struct audit_parent *audit_init_parent(struct nameidata *ndp)
return ERR_PTR(ret); return ERR_PTR(ret);
} }
fsnotify_recalc_group_mask(audit_watch_group);
return parent; return parent;
} }
@ -353,6 +355,9 @@ static void audit_remove_parent_watches(struct audit_parent *parent)
mutex_unlock(&audit_filter_mutex); mutex_unlock(&audit_filter_mutex);
fsnotify_destroy_mark_by_entry(&parent->mark); fsnotify_destroy_mark_by_entry(&parent->mark);
fsnotify_recalc_group_mask(audit_watch_group);
} }
/* Get path information necessary for adding watches. */ /* Get path information necessary for adding watches. */
@ -503,6 +508,9 @@ void audit_remove_watch_rule(struct audit_krule *krule)
audit_put_parent(parent); audit_put_parent(parent);
} }
} }
fsnotify_recalc_group_mask(audit_watch_group);
} }
static bool audit_watch_should_send_event(struct fsnotify_group *group, struct inode *inode, static bool audit_watch_should_send_event(struct fsnotify_group *group, struct inode *inode,
@ -577,8 +585,7 @@ static const struct fsnotify_ops audit_watch_fsnotify_ops = {
static int __init audit_watch_init(void) static int __init audit_watch_init(void)
{ {
audit_watch_group = fsnotify_alloc_group(AUDIT_FS_WATCH, audit_watch_group = fsnotify_alloc_group(0, &audit_watch_fsnotify_ops);
&audit_watch_fsnotify_ops);
if (IS_ERR(audit_watch_group)) { if (IS_ERR(audit_watch_group)) {
audit_watch_group = NULL; audit_watch_group = NULL;
audit_panic("cannot create audit fsnotify group"); audit_panic("cannot create audit fsnotify group");