leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gfs2: rename gfs2_write_full_page to gfs2_write_jdata_page, remove parm

Browse Source 
Since the function is only used for writing jdata pages, this patch
simply renames function gfs2_write_full_page to a more appropriate
name: gfs2_write_jdata_page. This makes the code easier to understand.

The function was only called in one place, which passed in a pointer to
function gfs2_get_block_noalloc. The function doesn't need to be
passed in. Therefore, this also eliminates the unnecessary parameter
to increase efficiency.

I also took the liberty of cleaning up the function comments.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
This commit is contained in:
Bob Peterson 2020-07-22 11:51:09 -05:00 committed by Andreas Gruenbacher
parent 0ddc5154b2
commit 21b6924bb7
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
fs/gfs2/aops.c
View File

@ -106,11 +106,16 @@ out:
return 0; return 0;
} }
/* This is the same as calling block_write_full_page, but it also /**
* gfs2_write_jdata_page - gfs2 jdata-specific version of block_write_full_page
* @page: The page to write
* @wbc: The writeback control
*
* This is the same as calling block_write_full_page, but it also
* writes pages outside of i_size * writes pages outside of i_size
*/ */
static int gfs2_write_full_page(struct page *page, get_block_t *get_block, static int gfs2_write_jdata_page(struct page *page,
struct writeback_control *wbc) struct writeback_control *wbc)
{ {
struct inode * const inode = page->mapping->host; struct inode * const inode = page->mapping->host;
loff_t i_size = i_size_read(inode); loff_t i_size = i_size_read(inode);
@ -128,7 +133,7 @@ static int gfs2_write_full_page(struct page *page, get_block_t *get_block,
if (page->index == end_index && offset) if (page->index == end_index && offset)
zero_user_segment(page, offset, PAGE_SIZE); zero_user_segment(page, offset, PAGE_SIZE);
return __block_write_full_page(inode, page, get_block, wbc, return __block_write_full_page(inode, page, gfs2_get_block_noalloc, wbc,
end_buffer_async_write); end_buffer_async_write);
} }
@ -157,7 +162,7 @@ static int __gfs2_jdata_writepage(struct page *page, struct writeback_control *w
} }
gfs2_page_add_databufs(ip, page, 0, sdp->sd_vfs->s_blocksize); gfs2_page_add_databufs(ip, page, 0, sdp->sd_vfs->s_blocksize);
} }
return gfs2_write_full_page(page, gfs2_get_block_noalloc, wbc); return gfs2_write_jdata_page(page, wbc);
} }
/** /**