leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: gadget: dummy_hcd: fix null-deref free req

Browse Source 
_ep to ep is a pointer substraction so ep won't be zero unless _ep was
8. This was not intendent by the author, it was probably a typo while
checking for NULL of the argument.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Sebastian Andrzej Siewior 2012-01-25 15:18:58 +01:00 committed by Felipe Balbi
parent 3cf0ad02e4
commit 20edfbb6a1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/gadget/dummy_hcd.c
View File

@ -599,8 +599,10 @@ static void dummy_free_request(struct usb_ep *_ep, struct usb_request *_req)
struct dummy_ep *ep;
struct dummy_request *req;
if (!_ep || !_req)
return;
ep = usb_ep_to_dummy_ep(_ep);
if (!ep || !_req || (!ep->desc && _ep->name != ep0name))
if (!ep->desc && _ep->name != ep0name)
return;
req = usb_request_to_dummy_request(_req);