forked from Minki/linux
irqchip/irq-rda-intc: Fix return value check in rda8810_intc_init()
In case of error, the function of_io_request_and_map() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Fixes: d852e62ad6
("irqchip: Add RDA8810PL interrupt driver")
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
This commit is contained in:
parent
893b0aff9a
commit
1fb51c975a
|
@ -85,8 +85,8 @@ static int __init rda8810_intc_init(struct device_node *node,
|
||||||
struct device_node *parent)
|
struct device_node *parent)
|
||||||
{
|
{
|
||||||
rda_intc_base = of_io_request_and_map(node, 0, "rda-intc");
|
rda_intc_base = of_io_request_and_map(node, 0, "rda-intc");
|
||||||
if (!rda_intc_base)
|
if (IS_ERR(rda_intc_base))
|
||||||
return -ENXIO;
|
return PTR_ERR(rda_intc_base);
|
||||||
|
|
||||||
/* Mask all interrupt sources */
|
/* Mask all interrupt sources */
|
||||||
writel_relaxed(RDA_IRQ_MASK_ALL, rda_intc_base + RDA_INTC_MASK_CLR);
|
writel_relaxed(RDA_IRQ_MASK_ALL, rda_intc_base + RDA_INTC_MASK_CLR);
|
||||||
|
|
Loading…
Reference in New Issue
Block a user