leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pinctrl: sirf: atlas7: use struct_size() in devm_kzalloc()

Browse Source 
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Gustavo A. R. Silva 2019-01-04 15:35:08 -06:00 committed by Linus Walleij
parent 16f4372fd7
commit 1e11820f72
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pinctrl/sirf/pinctrl-atlas7.c
View File

@ -6007,8 +6007,8 @@ static int atlas7_gpio_probe(struct platform_device *pdev)
}
/* retrieve gpio descriptor data */
a7gc = devm_kzalloc(&pdev->dev, sizeof(*a7gc) +
sizeof(struct atlas7_gpio_bank) * nbank, GFP_KERNEL);
a7gc = devm_kzalloc(&pdev->dev, struct_size(a7gc, banks, nbank),
GFP_KERNEL);
if (!a7gc)
return -ENOMEM;