leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scsi: NCR5380: Clear all unissued commands on host reset

Browse Source 
When doing a host reset we should be clearing all outstanding commands, not
just the command triggering the reset.

[mkp: adjusted Hannes' SoB address]

Signed-off-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Ondrey Zary <linux@rainbow-software.org>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Hannes Reinecke 2018-09-27 11:17:11 +10:00 committed by Martin K. Petersen
parent 90ded4e200
commit 1aeeeed7f0
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/scsi/NCR5380.c
View File

@ -2308,7 +2308,7 @@ static int NCR5380_host_reset(struct scsi_cmnd *cmd)
spin_lock_irqsave(&hostdata->lock, flags); spin_lock_irqsave(&hostdata->lock, flags);
#if (NDEBUG & NDEBUG_ANY) #if (NDEBUG & NDEBUG_ANY)
scmd_printk(KERN_INFO, cmd, __func__); shost_printk(KERN_INFO, instance, __func__);
#endif #endif
NCR5380_dprint(NDEBUG_ANY, instance); NCR5380_dprint(NDEBUG_ANY, instance);
NCR5380_dprint_phase(NDEBUG_ANY, instance); NCR5380_dprint_phase(NDEBUG_ANY, instance);
@ -2326,10 +2326,13 @@ static int NCR5380_host_reset(struct scsi_cmnd *cmd)
* commands! * commands!
*/ */
if (list_del_cmd(&hostdata->unissued, cmd)) { list_for_each_entry(ncmd, &hostdata->unissued, list) {
struct scsi_cmnd *cmd = NCR5380_to_scmd(ncmd);
cmd->result = DID_RESET << 16; cmd->result = DID_RESET << 16;
cmd->scsi_done(cmd); cmd->scsi_done(cmd);
} }
INIT_LIST_HEAD(&hostdata->unissued);
if (hostdata->selecting) { if (hostdata->selecting) {
hostdata->selecting->result = DID_RESET << 16; hostdata->selecting->result = DID_RESET << 16;