leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libata: clear drvdata in ata_host_release(), take#2

Browse Source 
Clearing drvdata in ->remove_one causes NULL pointer deference.  Clear
drvdata only in ata_host_release() after all resources are freed.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Tejun Heo 2007-02-27 22:33:21 +09:00 committed by Jeff Garzik
parent 7b965e0884
commit 1aa56cca5b
4 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/ata/libata-core.c
View File

@ -5680,6 +5680,8 @@ static void ata_host_release(struct device *gendev, void *res)
if (host->ops->host_stop) if (host->ops->host_stop)
host->ops->host_stop(host); host->ops->host_stop(host);
dev_set_drvdata(gendev, NULL);
} }
/** /**
@ -5902,7 +5904,6 @@ int ata_device_add(const struct ata_probe_ent *ent)
err_out: err_out:
devres_release_group(dev, ata_device_add); devres_release_group(dev, ata_device_add);
dev_set_drvdata(dev, NULL);
VPRINTK("EXIT, returning %d\n", rc); VPRINTK("EXIT, returning %d\n", rc);
return 0; return 0;
} }

1
drivers/ata/pata_cs5520.c
View File

@ -306,7 +306,6 @@ static void __devexit cs5520_remove_one(struct pci_dev *pdev)
struct ata_host *host = dev_get_drvdata(dev); struct ata_host *host = dev_get_drvdata(dev);
ata_host_detach(host); ata_host_detach(host);
dev_set_drvdata(dev, NULL);
} }
/** /**

1
drivers/ata/pata_isapnp.c
View File

@ -128,7 +128,6 @@ static void isapnp_remove_one(struct pnp_dev *idev)
struct ata_host *host = dev_get_drvdata(dev); struct ata_host *host = dev_get_drvdata(dev);
ata_host_detach(host); ata_host_detach(host);
dev_set_drvdata(dev, NULL);
} }
static struct pnp_device_id isapnp_devices[] = { static struct pnp_device_id isapnp_devices[] = {

1
drivers/ata/pata_platform.c
View File

@ -228,7 +228,6 @@ static int __devexit pata_platform_remove(struct platform_device *pdev)
struct ata_host *host = dev_get_drvdata(dev); struct ata_host *host = dev_get_drvdata(dev);
ata_host_detach(host); ata_host_detach(host);
dev_set_drvdata(dev, NULL);
return 0; return 0;
} }