forked from Minki/linux
kobject: should use kobject_put() in kset-example
We should call kobject_put() instead of kfree() if kobject_init_and_add() returns an error, shouldn't we? Don't set up a bad example ;) Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
a231934bdf
commit
185000fc55
@ -211,7 +211,7 @@ static struct foo_obj *create_foo_obj(const char *name)
|
||||
*/
|
||||
retval = kobject_init_and_add(&foo->kobj, &foo_ktype, NULL, "%s", name);
|
||||
if (retval) {
|
||||
kfree(foo);
|
||||
kobject_put(&foo->kobj);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user