leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/msm: fix potential memleak in error branch

Browse Source 
In function msm_submitqueue_create, the queue is a local
variable, in return -EINVAL branch, queue didn`t add to ctx`s
list yet, and also didn`t kfree, this maybe bring in potential
memleak.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
[trivial commit msg fixup]
Signed-off-by: Rob Clark <robdclark@chromium.org>
This commit is contained in:
Bernard Zhao
2020-06-12 09:23:49 +08:00
committed by Rob Clark
parent 5fddd4f5db
commit 177d381963
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/msm/msm_submitqueue.c
View File

@@ -71,8 +71,10 @@ int msm_submitqueue_create(struct drm_device *drm, struct msm_file_private *ctx,
queue->flags = flags; queue->flags = flags;
if (priv->gpu) { if (priv->gpu) {
if (prio >= priv->gpu->nr_rings) if (prio >= priv->gpu->nr_rings) {
kfree(queue);
return -EINVAL; return -EINVAL;
}
queue->prio = prio; queue->prio = prio;
} }