leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf evsel: Check if callchain is enabled before setting it up

Browse Source 
The construct:

	if (callchain_param)
		perf_evsel__config_callchain(evsel, opts, &callchain_param);

happens in several places, so make perf_evsel__config_callchain() work
just like free(NULL), do nothing if param->enabled is not set.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Hendrick Brueckner <brueckner@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Thomas Richter <tmricht@linux.vnet.ibm.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-ykk0qzxnxwx3o611ctjnmxav@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo 2018-01-12 16:21:04 -03:00
parent fa1195ccc0
commit 1688c2fdf6
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/perf/util/evsel.c
View File

@ -651,7 +651,7 @@ int perf_evsel__group_desc(struct perf_evsel *evsel, char *buf, size_t size)
return ret; return ret;
} }
void perf_evsel__config_callchain(struct perf_evsel *evsel, static void __perf_evsel__config_callchain(struct perf_evsel *evsel,
struct record_opts *opts, struct record_opts *opts,
struct callchain_param *param) struct callchain_param *param)
{ {
@ -699,6 +699,14 @@ void perf_evsel__config_callchain(struct perf_evsel *evsel,
} }
} }
void perf_evsel__config_callchain(struct perf_evsel *evsel,
struct record_opts *opts,
struct callchain_param *param)
{
if (param->enabled)
return __perf_evsel__config_callchain(evsel, opts, param);
}
static void static void
perf_evsel__reset_callgraph(struct perf_evsel *evsel, perf_evsel__reset_callgraph(struct perf_evsel *evsel,
struct callchain_param *param) struct callchain_param *param)