leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

Browse Source 
Here, If devm_ioremap will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference.
This error check will avoid NULL pointer dereference.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Arvind Yadav
2016-12-15 00:33:30 +05:30
committed by David S. Miller
parent 52f40e9d65
commit 162809dfc2
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
View File

@@ -1469,6 +1469,12 @@ static int octeon_mgmt_probe(struct platform_device *pdev)
p->agl = (u64)devm_ioremap(&pdev->dev, p->agl_phys, p->agl_size); p->agl = (u64)devm_ioremap(&pdev->dev, p->agl_phys, p->agl_size);
p->agl_prt_ctl = (u64)devm_ioremap(&pdev->dev, p->agl_prt_ctl_phys, p->agl_prt_ctl = (u64)devm_ioremap(&pdev->dev, p->agl_prt_ctl_phys,
p->agl_prt_ctl_size); p->agl_prt_ctl_size);
if (!p->mix || !p->agl || !p->agl_prt_ctl) {
dev_err(&pdev->dev, "failed to map I/O memory\n");
result = -ENOMEM;
goto err;
}
spin_lock_init(&p->lock); spin_lock_init(&p->lock);
skb_queue_head_init(&p->tx_list); skb_queue_head_init(&p->tx_list);