leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: dwc3: debug: purge usage of strcat

Browse Source 
Now that buffer size is always passed around, we don't need to rely on
strcat anymore.

Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
This commit is contained in:
Felipe Balbi 2019-02-05 09:00:14 +02:00
parent 7790b3556f
commit 1381a5113c
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/usb/dwc3/debug.h
View File

@ -545,21 +545,25 @@ static inline const char *dwc3_ep_event_string(char *str, size_t size,
status & DEPEVT_STATUS_TRANSFER_ACTIVE ? status & DEPEVT_STATUS_TRANSFER_ACTIVE ?
" (Active)" : " (Not Active)"); " (Active)" : " (Not Active)");
len = strlen(str);
/* Control Endpoints */ /* Control Endpoints */
if (epnum <= 1) { if (epnum <= 1) {
int phase = DEPEVT_STATUS_CONTROL_PHASE(event->status); int phase = DEPEVT_STATUS_CONTROL_PHASE(event->status);
switch (phase) { switch (phase) {
case DEPEVT_STATUS_CONTROL_DATA: case DEPEVT_STATUS_CONTROL_DATA:
strcat(str, " [Data Phase]"); snprintf(str + ret, size - ret,
" [Data Phase]");
break; break;
case DEPEVT_STATUS_CONTROL_STATUS: case DEPEVT_STATUS_CONTROL_STATUS:
strcat(str, " [Status Phase]"); snprintf(str + ret, size - ret,
" [Status Phase]");
} }
} }
break; break;
case DWC3_DEPEVT_RXTXFIFOEVT: case DWC3_DEPEVT_RXTXFIFOEVT:
strcat(str, "FIFO"); snprintf(str + ret, size - ret, "FIFO");
break; break;
case DWC3_DEPEVT_STREAMEVT: case DWC3_DEPEVT_STREAMEVT:
status = event->status; status = event->status;
@ -571,13 +575,13 @@ static inline const char *dwc3_ep_event_string(char *str, size_t size,
break; break;
case DEPEVT_STREAMEVT_NOTFOUND: case DEPEVT_STREAMEVT_NOTFOUND:
default: default:
strcat(str, " Stream Not Found"); snprintf(str + ret, size - ret, " Stream Not Found");
break; break;
} }
break; break;
case DWC3_DEPEVT_EPCMDCMPLT: case DWC3_DEPEVT_EPCMDCMPLT:
strcat(str, "Endpoint Command Complete"); snprintf(str + ret, size - ret, "Endpoint Command Complete");
break; break;
default: default:
snprintf(str, size, "UNKNOWN"); snprintf(str, size, "UNKNOWN");