leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

isdn: icn: use strlcpy() when parsing setup options

Browse Source 
If you pass an invalid string here then you probably deserve the memory
corruption, but it annoys static analysis tools so lets fix it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Carpenter 2015-03-15 13:48:03 +03:00 committed by David S. Miller
parent 7d985ed1dc
commit 10640d3455
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/isdn/icn/icn.c
View File

@ -1609,7 +1609,7 @@ icn_setup(char *line)
if (ints[0] > 1) if (ints[0] > 1)
membase = (unsigned long)ints[2]; membase = (unsigned long)ints[2];
if (str && *str) { if (str && *str) {
strcpy(sid, str); strlcpy(sid, str, sizeof(sid));
icn_id = sid; icn_id = sid;
if ((p = strchr(sid, ','))) { if ((p = strchr(sid, ','))) {
*p++ = 0; *p++ = 0;