leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ALSA] Dereference after free in snd_hwdep_release()

Browse Source 
snd_card_file_remove() may free hw->card so we can't dereference
hw->card->module after that.
Coverity ID 1420.

Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
This commit is contained in:
Florin Malita 2006-09-29 12:55:25 +02:00 committed by Jaroslav Kysela
parent 92b93d3171
commit 104326f8df
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sound/core/hwdep.c
View File

@ -158,6 +158,7 @@ static int snd_hwdep_release(struct inode *inode, struct file * file)
{ {
int err = -ENXIO; int err = -ENXIO;
struct snd_hwdep *hw = file->private_data; struct snd_hwdep *hw = file->private_data;
struct module *mod = hw->card->module;
mutex_lock(&hw->open_mutex); mutex_lock(&hw->open_mutex);
if (hw->ops.release) { if (hw->ops.release) {
err = hw->ops.release(hw, file); err = hw->ops.release(hw, file);
@ -167,7 +168,7 @@ static int snd_hwdep_release(struct inode *inode, struct file * file)
hw->used--; hw->used--;
snd_card_file_remove(hw->card, file); snd_card_file_remove(hw->card, file);
mutex_unlock(&hw->open_mutex); mutex_unlock(&hw->open_mutex);
module_put(hw->card->module); module_put(mod);
return err; return err;
} }