leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i2c: mxs: : use proper DMAENGINE API for termination

Browse Source 
dmaengine_terminate_all() is deprecated in favor of explicitly saying if
it should be sync or async. Here, we want dmaengine_terminate_sync()
because there is no other synchronization code in the driver to handle
an async case.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
This commit is contained in:
Wolfram Sang
2021-06-23 11:59:37 +02:00
committed by Wolfram Sang
parent 73a370cff4
commit 101703ca8e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/i2c/busses/i2c-mxs.c
View File

@@ -290,14 +290,14 @@ read_init_dma_fail:
select_init_dma_fail: select_init_dma_fail:
dma_unmap_sg(i2c->dev, &i2c->sg_io[0], 1, DMA_TO_DEVICE); dma_unmap_sg(i2c->dev, &i2c->sg_io[0], 1, DMA_TO_DEVICE);
select_init_pio_fail: select_init_pio_fail:
dmaengine_terminate_all(i2c->dmach); dmaengine_terminate_sync(i2c->dmach);
return -EINVAL; return -EINVAL;
/* Write failpath. */ /* Write failpath. */
write_init_dma_fail: write_init_dma_fail:
dma_unmap_sg(i2c->dev, i2c->sg_io, 2, DMA_TO_DEVICE); dma_unmap_sg(i2c->dev, i2c->sg_io, 2, DMA_TO_DEVICE);
write_init_pio_fail: write_init_pio_fail:
dmaengine_terminate_all(i2c->dmach); dmaengine_terminate_sync(i2c->dmach);
return -EINVAL; return -EINVAL;
} }