leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xfs: in _attrlist_by_handle, copy the cursor back to userspace

Browse Source 
When we're iterating inode xattrs by handle, we have to copy the
cursor back to userspace so that a subsequent invocation actually
retrieves subsequent contents.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Darrick J. Wong 2016-08-03 10:58:53 +10:00 committed by Dave Chinner
parent f2bdfda9a1
commit 0facef7fb0
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/xfs/xfs_ioctl.c
View File

@ -387,6 +387,7 @@ xfs_attrlist_by_handle(
{ {
int error = -ENOMEM; int error = -ENOMEM;
attrlist_cursor_kern_t *cursor; attrlist_cursor_kern_t *cursor;
struct xfs_fsop_attrlist_handlereq __user *p = arg;
xfs_fsop_attrlist_handlereq_t al_hreq; xfs_fsop_attrlist_handlereq_t al_hreq;
struct dentry *dentry; struct dentry *dentry;
char *kbuf; char *kbuf;
@ -419,6 +420,11 @@ xfs_attrlist_by_handle(
if (error) if (error)
goto out_kfree; goto out_kfree;
if (copy_to_user(&p->pos, cursor, sizeof(attrlist_cursor_kern_t))) {
error = -EFAULT;
goto out_kfree;
}
if (copy_to_user(al_hreq.buffer, kbuf, al_hreq.buflen)) if (copy_to_user(al_hreq.buffer, kbuf, al_hreq.buflen))
error = -EFAULT; error = -EFAULT;