leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

jbd2: jbd2_get_transaction does not need to return a value

Browse Source 
In jbd2_get_transaction, a new transaction is initialized,
and set to the j_running_transaction. No need for a return
value, so remove it.

Also, adjust some comments to match the actual operation
of this function.

Signed-off-by: Liu Song <liu.song11@zte.com.cn>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Liu Song 2019-03-01 00:36:57 -05:00 committed by Theodore Ts'o
parent 6e876c3dd2
commit 0df6f46995
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/jbd2/transaction.c
View File

@ -63,7 +63,7 @@ void jbd2_journal_free_transaction(transaction_t *transaction)
/* /*
* jbd2_get_transaction: obtain a new transaction_t object. * jbd2_get_transaction: obtain a new transaction_t object.
* *
* Simply allocate and initialise a new transaction. Create it in * Simply initialise a new transaction. Initialize it in
* RUNNING state and add it to the current journal (which should not * RUNNING state and add it to the current journal (which should not
* have an existing running transaction: we only make a new transaction * have an existing running transaction: we only make a new transaction
* once we have started to commit the old one). * once we have started to commit the old one).
@ -75,8 +75,8 @@ void jbd2_journal_free_transaction(transaction_t *transaction)
* *
*/ */
static transaction_t * static void jbd2_get_transaction(journal_t *journal,
jbd2_get_transaction(journal_t *journal, transaction_t *transaction) transaction_t *transaction)
{ {
transaction->t_journal = journal; transaction->t_journal = journal;
transaction->t_state = T_RUNNING; transaction->t_state = T_RUNNING;
@ -100,8 +100,6 @@ jbd2_get_transaction(journal_t *journal, transaction_t *transaction)
transaction->t_max_wait = 0; transaction->t_max_wait = 0;
transaction->t_start = jiffies; transaction->t_start = jiffies;
transaction->t_requested = 0; transaction->t_requested = 0;
return transaction;
} }
/* /*