leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xfs: fix xfs_get_extsz_hint for a zero extent size hint

Browse Source 
We can easily set the extsize flag without setting an extent size
hint, or one that evaluates to zero.  Historically the di_extsize
field was only used when it was non-zero, but the commit

	"Cleanup inode extent size hint extraction"

broke this.  Restore the old behaviour, thus fixing xfsqa 090 with
a debug kernel.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
This commit is contained in:
Christoph Hellwig 2011-01-25 09:06:20 +00:00 committed by Alex Elder
parent 04e99455ea
commit 0d8b30ad19
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
fs/xfs/xfs_rw.c
View File

@ -173,17 +173,9 @@ xfs_extlen_t
xfs_get_extsz_hint( xfs_get_extsz_hint(
struct xfs_inode *ip) struct xfs_inode *ip)
{ {
xfs_extlen_t extsz; if ((ip->i_d.di_flags & XFS_DIFLAG_EXTSIZE) && ip->i_d.di_extsize)
return ip->i_d.di_extsize;
if (unlikely(XFS_IS_REALTIME_INODE(ip))) { if (XFS_IS_REALTIME_INODE(ip))
extsz = (ip->i_d.di_flags & XFS_DIFLAG_EXTSIZE) return ip->i_mount->m_sb.sb_rextsize;
? ip->i_d.di_extsize return 0;
: ip->i_mount->m_sb.sb_rextsize;
ASSERT(extsz);
} else {
extsz = (ip->i_d.di_flags & XFS_DIFLAG_EXTSIZE)
? ip->i_d.di_extsize : 0;
}
return extsz;
} }