leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

raw: Add missing annotations to raw_seq_start() and raw_seq_stop()

Browse Source 
Sparse reports warnings at raw_seq_start() and raw_seq_stop()

warning: context imbalance in raw_seq_start() - wrong count at exit
warning: context imbalance in raw_seq_stop() - unexpected unlock

The root cause is the missing annotations at raw_seq_start()
	and raw_seq_stop()
Add the missing __acquires(&h->lock) annotation
Add the missing __releases(&h->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jules Irenge 2020-03-11 01:09:02 +00:00 committed by David S. Miller
parent 4cda75275f
commit 0d8a42c93a
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/ipv4/raw.c
View File

@ -1034,6 +1034,7 @@ static struct sock *raw_get_idx(struct seq_file *seq, loff_t pos)
} }
void *raw_seq_start(struct seq_file *seq, loff_t *pos) void *raw_seq_start(struct seq_file *seq, loff_t *pos)
__acquires(&h->lock)
{ {
struct raw_hashinfo *h = PDE_DATA(file_inode(seq->file)); struct raw_hashinfo *h = PDE_DATA(file_inode(seq->file));
@ -1056,6 +1057,7 @@ void *raw_seq_next(struct seq_file *seq, void *v, loff_t *pos)
EXPORT_SYMBOL_GPL(raw_seq_next); EXPORT_SYMBOL_GPL(raw_seq_next);
void raw_seq_stop(struct seq_file *seq, void *v) void raw_seq_stop(struct seq_file *seq, void *v)
__releases(&h->lock)
{ {
struct raw_hashinfo *h = PDE_DATA(file_inode(seq->file)); struct raw_hashinfo *h = PDE_DATA(file_inode(seq->file));