ALSA: Avoid endless sleep after disconnect
When disconnect callback is called, each component should wake up sleepers and check card->shutdown flag for avoiding the endless sleep blocking the proper resource release. Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
a0830dbd4e
commit
0914f7961b
@ -1437,6 +1437,8 @@ static ssize_t snd_ctl_read(struct file *file, char __user *buffer,
|
|||||||
spin_unlock_irq(&ctl->read_lock);
|
spin_unlock_irq(&ctl->read_lock);
|
||||||
schedule();
|
schedule();
|
||||||
remove_wait_queue(&ctl->change_sleep, &wait);
|
remove_wait_queue(&ctl->change_sleep, &wait);
|
||||||
|
if (ctl->card->shutdown)
|
||||||
|
return -ENODEV;
|
||||||
if (signal_pending(current))
|
if (signal_pending(current))
|
||||||
return -ERESTARTSYS;
|
return -ERESTARTSYS;
|
||||||
spin_lock_irq(&ctl->read_lock);
|
spin_lock_irq(&ctl->read_lock);
|
||||||
|
@ -131,6 +131,10 @@ static int snd_hwdep_open(struct inode *inode, struct file * file)
|
|||||||
mutex_unlock(&hw->open_mutex);
|
mutex_unlock(&hw->open_mutex);
|
||||||
schedule();
|
schedule();
|
||||||
mutex_lock(&hw->open_mutex);
|
mutex_lock(&hw->open_mutex);
|
||||||
|
if (hw->card->shutdown) {
|
||||||
|
err = -ENODEV;
|
||||||
|
break;
|
||||||
|
}
|
||||||
if (signal_pending(current)) {
|
if (signal_pending(current)) {
|
||||||
err = -ERESTARTSYS;
|
err = -ERESTARTSYS;
|
||||||
break;
|
break;
|
||||||
@ -462,12 +466,15 @@ static int snd_hwdep_dev_disconnect(struct snd_device *device)
|
|||||||
mutex_unlock(®ister_mutex);
|
mutex_unlock(®ister_mutex);
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
mutex_lock(&hwdep->open_mutex);
|
||||||
|
wake_up(&hwdep->open_wait);
|
||||||
#ifdef CONFIG_SND_OSSEMUL
|
#ifdef CONFIG_SND_OSSEMUL
|
||||||
if (hwdep->ossreg)
|
if (hwdep->ossreg)
|
||||||
snd_unregister_oss_device(hwdep->oss_type, hwdep->card, hwdep->device);
|
snd_unregister_oss_device(hwdep->oss_type, hwdep->card, hwdep->device);
|
||||||
#endif
|
#endif
|
||||||
snd_unregister_device(SNDRV_DEVICE_TYPE_HWDEP, hwdep->card, hwdep->device);
|
snd_unregister_device(SNDRV_DEVICE_TYPE_HWDEP, hwdep->card, hwdep->device);
|
||||||
list_del_init(&hwdep->list);
|
list_del_init(&hwdep->list);
|
||||||
|
mutex_unlock(&hwdep->open_mutex);
|
||||||
mutex_unlock(®ister_mutex);
|
mutex_unlock(®ister_mutex);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
@ -2441,6 +2441,10 @@ static int snd_pcm_oss_open(struct inode *inode, struct file *file)
|
|||||||
mutex_unlock(&pcm->open_mutex);
|
mutex_unlock(&pcm->open_mutex);
|
||||||
schedule();
|
schedule();
|
||||||
mutex_lock(&pcm->open_mutex);
|
mutex_lock(&pcm->open_mutex);
|
||||||
|
if (pcm->card->shutdown) {
|
||||||
|
err = -ENODEV;
|
||||||
|
break;
|
||||||
|
}
|
||||||
if (signal_pending(current)) {
|
if (signal_pending(current)) {
|
||||||
err = -ERESTARTSYS;
|
err = -ERESTARTSYS;
|
||||||
break;
|
break;
|
||||||
|
@ -1087,12 +1087,16 @@ static int snd_pcm_dev_disconnect(struct snd_device *device)
|
|||||||
goto unlock;
|
goto unlock;
|
||||||
|
|
||||||
mutex_lock(&pcm->open_mutex);
|
mutex_lock(&pcm->open_mutex);
|
||||||
|
wake_up(&pcm->open_wait);
|
||||||
list_del_init(&pcm->list);
|
list_del_init(&pcm->list);
|
||||||
for (cidx = 0; cidx < 2; cidx++)
|
for (cidx = 0; cidx < 2; cidx++)
|
||||||
for (substream = pcm->streams[cidx].substream; substream; substream = substream->next) {
|
for (substream = pcm->streams[cidx].substream; substream; substream = substream->next) {
|
||||||
snd_pcm_stream_lock_irq(substream);
|
snd_pcm_stream_lock_irq(substream);
|
||||||
if (substream->runtime)
|
if (substream->runtime) {
|
||||||
substream->runtime->status->state = SNDRV_PCM_STATE_DISCONNECTED;
|
substream->runtime->status->state = SNDRV_PCM_STATE_DISCONNECTED;
|
||||||
|
wake_up(&substream->runtime->sleep);
|
||||||
|
wake_up(&substream->runtime->tsleep);
|
||||||
|
}
|
||||||
snd_pcm_stream_unlock_irq(substream);
|
snd_pcm_stream_unlock_irq(substream);
|
||||||
}
|
}
|
||||||
list_for_each_entry(notify, &snd_pcm_notify_list, list) {
|
list_for_each_entry(notify, &snd_pcm_notify_list, list) {
|
||||||
|
@ -1518,6 +1518,10 @@ static int snd_pcm_drain(struct snd_pcm_substream *substream,
|
|||||||
down_read(&snd_pcm_link_rwsem);
|
down_read(&snd_pcm_link_rwsem);
|
||||||
snd_pcm_stream_lock_irq(substream);
|
snd_pcm_stream_lock_irq(substream);
|
||||||
remove_wait_queue(&to_check->sleep, &wait);
|
remove_wait_queue(&to_check->sleep, &wait);
|
||||||
|
if (card->shutdown) {
|
||||||
|
result = -ENODEV;
|
||||||
|
break;
|
||||||
|
}
|
||||||
if (tout == 0) {
|
if (tout == 0) {
|
||||||
if (substream->runtime->status->state == SNDRV_PCM_STATE_SUSPENDED)
|
if (substream->runtime->status->state == SNDRV_PCM_STATE_SUSPENDED)
|
||||||
result = -ESTRPIPE;
|
result = -ESTRPIPE;
|
||||||
@ -2169,6 +2173,10 @@ static int snd_pcm_open(struct file *file, struct snd_pcm *pcm, int stream)
|
|||||||
mutex_unlock(&pcm->open_mutex);
|
mutex_unlock(&pcm->open_mutex);
|
||||||
schedule();
|
schedule();
|
||||||
mutex_lock(&pcm->open_mutex);
|
mutex_lock(&pcm->open_mutex);
|
||||||
|
if (pcm->card->shutdown) {
|
||||||
|
err = -ENODEV;
|
||||||
|
break;
|
||||||
|
}
|
||||||
if (signal_pending(current)) {
|
if (signal_pending(current)) {
|
||||||
err = -ERESTARTSYS;
|
err = -ERESTARTSYS;
|
||||||
break;
|
break;
|
||||||
|
@ -424,6 +424,10 @@ static int snd_rawmidi_open(struct inode *inode, struct file *file)
|
|||||||
mutex_unlock(&rmidi->open_mutex);
|
mutex_unlock(&rmidi->open_mutex);
|
||||||
schedule();
|
schedule();
|
||||||
mutex_lock(&rmidi->open_mutex);
|
mutex_lock(&rmidi->open_mutex);
|
||||||
|
if (rmidi->card->shutdown) {
|
||||||
|
err = -ENODEV;
|
||||||
|
break;
|
||||||
|
}
|
||||||
if (signal_pending(current)) {
|
if (signal_pending(current)) {
|
||||||
err = -ERESTARTSYS;
|
err = -ERESTARTSYS;
|
||||||
break;
|
break;
|
||||||
@ -995,6 +999,8 @@ static ssize_t snd_rawmidi_read(struct file *file, char __user *buf, size_t coun
|
|||||||
spin_unlock_irq(&runtime->lock);
|
spin_unlock_irq(&runtime->lock);
|
||||||
schedule();
|
schedule();
|
||||||
remove_wait_queue(&runtime->sleep, &wait);
|
remove_wait_queue(&runtime->sleep, &wait);
|
||||||
|
if (rfile->rmidi->card->shutdown)
|
||||||
|
return -ENODEV;
|
||||||
if (signal_pending(current))
|
if (signal_pending(current))
|
||||||
return result > 0 ? result : -ERESTARTSYS;
|
return result > 0 ? result : -ERESTARTSYS;
|
||||||
if (!runtime->avail)
|
if (!runtime->avail)
|
||||||
@ -1238,6 +1244,8 @@ static ssize_t snd_rawmidi_write(struct file *file, const char __user *buf,
|
|||||||
spin_unlock_irq(&runtime->lock);
|
spin_unlock_irq(&runtime->lock);
|
||||||
timeout = schedule_timeout(30 * HZ);
|
timeout = schedule_timeout(30 * HZ);
|
||||||
remove_wait_queue(&runtime->sleep, &wait);
|
remove_wait_queue(&runtime->sleep, &wait);
|
||||||
|
if (rfile->rmidi->card->shutdown)
|
||||||
|
return -ENODEV;
|
||||||
if (signal_pending(current))
|
if (signal_pending(current))
|
||||||
return result > 0 ? result : -ERESTARTSYS;
|
return result > 0 ? result : -ERESTARTSYS;
|
||||||
if (!runtime->avail && !timeout)
|
if (!runtime->avail && !timeout)
|
||||||
@ -1613,9 +1621,20 @@ static int snd_rawmidi_dev_register(struct snd_device *device)
|
|||||||
static int snd_rawmidi_dev_disconnect(struct snd_device *device)
|
static int snd_rawmidi_dev_disconnect(struct snd_device *device)
|
||||||
{
|
{
|
||||||
struct snd_rawmidi *rmidi = device->device_data;
|
struct snd_rawmidi *rmidi = device->device_data;
|
||||||
|
int dir;
|
||||||
|
|
||||||
mutex_lock(®ister_mutex);
|
mutex_lock(®ister_mutex);
|
||||||
|
mutex_lock(&rmidi->open_mutex);
|
||||||
|
wake_up(&rmidi->open_wait);
|
||||||
list_del_init(&rmidi->list);
|
list_del_init(&rmidi->list);
|
||||||
|
for (dir = 0; dir < 2; dir++) {
|
||||||
|
struct snd_rawmidi_substream *s;
|
||||||
|
list_for_each_entry(s, &rmidi->streams[dir].substreams, list) {
|
||||||
|
if (s->runtime)
|
||||||
|
wake_up(&s->runtime->sleep);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
#ifdef CONFIG_SND_OSSEMUL
|
#ifdef CONFIG_SND_OSSEMUL
|
||||||
if (rmidi->ossreg) {
|
if (rmidi->ossreg) {
|
||||||
if ((int)rmidi->device == midi_map[rmidi->card->number]) {
|
if ((int)rmidi->device == midi_map[rmidi->card->number]) {
|
||||||
@ -1630,6 +1649,7 @@ static int snd_rawmidi_dev_disconnect(struct snd_device *device)
|
|||||||
}
|
}
|
||||||
#endif /* CONFIG_SND_OSSEMUL */
|
#endif /* CONFIG_SND_OSSEMUL */
|
||||||
snd_unregister_device(SNDRV_DEVICE_TYPE_RAWMIDI, rmidi->card, rmidi->device);
|
snd_unregister_device(SNDRV_DEVICE_TYPE_RAWMIDI, rmidi->card, rmidi->device);
|
||||||
|
mutex_unlock(&rmidi->open_mutex);
|
||||||
mutex_unlock(®ister_mutex);
|
mutex_unlock(®ister_mutex);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user