leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MIPS: elf2ecoff: Rewrite main processing loop to switch.

Browse Source 
The if construct was getting hard to read and would be getting even more
complex with the next bug fix.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
This commit is contained in:
Ralf Baechle 2015-02-02 01:01:46 +01:00
parent 39148e94e3
commit 06a40ed186
1 changed files with 33 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
arch/mips/boot/elf2ecoff.c
View File

@ -349,17 +349,14 @@ int main(int argc, char *argv[])
for (i = 0; i < ex.e_phnum; i++) { for (i = 0; i < ex.e_phnum; i++) {
/* Section types we can ignore... */ /* Section types we can ignore... */
if (ph[i].p_type == PT_NULL || ph[i].p_type == PT_NOTE || switch (ph[i].p_type) {
ph[i].p_type == PT_PHDR case PT_NULL:
|| ph[i].p_type == PT_MIPS_REGINFO) case PT_NOTE:
case PT_PHDR:
case PT_MIPS_REGINFO:
continue; continue;
/* Section types we can't handle... */
else if (ph[i].p_type != PT_LOAD) { case PT_LOAD:
fprintf(stderr,
"Program header %d type %d can't be converted.\n",
ex.e_phnum, ph[i].p_type);
exit(1);
}
/* Writable (data) segment? */ /* Writable (data) segment? */
if (ph[i].p_flags & PF_W) { if (ph[i].p_flags & PF_W) {
struct sect ndata, nbss; struct sect ndata, nbss;
@ -382,6 +379,15 @@ int main(int argc, char *argv[])
/* Remember the lowest segment start address. */ /* Remember the lowest segment start address. */
if (ph[i].p_vaddr < cur_vma) if (ph[i].p_vaddr < cur_vma)
cur_vma = ph[i].p_vaddr; cur_vma = ph[i].p_vaddr;
break;
default:
/* Section types we can't handle... */
fprintf(stderr,
"Program header %d type %d can't be converted.\n",
ex.e_phnum, ph[i].p_type);
exit(1);
}
} }
/* Sections must be in order to be converted... */ /* Sections must be in order to be converted... */