leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf evlist: Factor out asprintf routine to build a tracepoint pid filter

Browse Source 
Will be used to append such lists to existing filters.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Luis Cláudio Gonçalves <lclaudio@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-798vlyqfqw938ehoe8etivx1@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo 2019-10-07 16:43:03 -03:00
parent c330ef2847
commit 05cea4492c
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tools/perf/util/evlist.c
View File

@ -1053,6 +1053,9 @@ int perf_evlist__set_tp_filter(struct evlist *evlist, const char *filter)
struct evsel *evsel; struct evsel *evsel;
int err = 0; int err = 0;
if (filter == NULL)
return -1;
evlist__for_each_entry(evlist, evsel) { evlist__for_each_entry(evlist, evsel) {
if (evsel->core.attr.type != PERF_TYPE_TRACEPOINT) if (evsel->core.attr.type != PERF_TYPE_TRACEPOINT)
continue; continue;
@ -1065,16 +1068,15 @@ int perf_evlist__set_tp_filter(struct evlist *evlist, const char *filter)
return err; return err;
} }
int perf_evlist__set_tp_filter_pids(struct evlist *evlist, size_t npids, pid_t *pids) static char *asprintf__tp_filter_pids(size_t npids, pid_t *pids)
{ {
char *filter; char *filter;
int ret = -1;
size_t i; size_t i;
for (i = 0; i < npids; ++i) { for (i = 0; i < npids; ++i) {
if (i == 0) { if (i == 0) {
if (asprintf(&filter, "common_pid != %d", pids[i]) < 0) if (asprintf(&filter, "common_pid != %d", pids[i]) < 0)
return -1; return NULL;
} else { } else {
char *tmp; char *tmp;
@ -1086,8 +1088,17 @@ int perf_evlist__set_tp_filter_pids(struct evlist *evlist, size_t npids, pid_t *
} }
} }
ret = perf_evlist__set_tp_filter(evlist, filter); return filter;
out_free: out_free:
free(filter);
return NULL;
}
int perf_evlist__set_tp_filter_pids(struct evlist *evlist, size_t npids, pid_t *pids)
{
char *filter = asprintf__tp_filter_pids(npids, pids);
int ret = perf_evlist__set_tp_filter(evlist, filter);
free(filter); free(filter);
return ret; return ret;
} }