leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ACPI: drop unnecessary local variable from acpi_system_write_wakeup_device()

Browse Source 
The LEN variable is unsigned, therefore checking whether it is less than 0 is
useless. Also drop the LEN variable, since the COUNT parameter can be used
instead.

[rjw: Changed the subject.]
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Cyril Roelandt 2012-11-22 23:20:31 +01:00 committed by Rafael J. Wysocki
parent 66fd3835ac
commit 05bce79e6d
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/acpi/proc.c
View File

@ -362,16 +362,13 @@ acpi_system_write_wakeup_device(struct file *file,
struct list_head *node, *next; struct list_head *node, *next;
char strbuf[5]; char strbuf[5];
char str[5] = ""; char str[5] = "";
unsigned int len = count;
if (len > 4) if (count > 4)
len = 4; count = 4;
if (len < 0)
return -EFAULT;
if (copy_from_user(strbuf, buffer, len)) if (copy_from_user(strbuf, buffer, count))
return -EFAULT; return -EFAULT;
strbuf[len] = '\0'; strbuf[count] = '\0';
sscanf(strbuf, "%s", str); sscanf(strbuf, "%s", str);
mutex_lock(&acpi_device_lock); mutex_lock(&acpi_device_lock);