leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soundwire: bandwidth allocation: improve error messages

Browse Source 
In rare corner cases, we see an error with the log:

[  838.297840] soundwire sdw-master-1: Compute bus params failed: -22

That's not very useful, there can be two different error conditions
with the same -EINVAL code provided to the caller.

Let's add better dev_err() messages to figure out what went wrong.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210511054945.29558-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Pierre-Louis Bossart
2021-05-11 13:49:45 +08:00
committed by Vinod Koul
parent 9c294739cf
commit 0531e6b605
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/soundwire/generic_bandwidth_allocation.c
View File

@@ -382,12 +382,18 @@ static int sdw_compute_bus_params(struct sdw_bus *bus)
*/ */
} }
if (i == clk_values) if (i == clk_values) {
dev_err(bus->dev, "%s: could not find clock value for bandwidth %d\n",
__func__, bus->params.bandwidth);
return -EINVAL; return -EINVAL;
}
ret = sdw_select_row_col(bus, curr_dr_freq); ret = sdw_select_row_col(bus, curr_dr_freq);
if (ret < 0) if (ret < 0) {
dev_err(bus->dev, "%s: could not find frame configuration for bus dr_freq %d\n",
__func__, curr_dr_freq);
return -EINVAL; return -EINVAL;
}
bus->params.curr_dr_freq = curr_dr_freq; bus->params.curr_dr_freq = curr_dr_freq;
return 0; return 0;
@@ -404,10 +410,8 @@ int sdw_compute_params(struct sdw_bus *bus)
/* Computes clock frequency, frame shape and frame frequency */ /* Computes clock frequency, frame shape and frame frequency */
ret = sdw_compute_bus_params(bus); ret = sdw_compute_bus_params(bus);
if (ret < 0) { if (ret < 0)
dev_err(bus->dev, "Compute bus params failed: %d\n", ret);
return ret; return ret;
}
/* Compute transport and port params */ /* Compute transport and port params */
ret = sdw_compute_port_params(bus); ret = sdw_compute_port_params(bus);