leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

posix-cpu-timers: Sample task times once in expiry check

Browse Source 
Sampling the task times twice does not make sense. Do it once.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lkml.kernel.org/r/20190821192920.639878168@linutronix.de
This commit is contained in:
Thomas Gleixner
2019-08-21 21:09:02 +02:00
parent 8c2d74f037
commit 0476ff2c15
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/time/posix-cpu-timers.c
View File

@@ -785,9 +785,9 @@ static inline void check_dl_overrun(struct task_struct *tsk)
static void check_thread_timers(struct task_struct *tsk, static void check_thread_timers(struct task_struct *tsk,
struct list_head *firing) struct list_head *firing)
{ {
struct list_head *timers = tsk->cpu_timers;
struct task_cputime *tsk_expires = &tsk->cputime_expires; struct task_cputime *tsk_expires = &tsk->cputime_expires;
u64 expires; struct list_head *timers = tsk->cpu_timers;
u64 expires, stime, utime;
unsigned long soft; unsigned long soft;
if (dl_task(tsk)) if (dl_task(tsk))
@@ -800,10 +800,12 @@ static void check_thread_timers(struct task_struct *tsk,
if (task_cputime_zero(&tsk->cputime_expires)) if (task_cputime_zero(&tsk->cputime_expires))
return; return;
expires = check_timers_list(timers, firing, prof_ticks(tsk)); task_cputime(tsk, &utime, &stime);
expires = check_timers_list(timers, firing, utime + stime);
tsk_expires->prof_exp = expires; tsk_expires->prof_exp = expires;
expires = check_timers_list(++timers, firing, virt_ticks(tsk)); expires = check_timers_list(++timers, firing, utime);
tsk_expires->virt_exp = expires; tsk_expires->virt_exp = expires;
tsk_expires->sched_exp = check_timers_list(++timers, firing, tsk_expires->sched_exp = check_timers_list(++timers, firing,