leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bluetooth: SCO: Fix sco_send_frame returning skb->len

Browse Source 
The skb in modified by hci_send_sco which pushes SCO headers thus
changing skb->len causing sco_sock_sendmsg to fail.

Fixes: 0771cbb3b9 ("Bluetooth: SCO: Replace use of memcpy_from_msg with bt_skb_sendmsg")
Tested-by: Tedd Ho-Jeong An <tedd.an@intel.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
This commit is contained in:
Luiz Augusto von Dentz 2021-09-16 13:10:49 -07:00 committed by Marcel Holtmann
parent 266191aa8d
commit 037ce005af
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
net/bluetooth/sco.c
View File

@ -284,16 +284,17 @@ static int sco_connect(struct hci_dev *hdev, struct sock *sk)
static int sco_send_frame(struct sock *sk, struct sk_buff *skb)
{
struct sco_conn *conn = sco_pi(sk)->conn;
int len = skb->len;
/* Check outgoing MTU */
if (skb->len > conn->mtu)
if (len > conn->mtu)
return -EINVAL;
BT_DBG("sk %p len %d", sk, skb->len);
BT_DBG("sk %p len %d", sk, len);
hci_send_sco(conn->hcon, skb);
return skb->len;
return len;
}
static void sco_recv_frame(struct sco_conn *conn, struct sk_buff *skb)
@ -744,7 +745,8 @@ static int sco_sock_sendmsg(struct socket *sock, struct msghdr *msg,
err = -ENOTCONN;
release_sock(sk);
if (err)
if (err < 0)
kfree_skb(skb);
return err;
}