leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: isp1760: Use kasprintf

Browse Source 
Use kasprintf instead of combination of kmalloc and sprintf and
therefore avoid unnecessary computation of string length.
Also, remove the useless local variable.

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Himanshu Jha 2018-03-08 00:08:24 +05:30 committed by Greg Kroah-Hartman
parent 161c3bc30f
commit 01812ba34a
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/usb/isp1760/isp1760-udc.c
View File

@ -1441,7 +1441,6 @@ int isp1760_udc_register(struct isp1760_device *isp, int irq,
unsigned long irqflags) unsigned long irqflags)
{ {
struct isp1760_udc *udc = &isp->udc; struct isp1760_udc *udc = &isp->udc;
const char *devname;
int ret; int ret;
udc->irq = -1; udc->irq = -1;
@ -1455,13 +1454,10 @@ int isp1760_udc_register(struct isp1760_device *isp, int irq,
if (ret < 0) if (ret < 0)
return ret; return ret;
devname = dev_name(isp->dev); udc->irqname = kasprintf(GFP_KERNEL, "%s (udc)", dev_name(isp->dev));
udc->irqname = kmalloc(strlen(devname) + 7, GFP_KERNEL);
if (!udc->irqname) if (!udc->irqname)
return -ENOMEM; return -ENOMEM;
sprintf(udc->irqname, "%s (udc)", devname);
ret = request_irq(irq, isp1760_udc_irq, IRQF_SHARED | irqflags, ret = request_irq(irq, isp1760_udc_irq, IRQF_SHARED | irqflags,
udc->irqname, udc); udc->irqname, udc);
if (ret < 0) if (ret < 0)