2017-09-12 19:58:20 +00:00
|
|
|
/*
|
|
|
|
* Copyright 2015 Advanced Micro Devices, Inc.
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
*
|
|
|
|
* Authors: AMD
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
2018-11-30 14:57:06 +00:00
|
|
|
/* The caprices of the preprocessor require that this be declared right here */
|
|
|
|
#define CREATE_TRACE_POINTS
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
#include "dm_services_types.h"
|
|
|
|
#include "dc.h"
|
2017-07-31 15:29:25 +00:00
|
|
|
#include "dc/inc/core_types.h"
|
2019-04-29 13:39:15 +00:00
|
|
|
#include "dal_asic_id.h"
|
2020-04-22 02:01:58 +00:00
|
|
|
#include "dmub/dmub_srv.h"
|
2019-10-25 00:38:48 +00:00
|
|
|
#include "dc/inc/hw/dmcu.h"
|
|
|
|
#include "dc/inc/hw/abm.h"
|
2019-10-28 13:07:30 +00:00
|
|
|
#include "dc/dc_dmub_srv.h"
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
#include "vid.h"
|
|
|
|
#include "amdgpu.h"
|
2017-01-12 14:09:08 +00:00
|
|
|
#include "amdgpu_display.h"
|
2018-09-11 17:49:49 +00:00
|
|
|
#include "amdgpu_ucode.h"
|
2017-09-12 19:58:20 +00:00
|
|
|
#include "atom.h"
|
|
|
|
#include "amdgpu_dm.h"
|
2019-05-24 19:44:20 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
|
|
|
#include "amdgpu_dm_hdcp.h"
|
2019-08-16 18:49:05 +00:00
|
|
|
#include <drm/drm_hdcp.h>
|
2019-05-24 19:44:20 +00:00
|
|
|
#endif
|
2017-08-10 17:29:07 +00:00
|
|
|
#include "amdgpu_pm.h"
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
#include "amd_shared.h"
|
|
|
|
#include "amdgpu_dm_irq.h"
|
|
|
|
#include "dm_helpers.h"
|
2017-08-10 17:29:07 +00:00
|
|
|
#include "amdgpu_dm_mst_types.h"
|
2018-06-01 13:49:06 +00:00
|
|
|
#if defined(CONFIG_DEBUG_FS)
|
|
|
|
#include "amdgpu_dm_debugfs.h"
|
|
|
|
#endif
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
#include "ivsrcid/ivsrcid_vislands30.h"
|
|
|
|
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/moduleparam.h>
|
|
|
|
#include <linux/version.h>
|
2017-08-10 17:29:07 +00:00
|
|
|
#include <linux/types.h>
|
drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()
So, unfortunately I recently made the discovery that in the upstream
kernel, the only reason that amdgpu is not currently suffering from
issues with runtime PM putting the GPU into suspend while it's driving
displays is due to the fact that on most prime systems, we have sound
devices associated with the GPU that hold their own runtime PM ref for
the GPU.
What this means however, is that in the event that there isn't any kind
of sound device active (which can easily be reproduced by building a
kernel with sound drivers disabled), the GPU will fall asleep even when
there's displays active. This appears to be in part due to the fact that
amdgpu has not actually ever relied on it's rpm_idle() function to be
the only thing keeping it running, and normally grabs it's own power
references whenever there are displays active (as can be seen with the
original pre-DC codepath in amdgpu_display_crtc_set_config() in
amdgpu_display.c). This means it's very likely that this bug was
introduced during the switch over the DC.
So to fix this, we start grabbing runtime PM references every time we
enable a previously disabled CRTC in atomic_commit_tail(). This appears
to be the correct solution, as it matches up with what i915 does in
i915/intel_runtime_pm.c.
The one sideaffect of this is that we ignore the variable that the
pre-DC code used to use for tracking when it needed runtime PM refs,
adev->have_disp_power_ref. This is mainly because there's no way for a
driver to tell whether or not all of it's CRTCs are enabled or disabled
when we've begun committing an atomic state, as there may be CRTC
commits happening in parallel that aren't contained within the atomic
state being committed. So, it's safer to just get/put a reference for
each CRTC being enabled or disabled in the new atomic state.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Acked-by: Christian König <christian.koenig@amd.com>.
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
2018-06-04 19:35:03 +00:00
|
|
|
#include <linux/pm_runtime.h>
|
2019-06-09 22:07:55 +00:00
|
|
|
#include <linux/pci.h>
|
2018-09-11 17:49:49 +00:00
|
|
|
#include <linux/firmware.h>
|
2019-07-11 19:31:46 +00:00
|
|
|
#include <linux/component.h>
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
#include <drm/drm_atomic.h>
|
2018-12-05 19:59:07 +00:00
|
|
|
#include <drm/drm_atomic_uapi.h>
|
2017-09-12 19:58:20 +00:00
|
|
|
#include <drm/drm_atomic_helper.h>
|
|
|
|
#include <drm/drm_dp_mst_helper.h>
|
2017-08-10 17:29:07 +00:00
|
|
|
#include <drm/drm_fb_helper.h>
|
2019-06-09 22:07:55 +00:00
|
|
|
#include <drm/drm_fourcc.h>
|
2017-08-10 17:29:07 +00:00
|
|
|
#include <drm/drm_edid.h>
|
2019-06-09 22:07:55 +00:00
|
|
|
#include <drm/drm_vblank.h>
|
2019-07-11 19:31:46 +00:00
|
|
|
#include <drm/drm_audio_component.h>
|
2019-09-16 20:52:58 +00:00
|
|
|
#include <drm/drm_hdcp.h>
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2019-11-06 19:48:35 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN)
|
2019-03-05 11:52:22 +00:00
|
|
|
#include "ivsrcid/dcn/irqsrcs_dcn_1_0.h"
|
2017-06-15 20:27:42 +00:00
|
|
|
|
2017-11-27 10:59:10 +00:00
|
|
|
#include "dcn/dcn_1_0_offset.h"
|
|
|
|
#include "dcn/dcn_1_0_sh_mask.h"
|
2018-01-15 07:43:23 +00:00
|
|
|
#include "soc15_hw_ip.h"
|
|
|
|
#include "vega10_ip_offset.h"
|
2017-06-15 20:27:42 +00:00
|
|
|
|
|
|
|
#include "soc15_common.h"
|
|
|
|
#endif
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
#include "modules/inc/mod_freesync.h"
|
2018-11-26 16:38:33 +00:00
|
|
|
#include "modules/power/power_helpers.h"
|
2018-11-05 22:55:53 +00:00
|
|
|
#include "modules/inc/mod_info_packet.h"
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-10-25 00:38:48 +00:00
|
|
|
#define FIRMWARE_RENOIR_DMUB "amdgpu/renoir_dmcub.bin"
|
|
|
|
MODULE_FIRMWARE(FIRMWARE_RENOIR_DMUB);
|
2020-05-21 16:48:41 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN3_0)
|
|
|
|
#define FIRMWARE_SIENNA_CICHLID_DMUB "amdgpu/sienna_cichlid_dmcub.bin"
|
|
|
|
MODULE_FIRMWARE(FIRMWARE_SIENNA_CICHLID_DMUB);
|
2020-07-21 17:59:52 +00:00
|
|
|
#define FIRMWARE_NAVY_FLOUNDER_DMUB "amdgpu/navy_flounder_dmcub.bin"
|
|
|
|
MODULE_FIRMWARE(FIRMWARE_NAVY_FLOUNDER_DMUB);
|
2020-05-21 16:48:41 +00:00
|
|
|
#endif
|
2019-10-28 13:22:34 +00:00
|
|
|
|
2018-09-11 17:49:49 +00:00
|
|
|
#define FIRMWARE_RAVEN_DMCU "amdgpu/raven_dmcu.bin"
|
|
|
|
MODULE_FIRMWARE(FIRMWARE_RAVEN_DMCU);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2020-02-05 14:39:41 +00:00
|
|
|
#define FIRMWARE_NAVI12_DMCU "amdgpu/navi12_dmcu.bin"
|
|
|
|
MODULE_FIRMWARE(FIRMWARE_NAVI12_DMCU);
|
|
|
|
|
2019-11-25 14:49:27 +00:00
|
|
|
/* Number of bytes in PSP header for firmware. */
|
|
|
|
#define PSP_HEADER_BYTES 0x100
|
|
|
|
|
|
|
|
/* Number of bytes in PSP footer for firmware. */
|
|
|
|
#define PSP_FOOTER_BYTES 0x100
|
|
|
|
|
2018-09-14 15:20:08 +00:00
|
|
|
/**
|
|
|
|
* DOC: overview
|
|
|
|
*
|
|
|
|
* The AMDgpu display manager, **amdgpu_dm** (or even simpler,
|
|
|
|
* **dm**) sits between DRM and DC. It acts as a liason, converting DRM
|
|
|
|
* requests into DC requests, and DC responses into DRM responses.
|
|
|
|
*
|
|
|
|
* The root control structure is &struct amdgpu_display_manager.
|
|
|
|
*/
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
/* basic init/fini API */
|
|
|
|
static int amdgpu_dm_init(struct amdgpu_device *adev);
|
|
|
|
static void amdgpu_dm_fini(struct amdgpu_device *adev);
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* initializes drm_device display related structures, based on the information
|
2017-10-10 21:51:02 +00:00
|
|
|
* provided by DAL. The drm strcutures are: drm_crtc, drm_connector,
|
|
|
|
* drm_encoder, drm_mode_config
|
|
|
|
*
|
|
|
|
* Returns 0 on success
|
|
|
|
*/
|
|
|
|
static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev);
|
|
|
|
/* removes and deallocates the drm structures, created by the above function */
|
|
|
|
static void amdgpu_dm_destroy_drm_device(struct amdgpu_display_manager *dm);
|
|
|
|
|
|
|
|
static int amdgpu_dm_plane_init(struct amdgpu_display_manager *dm,
|
2018-10-05 15:58:34 +00:00
|
|
|
struct drm_plane *plane,
|
2019-03-14 19:58:51 +00:00
|
|
|
unsigned long possible_crtcs,
|
|
|
|
const struct dc_plane_cap *plane_cap);
|
2017-10-10 21:51:02 +00:00
|
|
|
static int amdgpu_dm_crtc_init(struct amdgpu_display_manager *dm,
|
|
|
|
struct drm_plane *plane,
|
|
|
|
uint32_t link_index);
|
|
|
|
static int amdgpu_dm_connector_init(struct amdgpu_display_manager *dm,
|
|
|
|
struct amdgpu_dm_connector *amdgpu_dm_connector,
|
|
|
|
uint32_t link_index,
|
|
|
|
struct amdgpu_encoder *amdgpu_encoder);
|
|
|
|
static int amdgpu_dm_encoder_init(struct drm_device *dev,
|
|
|
|
struct amdgpu_encoder *aencoder,
|
|
|
|
uint32_t link_index);
|
|
|
|
|
|
|
|
static int amdgpu_dm_connector_get_modes(struct drm_connector *connector);
|
|
|
|
|
|
|
|
static int amdgpu_dm_atomic_commit(struct drm_device *dev,
|
|
|
|
struct drm_atomic_state *state,
|
|
|
|
bool nonblock);
|
|
|
|
|
|
|
|
static void amdgpu_dm_atomic_commit_tail(struct drm_atomic_state *state);
|
|
|
|
|
|
|
|
static int amdgpu_dm_atomic_check(struct drm_device *dev,
|
|
|
|
struct drm_atomic_state *state);
|
|
|
|
|
2018-12-05 19:59:07 +00:00
|
|
|
static void handle_cursor_update(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *old_plane_state);
|
2017-10-10 21:51:02 +00:00
|
|
|
|
2019-09-20 23:03:17 +00:00
|
|
|
static void amdgpu_dm_set_psr_caps(struct dc_link *link);
|
|
|
|
static bool amdgpu_dm_psr_enable(struct dc_stream_state *stream);
|
|
|
|
static bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream);
|
|
|
|
static bool amdgpu_dm_psr_disable(struct dc_stream_state *stream);
|
|
|
|
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
/*
|
|
|
|
* dm_vblank_get_counter
|
|
|
|
*
|
|
|
|
* @brief
|
|
|
|
* Get counter for number of vertical blanks
|
|
|
|
*
|
|
|
|
* @param
|
|
|
|
* struct amdgpu_device *adev - [in] desired amdgpu device
|
|
|
|
* int disp_idx - [in] which CRTC to get the counter from
|
|
|
|
*
|
|
|
|
* @return
|
|
|
|
* Counter for vertical blanks
|
|
|
|
*/
|
|
|
|
static u32 dm_vblank_get_counter(struct amdgpu_device *adev, int crtc)
|
|
|
|
{
|
|
|
|
if (crtc >= adev->mode_info.num_crtc)
|
|
|
|
return 0;
|
|
|
|
else {
|
|
|
|
struct amdgpu_crtc *acrtc = adev->mode_info.crtcs[crtc];
|
2017-06-29 16:03:59 +00:00
|
|
|
struct dm_crtc_state *acrtc_state = to_dm_crtc_state(
|
|
|
|
acrtc->base.state);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2017-06-29 16:03:59 +00:00
|
|
|
|
|
|
|
if (acrtc_state->stream == NULL) {
|
2017-07-27 13:33:33 +00:00
|
|
|
DRM_ERROR("dc_stream_state is NULL for crtc '%d'!\n",
|
|
|
|
crtc);
|
2017-09-12 19:58:20 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-06-29 16:03:59 +00:00
|
|
|
return dc_stream_get_vblank_counter(acrtc_state->stream);
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int dm_crtc_get_scanoutpos(struct amdgpu_device *adev, int crtc,
|
2017-10-10 21:44:52 +00:00
|
|
|
u32 *vbl, u32 *position)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
2017-04-11 19:15:28 +00:00
|
|
|
uint32_t v_blank_start, v_blank_end, h_position, v_position;
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
if ((crtc < 0) || (crtc >= adev->mode_info.num_crtc))
|
|
|
|
return -EINVAL;
|
|
|
|
else {
|
|
|
|
struct amdgpu_crtc *acrtc = adev->mode_info.crtcs[crtc];
|
2017-06-29 16:03:59 +00:00
|
|
|
struct dm_crtc_state *acrtc_state = to_dm_crtc_state(
|
|
|
|
acrtc->base.state);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2017-06-29 16:03:59 +00:00
|
|
|
if (acrtc_state->stream == NULL) {
|
2017-07-27 13:33:33 +00:00
|
|
|
DRM_ERROR("dc_stream_state is NULL for crtc '%d'!\n",
|
|
|
|
crtc);
|
2017-09-12 19:58:20 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-04-11 19:15:28 +00:00
|
|
|
/*
|
|
|
|
* TODO rework base driver to use values directly.
|
|
|
|
* for now parse it back into reg-format
|
|
|
|
*/
|
2017-06-29 16:03:59 +00:00
|
|
|
dc_stream_get_scanoutpos(acrtc_state->stream,
|
2017-04-11 19:15:28 +00:00
|
|
|
&v_blank_start,
|
|
|
|
&v_blank_end,
|
|
|
|
&h_position,
|
|
|
|
&v_position);
|
|
|
|
|
2017-05-12 20:19:15 +00:00
|
|
|
*position = v_position | (h_position << 16);
|
|
|
|
*vbl = v_blank_start | (v_blank_end << 16);
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool dm_is_idle(void *handle)
|
|
|
|
{
|
|
|
|
/* XXX todo */
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int dm_wait_for_idle(void *handle)
|
|
|
|
{
|
|
|
|
/* XXX todo */
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool dm_check_soft_reset(void *handle)
|
|
|
|
{
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int dm_soft_reset(void *handle)
|
|
|
|
{
|
|
|
|
/* XXX todo */
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static struct amdgpu_crtc *
|
|
|
|
get_crtc_by_otg_inst(struct amdgpu_device *adev,
|
|
|
|
int otg_inst)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
|
|
|
struct drm_device *dev = adev->ddev;
|
|
|
|
struct drm_crtc *crtc;
|
|
|
|
struct amdgpu_crtc *amdgpu_crtc;
|
|
|
|
|
|
|
|
if (otg_inst == -1) {
|
|
|
|
WARN_ON(1);
|
|
|
|
return adev->mode_info.crtcs[0];
|
|
|
|
}
|
|
|
|
|
|
|
|
list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
|
|
|
|
amdgpu_crtc = to_amdgpu_crtc(crtc);
|
|
|
|
|
|
|
|
if (amdgpu_crtc->otg_inst == otg_inst)
|
|
|
|
return amdgpu_crtc;
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2019-03-29 12:00:54 +00:00
|
|
|
static inline bool amdgpu_dm_vrr_active(struct dm_crtc_state *dm_state)
|
|
|
|
{
|
|
|
|
return dm_state->freesync_config.state == VRR_STATE_ACTIVE_VARIABLE ||
|
|
|
|
dm_state->freesync_config.state == VRR_STATE_ACTIVE_FIXED;
|
|
|
|
}
|
|
|
|
|
2019-09-18 15:42:59 +00:00
|
|
|
/**
|
|
|
|
* dm_pflip_high_irq() - Handle pageflip interrupt
|
|
|
|
* @interrupt_params: ignored
|
|
|
|
*
|
|
|
|
* Handles the pageflip interrupt by notifying all interested parties
|
|
|
|
* that the pageflip has been completed.
|
|
|
|
*/
|
2017-09-12 19:58:20 +00:00
|
|
|
static void dm_pflip_high_irq(void *interrupt_params)
|
|
|
|
{
|
|
|
|
struct amdgpu_crtc *amdgpu_crtc;
|
|
|
|
struct common_irq_params *irq_params = interrupt_params;
|
|
|
|
struct amdgpu_device *adev = irq_params->adev;
|
|
|
|
unsigned long flags;
|
drm/amd/display: Make pageflip event delivery compatible with VRR.
We want vblank counts and timestamps of flip completion as sent
in pageflip completion events to be consistent with the vblank
count and timestamp of the vblank of flip completion, like in non
VRR mode.
In VRR mode, drm_update_vblank_count() - and thereby vblank
count and timestamp updates - must be delayed until after the
end of front-porch of each vblank, as it is only safe to
calculate vblank timestamps outside of the front-porch, when
we actually know when the vblank will end or has ended.
The function drm_update_vblank_count() which updates timestamps
and counts gets called by drm_crtc_accurate_vblank_count() or by
drm_crtc_handle_vblank().
Therefore we must make sure that pageflip events for a completed
flip are only sent out after drm_crtc_accurate_vblank_count() or
drm_crtc_handle_vblank() is executed, after end of front-porch
for the vblank of flip completion.
Two cases:
a) Pageflip irq handler executes inside front-porch:
In this case we must defer sending pageflip events until
drm_crtc_handle_vblank() executes after end of front-porch,
and thereby calculates proper vblank count and timestamp.
Iow. the pflip irq handler must just arm a pageflip event
to be sent out by drm_crtc_handle_vblank() later on.
b) Pageflip irq handler executes after end of front-porch, e.g.,
after flip completion in back-porch or due to a massively
delayed handler invocation into the active scanout of the new
frame. In this case we can call drm_crtc_accurate_vblank_count()
to safely force calculation of a proper vblank count and
timestamp, and must send the pageflip completion event
ourselves from the pageflip irq handler.
This is the same behaviour as needed for standard fixed refresh
rate mode.
To decide from within pageflip handler if we are in case a) or b),
we check the current scanout position against the boundary of
front-porch. In non-VRR mode we just do what we did in the past.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-03-29 12:00:57 +00:00
|
|
|
struct drm_pending_vblank_event *e;
|
|
|
|
struct dm_crtc_state *acrtc_state;
|
|
|
|
uint32_t vpos, hpos, v_blank_start, v_blank_end;
|
|
|
|
bool vrr_active;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
amdgpu_crtc = get_crtc_by_otg_inst(adev, irq_params->irq_src - IRQ_TYPE_PFLIP);
|
|
|
|
|
|
|
|
/* IRQ could occur when in initial stage */
|
2018-08-15 18:38:30 +00:00
|
|
|
/* TODO work and BO cleanup */
|
2017-09-12 19:58:20 +00:00
|
|
|
if (amdgpu_crtc == NULL) {
|
|
|
|
DRM_DEBUG_DRIVER("CRTC is null, returning.\n");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
spin_lock_irqsave(&adev->ddev->event_lock, flags);
|
|
|
|
|
|
|
|
if (amdgpu_crtc->pflip_status != AMDGPU_FLIP_SUBMITTED){
|
|
|
|
DRM_DEBUG_DRIVER("amdgpu_crtc->pflip_status = %d !=AMDGPU_FLIP_SUBMITTED(%d) on crtc:%d[%p] \n",
|
|
|
|
amdgpu_crtc->pflip_status,
|
|
|
|
AMDGPU_FLIP_SUBMITTED,
|
|
|
|
amdgpu_crtc->crtc_id,
|
|
|
|
amdgpu_crtc);
|
|
|
|
spin_unlock_irqrestore(&adev->ddev->event_lock, flags);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
drm/amd/display: Make pageflip event delivery compatible with VRR.
We want vblank counts and timestamps of flip completion as sent
in pageflip completion events to be consistent with the vblank
count and timestamp of the vblank of flip completion, like in non
VRR mode.
In VRR mode, drm_update_vblank_count() - and thereby vblank
count and timestamp updates - must be delayed until after the
end of front-porch of each vblank, as it is only safe to
calculate vblank timestamps outside of the front-porch, when
we actually know when the vblank will end or has ended.
The function drm_update_vblank_count() which updates timestamps
and counts gets called by drm_crtc_accurate_vblank_count() or by
drm_crtc_handle_vblank().
Therefore we must make sure that pageflip events for a completed
flip are only sent out after drm_crtc_accurate_vblank_count() or
drm_crtc_handle_vblank() is executed, after end of front-porch
for the vblank of flip completion.
Two cases:
a) Pageflip irq handler executes inside front-porch:
In this case we must defer sending pageflip events until
drm_crtc_handle_vblank() executes after end of front-porch,
and thereby calculates proper vblank count and timestamp.
Iow. the pflip irq handler must just arm a pageflip event
to be sent out by drm_crtc_handle_vblank() later on.
b) Pageflip irq handler executes after end of front-porch, e.g.,
after flip completion in back-porch or due to a massively
delayed handler invocation into the active scanout of the new
frame. In this case we can call drm_crtc_accurate_vblank_count()
to safely force calculation of a proper vblank count and
timestamp, and must send the pageflip completion event
ourselves from the pageflip irq handler.
This is the same behaviour as needed for standard fixed refresh
rate mode.
To decide from within pageflip handler if we are in case a) or b),
we check the current scanout position against the boundary of
front-porch. In non-VRR mode we just do what we did in the past.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-03-29 12:00:57 +00:00
|
|
|
/* page flip completed. */
|
|
|
|
e = amdgpu_crtc->event;
|
|
|
|
amdgpu_crtc->event = NULL;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
drm/amd/display: Make pageflip event delivery compatible with VRR.
We want vblank counts and timestamps of flip completion as sent
in pageflip completion events to be consistent with the vblank
count and timestamp of the vblank of flip completion, like in non
VRR mode.
In VRR mode, drm_update_vblank_count() - and thereby vblank
count and timestamp updates - must be delayed until after the
end of front-porch of each vblank, as it is only safe to
calculate vblank timestamps outside of the front-porch, when
we actually know when the vblank will end or has ended.
The function drm_update_vblank_count() which updates timestamps
and counts gets called by drm_crtc_accurate_vblank_count() or by
drm_crtc_handle_vblank().
Therefore we must make sure that pageflip events for a completed
flip are only sent out after drm_crtc_accurate_vblank_count() or
drm_crtc_handle_vblank() is executed, after end of front-porch
for the vblank of flip completion.
Two cases:
a) Pageflip irq handler executes inside front-porch:
In this case we must defer sending pageflip events until
drm_crtc_handle_vblank() executes after end of front-porch,
and thereby calculates proper vblank count and timestamp.
Iow. the pflip irq handler must just arm a pageflip event
to be sent out by drm_crtc_handle_vblank() later on.
b) Pageflip irq handler executes after end of front-porch, e.g.,
after flip completion in back-porch or due to a massively
delayed handler invocation into the active scanout of the new
frame. In this case we can call drm_crtc_accurate_vblank_count()
to safely force calculation of a proper vblank count and
timestamp, and must send the pageflip completion event
ourselves from the pageflip irq handler.
This is the same behaviour as needed for standard fixed refresh
rate mode.
To decide from within pageflip handler if we are in case a) or b),
we check the current scanout position against the boundary of
front-porch. In non-VRR mode we just do what we did in the past.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-03-29 12:00:57 +00:00
|
|
|
if (!e)
|
|
|
|
WARN_ON(1);
|
2017-06-07 22:28:43 +00:00
|
|
|
|
drm/amd/display: Make pageflip event delivery compatible with VRR.
We want vblank counts and timestamps of flip completion as sent
in pageflip completion events to be consistent with the vblank
count and timestamp of the vblank of flip completion, like in non
VRR mode.
In VRR mode, drm_update_vblank_count() - and thereby vblank
count and timestamp updates - must be delayed until after the
end of front-porch of each vblank, as it is only safe to
calculate vblank timestamps outside of the front-porch, when
we actually know when the vblank will end or has ended.
The function drm_update_vblank_count() which updates timestamps
and counts gets called by drm_crtc_accurate_vblank_count() or by
drm_crtc_handle_vblank().
Therefore we must make sure that pageflip events for a completed
flip are only sent out after drm_crtc_accurate_vblank_count() or
drm_crtc_handle_vblank() is executed, after end of front-porch
for the vblank of flip completion.
Two cases:
a) Pageflip irq handler executes inside front-porch:
In this case we must defer sending pageflip events until
drm_crtc_handle_vblank() executes after end of front-porch,
and thereby calculates proper vblank count and timestamp.
Iow. the pflip irq handler must just arm a pageflip event
to be sent out by drm_crtc_handle_vblank() later on.
b) Pageflip irq handler executes after end of front-porch, e.g.,
after flip completion in back-porch or due to a massively
delayed handler invocation into the active scanout of the new
frame. In this case we can call drm_crtc_accurate_vblank_count()
to safely force calculation of a proper vblank count and
timestamp, and must send the pageflip completion event
ourselves from the pageflip irq handler.
This is the same behaviour as needed for standard fixed refresh
rate mode.
To decide from within pageflip handler if we are in case a) or b),
we check the current scanout position against the boundary of
front-porch. In non-VRR mode we just do what we did in the past.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-03-29 12:00:57 +00:00
|
|
|
acrtc_state = to_dm_crtc_state(amdgpu_crtc->base.state);
|
|
|
|
vrr_active = amdgpu_dm_vrr_active(acrtc_state);
|
|
|
|
|
|
|
|
/* Fixed refresh rate, or VRR scanout position outside front-porch? */
|
|
|
|
if (!vrr_active ||
|
|
|
|
!dc_stream_get_scanoutpos(acrtc_state->stream, &v_blank_start,
|
|
|
|
&v_blank_end, &hpos, &vpos) ||
|
|
|
|
(vpos < v_blank_start)) {
|
|
|
|
/* Update to correct count and vblank timestamp if racing with
|
|
|
|
* vblank irq. This also updates to the correct vblank timestamp
|
|
|
|
* even in VRR mode, as scanout is past the front-porch atm.
|
|
|
|
*/
|
|
|
|
drm_crtc_accurate_vblank_count(&amdgpu_crtc->base);
|
2017-06-07 22:28:43 +00:00
|
|
|
|
drm/amd/display: Make pageflip event delivery compatible with VRR.
We want vblank counts and timestamps of flip completion as sent
in pageflip completion events to be consistent with the vblank
count and timestamp of the vblank of flip completion, like in non
VRR mode.
In VRR mode, drm_update_vblank_count() - and thereby vblank
count and timestamp updates - must be delayed until after the
end of front-porch of each vblank, as it is only safe to
calculate vblank timestamps outside of the front-porch, when
we actually know when the vblank will end or has ended.
The function drm_update_vblank_count() which updates timestamps
and counts gets called by drm_crtc_accurate_vblank_count() or by
drm_crtc_handle_vblank().
Therefore we must make sure that pageflip events for a completed
flip are only sent out after drm_crtc_accurate_vblank_count() or
drm_crtc_handle_vblank() is executed, after end of front-porch
for the vblank of flip completion.
Two cases:
a) Pageflip irq handler executes inside front-porch:
In this case we must defer sending pageflip events until
drm_crtc_handle_vblank() executes after end of front-porch,
and thereby calculates proper vblank count and timestamp.
Iow. the pflip irq handler must just arm a pageflip event
to be sent out by drm_crtc_handle_vblank() later on.
b) Pageflip irq handler executes after end of front-porch, e.g.,
after flip completion in back-porch or due to a massively
delayed handler invocation into the active scanout of the new
frame. In this case we can call drm_crtc_accurate_vblank_count()
to safely force calculation of a proper vblank count and
timestamp, and must send the pageflip completion event
ourselves from the pageflip irq handler.
This is the same behaviour as needed for standard fixed refresh
rate mode.
To decide from within pageflip handler if we are in case a) or b),
we check the current scanout position against the boundary of
front-porch. In non-VRR mode we just do what we did in the past.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-03-29 12:00:57 +00:00
|
|
|
/* Wake up userspace by sending the pageflip event with proper
|
|
|
|
* count and timestamp of vblank of flip completion.
|
|
|
|
*/
|
|
|
|
if (e) {
|
|
|
|
drm_crtc_send_vblank_event(&amdgpu_crtc->base, e);
|
|
|
|
|
|
|
|
/* Event sent, so done with vblank for this flip */
|
|
|
|
drm_crtc_vblank_put(&amdgpu_crtc->base);
|
|
|
|
}
|
|
|
|
} else if (e) {
|
|
|
|
/* VRR active and inside front-porch: vblank count and
|
|
|
|
* timestamp for pageflip event will only be up to date after
|
|
|
|
* drm_crtc_handle_vblank() has been executed from late vblank
|
|
|
|
* irq handler after start of back-porch (vline 0). We queue the
|
|
|
|
* pageflip event for send-out by drm_crtc_handle_vblank() with
|
|
|
|
* updated timestamp and count, once it runs after us.
|
|
|
|
*
|
|
|
|
* We need to open-code this instead of using the helper
|
|
|
|
* drm_crtc_arm_vblank_event(), as that helper would
|
|
|
|
* call drm_crtc_accurate_vblank_count(), which we must
|
|
|
|
* not call in VRR mode while we are in front-porch!
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* sequence will be replaced by real count during send-out. */
|
|
|
|
e->sequence = drm_crtc_vblank_count(&amdgpu_crtc->base);
|
|
|
|
e->pipe = amdgpu_crtc->crtc_id;
|
|
|
|
|
|
|
|
list_add_tail(&e->base.link, &adev->ddev->vblank_event_list);
|
|
|
|
e = NULL;
|
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
|
drm/amd/display: Rework vrr flip throttling for late vblank irq.
For throttling to work correctly, we always need a baseline vblank
count last_flip_vblank that increments at start of front-porch.
This is the case for drm_crtc_vblank_count() in non-VRR mode, where
the vblank irq fires at start of front-porch and triggers DRM core
vblank handling, but it is no longer the case in VRR mode, where
core vblank handling is done later, after end of front-porch.
Therefore drm_crtc_vblank_count() is no longer useful for this.
We also can't use drm_crtc_accurate_vblank_count(), as that would
screw up vblank timestamps in VRR mode when called in front-porch.
To solve this, use the cooked hardware vblank counter returned by
amdgpu_get_vblank_counter_kms() instead, as that one is cooked to
always increment at start of front-porch, independent of when
vblank related irq's fire.
This patch allows vblank irq handling to happen anywhere within
vblank of even after it, without a negative impact on flip
throttling, so followup patches can shift the vblank core
handling trigger point wherever they need it.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-02 22:00:06 +00:00
|
|
|
/* Keep track of vblank of this flip for flip throttling. We use the
|
|
|
|
* cooked hw counter, as that one incremented at start of this vblank
|
|
|
|
* of pageflip completion, so last_flip_vblank is the forbidden count
|
|
|
|
* for queueing new pageflips if vsync + VRR is enabled.
|
|
|
|
*/
|
2020-01-23 13:59:26 +00:00
|
|
|
amdgpu_crtc->last_flip_vblank =
|
|
|
|
amdgpu_get_vblank_counter_kms(&amdgpu_crtc->base);
|
drm/amd/display: Rework vrr flip throttling for late vblank irq.
For throttling to work correctly, we always need a baseline vblank
count last_flip_vblank that increments at start of front-porch.
This is the case for drm_crtc_vblank_count() in non-VRR mode, where
the vblank irq fires at start of front-porch and triggers DRM core
vblank handling, but it is no longer the case in VRR mode, where
core vblank handling is done later, after end of front-porch.
Therefore drm_crtc_vblank_count() is no longer useful for this.
We also can't use drm_crtc_accurate_vblank_count(), as that would
screw up vblank timestamps in VRR mode when called in front-porch.
To solve this, use the cooked hardware vblank counter returned by
amdgpu_get_vblank_counter_kms() instead, as that one is cooked to
always increment at start of front-porch, independent of when
vblank related irq's fire.
This patch allows vblank irq handling to happen anywhere within
vblank of even after it, without a negative impact on flip
throttling, so followup patches can shift the vblank core
handling trigger point wherever they need it.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-02 22:00:06 +00:00
|
|
|
|
2017-04-20 19:57:05 +00:00
|
|
|
amdgpu_crtc->pflip_status = AMDGPU_FLIP_NONE;
|
2017-09-12 19:58:20 +00:00
|
|
|
spin_unlock_irqrestore(&adev->ddev->event_lock, flags);
|
|
|
|
|
drm/amd/display: Make pageflip event delivery compatible with VRR.
We want vblank counts and timestamps of flip completion as sent
in pageflip completion events to be consistent with the vblank
count and timestamp of the vblank of flip completion, like in non
VRR mode.
In VRR mode, drm_update_vblank_count() - and thereby vblank
count and timestamp updates - must be delayed until after the
end of front-porch of each vblank, as it is only safe to
calculate vblank timestamps outside of the front-porch, when
we actually know when the vblank will end or has ended.
The function drm_update_vblank_count() which updates timestamps
and counts gets called by drm_crtc_accurate_vblank_count() or by
drm_crtc_handle_vblank().
Therefore we must make sure that pageflip events for a completed
flip are only sent out after drm_crtc_accurate_vblank_count() or
drm_crtc_handle_vblank() is executed, after end of front-porch
for the vblank of flip completion.
Two cases:
a) Pageflip irq handler executes inside front-porch:
In this case we must defer sending pageflip events until
drm_crtc_handle_vblank() executes after end of front-porch,
and thereby calculates proper vblank count and timestamp.
Iow. the pflip irq handler must just arm a pageflip event
to be sent out by drm_crtc_handle_vblank() later on.
b) Pageflip irq handler executes after end of front-porch, e.g.,
after flip completion in back-porch or due to a massively
delayed handler invocation into the active scanout of the new
frame. In this case we can call drm_crtc_accurate_vblank_count()
to safely force calculation of a proper vblank count and
timestamp, and must send the pageflip completion event
ourselves from the pageflip irq handler.
This is the same behaviour as needed for standard fixed refresh
rate mode.
To decide from within pageflip handler if we are in case a) or b),
we check the current scanout position against the boundary of
front-porch. In non-VRR mode we just do what we did in the past.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-03-29 12:00:57 +00:00
|
|
|
DRM_DEBUG_DRIVER("crtc:%d[%p], pflip_stat:AMDGPU_FLIP_NONE, vrr[%d]-fp %d\n",
|
|
|
|
amdgpu_crtc->crtc_id, amdgpu_crtc,
|
|
|
|
vrr_active, (int) !e);
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
2019-03-29 12:00:56 +00:00
|
|
|
static void dm_vupdate_high_irq(void *interrupt_params)
|
|
|
|
{
|
|
|
|
struct common_irq_params *irq_params = interrupt_params;
|
|
|
|
struct amdgpu_device *adev = irq_params->adev;
|
|
|
|
struct amdgpu_crtc *acrtc;
|
|
|
|
struct dm_crtc_state *acrtc_state;
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
unsigned long flags;
|
2019-03-29 12:00:56 +00:00
|
|
|
|
|
|
|
acrtc = get_crtc_by_otg_inst(adev, irq_params->irq_src - IRQ_TYPE_VUPDATE);
|
|
|
|
|
|
|
|
if (acrtc) {
|
|
|
|
acrtc_state = to_dm_crtc_state(acrtc->base.state);
|
|
|
|
|
2020-01-24 01:07:42 +00:00
|
|
|
DRM_DEBUG_VBL("crtc:%d, vupdate-vrr:%d\n",
|
|
|
|
acrtc->crtc_id,
|
|
|
|
amdgpu_dm_vrr_active(acrtc_state));
|
2019-03-29 12:00:56 +00:00
|
|
|
|
|
|
|
/* Core vblank handling is done here after end of front-porch in
|
|
|
|
* vrr mode, as vblank timestamping will give valid results
|
|
|
|
* while now done after front-porch. This will also deliver
|
|
|
|
* page-flip completion events that have been queued to us
|
|
|
|
* if a pageflip happened inside front-porch.
|
|
|
|
*/
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
if (amdgpu_dm_vrr_active(acrtc_state)) {
|
2019-03-29 12:00:56 +00:00
|
|
|
drm_crtc_handle_vblank(&acrtc->base);
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
|
|
|
|
/* BTR processing for pre-DCE12 ASICs */
|
|
|
|
if (acrtc_state->stream &&
|
|
|
|
adev->family < AMDGPU_FAMILY_AI) {
|
|
|
|
spin_lock_irqsave(&adev->ddev->event_lock, flags);
|
|
|
|
mod_freesync_handle_v_update(
|
|
|
|
adev->dm.freesync_module,
|
|
|
|
acrtc_state->stream,
|
|
|
|
&acrtc_state->vrr_params);
|
|
|
|
|
|
|
|
dc_stream_adjust_vmin_vmax(
|
|
|
|
adev->dm.dc,
|
|
|
|
acrtc_state->stream,
|
|
|
|
&acrtc_state->vrr_params.adjust);
|
|
|
|
spin_unlock_irqrestore(&adev->ddev->event_lock, flags);
|
|
|
|
}
|
|
|
|
}
|
2019-03-29 12:00:56 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-09-18 15:42:59 +00:00
|
|
|
/**
|
|
|
|
* dm_crtc_high_irq() - Handles CRTC interrupt
|
2020-05-06 19:47:54 +00:00
|
|
|
* @interrupt_params: used for determining the CRTC instance
|
2019-09-18 15:42:59 +00:00
|
|
|
*
|
|
|
|
* Handles the CRTC/VSYNC interrupt by notfying DRM's VBLANK
|
|
|
|
* event handler.
|
|
|
|
*/
|
2017-09-12 19:58:20 +00:00
|
|
|
static void dm_crtc_high_irq(void *interrupt_params)
|
|
|
|
{
|
|
|
|
struct common_irq_params *irq_params = interrupt_params;
|
|
|
|
struct amdgpu_device *adev = irq_params->adev;
|
|
|
|
struct amdgpu_crtc *acrtc;
|
2018-12-05 17:08:56 +00:00
|
|
|
struct dm_crtc_state *acrtc_state;
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
unsigned long flags;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2017-04-19 17:29:11 +00:00
|
|
|
acrtc = get_crtc_by_otg_inst(adev, irq_params->irq_src - IRQ_TYPE_VBLANK);
|
2019-11-04 14:22:23 +00:00
|
|
|
if (!acrtc)
|
|
|
|
return;
|
|
|
|
|
|
|
|
acrtc_state = to_dm_crtc_state(acrtc->base.state);
|
|
|
|
|
drm/amd/display: Fix pageflip event race condition for DCN.
Commit '16f17eda8bad ("drm/amd/display: Send vblank and user
events at vsartup for DCN")' introduces a new way of pageflip
completion handling for DCN, and some trouble.
The current implementation introduces a race condition, which
can cause pageflip completion events to be sent out one vblank
too early, thereby confusing userspace and causing flicker:
prepare_flip_isr():
1. Pageflip programming takes the ddev->event_lock.
2. Sets acrtc->pflip_status == AMDGPU_FLIP_SUBMITTED
3. Releases ddev->event_lock.
--> Deadline for surface address regs double-buffering passes on
target pipe.
4. dc_commit_updates_for_stream() MMIO programs the new pageflip
into hw, but too late for current vblank.
=> pflip_status == AMDGPU_FLIP_SUBMITTED, but flip won't complete
in current vblank due to missing the double-buffering deadline
by a tiny bit.
5. VSTARTUP trigger point in vblank is reached, VSTARTUP irq fires,
dm_dcn_crtc_high_irq() gets called.
6. Detects pflip_status == AMDGPU_FLIP_SUBMITTED and assumes the
pageflip has been completed/will complete in this vblank and
sends out pageflip completion event to userspace and resets
pflip_status = AMDGPU_FLIP_NONE.
=> Flip completion event sent out one vblank too early.
This behaviour has been observed during my testing with measurement
hardware a couple of time.
The commit message says that the extra flip event code was added to
dm_dcn_crtc_high_irq() to prevent missing to send out pageflip events
in case the pflip irq doesn't fire, because the "DCH HUBP" component
is clock gated and doesn't fire pflip irqs in that state. Also that
this clock gating may happen if no planes are active. This suggests
that the problem addressed by that commit can't happen if planes
are active.
The proposed solution is therefore to only execute the extra pflip
completion code iff the count of active planes is zero and otherwise
leave pflip completion handling to the pflip irq handler, for a
more race-free experience.
Note that i don't know if this fixes the problem the original commit
tried to address, as i don't know what the test scenario was. It
does fix the observed too early pageflip events though and points
out the problem introduced.
Fixes: 16f17eda8bad ("drm/amd/display: Send vblank and user events at vsartup for DCN")
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2020-03-02 06:17:32 +00:00
|
|
|
DRM_DEBUG_VBL("crtc:%d, vupdate-vrr:%d, planes:%d\n", acrtc->crtc_id,
|
|
|
|
amdgpu_dm_vrr_active(acrtc_state),
|
|
|
|
acrtc_state->active_planes);
|
2019-11-04 14:22:23 +00:00
|
|
|
|
2020-05-06 19:47:54 +00:00
|
|
|
/**
|
|
|
|
* Core vblank handling at start of front-porch is only possible
|
|
|
|
* in non-vrr mode, as only there vblank timestamping will give
|
|
|
|
* valid results while done in front-porch. Otherwise defer it
|
|
|
|
* to dm_vupdate_high_irq after end of front-porch.
|
|
|
|
*/
|
|
|
|
if (!amdgpu_dm_vrr_active(acrtc_state))
|
|
|
|
drm_crtc_handle_vblank(&acrtc->base);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Following stuff must happen at start of vblank, for crc
|
|
|
|
* computation and below-the-range btr support in vrr mode.
|
|
|
|
*/
|
2019-11-04 14:22:23 +00:00
|
|
|
amdgpu_dm_crtc_handle_crc_irq(&acrtc->base);
|
2020-05-06 19:47:54 +00:00
|
|
|
|
|
|
|
/* BTR updates need to happen before VUPDATE on Vega and above. */
|
|
|
|
if (adev->family < AMDGPU_FAMILY_AI)
|
|
|
|
return;
|
2019-11-04 14:22:23 +00:00
|
|
|
|
|
|
|
spin_lock_irqsave(&adev->ddev->event_lock, flags);
|
|
|
|
|
2020-05-06 19:47:54 +00:00
|
|
|
if (acrtc_state->stream && acrtc_state->vrr_params.supported &&
|
2019-11-04 14:22:23 +00:00
|
|
|
acrtc_state->freesync_config.state == VRR_STATE_ACTIVE_VARIABLE) {
|
2020-05-06 19:47:54 +00:00
|
|
|
mod_freesync_handle_v_update(adev->dm.freesync_module,
|
|
|
|
acrtc_state->stream,
|
|
|
|
&acrtc_state->vrr_params);
|
2019-11-04 14:22:23 +00:00
|
|
|
|
2020-05-06 19:47:54 +00:00
|
|
|
dc_stream_adjust_vmin_vmax(adev->dm.dc, acrtc_state->stream,
|
|
|
|
&acrtc_state->vrr_params.adjust);
|
2019-11-04 14:22:23 +00:00
|
|
|
}
|
|
|
|
|
drm/amd/display: Fix pageflip event race condition for DCN.
Commit '16f17eda8bad ("drm/amd/display: Send vblank and user
events at vsartup for DCN")' introduces a new way of pageflip
completion handling for DCN, and some trouble.
The current implementation introduces a race condition, which
can cause pageflip completion events to be sent out one vblank
too early, thereby confusing userspace and causing flicker:
prepare_flip_isr():
1. Pageflip programming takes the ddev->event_lock.
2. Sets acrtc->pflip_status == AMDGPU_FLIP_SUBMITTED
3. Releases ddev->event_lock.
--> Deadline for surface address regs double-buffering passes on
target pipe.
4. dc_commit_updates_for_stream() MMIO programs the new pageflip
into hw, but too late for current vblank.
=> pflip_status == AMDGPU_FLIP_SUBMITTED, but flip won't complete
in current vblank due to missing the double-buffering deadline
by a tiny bit.
5. VSTARTUP trigger point in vblank is reached, VSTARTUP irq fires,
dm_dcn_crtc_high_irq() gets called.
6. Detects pflip_status == AMDGPU_FLIP_SUBMITTED and assumes the
pageflip has been completed/will complete in this vblank and
sends out pageflip completion event to userspace and resets
pflip_status = AMDGPU_FLIP_NONE.
=> Flip completion event sent out one vblank too early.
This behaviour has been observed during my testing with measurement
hardware a couple of time.
The commit message says that the extra flip event code was added to
dm_dcn_crtc_high_irq() to prevent missing to send out pageflip events
in case the pflip irq doesn't fire, because the "DCH HUBP" component
is clock gated and doesn't fire pflip irqs in that state. Also that
this clock gating may happen if no planes are active. This suggests
that the problem addressed by that commit can't happen if planes
are active.
The proposed solution is therefore to only execute the extra pflip
completion code iff the count of active planes is zero and otherwise
leave pflip completion handling to the pflip irq handler, for a
more race-free experience.
Note that i don't know if this fixes the problem the original commit
tried to address, as i don't know what the test scenario was. It
does fix the observed too early pageflip events though and points
out the problem introduced.
Fixes: 16f17eda8bad ("drm/amd/display: Send vblank and user events at vsartup for DCN")
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2020-03-02 06:17:32 +00:00
|
|
|
/*
|
|
|
|
* If there aren't any active_planes then DCH HUBP may be clock-gated.
|
|
|
|
* In that case, pageflip completion interrupts won't fire and pageflip
|
|
|
|
* completion events won't get delivered. Prevent this by sending
|
|
|
|
* pending pageflip events from here if a flip is still pending.
|
|
|
|
*
|
|
|
|
* If any planes are enabled, use dm_pflip_high_irq() instead, to
|
|
|
|
* avoid race conditions between flip programming and completion,
|
|
|
|
* which could cause too early flip completion events.
|
|
|
|
*/
|
2020-05-06 19:47:54 +00:00
|
|
|
if (adev->family >= AMDGPU_FAMILY_RV &&
|
|
|
|
acrtc->pflip_status == AMDGPU_FLIP_SUBMITTED &&
|
drm/amd/display: Fix pageflip event race condition for DCN.
Commit '16f17eda8bad ("drm/amd/display: Send vblank and user
events at vsartup for DCN")' introduces a new way of pageflip
completion handling for DCN, and some trouble.
The current implementation introduces a race condition, which
can cause pageflip completion events to be sent out one vblank
too early, thereby confusing userspace and causing flicker:
prepare_flip_isr():
1. Pageflip programming takes the ddev->event_lock.
2. Sets acrtc->pflip_status == AMDGPU_FLIP_SUBMITTED
3. Releases ddev->event_lock.
--> Deadline for surface address regs double-buffering passes on
target pipe.
4. dc_commit_updates_for_stream() MMIO programs the new pageflip
into hw, but too late for current vblank.
=> pflip_status == AMDGPU_FLIP_SUBMITTED, but flip won't complete
in current vblank due to missing the double-buffering deadline
by a tiny bit.
5. VSTARTUP trigger point in vblank is reached, VSTARTUP irq fires,
dm_dcn_crtc_high_irq() gets called.
6. Detects pflip_status == AMDGPU_FLIP_SUBMITTED and assumes the
pageflip has been completed/will complete in this vblank and
sends out pageflip completion event to userspace and resets
pflip_status = AMDGPU_FLIP_NONE.
=> Flip completion event sent out one vblank too early.
This behaviour has been observed during my testing with measurement
hardware a couple of time.
The commit message says that the extra flip event code was added to
dm_dcn_crtc_high_irq() to prevent missing to send out pageflip events
in case the pflip irq doesn't fire, because the "DCH HUBP" component
is clock gated and doesn't fire pflip irqs in that state. Also that
this clock gating may happen if no planes are active. This suggests
that the problem addressed by that commit can't happen if planes
are active.
The proposed solution is therefore to only execute the extra pflip
completion code iff the count of active planes is zero and otherwise
leave pflip completion handling to the pflip irq handler, for a
more race-free experience.
Note that i don't know if this fixes the problem the original commit
tried to address, as i don't know what the test scenario was. It
does fix the observed too early pageflip events though and points
out the problem introduced.
Fixes: 16f17eda8bad ("drm/amd/display: Send vblank and user events at vsartup for DCN")
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2020-03-02 06:17:32 +00:00
|
|
|
acrtc_state->active_planes == 0) {
|
2019-11-04 14:22:23 +00:00
|
|
|
if (acrtc->event) {
|
|
|
|
drm_crtc_send_vblank_event(&acrtc->base, acrtc->event);
|
|
|
|
acrtc->event = NULL;
|
|
|
|
drm_crtc_vblank_put(&acrtc->base);
|
|
|
|
}
|
|
|
|
acrtc->pflip_status = AMDGPU_FLIP_NONE;
|
|
|
|
}
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&adev->ddev->event_lock, flags);
|
|
|
|
}
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
static int dm_set_clockgating_state(void *handle,
|
|
|
|
enum amd_clockgating_state state)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int dm_set_powergating_state(void *handle,
|
|
|
|
enum amd_powergating_state state)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Prototypes of private functions */
|
|
|
|
static int dm_early_init(void* handle);
|
|
|
|
|
2017-07-27 23:53:55 +00:00
|
|
|
/* Allocate memory for FBC compressed data */
|
2018-02-06 23:47:26 +00:00
|
|
|
static void amdgpu_dm_fbc_init(struct drm_connector *connector)
|
2017-07-27 23:53:55 +00:00
|
|
|
{
|
2018-02-06 23:47:26 +00:00
|
|
|
struct drm_device *dev = connector->dev;
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
2017-07-27 23:53:55 +00:00
|
|
|
struct dm_comressor_info *compressor = &adev->dm.compressor;
|
2018-02-06 23:47:26 +00:00
|
|
|
struct amdgpu_dm_connector *aconn = to_amdgpu_dm_connector(connector);
|
|
|
|
struct drm_display_mode *mode;
|
2017-12-13 22:25:02 +00:00
|
|
|
unsigned long max_size = 0;
|
|
|
|
|
|
|
|
if (adev->dm.dc->fbc_compressor == NULL)
|
|
|
|
return;
|
2017-07-27 23:53:55 +00:00
|
|
|
|
2018-02-06 23:47:26 +00:00
|
|
|
if (aconn->dc_link->connector_signal != SIGNAL_TYPE_EDP)
|
2017-12-13 22:25:02 +00:00
|
|
|
return;
|
|
|
|
|
2018-02-06 23:47:26 +00:00
|
|
|
if (compressor->bo_ptr)
|
|
|
|
return;
|
2017-12-13 22:25:02 +00:00
|
|
|
|
|
|
|
|
2018-02-06 23:47:26 +00:00
|
|
|
list_for_each_entry(mode, &connector->modes, head) {
|
|
|
|
if (max_size < mode->htotal * mode->vtotal)
|
|
|
|
max_size = mode->htotal * mode->vtotal;
|
2017-12-13 22:25:02 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (max_size) {
|
|
|
|
int r = amdgpu_bo_create_kernel(adev, max_size * 4, PAGE_SIZE,
|
2018-02-20 09:04:16 +00:00
|
|
|
AMDGPU_GEM_DOMAIN_GTT, &compressor->bo_ptr,
|
2017-12-13 22:25:02 +00:00
|
|
|
&compressor->gpu_addr, &compressor->cpu_addr);
|
2017-07-27 23:53:55 +00:00
|
|
|
|
|
|
|
if (r)
|
2017-12-13 22:25:02 +00:00
|
|
|
DRM_ERROR("DM: Failed to initialize FBC\n");
|
|
|
|
else {
|
|
|
|
adev->dm.dc->ctx->fbc_gpu_addr = compressor->gpu_addr;
|
|
|
|
DRM_INFO("DM: FBC alloc %lu\n", max_size*4);
|
|
|
|
}
|
|
|
|
|
2017-07-27 23:53:55 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2019-07-11 19:31:46 +00:00
|
|
|
static int amdgpu_dm_audio_component_get_eld(struct device *kdev, int port,
|
|
|
|
int pipe, bool *enabled,
|
|
|
|
unsigned char *buf, int max_bytes)
|
|
|
|
{
|
|
|
|
struct drm_device *dev = dev_get_drvdata(kdev);
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
struct drm_connector *connector;
|
|
|
|
struct drm_connector_list_iter conn_iter;
|
|
|
|
struct amdgpu_dm_connector *aconnector;
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
*enabled = false;
|
|
|
|
|
|
|
|
mutex_lock(&adev->dm.audio_lock);
|
|
|
|
|
|
|
|
drm_connector_list_iter_begin(dev, &conn_iter);
|
|
|
|
drm_for_each_connector_iter(connector, &conn_iter) {
|
|
|
|
aconnector = to_amdgpu_dm_connector(connector);
|
|
|
|
if (aconnector->audio_inst != port)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
*enabled = true;
|
|
|
|
ret = drm_eld_size(connector->eld);
|
|
|
|
memcpy(buf, connector->eld, min(max_bytes, ret));
|
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
drm_connector_list_iter_end(&conn_iter);
|
|
|
|
|
|
|
|
mutex_unlock(&adev->dm.audio_lock);
|
|
|
|
|
|
|
|
DRM_DEBUG_KMS("Get ELD : idx=%d ret=%d en=%d\n", port, ret, *enabled);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct drm_audio_component_ops amdgpu_dm_audio_component_ops = {
|
|
|
|
.get_eld = amdgpu_dm_audio_component_get_eld,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int amdgpu_dm_audio_component_bind(struct device *kdev,
|
|
|
|
struct device *hda_kdev, void *data)
|
|
|
|
{
|
|
|
|
struct drm_device *dev = dev_get_drvdata(kdev);
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
struct drm_audio_component *acomp = data;
|
|
|
|
|
|
|
|
acomp->ops = &amdgpu_dm_audio_component_ops;
|
|
|
|
acomp->dev = kdev;
|
|
|
|
adev->dm.audio_component = acomp;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void amdgpu_dm_audio_component_unbind(struct device *kdev,
|
|
|
|
struct device *hda_kdev, void *data)
|
|
|
|
{
|
|
|
|
struct drm_device *dev = dev_get_drvdata(kdev);
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
struct drm_audio_component *acomp = data;
|
|
|
|
|
|
|
|
acomp->ops = NULL;
|
|
|
|
acomp->dev = NULL;
|
|
|
|
adev->dm.audio_component = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct component_ops amdgpu_dm_audio_component_bind_ops = {
|
|
|
|
.bind = amdgpu_dm_audio_component_bind,
|
|
|
|
.unbind = amdgpu_dm_audio_component_unbind,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int amdgpu_dm_audio_init(struct amdgpu_device *adev)
|
|
|
|
{
|
|
|
|
int i, ret;
|
|
|
|
|
|
|
|
if (!amdgpu_audio)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
adev->mode_info.audio.enabled = true;
|
|
|
|
|
|
|
|
adev->mode_info.audio.num_pins = adev->dm.dc->res_pool->audio_count;
|
|
|
|
|
|
|
|
for (i = 0; i < adev->mode_info.audio.num_pins; i++) {
|
|
|
|
adev->mode_info.audio.pin[i].channels = -1;
|
|
|
|
adev->mode_info.audio.pin[i].rate = -1;
|
|
|
|
adev->mode_info.audio.pin[i].bits_per_sample = -1;
|
|
|
|
adev->mode_info.audio.pin[i].status_bits = 0;
|
|
|
|
adev->mode_info.audio.pin[i].category_code = 0;
|
|
|
|
adev->mode_info.audio.pin[i].connected = false;
|
|
|
|
adev->mode_info.audio.pin[i].id =
|
|
|
|
adev->dm.dc->res_pool->audios[i]->inst;
|
|
|
|
adev->mode_info.audio.pin[i].offset = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = component_add(adev->dev, &amdgpu_dm_audio_component_bind_ops);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
adev->dm.audio_registered = true;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void amdgpu_dm_audio_fini(struct amdgpu_device *adev)
|
|
|
|
{
|
|
|
|
if (!amdgpu_audio)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (!adev->mode_info.audio.enabled)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (adev->dm.audio_registered) {
|
|
|
|
component_del(adev->dev, &amdgpu_dm_audio_component_bind_ops);
|
|
|
|
adev->dm.audio_registered = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* TODO: Disable audio? */
|
|
|
|
|
|
|
|
adev->mode_info.audio.enabled = false;
|
|
|
|
}
|
|
|
|
|
2020-06-18 13:07:13 +00:00
|
|
|
static void amdgpu_dm_audio_eld_notify(struct amdgpu_device *adev, int pin)
|
2019-07-11 19:31:46 +00:00
|
|
|
{
|
|
|
|
struct drm_audio_component *acomp = adev->dm.audio_component;
|
|
|
|
|
|
|
|
if (acomp && acomp->audio_ops && acomp->audio_ops->pin_eld_notify) {
|
|
|
|
DRM_DEBUG_KMS("Notify ELD: %d\n", pin);
|
|
|
|
|
|
|
|
acomp->audio_ops->pin_eld_notify(acomp->audio_ops->audio_ptr,
|
|
|
|
pin, -1);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-10-25 00:38:48 +00:00
|
|
|
static int dm_dmub_hw_init(struct amdgpu_device *adev)
|
|
|
|
{
|
|
|
|
const struct dmcub_firmware_header_v1_0 *hdr;
|
|
|
|
struct dmub_srv *dmub_srv = adev->dm.dmub_srv;
|
2019-11-25 14:49:27 +00:00
|
|
|
struct dmub_srv_fb_info *fb_info = adev->dm.dmub_fb_info;
|
2019-10-25 00:38:48 +00:00
|
|
|
const struct firmware *dmub_fw = adev->dm.dmub_fw;
|
|
|
|
struct dmcu *dmcu = adev->dm.dc->res_pool->dmcu;
|
|
|
|
struct abm *abm = adev->dm.dc->res_pool->abm;
|
|
|
|
struct dmub_srv_hw_params hw_params;
|
|
|
|
enum dmub_status status;
|
|
|
|
const unsigned char *fw_inst_const, *fw_bss_data;
|
2019-11-25 14:49:27 +00:00
|
|
|
uint32_t i, fw_inst_const_size, fw_bss_data_size;
|
2019-10-25 00:38:48 +00:00
|
|
|
bool has_hw_support;
|
|
|
|
|
|
|
|
if (!dmub_srv)
|
|
|
|
/* DMUB isn't supported on the ASIC. */
|
|
|
|
return 0;
|
|
|
|
|
2019-11-25 14:49:27 +00:00
|
|
|
if (!fb_info) {
|
|
|
|
DRM_ERROR("No framebuffer info for DMUB service.\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2019-10-25 00:38:48 +00:00
|
|
|
if (!dmub_fw) {
|
|
|
|
/* Firmware required for DMUB support. */
|
|
|
|
DRM_ERROR("No firmware provided for DMUB.\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
status = dmub_srv_has_hw_support(dmub_srv, &has_hw_support);
|
|
|
|
if (status != DMUB_STATUS_OK) {
|
|
|
|
DRM_ERROR("Error checking HW support for DMUB: %d\n", status);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!has_hw_support) {
|
|
|
|
DRM_INFO("DMUB unsupported on ASIC\n");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
hdr = (const struct dmcub_firmware_header_v1_0 *)dmub_fw->data;
|
|
|
|
|
|
|
|
fw_inst_const = dmub_fw->data +
|
|
|
|
le32_to_cpu(hdr->header.ucode_array_offset_bytes) +
|
2019-11-25 14:49:27 +00:00
|
|
|
PSP_HEADER_BYTES;
|
2019-10-25 00:38:48 +00:00
|
|
|
|
|
|
|
fw_bss_data = dmub_fw->data +
|
|
|
|
le32_to_cpu(hdr->header.ucode_array_offset_bytes) +
|
|
|
|
le32_to_cpu(hdr->inst_const_bytes);
|
|
|
|
|
|
|
|
/* Copy firmware and bios info into FB memory. */
|
2019-11-25 14:49:27 +00:00
|
|
|
fw_inst_const_size = le32_to_cpu(hdr->inst_const_bytes) -
|
|
|
|
PSP_HEADER_BYTES - PSP_FOOTER_BYTES;
|
|
|
|
|
|
|
|
fw_bss_data_size = le32_to_cpu(hdr->bss_data_bytes);
|
|
|
|
|
2020-02-05 22:48:39 +00:00
|
|
|
/* if adev->firmware.load_type == AMDGPU_FW_LOAD_PSP,
|
|
|
|
* amdgpu_ucode_init_single_fw will load dmub firmware
|
|
|
|
* fw_inst_const part to cw0; otherwise, the firmware back door load
|
|
|
|
* will be done by dm_dmub_hw_init
|
|
|
|
*/
|
|
|
|
if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP) {
|
|
|
|
memcpy(fb_info->fb[DMUB_WINDOW_0_INST_CONST].cpu_addr, fw_inst_const,
|
|
|
|
fw_inst_const_size);
|
|
|
|
}
|
|
|
|
|
2020-04-05 20:41:14 +00:00
|
|
|
if (fw_bss_data_size)
|
|
|
|
memcpy(fb_info->fb[DMUB_WINDOW_2_BSS_DATA].cpu_addr,
|
|
|
|
fw_bss_data, fw_bss_data_size);
|
2020-02-05 22:48:39 +00:00
|
|
|
|
|
|
|
/* Copy firmware bios info into FB memory. */
|
2019-11-25 14:49:27 +00:00
|
|
|
memcpy(fb_info->fb[DMUB_WINDOW_3_VBIOS].cpu_addr, adev->bios,
|
|
|
|
adev->bios_size);
|
|
|
|
|
|
|
|
/* Reset regions that need to be reset. */
|
|
|
|
memset(fb_info->fb[DMUB_WINDOW_4_MAILBOX].cpu_addr, 0,
|
|
|
|
fb_info->fb[DMUB_WINDOW_4_MAILBOX].size);
|
|
|
|
|
|
|
|
memset(fb_info->fb[DMUB_WINDOW_5_TRACEBUFF].cpu_addr, 0,
|
|
|
|
fb_info->fb[DMUB_WINDOW_5_TRACEBUFF].size);
|
|
|
|
|
|
|
|
memset(fb_info->fb[DMUB_WINDOW_6_FW_STATE].cpu_addr, 0,
|
|
|
|
fb_info->fb[DMUB_WINDOW_6_FW_STATE].size);
|
2019-10-25 00:38:48 +00:00
|
|
|
|
|
|
|
/* Initialize hardware. */
|
|
|
|
memset(&hw_params, 0, sizeof(hw_params));
|
|
|
|
hw_params.fb_base = adev->gmc.fb_start;
|
|
|
|
hw_params.fb_offset = adev->gmc.aper_base;
|
|
|
|
|
2020-02-05 19:58:53 +00:00
|
|
|
/* backdoor load firmware and trigger dmub running */
|
|
|
|
if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP)
|
|
|
|
hw_params.load_inst_const = true;
|
|
|
|
|
2019-10-25 00:38:48 +00:00
|
|
|
if (dmcu)
|
|
|
|
hw_params.psp_version = dmcu->psp_version;
|
|
|
|
|
2019-11-25 14:49:27 +00:00
|
|
|
for (i = 0; i < fb_info->num_fb; ++i)
|
|
|
|
hw_params.fb[i] = &fb_info->fb[i];
|
2019-10-25 00:38:48 +00:00
|
|
|
|
|
|
|
status = dmub_srv_hw_init(dmub_srv, &hw_params);
|
|
|
|
if (status != DMUB_STATUS_OK) {
|
|
|
|
DRM_ERROR("Error initializing DMUB HW: %d\n", status);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Wait for firmware load to finish. */
|
|
|
|
status = dmub_srv_wait_for_auto_load(dmub_srv, 100000);
|
|
|
|
if (status != DMUB_STATUS_OK)
|
|
|
|
DRM_WARN("Wait for DMUB auto-load failed: %d\n", status);
|
|
|
|
|
|
|
|
/* Init DMCU and ABM if available. */
|
|
|
|
if (dmcu && abm) {
|
|
|
|
dmcu->funcs->dmcu_init(dmcu);
|
|
|
|
abm->dmcu_is_running = dmcu->funcs->is_dmcu_initialized(dmcu);
|
|
|
|
}
|
|
|
|
|
2019-10-28 13:07:30 +00:00
|
|
|
adev->dm.dc->ctx->dmub_srv = dc_dmub_srv_create(adev->dm.dc, dmub_srv);
|
|
|
|
if (!adev->dm.dc->ctx->dmub_srv) {
|
|
|
|
DRM_ERROR("Couldn't allocate DC DMUB server!\n");
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
2019-10-25 00:38:48 +00:00
|
|
|
DRM_INFO("DMUB hardware initialized: version=0x%08X\n",
|
|
|
|
adev->dm.dmcub_fw_version);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static int amdgpu_dm_init(struct amdgpu_device *adev)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
|
|
|
struct dc_init_data init_data;
|
2019-05-24 19:44:20 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
|
|
|
struct dc_callback_init init_params;
|
|
|
|
#endif
|
2019-10-25 00:38:48 +00:00
|
|
|
int r;
|
2019-05-24 19:44:20 +00:00
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
adev->dm.ddev = adev->ddev;
|
|
|
|
adev->dm.adev = adev;
|
|
|
|
|
|
|
|
/* Zero all the fields */
|
|
|
|
memset(&init_data, 0, sizeof(init_data));
|
2019-05-24 19:44:20 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
|
|
|
memset(&init_params, 0, sizeof(init_params));
|
|
|
|
#endif
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2018-12-05 19:59:07 +00:00
|
|
|
mutex_init(&adev->dm.dc_lock);
|
2019-07-11 19:31:46 +00:00
|
|
|
mutex_init(&adev->dm.audio_lock);
|
2018-12-05 19:59:07 +00:00
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
if(amdgpu_dm_irq_init(adev)) {
|
|
|
|
DRM_ERROR("amdgpu: failed to initialize DM IRQ support.\n");
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
init_data.asic_id.chip_family = adev->family;
|
|
|
|
|
2020-02-25 19:56:37 +00:00
|
|
|
init_data.asic_id.pci_revision_id = adev->pdev->revision;
|
2017-09-12 19:58:20 +00:00
|
|
|
init_data.asic_id.hw_internal_rev = adev->external_rev_id;
|
|
|
|
|
2018-01-12 13:52:22 +00:00
|
|
|
init_data.asic_id.vram_width = adev->gmc.vram_width;
|
2017-09-12 19:58:20 +00:00
|
|
|
/* TODO: initialize init_data.asic_id.vram_type here!!!! */
|
|
|
|
init_data.asic_id.atombios_base_address =
|
|
|
|
adev->mode_info.atom_context->bios;
|
|
|
|
|
|
|
|
init_data.driver = adev;
|
|
|
|
|
|
|
|
adev->dm.cgs_device = amdgpu_cgs_create_device(adev);
|
|
|
|
|
|
|
|
if (!adev->dm.cgs_device) {
|
|
|
|
DRM_ERROR("amdgpu: failed to create cgs device.\n");
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
init_data.cgs_device = adev->dm.cgs_device;
|
|
|
|
|
|
|
|
init_data.dce_environment = DCE_ENV_PRODUCTION_DRV;
|
|
|
|
|
2020-01-08 22:43:55 +00:00
|
|
|
switch (adev->asic_type) {
|
|
|
|
case CHIP_CARRIZO:
|
|
|
|
case CHIP_STONEY:
|
|
|
|
case CHIP_RAVEN:
|
2020-01-08 22:47:23 +00:00
|
|
|
case CHIP_RENOIR:
|
2017-10-30 17:41:51 +00:00
|
|
|
init_data.flags.gpu_vm_support = true;
|
2020-01-08 22:43:55 +00:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
2017-10-30 17:41:51 +00:00
|
|
|
|
2018-11-06 20:19:49 +00:00
|
|
|
if (amdgpu_dc_feature_mask & DC_FBC_MASK)
|
|
|
|
init_data.flags.fbc_support = true;
|
|
|
|
|
2019-08-22 19:17:57 +00:00
|
|
|
if (amdgpu_dc_feature_mask & DC_MULTI_MON_PP_MCLK_SWITCH_MASK)
|
|
|
|
init_data.flags.multi_mon_pp_mclk_switch = true;
|
|
|
|
|
2019-10-21 18:58:47 +00:00
|
|
|
if (amdgpu_dc_feature_mask & DC_DISABLE_FRACTIONAL_PWM_MASK)
|
|
|
|
init_data.flags.disable_fractional_pwm = true;
|
|
|
|
|
2019-04-10 21:06:07 +00:00
|
|
|
init_data.flags.power_down_display_on_boot = true;
|
2019-05-07 20:08:22 +00:00
|
|
|
|
2019-05-07 19:34:21 +00:00
|
|
|
init_data.soc_bounding_box = adev->dm.soc_bounding_box;
|
2019-04-10 21:06:07 +00:00
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
/* Display Core create. */
|
|
|
|
adev->dm.dc = dc_create(&init_data);
|
|
|
|
|
2017-11-07 20:06:59 +00:00
|
|
|
if (adev->dm.dc) {
|
2017-11-21 18:19:32 +00:00
|
|
|
DRM_INFO("Display Core initialized with v%s!\n", DC_VER);
|
2017-11-07 20:06:59 +00:00
|
|
|
} else {
|
2017-11-21 18:19:32 +00:00
|
|
|
DRM_INFO("Display Core failed to initialize with v%s!\n", DC_VER);
|
2017-11-07 20:06:59 +00:00
|
|
|
goto error;
|
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2020-05-01 18:23:37 +00:00
|
|
|
if (amdgpu_dc_debug_mask & DC_DISABLE_PIPE_SPLIT) {
|
|
|
|
adev->dm.dc->debug.force_single_disp_pipe_split = false;
|
|
|
|
adev->dm.dc->debug.pipe_split_policy = MPC_SPLIT_AVOID;
|
|
|
|
}
|
|
|
|
|
2020-05-07 15:34:08 +00:00
|
|
|
if (adev->asic_type != CHIP_CARRIZO && adev->asic_type != CHIP_STONEY)
|
|
|
|
adev->dm.dc->debug.disable_stutter = amdgpu_pp_feature_mask & PP_STUTTER_MODE ? false : true;
|
|
|
|
|
2020-05-01 18:23:37 +00:00
|
|
|
if (amdgpu_dc_debug_mask & DC_DISABLE_STUTTER)
|
|
|
|
adev->dm.dc->debug.disable_stutter = true;
|
|
|
|
|
|
|
|
if (amdgpu_dc_debug_mask & DC_DISABLE_DSC)
|
|
|
|
adev->dm.dc->debug.disable_dsc = true;
|
|
|
|
|
|
|
|
if (amdgpu_dc_debug_mask & DC_DISABLE_CLOCK_GATING)
|
|
|
|
adev->dm.dc->debug.disable_clock_gate = true;
|
|
|
|
|
2019-10-25 00:38:48 +00:00
|
|
|
r = dm_dmub_hw_init(adev);
|
|
|
|
if (r) {
|
|
|
|
DRM_ERROR("DMUB interface failed to initialize: status=%d\n", r);
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
2020-01-10 14:17:58 +00:00
|
|
|
dc_hardware_init(adev->dm.dc);
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
adev->dm.freesync_module = mod_freesync_create(adev->dm.dc);
|
|
|
|
if (!adev->dm.freesync_module) {
|
|
|
|
DRM_ERROR(
|
|
|
|
"amdgpu: failed to initialize freesync_module.\n");
|
|
|
|
} else
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("amdgpu: freesync_module init done %p.\n",
|
2017-09-12 19:58:20 +00:00
|
|
|
adev->dm.freesync_module);
|
|
|
|
|
2018-02-02 15:18:56 +00:00
|
|
|
amdgpu_dm_init_color_mod();
|
|
|
|
|
2019-05-24 19:44:20 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
2019-06-24 18:54:13 +00:00
|
|
|
if (adev->asic_type >= CHIP_RAVEN) {
|
2019-12-12 21:28:23 +00:00
|
|
|
adev->dm.hdcp_workqueue = hdcp_create_workqueue(adev, &init_params.cp_psp, adev->dm.dc);
|
2019-05-24 19:44:20 +00:00
|
|
|
|
2019-06-24 18:54:13 +00:00
|
|
|
if (!adev->dm.hdcp_workqueue)
|
|
|
|
DRM_ERROR("amdgpu: failed to initialize hdcp_workqueue.\n");
|
|
|
|
else
|
|
|
|
DRM_DEBUG_DRIVER("amdgpu: hdcp_workqueue init done %p.\n", adev->dm.hdcp_workqueue);
|
2019-05-24 19:44:20 +00:00
|
|
|
|
2019-06-24 18:54:13 +00:00
|
|
|
dc_init_callbacks(adev->dm.dc, &init_params);
|
|
|
|
}
|
2019-05-24 19:44:20 +00:00
|
|
|
#endif
|
2017-09-12 19:58:20 +00:00
|
|
|
if (amdgpu_dm_initialize_drm_device(adev)) {
|
|
|
|
DRM_ERROR(
|
|
|
|
"amdgpu: failed to initialize sw for display support.\n");
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Update the actual used number of crtc */
|
|
|
|
adev->mode_info.num_crtc = adev->dm.display_indexes_num;
|
|
|
|
|
2020-07-10 21:50:00 +00:00
|
|
|
/* create fake encoders for MST */
|
|
|
|
dm_dp_create_fake_mst_encoders(adev);
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
/* TODO: Add_display_info? */
|
|
|
|
|
|
|
|
/* TODO use dynamic cursor width */
|
2017-02-22 19:24:11 +00:00
|
|
|
adev->ddev->mode_config.cursor_width = adev->dm.dc->caps.max_cursor_size;
|
|
|
|
adev->ddev->mode_config.cursor_height = adev->dm.dc->caps.max_cursor_size;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
if (drm_vblank_init(adev->ddev, adev->dm.display_indexes_num)) {
|
|
|
|
DRM_ERROR(
|
|
|
|
"amdgpu: failed to initialize sw for display support.\n");
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("KMS initialized.\n");
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
error:
|
|
|
|
amdgpu_dm_fini(adev);
|
|
|
|
|
2018-09-13 16:01:28 +00:00
|
|
|
return -EINVAL;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static void amdgpu_dm_fini(struct amdgpu_device *adev)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
2020-07-10 21:50:00 +00:00
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < adev->dm.display_indexes_num; i++) {
|
|
|
|
drm_encoder_cleanup(&adev->dm.mst_encoders[i].base);
|
|
|
|
}
|
|
|
|
|
2019-07-11 19:31:46 +00:00
|
|
|
amdgpu_dm_audio_fini(adev);
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
amdgpu_dm_destroy_drm_device(&adev->dm);
|
2019-05-27 03:12:51 +00:00
|
|
|
|
2019-05-24 19:44:20 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
|
|
|
if (adev->dm.hdcp_workqueue) {
|
|
|
|
hdcp_destroy(adev->dm.hdcp_workqueue);
|
|
|
|
adev->dm.hdcp_workqueue = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (adev->dm.dc)
|
|
|
|
dc_deinit_callbacks(adev->dm.dc);
|
|
|
|
#endif
|
2019-10-28 13:07:30 +00:00
|
|
|
if (adev->dm.dc->ctx->dmub_srv) {
|
|
|
|
dc_dmub_srv_destroy(&adev->dm.dc->ctx->dmub_srv);
|
|
|
|
adev->dm.dc->ctx->dmub_srv = NULL;
|
|
|
|
}
|
|
|
|
|
2019-10-25 00:38:48 +00:00
|
|
|
if (adev->dm.dmub_bo)
|
|
|
|
amdgpu_bo_free_kernel(&adev->dm.dmub_bo,
|
|
|
|
&adev->dm.dmub_bo_gpu_addr,
|
|
|
|
&adev->dm.dmub_bo_cpu_addr);
|
2019-05-24 19:44:20 +00:00
|
|
|
|
2019-05-27 03:12:51 +00:00
|
|
|
/* DC Destroy TODO: Replace destroy DAL */
|
|
|
|
if (adev->dm.dc)
|
|
|
|
dc_destroy(&adev->dm.dc);
|
2017-09-12 19:58:20 +00:00
|
|
|
/*
|
|
|
|
* TODO: pageflip, vlank interrupt
|
|
|
|
*
|
|
|
|
* amdgpu_dm_irq_fini(adev);
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (adev->dm.cgs_device) {
|
|
|
|
amdgpu_cgs_destroy_device(adev->dm.cgs_device);
|
|
|
|
adev->dm.cgs_device = NULL;
|
|
|
|
}
|
|
|
|
if (adev->dm.freesync_module) {
|
|
|
|
mod_freesync_destroy(adev->dm.freesync_module);
|
|
|
|
adev->dm.freesync_module = NULL;
|
|
|
|
}
|
2018-12-05 19:59:07 +00:00
|
|
|
|
2019-07-11 19:31:46 +00:00
|
|
|
mutex_destroy(&adev->dm.audio_lock);
|
2018-12-05 19:59:07 +00:00
|
|
|
mutex_destroy(&adev->dm.dc_lock);
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-09-11 17:49:49 +00:00
|
|
|
static int load_dmcu_fw(struct amdgpu_device *adev)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
2019-04-29 13:39:15 +00:00
|
|
|
const char *fw_name_dmcu = NULL;
|
2018-09-11 17:49:49 +00:00
|
|
|
int r;
|
|
|
|
const struct dmcu_firmware_header_v1_0 *hdr;
|
|
|
|
|
|
|
|
switch(adev->asic_type) {
|
|
|
|
case CHIP_BONAIRE:
|
|
|
|
case CHIP_HAWAII:
|
|
|
|
case CHIP_KAVERI:
|
|
|
|
case CHIP_KABINI:
|
|
|
|
case CHIP_MULLINS:
|
|
|
|
case CHIP_TONGA:
|
|
|
|
case CHIP_FIJI:
|
|
|
|
case CHIP_CARRIZO:
|
|
|
|
case CHIP_STONEY:
|
|
|
|
case CHIP_POLARIS11:
|
|
|
|
case CHIP_POLARIS10:
|
|
|
|
case CHIP_POLARIS12:
|
|
|
|
case CHIP_VEGAM:
|
|
|
|
case CHIP_VEGA10:
|
|
|
|
case CHIP_VEGA12:
|
|
|
|
case CHIP_VEGA20:
|
2019-02-22 21:52:52 +00:00
|
|
|
case CHIP_NAVI10:
|
2019-03-15 11:15:21 +00:00
|
|
|
case CHIP_NAVI14:
|
2019-07-26 21:08:45 +00:00
|
|
|
case CHIP_RENOIR:
|
2020-05-21 16:48:41 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN3_0)
|
|
|
|
case CHIP_SIENNA_CICHLID:
|
2020-07-08 21:11:12 +00:00
|
|
|
case CHIP_NAVY_FLOUNDER:
|
2020-05-21 16:48:41 +00:00
|
|
|
#endif
|
2018-09-11 17:49:49 +00:00
|
|
|
return 0;
|
2020-02-05 14:39:41 +00:00
|
|
|
case CHIP_NAVI12:
|
|
|
|
fw_name_dmcu = FIRMWARE_NAVI12_DMCU;
|
|
|
|
break;
|
2018-09-11 17:49:49 +00:00
|
|
|
case CHIP_RAVEN:
|
2019-04-29 13:39:15 +00:00
|
|
|
if (ASICREV_IS_PICASSO(adev->external_rev_id))
|
|
|
|
fw_name_dmcu = FIRMWARE_RAVEN_DMCU;
|
|
|
|
else if (ASICREV_IS_RAVEN2(adev->external_rev_id))
|
|
|
|
fw_name_dmcu = FIRMWARE_RAVEN_DMCU;
|
|
|
|
else
|
|
|
|
return 0;
|
2018-09-11 17:49:49 +00:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);
|
2018-09-13 16:01:28 +00:00
|
|
|
return -EINVAL;
|
2018-09-11 17:49:49 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP) {
|
|
|
|
DRM_DEBUG_KMS("dm: DMCU firmware not supported on direct or SMU loading\n");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
r = request_firmware_direct(&adev->dm.fw_dmcu, fw_name_dmcu, adev->dev);
|
|
|
|
if (r == -ENOENT) {
|
|
|
|
/* DMCU firmware is not necessary, so don't raise a fuss if it's missing */
|
|
|
|
DRM_DEBUG_KMS("dm: DMCU firmware not found\n");
|
|
|
|
adev->dm.fw_dmcu = NULL;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
if (r) {
|
|
|
|
dev_err(adev->dev, "amdgpu_dm: Can't load firmware \"%s\"\n",
|
|
|
|
fw_name_dmcu);
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
r = amdgpu_ucode_validate(adev->dm.fw_dmcu);
|
|
|
|
if (r) {
|
|
|
|
dev_err(adev->dev, "amdgpu_dm: Can't validate firmware \"%s\"\n",
|
|
|
|
fw_name_dmcu);
|
|
|
|
release_firmware(adev->dm.fw_dmcu);
|
|
|
|
adev->dm.fw_dmcu = NULL;
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
hdr = (const struct dmcu_firmware_header_v1_0 *)adev->dm.fw_dmcu->data;
|
|
|
|
adev->firmware.ucode[AMDGPU_UCODE_ID_DMCU_ERAM].ucode_id = AMDGPU_UCODE_ID_DMCU_ERAM;
|
|
|
|
adev->firmware.ucode[AMDGPU_UCODE_ID_DMCU_ERAM].fw = adev->dm.fw_dmcu;
|
|
|
|
adev->firmware.fw_size +=
|
|
|
|
ALIGN(le32_to_cpu(hdr->header.ucode_size_bytes) - le32_to_cpu(hdr->intv_size_bytes), PAGE_SIZE);
|
|
|
|
|
|
|
|
adev->firmware.ucode[AMDGPU_UCODE_ID_DMCU_INTV].ucode_id = AMDGPU_UCODE_ID_DMCU_INTV;
|
|
|
|
adev->firmware.ucode[AMDGPU_UCODE_ID_DMCU_INTV].fw = adev->dm.fw_dmcu;
|
|
|
|
adev->firmware.fw_size +=
|
|
|
|
ALIGN(le32_to_cpu(hdr->intv_size_bytes), PAGE_SIZE);
|
|
|
|
|
2018-09-13 19:36:27 +00:00
|
|
|
adev->dm.dmcu_fw_version = le32_to_cpu(hdr->header.ucode_version);
|
|
|
|
|
2018-09-11 17:49:49 +00:00
|
|
|
DRM_DEBUG_KMS("PSP loading DMCU firmware\n");
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-10-25 00:38:48 +00:00
|
|
|
static uint32_t amdgpu_dm_dmub_reg_read(void *ctx, uint32_t address)
|
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = ctx;
|
|
|
|
|
|
|
|
return dm_read_reg(adev->dm.dc->ctx, address);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void amdgpu_dm_dmub_reg_write(void *ctx, uint32_t address,
|
|
|
|
uint32_t value)
|
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = ctx;
|
|
|
|
|
|
|
|
return dm_write_reg(adev->dm.dc->ctx, address, value);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int dm_dmub_sw_init(struct amdgpu_device *adev)
|
|
|
|
{
|
|
|
|
struct dmub_srv_create_params create_params;
|
2019-11-25 14:49:27 +00:00
|
|
|
struct dmub_srv_region_params region_params;
|
|
|
|
struct dmub_srv_region_info region_info;
|
|
|
|
struct dmub_srv_fb_params fb_params;
|
|
|
|
struct dmub_srv_fb_info *fb_info;
|
|
|
|
struct dmub_srv *dmub_srv;
|
2019-10-25 00:38:48 +00:00
|
|
|
const struct dmcub_firmware_header_v1_0 *hdr;
|
|
|
|
const char *fw_name_dmub;
|
|
|
|
enum dmub_asic dmub_asic;
|
|
|
|
enum dmub_status status;
|
|
|
|
int r;
|
|
|
|
|
|
|
|
switch (adev->asic_type) {
|
|
|
|
case CHIP_RENOIR:
|
|
|
|
dmub_asic = DMUB_ASIC_DCN21;
|
|
|
|
fw_name_dmub = FIRMWARE_RENOIR_DMUB;
|
|
|
|
break;
|
2020-05-21 16:48:41 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN3_0)
|
|
|
|
case CHIP_SIENNA_CICHLID:
|
|
|
|
dmub_asic = DMUB_ASIC_DCN30;
|
|
|
|
fw_name_dmub = FIRMWARE_SIENNA_CICHLID_DMUB;
|
|
|
|
break;
|
2020-07-21 17:59:52 +00:00
|
|
|
case CHIP_NAVY_FLOUNDER:
|
|
|
|
dmub_asic = DMUB_ASIC_DCN30;
|
|
|
|
fw_name_dmub = FIRMWARE_NAVY_FLOUNDER_DMUB;
|
2020-05-21 16:48:41 +00:00
|
|
|
break;
|
|
|
|
#endif
|
2019-10-25 00:38:48 +00:00
|
|
|
|
|
|
|
default:
|
|
|
|
/* ASIC doesn't support DMUB. */
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
r = request_firmware_direct(&adev->dm.dmub_fw, fw_name_dmub, adev->dev);
|
|
|
|
if (r) {
|
|
|
|
DRM_ERROR("DMUB firmware loading failed: %d\n", r);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
r = amdgpu_ucode_validate(adev->dm.dmub_fw);
|
|
|
|
if (r) {
|
|
|
|
DRM_ERROR("Couldn't validate DMUB firmware: %d\n", r);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
hdr = (const struct dmcub_firmware_header_v1_0 *)adev->dm.dmub_fw->data;
|
|
|
|
|
2020-01-28 20:14:07 +00:00
|
|
|
if (adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) {
|
|
|
|
adev->firmware.ucode[AMDGPU_UCODE_ID_DMCUB].ucode_id =
|
|
|
|
AMDGPU_UCODE_ID_DMCUB;
|
|
|
|
adev->firmware.ucode[AMDGPU_UCODE_ID_DMCUB].fw =
|
|
|
|
adev->dm.dmub_fw;
|
|
|
|
adev->firmware.fw_size +=
|
|
|
|
ALIGN(le32_to_cpu(hdr->inst_const_bytes), PAGE_SIZE);
|
2019-10-25 00:38:48 +00:00
|
|
|
|
2020-01-28 20:14:07 +00:00
|
|
|
DRM_INFO("Loading DMUB firmware via PSP: version=0x%08X\n",
|
|
|
|
adev->dm.dmcub_fw_version);
|
|
|
|
}
|
|
|
|
|
|
|
|
adev->dm.dmcub_fw_version = le32_to_cpu(hdr->header.ucode_version);
|
2019-10-25 00:38:48 +00:00
|
|
|
|
2019-11-25 14:49:27 +00:00
|
|
|
adev->dm.dmub_srv = kzalloc(sizeof(*adev->dm.dmub_srv), GFP_KERNEL);
|
|
|
|
dmub_srv = adev->dm.dmub_srv;
|
|
|
|
|
|
|
|
if (!dmub_srv) {
|
|
|
|
DRM_ERROR("Failed to allocate DMUB service!\n");
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
memset(&create_params, 0, sizeof(create_params));
|
|
|
|
create_params.user_ctx = adev;
|
|
|
|
create_params.funcs.reg_read = amdgpu_dm_dmub_reg_read;
|
|
|
|
create_params.funcs.reg_write = amdgpu_dm_dmub_reg_write;
|
|
|
|
create_params.asic = dmub_asic;
|
|
|
|
|
|
|
|
/* Create the DMUB service. */
|
|
|
|
status = dmub_srv_create(dmub_srv, &create_params);
|
|
|
|
if (status != DMUB_STATUS_OK) {
|
|
|
|
DRM_ERROR("Error creating DMUB service: %d\n", status);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Calculate the size of all the regions for the DMUB service. */
|
|
|
|
memset(®ion_params, 0, sizeof(region_params));
|
|
|
|
|
|
|
|
region_params.inst_const_size = le32_to_cpu(hdr->inst_const_bytes) -
|
|
|
|
PSP_HEADER_BYTES - PSP_FOOTER_BYTES;
|
|
|
|
region_params.bss_data_size = le32_to_cpu(hdr->bss_data_bytes);
|
|
|
|
region_params.vbios_size = adev->bios_size;
|
2020-04-30 16:24:05 +00:00
|
|
|
region_params.fw_bss_data = region_params.bss_data_size ?
|
2019-11-28 20:21:26 +00:00
|
|
|
adev->dm.dmub_fw->data +
|
|
|
|
le32_to_cpu(hdr->header.ucode_array_offset_bytes) +
|
2020-04-30 16:24:05 +00:00
|
|
|
le32_to_cpu(hdr->inst_const_bytes) : NULL;
|
2020-04-05 20:41:14 +00:00
|
|
|
region_params.fw_inst_const =
|
|
|
|
adev->dm.dmub_fw->data +
|
|
|
|
le32_to_cpu(hdr->header.ucode_array_offset_bytes) +
|
|
|
|
PSP_HEADER_BYTES;
|
2019-11-25 14:49:27 +00:00
|
|
|
|
|
|
|
status = dmub_srv_calc_region_info(dmub_srv, ®ion_params,
|
|
|
|
®ion_info);
|
|
|
|
|
|
|
|
if (status != DMUB_STATUS_OK) {
|
|
|
|
DRM_ERROR("Error calculating DMUB region info: %d\n", status);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Allocate a framebuffer based on the total size of all the regions.
|
|
|
|
* TODO: Move this into GART.
|
|
|
|
*/
|
|
|
|
r = amdgpu_bo_create_kernel(adev, region_info.fb_size, PAGE_SIZE,
|
|
|
|
AMDGPU_GEM_DOMAIN_VRAM, &adev->dm.dmub_bo,
|
|
|
|
&adev->dm.dmub_bo_gpu_addr,
|
|
|
|
&adev->dm.dmub_bo_cpu_addr);
|
|
|
|
if (r)
|
|
|
|
return r;
|
|
|
|
|
|
|
|
/* Rebase the regions on the framebuffer address. */
|
|
|
|
memset(&fb_params, 0, sizeof(fb_params));
|
|
|
|
fb_params.cpu_addr = adev->dm.dmub_bo_cpu_addr;
|
|
|
|
fb_params.gpu_addr = adev->dm.dmub_bo_gpu_addr;
|
|
|
|
fb_params.region_info = ®ion_info;
|
|
|
|
|
|
|
|
adev->dm.dmub_fb_info =
|
|
|
|
kzalloc(sizeof(*adev->dm.dmub_fb_info), GFP_KERNEL);
|
|
|
|
fb_info = adev->dm.dmub_fb_info;
|
|
|
|
|
|
|
|
if (!fb_info) {
|
|
|
|
DRM_ERROR(
|
|
|
|
"Failed to allocate framebuffer info for DMUB service!\n");
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
status = dmub_srv_calc_fb_info(dmub_srv, &fb_params, fb_info);
|
|
|
|
if (status != DMUB_STATUS_OK) {
|
|
|
|
DRM_ERROR("Error calculating DMUB FB info: %d\n", status);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2019-10-25 00:38:48 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-09-11 17:49:49 +00:00
|
|
|
static int dm_sw_init(void *handle)
|
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
|
2019-10-25 00:38:48 +00:00
|
|
|
int r;
|
|
|
|
|
|
|
|
r = dm_dmub_sw_init(adev);
|
|
|
|
if (r)
|
|
|
|
return r;
|
2018-09-11 17:49:49 +00:00
|
|
|
|
|
|
|
return load_dmcu_fw(adev);
|
|
|
|
}
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
static int dm_sw_fini(void *handle)
|
|
|
|
{
|
2018-09-11 17:49:49 +00:00
|
|
|
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
|
|
|
|
|
2019-11-25 14:49:27 +00:00
|
|
|
kfree(adev->dm.dmub_fb_info);
|
|
|
|
adev->dm.dmub_fb_info = NULL;
|
|
|
|
|
2019-10-25 00:38:48 +00:00
|
|
|
if (adev->dm.dmub_srv) {
|
|
|
|
dmub_srv_destroy(adev->dm.dmub_srv);
|
|
|
|
adev->dm.dmub_srv = NULL;
|
|
|
|
}
|
|
|
|
|
2020-06-25 13:35:07 +00:00
|
|
|
release_firmware(adev->dm.dmub_fw);
|
|
|
|
adev->dm.dmub_fw = NULL;
|
2019-10-25 00:38:48 +00:00
|
|
|
|
2020-06-25 13:35:07 +00:00
|
|
|
release_firmware(adev->dm.fw_dmcu);
|
|
|
|
adev->dm.fw_dmcu = NULL;
|
2018-09-11 17:49:49 +00:00
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-12-29 18:21:31 +00:00
|
|
|
static int detect_mst_link_for_all_connectors(struct drm_device *dev)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector;
|
2017-09-12 19:58:20 +00:00
|
|
|
struct drm_connector *connector;
|
2019-09-03 20:46:01 +00:00
|
|
|
struct drm_connector_list_iter iter;
|
2016-12-29 18:21:31 +00:00
|
|
|
int ret = 0;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2019-09-03 20:46:01 +00:00
|
|
|
drm_connector_list_iter_begin(dev, &iter);
|
|
|
|
drm_for_each_connector_iter(connector, &iter) {
|
2017-11-07 20:06:57 +00:00
|
|
|
aconnector = to_amdgpu_dm_connector(connector);
|
2017-11-03 20:04:34 +00:00
|
|
|
if (aconnector->dc_link->type == dc_connection_mst_branch &&
|
|
|
|
aconnector->mst_mgr.aux) {
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("DM_MST: starting TM on aconnector: %p [id: %d]\n",
|
2019-09-03 20:46:01 +00:00
|
|
|
aconnector,
|
|
|
|
aconnector->base.base.id);
|
2016-12-29 18:21:31 +00:00
|
|
|
|
|
|
|
ret = drm_dp_mst_topology_mgr_set_mst(&aconnector->mst_mgr, true);
|
|
|
|
if (ret < 0) {
|
|
|
|
DRM_ERROR("DM_MST: Failed to start MST\n");
|
2019-09-03 20:46:01 +00:00
|
|
|
aconnector->dc_link->type =
|
|
|
|
dc_connection_single;
|
|
|
|
break;
|
2016-12-29 18:21:31 +00:00
|
|
|
}
|
2019-09-03 20:46:01 +00:00
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
2019-09-03 20:46:01 +00:00
|
|
|
drm_connector_list_iter_end(&iter);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2016-12-29 18:21:31 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int dm_late_init(void *handle)
|
|
|
|
{
|
2017-12-13 22:25:02 +00:00
|
|
|
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
|
2016-12-29 18:21:31 +00:00
|
|
|
|
2018-11-26 16:38:33 +00:00
|
|
|
struct dmcu_iram_parameters params;
|
|
|
|
unsigned int linear_lut[16];
|
|
|
|
int i;
|
2020-04-24 18:09:23 +00:00
|
|
|
struct dmcu *dmcu = NULL;
|
2020-07-10 14:33:05 +00:00
|
|
|
bool ret = true;
|
2018-11-26 16:38:33 +00:00
|
|
|
|
2020-07-08 08:16:22 +00:00
|
|
|
if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw)
|
2020-04-24 18:09:23 +00:00
|
|
|
return detect_mst_link_for_all_connectors(adev->ddev);
|
|
|
|
|
|
|
|
dmcu = adev->dm.dc->res_pool->dmcu;
|
|
|
|
|
2018-11-26 16:38:33 +00:00
|
|
|
for (i = 0; i < 16; i++)
|
|
|
|
linear_lut[i] = 0xFFFF * i / 15;
|
|
|
|
|
|
|
|
params.set = 0;
|
|
|
|
params.backlight_ramping_start = 0xCCCC;
|
|
|
|
params.backlight_ramping_reduction = 0xCCCCCCCC;
|
|
|
|
params.backlight_lut_array_size = 16;
|
|
|
|
params.backlight_lut_array = linear_lut;
|
|
|
|
|
2019-08-29 14:49:12 +00:00
|
|
|
/* Min backlight level after ABM reduction, Don't allow below 1%
|
|
|
|
* 0xFFFF x 0.01 = 0x28F
|
|
|
|
*/
|
|
|
|
params.min_abm_backlight = 0x28F;
|
|
|
|
|
2020-07-10 14:33:05 +00:00
|
|
|
/* In the case where abm is implemented on dmcub,
|
|
|
|
* dmcu object will be null.
|
|
|
|
* ABM 2.4 and up are implemented on dmcub.
|
|
|
|
*/
|
|
|
|
if (dmcu)
|
|
|
|
ret = dmcu_load_iram(dmcu, params);
|
|
|
|
else if (adev->dm.dc->ctx->dmub_srv)
|
2020-07-31 17:57:05 +00:00
|
|
|
ret = dmub_init_abm_config(adev->dm.dc->res_pool, params);
|
2018-11-26 16:38:33 +00:00
|
|
|
|
2020-05-28 13:44:44 +00:00
|
|
|
if (!ret)
|
|
|
|
return -EINVAL;
|
2018-11-26 16:38:33 +00:00
|
|
|
|
2017-12-13 22:25:02 +00:00
|
|
|
return detect_mst_link_for_all_connectors(adev->ddev);
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void s3_handle_mst(struct drm_device *dev, bool suspend)
|
|
|
|
{
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector;
|
2017-09-12 19:58:20 +00:00
|
|
|
struct drm_connector *connector;
|
2019-09-03 20:46:01 +00:00
|
|
|
struct drm_connector_list_iter iter;
|
2019-01-08 21:11:27 +00:00
|
|
|
struct drm_dp_mst_topology_mgr *mgr;
|
|
|
|
int ret;
|
|
|
|
bool need_hotplug = false;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2019-09-03 20:46:01 +00:00
|
|
|
drm_connector_list_iter_begin(dev, &iter);
|
|
|
|
drm_for_each_connector_iter(connector, &iter) {
|
2019-01-08 21:11:27 +00:00
|
|
|
aconnector = to_amdgpu_dm_connector(connector);
|
|
|
|
if (aconnector->dc_link->type != dc_connection_mst_branch ||
|
|
|
|
aconnector->mst_port)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
mgr = &aconnector->mst_mgr;
|
|
|
|
|
|
|
|
if (suspend) {
|
|
|
|
drm_dp_mst_topology_mgr_suspend(mgr);
|
|
|
|
} else {
|
drm/dp_mst: Add basic topology reprobing when resuming
Finally! For a very long time, our MST helpers have had one very
annoying issue: They don't know how to reprobe the topology state when
coming out of suspend. This means that if a user has a machine connected
to an MST topology and decides to suspend their machine, we lose all
topology changes that happened during that period. That can be a big
problem if the machine was connected to a different topology on the same
port before resuming, as we won't bother reprobing any of the ports and
likely cause the user's monitors not to come back up as expected.
So, we start fixing this by teaching our MST helpers how to reprobe the
link addresses of each connected topology when resuming. As it turns
out, the behavior that we want here is identical to the behavior we want
when initially probing a newly connected MST topology, with a couple of
important differences:
- We need to be more careful about handling the potential races between
events from the MST hub that could change the topology state as we're
performing the link address reprobe
- We need to be more careful about handling unlikely state changes on
ports - such as an input port turning into an output port, something
that would be far more likely to happen in situations like the MST hub
we're connected to being changed while we're suspend
Both of which have been solved by previous commits. That leaves one
requirement:
- We need to prune any MST ports in our in-memory topology state that
were present when suspending, but have not appeared in the post-resume
link address response from their parent branch device
Which we can now handle in this commit by modifying
drm_dp_send_link_address(). We then introduce suspend/resume reprobing
by introducing drm_dp_mst_topology_mgr_invalidate_mstb(), which we call
in drm_dp_mst_topology_mgr_suspend() to traverse the in-memory topology
state to indicate that each mstb needs it's link address resent and PBN
resources reprobed.
On resume, we start back up &mgr->work and have it reprobe the topology
in the same way we would on a hotplug, removing any leftover ports that
no longer appear in the topology state.
Changes since v4:
* Split indenting changes in drm_dp_mst_topology_mgr_resume() into a
separate patch
* Only fire hotplugs when something has actually changed after a link
address probe
* Don't try to change port->connector at all on ports, just throw out
ports that need their connectors removed to make things easier.
Cc: Juston Li <juston.li@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Harry Wentland <hwentlan@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Sean Paul <sean@poorly.run>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191022023641.8026-14-lyude@redhat.com
2019-06-17 23:57:33 +00:00
|
|
|
ret = drm_dp_mst_topology_mgr_resume(mgr, true);
|
2019-01-08 21:11:27 +00:00
|
|
|
if (ret < 0) {
|
|
|
|
drm_dp_mst_topology_mgr_set_mst(mgr, false);
|
|
|
|
need_hotplug = true;
|
|
|
|
}
|
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
2019-09-03 20:46:01 +00:00
|
|
|
drm_connector_list_iter_end(&iter);
|
2019-01-08 21:11:27 +00:00
|
|
|
|
|
|
|
if (need_hotplug)
|
|
|
|
drm_kms_helper_hotplug_event(dev);
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
2020-02-13 15:50:13 +00:00
|
|
|
static int amdgpu_dm_smu_write_watermarks_table(struct amdgpu_device *adev)
|
|
|
|
{
|
|
|
|
struct smu_context *smu = &adev->smu;
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
if (!is_support_sw_smu(adev))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* This interface is for dGPU Navi1x.Linux dc-pplib interface depends
|
|
|
|
* on window driver dc implementation.
|
|
|
|
* For Navi1x, clock settings of dcn watermarks are fixed. the settings
|
|
|
|
* should be passed to smu during boot up and resume from s3.
|
|
|
|
* boot up: dc calculate dcn watermark clock settings within dc_create,
|
|
|
|
* dcn20_resource_construct
|
|
|
|
* then call pplib functions below to pass the settings to smu:
|
|
|
|
* smu_set_watermarks_for_clock_ranges
|
|
|
|
* smu_set_watermarks_table
|
|
|
|
* navi10_set_watermarks_table
|
|
|
|
* smu_write_watermarks_table
|
|
|
|
*
|
|
|
|
* For Renoir, clock settings of dcn watermark are also fixed values.
|
|
|
|
* dc has implemented different flow for window driver:
|
|
|
|
* dc_hardware_init / dc_set_power_state
|
|
|
|
* dcn10_init_hw
|
|
|
|
* notify_wm_ranges
|
|
|
|
* set_wm_ranges
|
|
|
|
* -- Linux
|
|
|
|
* smu_set_watermarks_for_clock_ranges
|
|
|
|
* renoir_set_watermarks_table
|
|
|
|
* smu_write_watermarks_table
|
|
|
|
*
|
|
|
|
* For Linux,
|
|
|
|
* dc_hardware_init -> amdgpu_dm_init
|
|
|
|
* dc_set_power_state --> dm_resume
|
|
|
|
*
|
|
|
|
* therefore, this function apply to navi10/12/14 but not Renoir
|
|
|
|
* *
|
|
|
|
*/
|
|
|
|
switch(adev->asic_type) {
|
|
|
|
case CHIP_NAVI10:
|
|
|
|
case CHIP_NAVI14:
|
|
|
|
case CHIP_NAVI12:
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-07-07 07:52:39 +00:00
|
|
|
ret = smu_write_watermarks_table(smu);
|
|
|
|
if (ret) {
|
|
|
|
DRM_ERROR("Failed to update WMTABLE!\n");
|
|
|
|
return ret;
|
2020-02-13 15:50:13 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-09-14 15:20:08 +00:00
|
|
|
/**
|
|
|
|
* dm_hw_init() - Initialize DC device
|
2019-10-05 11:32:05 +00:00
|
|
|
* @handle: The base driver device containing the amdgpu_dm device.
|
2018-09-14 15:20:08 +00:00
|
|
|
*
|
|
|
|
* Initialize the &struct amdgpu_display_manager device. This involves calling
|
|
|
|
* the initializers of each DM component, then populating the struct with them.
|
|
|
|
*
|
|
|
|
* Although the function implies hardware initialization, both hardware and
|
|
|
|
* software are initialized here. Splitting them out to their relevant init
|
|
|
|
* hooks is a future TODO item.
|
|
|
|
*
|
|
|
|
* Some notable things that are initialized here:
|
|
|
|
*
|
|
|
|
* - Display Core, both software and hardware
|
|
|
|
* - DC modules that we need (freesync and color management)
|
|
|
|
* - DRM software states
|
|
|
|
* - Interrupt sources and handlers
|
|
|
|
* - Vblank support
|
|
|
|
* - Debug FS entries, if enabled
|
|
|
|
*/
|
2017-09-12 19:58:20 +00:00
|
|
|
static int dm_hw_init(void *handle)
|
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
|
|
|
|
/* Create DAL display manager */
|
|
|
|
amdgpu_dm_init(adev);
|
|
|
|
amdgpu_dm_hpd_init(adev);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-09-14 15:20:08 +00:00
|
|
|
/**
|
|
|
|
* dm_hw_fini() - Teardown DC device
|
2019-10-05 11:32:05 +00:00
|
|
|
* @handle: The base driver device containing the amdgpu_dm device.
|
2018-09-14 15:20:08 +00:00
|
|
|
*
|
|
|
|
* Teardown components within &struct amdgpu_display_manager that require
|
|
|
|
* cleanup. This involves cleaning up the DRM device, DC, and any modules that
|
|
|
|
* were loaded. Also flush IRQ workqueues and disable them.
|
|
|
|
*/
|
2017-09-12 19:58:20 +00:00
|
|
|
static int dm_hw_fini(void *handle)
|
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
|
|
|
|
|
|
|
|
amdgpu_dm_hpd_fini(adev);
|
|
|
|
|
|
|
|
amdgpu_dm_irq_fini(adev);
|
2017-05-22 05:11:15 +00:00
|
|
|
amdgpu_dm_fini(adev);
|
2017-09-12 19:58:20 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-05-11 18:21:17 +00:00
|
|
|
|
|
|
|
static int dm_enable_vblank(struct drm_crtc *crtc);
|
|
|
|
static void dm_disable_vblank(struct drm_crtc *crtc);
|
|
|
|
|
|
|
|
static void dm_gpureset_toggle_interrupts(struct amdgpu_device *adev,
|
|
|
|
struct dc_state *state, bool enable)
|
|
|
|
{
|
|
|
|
enum dc_irq_source irq_source;
|
|
|
|
struct amdgpu_crtc *acrtc;
|
|
|
|
int rc = -EBUSY;
|
|
|
|
int i = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < state->stream_count; i++) {
|
|
|
|
acrtc = get_crtc_by_otg_inst(
|
|
|
|
adev, state->stream_status[i].primary_otg_inst);
|
|
|
|
|
|
|
|
if (acrtc && state->stream_status[i].plane_count != 0) {
|
|
|
|
irq_source = IRQ_TYPE_PFLIP + acrtc->otg_inst;
|
|
|
|
rc = dc_interrupt_set(adev->dm.dc, irq_source, enable) ? 0 : -EBUSY;
|
|
|
|
DRM_DEBUG("crtc %d - vupdate irq %sabling: r=%d\n",
|
|
|
|
acrtc->crtc_id, enable ? "en" : "dis", rc);
|
|
|
|
if (rc)
|
|
|
|
DRM_WARN("Failed to %s pflip interrupts\n",
|
|
|
|
enable ? "enable" : "disable");
|
|
|
|
|
|
|
|
if (enable) {
|
|
|
|
rc = dm_enable_vblank(&acrtc->base);
|
|
|
|
if (rc)
|
|
|
|
DRM_WARN("Failed to enable vblank interrupts\n");
|
|
|
|
} else {
|
|
|
|
dm_disable_vblank(&acrtc->base);
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2020-06-18 13:07:13 +00:00
|
|
|
static enum dc_status amdgpu_dm_commit_zero_streams(struct dc *dc)
|
2020-05-11 18:21:17 +00:00
|
|
|
{
|
|
|
|
struct dc_state *context = NULL;
|
|
|
|
enum dc_status res = DC_ERROR_UNEXPECTED;
|
|
|
|
int i;
|
|
|
|
struct dc_stream_state *del_streams[MAX_PIPES];
|
|
|
|
int del_streams_count = 0;
|
|
|
|
|
|
|
|
memset(del_streams, 0, sizeof(del_streams));
|
|
|
|
|
|
|
|
context = dc_create_state(dc);
|
|
|
|
if (context == NULL)
|
|
|
|
goto context_alloc_fail;
|
|
|
|
|
|
|
|
dc_resource_state_copy_construct_current(dc, context);
|
|
|
|
|
|
|
|
/* First remove from context all streams */
|
|
|
|
for (i = 0; i < context->stream_count; i++) {
|
|
|
|
struct dc_stream_state *stream = context->streams[i];
|
|
|
|
|
|
|
|
del_streams[del_streams_count++] = stream;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Remove all planes for removed streams and then remove the streams */
|
|
|
|
for (i = 0; i < del_streams_count; i++) {
|
|
|
|
if (!dc_rem_all_planes_for_stream(dc, del_streams[i], context)) {
|
|
|
|
res = DC_FAIL_DETACH_SURFACES;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
res = dc_remove_stream_from_ctx(dc, context, del_streams[i]);
|
|
|
|
if (res != DC_OK)
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
res = dc_validate_global_state(dc, context, false);
|
|
|
|
|
|
|
|
if (res != DC_OK) {
|
|
|
|
DRM_ERROR("%s:resource validation failed, dc_status:%d\n", __func__, res);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
res = dc_commit_state(dc, context);
|
|
|
|
|
|
|
|
fail:
|
|
|
|
dc_release_state(context);
|
|
|
|
|
|
|
|
context_alloc_fail:
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
static int dm_suspend(void *handle)
|
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = handle;
|
|
|
|
struct amdgpu_display_manager *dm = &adev->dm;
|
|
|
|
int ret = 0;
|
|
|
|
|
2020-05-11 18:21:17 +00:00
|
|
|
if (adev->in_gpu_reset) {
|
|
|
|
mutex_lock(&dm->dc_lock);
|
|
|
|
dm->cached_dc_state = dc_copy_state(dm->dc->current_state);
|
|
|
|
|
|
|
|
dm_gpureset_toggle_interrupts(adev, dm->cached_dc_state, false);
|
|
|
|
|
|
|
|
amdgpu_dm_commit_zero_streams(dm->dc);
|
|
|
|
|
|
|
|
amdgpu_dm_irq_suspend(adev);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2019-01-24 20:07:52 +00:00
|
|
|
WARN_ON(adev->dm.cached_state);
|
|
|
|
adev->dm.cached_state = drm_atomic_helper_suspend(adev->ddev);
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
s3_handle_mst(adev->ddev, true);
|
|
|
|
|
|
|
|
amdgpu_dm_irq_suspend(adev);
|
|
|
|
|
2017-04-20 19:59:25 +00:00
|
|
|
|
2017-10-17 12:48:44 +00:00
|
|
|
dc_set_power_state(dm->dc, DC_ACPI_CM_POWER_STATE_D3);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2020-05-04 11:32:13 +00:00
|
|
|
return 0;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
2017-10-13 18:04:26 +00:00
|
|
|
static struct amdgpu_dm_connector *
|
|
|
|
amdgpu_dm_find_first_crtc_matching_connector(struct drm_atomic_state *state,
|
|
|
|
struct drm_crtc *crtc)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
|
|
|
uint32_t i;
|
2017-10-12 21:15:08 +00:00
|
|
|
struct drm_connector_state *new_con_state;
|
2017-09-12 19:58:20 +00:00
|
|
|
struct drm_connector *connector;
|
|
|
|
struct drm_crtc *crtc_from_state;
|
|
|
|
|
2017-10-12 21:15:08 +00:00
|
|
|
for_each_new_connector_in_state(state, connector, new_con_state, i) {
|
|
|
|
crtc_from_state = new_con_state->crtc;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
if (crtc_from_state == crtc)
|
2017-09-05 18:16:09 +00:00
|
|
|
return to_amdgpu_dm_connector(connector);
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2018-09-26 17:42:10 +00:00
|
|
|
static void emulated_link_detect(struct dc_link *link)
|
|
|
|
{
|
|
|
|
struct dc_sink_init_data sink_init_data = { 0 };
|
|
|
|
struct display_sink_capability sink_caps = { 0 };
|
|
|
|
enum dc_edid_status edid_status;
|
|
|
|
struct dc_context *dc_ctx = link->ctx;
|
|
|
|
struct dc_sink *sink = NULL;
|
|
|
|
struct dc_sink *prev_sink = NULL;
|
|
|
|
|
|
|
|
link->type = dc_connection_none;
|
|
|
|
prev_sink = link->local_sink;
|
|
|
|
|
|
|
|
if (prev_sink != NULL)
|
|
|
|
dc_sink_retain(prev_sink);
|
|
|
|
|
|
|
|
switch (link->connector_signal) {
|
|
|
|
case SIGNAL_TYPE_HDMI_TYPE_A: {
|
|
|
|
sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C;
|
|
|
|
sink_caps.signal = SIGNAL_TYPE_HDMI_TYPE_A;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case SIGNAL_TYPE_DVI_SINGLE_LINK: {
|
|
|
|
sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C;
|
|
|
|
sink_caps.signal = SIGNAL_TYPE_DVI_SINGLE_LINK;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case SIGNAL_TYPE_DVI_DUAL_LINK: {
|
|
|
|
sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C;
|
|
|
|
sink_caps.signal = SIGNAL_TYPE_DVI_DUAL_LINK;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case SIGNAL_TYPE_LVDS: {
|
|
|
|
sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C;
|
|
|
|
sink_caps.signal = SIGNAL_TYPE_LVDS;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case SIGNAL_TYPE_EDP: {
|
|
|
|
sink_caps.transaction_type =
|
|
|
|
DDC_TRANSACTION_TYPE_I2C_OVER_AUX;
|
|
|
|
sink_caps.signal = SIGNAL_TYPE_EDP;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case SIGNAL_TYPE_DISPLAY_PORT: {
|
|
|
|
sink_caps.transaction_type =
|
|
|
|
DDC_TRANSACTION_TYPE_I2C_OVER_AUX;
|
|
|
|
sink_caps.signal = SIGNAL_TYPE_VIRTUAL;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
default:
|
|
|
|
DC_ERROR("Invalid connector type! signal:%d\n",
|
|
|
|
link->connector_signal);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
sink_init_data.link = link;
|
|
|
|
sink_init_data.sink_signal = sink_caps.signal;
|
|
|
|
|
|
|
|
sink = dc_sink_create(&sink_init_data);
|
|
|
|
if (!sink) {
|
|
|
|
DC_ERROR("Failed to create sink!\n");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2019-02-10 10:13:01 +00:00
|
|
|
/* dc_sink_create returns a new reference */
|
2018-09-26 17:42:10 +00:00
|
|
|
link->local_sink = sink;
|
|
|
|
|
|
|
|
edid_status = dm_helpers_read_local_edid(
|
|
|
|
link->ctx,
|
|
|
|
link,
|
|
|
|
sink);
|
|
|
|
|
|
|
|
if (edid_status != EDID_OK)
|
|
|
|
DC_ERROR("Failed to read EDID");
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2020-05-11 18:21:17 +00:00
|
|
|
static void dm_gpureset_commit_state(struct dc_state *dc_state,
|
|
|
|
struct amdgpu_display_manager *dm)
|
|
|
|
{
|
|
|
|
struct {
|
|
|
|
struct dc_surface_update surface_updates[MAX_SURFACES];
|
|
|
|
struct dc_plane_info plane_infos[MAX_SURFACES];
|
|
|
|
struct dc_scaling_info scaling_infos[MAX_SURFACES];
|
|
|
|
struct dc_flip_addrs flip_addrs[MAX_SURFACES];
|
|
|
|
struct dc_stream_update stream_update;
|
|
|
|
} * bundle;
|
|
|
|
int k, m;
|
|
|
|
|
|
|
|
bundle = kzalloc(sizeof(*bundle), GFP_KERNEL);
|
|
|
|
|
|
|
|
if (!bundle) {
|
|
|
|
dm_error("Failed to allocate update bundle\n");
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (k = 0; k < dc_state->stream_count; k++) {
|
|
|
|
bundle->stream_update.stream = dc_state->streams[k];
|
|
|
|
|
|
|
|
for (m = 0; m < dc_state->stream_status->plane_count; m++) {
|
|
|
|
bundle->surface_updates[m].surface =
|
|
|
|
dc_state->stream_status->plane_states[m];
|
|
|
|
bundle->surface_updates[m].surface->force_full_update =
|
|
|
|
true;
|
|
|
|
}
|
|
|
|
dc_commit_updates_for_stream(
|
|
|
|
dm->dc, bundle->surface_updates,
|
|
|
|
dc_state->stream_status->plane_count,
|
|
|
|
dc_state->streams[k], &bundle->stream_update, dc_state);
|
|
|
|
}
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
kfree(bundle);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
static int dm_resume(void *handle)
|
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = handle;
|
|
|
|
struct drm_device *ddev = adev->ddev;
|
|
|
|
struct amdgpu_display_manager *dm = &adev->dm;
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector;
|
2017-09-12 19:58:20 +00:00
|
|
|
struct drm_connector *connector;
|
2019-09-03 20:46:01 +00:00
|
|
|
struct drm_connector_list_iter iter;
|
2017-09-12 19:58:20 +00:00
|
|
|
struct drm_crtc *crtc;
|
2017-10-12 21:15:08 +00:00
|
|
|
struct drm_crtc_state *new_crtc_state;
|
2017-11-01 20:49:14 +00:00
|
|
|
struct dm_crtc_state *dm_new_crtc_state;
|
|
|
|
struct drm_plane *plane;
|
|
|
|
struct drm_plane_state *new_plane_state;
|
|
|
|
struct dm_plane_state *dm_new_plane_state;
|
2019-03-19 23:29:16 +00:00
|
|
|
struct dm_atomic_state *dm_state = to_dm_atomic_state(dm->atomic_obj.state);
|
2018-09-26 17:42:10 +00:00
|
|
|
enum dc_connection_type new_connection_type = dc_connection_none;
|
2020-05-11 18:21:17 +00:00
|
|
|
struct dc_state *dc_state;
|
|
|
|
int i, r, j;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2020-05-11 18:21:17 +00:00
|
|
|
if (adev->in_gpu_reset) {
|
|
|
|
dc_state = dm->cached_dc_state;
|
|
|
|
|
|
|
|
r = dm_dmub_hw_init(adev);
|
|
|
|
if (r)
|
|
|
|
DRM_ERROR("DMUB interface failed to initialize: status=%d\n", r);
|
|
|
|
|
|
|
|
dc_set_power_state(dm->dc, DC_ACPI_CM_POWER_STATE_D0);
|
|
|
|
dc_resume(dm->dc);
|
|
|
|
|
|
|
|
amdgpu_dm_irq_resume_early(adev);
|
|
|
|
|
|
|
|
for (i = 0; i < dc_state->stream_count; i++) {
|
|
|
|
dc_state->streams[i]->mode_changed = true;
|
|
|
|
for (j = 0; j < dc_state->stream_status->plane_count; j++) {
|
|
|
|
dc_state->stream_status->plane_states[j]->update_flags.raw
|
|
|
|
= 0xffffffff;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
WARN_ON(!dc_commit_state(dm->dc, dc_state));
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2020-05-11 18:21:17 +00:00
|
|
|
dm_gpureset_commit_state(dm->cached_dc_state, dm);
|
|
|
|
|
|
|
|
dm_gpureset_toggle_interrupts(adev, dm->cached_dc_state, true);
|
|
|
|
|
|
|
|
dc_release_state(dm->cached_dc_state);
|
|
|
|
dm->cached_dc_state = NULL;
|
|
|
|
|
|
|
|
amdgpu_dm_irq_resume_late(adev);
|
|
|
|
|
|
|
|
mutex_unlock(&dm->dc_lock);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2019-03-19 23:29:16 +00:00
|
|
|
/* Recreate dc_state - DC invalidates it when setting power state to S3. */
|
|
|
|
dc_release_state(dm_state->context);
|
|
|
|
dm_state->context = dc_create_state(dm->dc);
|
|
|
|
/* TODO: Remove dc_state->dccg, use dc->dccg directly. */
|
|
|
|
dc_resource_state_construct(dm->dc, dm_state->context);
|
|
|
|
|
2019-11-25 14:49:27 +00:00
|
|
|
/* Before powering on DC we need to re-initialize DMUB. */
|
|
|
|
r = dm_dmub_hw_init(adev);
|
|
|
|
if (r)
|
|
|
|
DRM_ERROR("DMUB interface failed to initialize: status=%d\n", r);
|
|
|
|
|
2018-02-03 19:18:07 +00:00
|
|
|
/* power on hardware */
|
|
|
|
dc_set_power_state(dm->dc, DC_ACPI_CM_POWER_STATE_D0);
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
/* program HPD filter */
|
|
|
|
dc_resume(dm->dc);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* early enable HPD Rx IRQ, should be done before set mode as short
|
|
|
|
* pulse interrupts are used for MST
|
|
|
|
*/
|
|
|
|
amdgpu_dm_irq_resume_early(adev);
|
|
|
|
|
2019-07-16 22:22:16 +00:00
|
|
|
/* On resume we need to rewrite the MSTM control bits to enable MST*/
|
2019-09-25 21:52:48 +00:00
|
|
|
s3_handle_mst(ddev, false);
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
/* Do detection*/
|
2019-09-03 20:46:01 +00:00
|
|
|
drm_connector_list_iter_begin(ddev, &iter);
|
|
|
|
drm_for_each_connector_iter(connector, &iter) {
|
2017-09-05 18:16:09 +00:00
|
|
|
aconnector = to_amdgpu_dm_connector(connector);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* this is the case when traversing through already created
|
|
|
|
* MST connectors, should be skipped
|
|
|
|
*/
|
|
|
|
if (aconnector->mst_port)
|
|
|
|
continue;
|
|
|
|
|
2017-04-26 12:09:56 +00:00
|
|
|
mutex_lock(&aconnector->hpd_lock);
|
2018-09-26 17:42:10 +00:00
|
|
|
if (!dc_link_detect_sink(aconnector->dc_link, &new_connection_type))
|
|
|
|
DRM_ERROR("KMS: Failed to detect connector\n");
|
|
|
|
|
|
|
|
if (aconnector->base.force && new_connection_type == dc_connection_none)
|
|
|
|
emulated_link_detect(aconnector->dc_link);
|
|
|
|
else
|
|
|
|
dc_link_detect(aconnector->dc_link, DETECT_REASON_HPD);
|
2017-10-20 14:15:18 +00:00
|
|
|
|
|
|
|
if (aconnector->fake_enable && aconnector->dc_link->local_sink)
|
|
|
|
aconnector->fake_enable = false;
|
|
|
|
|
2019-02-10 10:13:01 +00:00
|
|
|
if (aconnector->dc_sink)
|
|
|
|
dc_sink_release(aconnector->dc_sink);
|
2017-09-12 19:58:20 +00:00
|
|
|
aconnector->dc_sink = NULL;
|
|
|
|
amdgpu_dm_update_connector_after_detect(aconnector);
|
2017-04-26 12:09:56 +00:00
|
|
|
mutex_unlock(&aconnector->hpd_lock);
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
2019-09-03 20:46:01 +00:00
|
|
|
drm_connector_list_iter_end(&iter);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/* Force mode set in atomic commit */
|
2018-02-03 19:18:07 +00:00
|
|
|
for_each_new_crtc_in_state(dm->cached_state, crtc, new_crtc_state, i)
|
2017-10-12 21:15:08 +00:00
|
|
|
new_crtc_state->active_changed = true;
|
2017-09-07 21:05:38 +00:00
|
|
|
|
2017-11-01 20:49:14 +00:00
|
|
|
/*
|
|
|
|
* atomic_check is expected to create the dc states. We need to release
|
|
|
|
* them here, since they were duplicated as part of the suspend
|
|
|
|
* procedure.
|
|
|
|
*/
|
2018-02-03 19:18:07 +00:00
|
|
|
for_each_new_crtc_in_state(dm->cached_state, crtc, new_crtc_state, i) {
|
2017-11-01 20:49:14 +00:00
|
|
|
dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
|
|
|
|
if (dm_new_crtc_state->stream) {
|
|
|
|
WARN_ON(kref_read(&dm_new_crtc_state->stream->refcount) > 1);
|
|
|
|
dc_stream_release(dm_new_crtc_state->stream);
|
|
|
|
dm_new_crtc_state->stream = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-02-03 19:18:07 +00:00
|
|
|
for_each_new_plane_in_state(dm->cached_state, plane, new_plane_state, i) {
|
2017-11-01 20:49:14 +00:00
|
|
|
dm_new_plane_state = to_dm_plane_state(new_plane_state);
|
|
|
|
if (dm_new_plane_state->dc_state) {
|
|
|
|
WARN_ON(kref_read(&dm_new_plane_state->dc_state->refcount) > 1);
|
|
|
|
dc_plane_state_release(dm_new_plane_state->dc_state);
|
|
|
|
dm_new_plane_state->dc_state = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
drm/amdgpu: Don't fail resume process if resuming atomic state fails
This is an ugly one unfortunately. Currently, all DRM drivers supporting
atomic modesetting will save the state that userspace had set before
suspending, then attempt to restore that state on resume. This probably
worked very well at one point, like many other things, until DP MST came
into the picture. While it's easy to restore state on normal display
connectors that were disconnected during suspend regardless of their
state post-resume, this can't really be done with MST because of the
fact that setting up a downstream sink requires performing sideband
transactions between the source and the MST hub, sending out the ACT
packets, etc.
Because of this, there isn't really a guarantee that we can restore the
atomic state we had before suspend once we've resumed. This sucks pretty
bad, but so far I haven't run into any compositors that this actually
causes serious issues with. Most compositors will notice the hotplug we
send afterwards, and then reprobe state.
Since nouveau and i915 also don't fail the suspend/resume process due to
failing to restore the atomic state, let's make amdgpu match this
behavior. Better to resume the GPU properly, then to stop the process
half way because of a potentially unavoidable atomic commit failure.
Eventually, we'll have a real fix for this problem on the DRM level. But
we've got some more important low-hanging fruit to deal with first.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Cc: Jerry Zuo <Jerry.Zuo@amd.com>
Cc: <stable@vger.kernel.org> # v4.15+
Link: https://patchwork.freedesktop.org/patch/msgid/20190108211133.32564-3-lyude@redhat.com
2019-01-08 21:11:28 +00:00
|
|
|
drm_atomic_helper_resume(ddev, dm->cached_state);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2018-02-03 19:18:07 +00:00
|
|
|
dm->cached_state = NULL;
|
2017-07-13 14:56:48 +00:00
|
|
|
|
2017-03-31 18:15:31 +00:00
|
|
|
amdgpu_dm_irq_resume_late(adev);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2020-02-13 15:50:13 +00:00
|
|
|
amdgpu_dm_smu_write_watermarks_table(adev);
|
|
|
|
|
drm/amdgpu: Don't fail resume process if resuming atomic state fails
This is an ugly one unfortunately. Currently, all DRM drivers supporting
atomic modesetting will save the state that userspace had set before
suspending, then attempt to restore that state on resume. This probably
worked very well at one point, like many other things, until DP MST came
into the picture. While it's easy to restore state on normal display
connectors that were disconnected during suspend regardless of their
state post-resume, this can't really be done with MST because of the
fact that setting up a downstream sink requires performing sideband
transactions between the source and the MST hub, sending out the ACT
packets, etc.
Because of this, there isn't really a guarantee that we can restore the
atomic state we had before suspend once we've resumed. This sucks pretty
bad, but so far I haven't run into any compositors that this actually
causes serious issues with. Most compositors will notice the hotplug we
send afterwards, and then reprobe state.
Since nouveau and i915 also don't fail the suspend/resume process due to
failing to restore the atomic state, let's make amdgpu match this
behavior. Better to resume the GPU properly, then to stop the process
half way because of a potentially unavoidable atomic commit failure.
Eventually, we'll have a real fix for this problem on the DRM level. But
we've got some more important low-hanging fruit to deal with first.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Cc: Jerry Zuo <Jerry.Zuo@amd.com>
Cc: <stable@vger.kernel.org> # v4.15+
Link: https://patchwork.freedesktop.org/patch/msgid/20190108211133.32564-3-lyude@redhat.com
2019-01-08 21:11:28 +00:00
|
|
|
return 0;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
2018-09-14 15:20:08 +00:00
|
|
|
/**
|
|
|
|
* DOC: DM Lifecycle
|
|
|
|
*
|
|
|
|
* DM (and consequently DC) is registered in the amdgpu base driver as a IP
|
|
|
|
* block. When CONFIG_DRM_AMD_DC is enabled, the DM device IP block is added to
|
|
|
|
* the base driver's device list to be initialized and torn down accordingly.
|
|
|
|
*
|
|
|
|
* The functions to do so are provided as hooks in &struct amd_ip_funcs.
|
|
|
|
*/
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
static const struct amd_ip_funcs amdgpu_dm_funcs = {
|
|
|
|
.name = "dm",
|
|
|
|
.early_init = dm_early_init,
|
2016-12-29 18:21:31 +00:00
|
|
|
.late_init = dm_late_init,
|
2017-09-12 19:58:20 +00:00
|
|
|
.sw_init = dm_sw_init,
|
|
|
|
.sw_fini = dm_sw_fini,
|
|
|
|
.hw_init = dm_hw_init,
|
|
|
|
.hw_fini = dm_hw_fini,
|
|
|
|
.suspend = dm_suspend,
|
|
|
|
.resume = dm_resume,
|
|
|
|
.is_idle = dm_is_idle,
|
|
|
|
.wait_for_idle = dm_wait_for_idle,
|
|
|
|
.check_soft_reset = dm_check_soft_reset,
|
|
|
|
.soft_reset = dm_soft_reset,
|
|
|
|
.set_clockgating_state = dm_set_clockgating_state,
|
|
|
|
.set_powergating_state = dm_set_powergating_state,
|
|
|
|
};
|
|
|
|
|
|
|
|
const struct amdgpu_ip_block_version dm_ip_block =
|
|
|
|
{
|
|
|
|
.type = AMD_IP_BLOCK_TYPE_DCE,
|
|
|
|
.major = 1,
|
|
|
|
.minor = 0,
|
|
|
|
.rev = 0,
|
|
|
|
.funcs = &amdgpu_dm_funcs,
|
|
|
|
};
|
|
|
|
|
2017-06-27 15:55:43 +00:00
|
|
|
|
2018-09-14 15:20:08 +00:00
|
|
|
/**
|
|
|
|
* DOC: atomic
|
|
|
|
*
|
|
|
|
* *WIP*
|
|
|
|
*/
|
2017-07-11 18:42:57 +00:00
|
|
|
|
2017-06-27 15:12:37 +00:00
|
|
|
static const struct drm_mode_config_funcs amdgpu_dm_mode_funcs = {
|
2018-01-19 17:24:39 +00:00
|
|
|
.fb_create = amdgpu_display_user_framebuffer_create,
|
2017-12-05 18:24:54 +00:00
|
|
|
.output_poll_changed = drm_fb_helper_output_poll_changed,
|
2017-09-12 19:58:20 +00:00
|
|
|
.atomic_check = amdgpu_dm_atomic_check,
|
2017-06-29 16:03:59 +00:00
|
|
|
.atomic_commit = amdgpu_dm_atomic_commit,
|
2017-04-20 19:57:05 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static struct drm_mode_config_helper_funcs amdgpu_dm_mode_config_helperfuncs = {
|
|
|
|
.atomic_commit_tail = amdgpu_dm_atomic_commit_tail
|
2017-09-12 19:58:20 +00:00
|
|
|
};
|
|
|
|
|
2020-01-24 15:44:20 +00:00
|
|
|
static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)
|
|
|
|
{
|
|
|
|
u32 max_cll, min_cll, max, min, q, r;
|
|
|
|
struct amdgpu_dm_backlight_caps *caps;
|
|
|
|
struct amdgpu_display_manager *dm;
|
|
|
|
struct drm_connector *conn_base;
|
|
|
|
struct amdgpu_device *adev;
|
2020-06-22 17:29:16 +00:00
|
|
|
struct dc_link *link = NULL;
|
2020-01-24 15:44:20 +00:00
|
|
|
static const u8 pre_computed_values[] = {
|
|
|
|
50, 51, 52, 53, 55, 56, 57, 58, 59, 61, 62, 63, 65, 66, 68, 69,
|
|
|
|
71, 72, 74, 75, 77, 79, 81, 82, 84, 86, 88, 90, 92, 94, 96, 98};
|
|
|
|
|
|
|
|
if (!aconnector || !aconnector->dc_link)
|
|
|
|
return;
|
|
|
|
|
2020-06-22 17:29:16 +00:00
|
|
|
link = aconnector->dc_link;
|
|
|
|
if (link->connector_signal != SIGNAL_TYPE_EDP)
|
|
|
|
return;
|
|
|
|
|
2020-01-24 15:44:20 +00:00
|
|
|
conn_base = &aconnector->base;
|
|
|
|
adev = conn_base->dev->dev_private;
|
|
|
|
dm = &adev->dm;
|
|
|
|
caps = &dm->backlight_caps;
|
|
|
|
caps->ext_caps = &aconnector->dc_link->dpcd_sink_ext_caps;
|
|
|
|
caps->aux_support = false;
|
|
|
|
max_cll = conn_base->hdr_sink_metadata.hdmi_type1.max_cll;
|
|
|
|
min_cll = conn_base->hdr_sink_metadata.hdmi_type1.min_cll;
|
|
|
|
|
|
|
|
if (caps->ext_caps->bits.oled == 1 ||
|
|
|
|
caps->ext_caps->bits.sdr_aux_backlight_control == 1 ||
|
|
|
|
caps->ext_caps->bits.hdr_aux_backlight_control == 1)
|
|
|
|
caps->aux_support = true;
|
|
|
|
|
|
|
|
/* From the specification (CTA-861-G), for calculating the maximum
|
|
|
|
* luminance we need to use:
|
|
|
|
* Luminance = 50*2**(CV/32)
|
|
|
|
* Where CV is a one-byte value.
|
|
|
|
* For calculating this expression we may need float point precision;
|
|
|
|
* to avoid this complexity level, we take advantage that CV is divided
|
|
|
|
* by a constant. From the Euclids division algorithm, we know that CV
|
|
|
|
* can be written as: CV = 32*q + r. Next, we replace CV in the
|
|
|
|
* Luminance expression and get 50*(2**q)*(2**(r/32)), hence we just
|
|
|
|
* need to pre-compute the value of r/32. For pre-computing the values
|
|
|
|
* We just used the following Ruby line:
|
|
|
|
* (0...32).each {|cv| puts (50*2**(cv/32.0)).round}
|
|
|
|
* The results of the above expressions can be verified at
|
|
|
|
* pre_computed_values.
|
|
|
|
*/
|
|
|
|
q = max_cll >> 5;
|
|
|
|
r = max_cll % 32;
|
|
|
|
max = (1 << q) * pre_computed_values[r];
|
|
|
|
|
|
|
|
// min luminance: maxLum * (CV/255)^2 / 100
|
|
|
|
q = DIV_ROUND_CLOSEST(min_cll, 255);
|
|
|
|
min = max * DIV_ROUND_CLOSEST((q * q), 100);
|
|
|
|
|
|
|
|
caps->aux_max_input_signal = max;
|
|
|
|
caps->aux_min_input_signal = min;
|
|
|
|
}
|
|
|
|
|
2020-02-13 17:44:35 +00:00
|
|
|
void amdgpu_dm_update_connector_after_detect(
|
|
|
|
struct amdgpu_dm_connector *aconnector)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
|
|
|
struct drm_connector *connector = &aconnector->base;
|
|
|
|
struct drm_device *dev = connector->dev;
|
2017-07-24 18:04:27 +00:00
|
|
|
struct dc_sink *sink;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
/* MST handled by drm_mst framework */
|
|
|
|
if (aconnector->mst_mgr.mst_state == true)
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
|
|
sink = aconnector->dc_link->local_sink;
|
2019-02-10 10:13:01 +00:00
|
|
|
if (sink)
|
|
|
|
dc_sink_retain(sink);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Edid mgmt connector gets first update only in mode_valid hook and then
|
2017-09-12 19:58:20 +00:00
|
|
|
* the connector sink is set to either fake or physical sink depends on link status.
|
2018-08-15 18:38:30 +00:00
|
|
|
* Skip if already done during boot.
|
2017-09-12 19:58:20 +00:00
|
|
|
*/
|
|
|
|
if (aconnector->base.force != DRM_FORCE_UNSPECIFIED
|
|
|
|
&& aconnector->dc_em_sink) {
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* For S3 resume with headless use eml_sink to fake stream
|
|
|
|
* because on resume connector->sink is set to NULL
|
2017-09-12 19:58:20 +00:00
|
|
|
*/
|
|
|
|
mutex_lock(&dev->mode_config.mutex);
|
|
|
|
|
|
|
|
if (sink) {
|
2016-12-07 19:10:05 +00:00
|
|
|
if (aconnector->dc_sink) {
|
2018-08-21 19:40:28 +00:00
|
|
|
amdgpu_dm_update_freesync_caps(connector, NULL);
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* retain and release below are used to
|
|
|
|
* bump up refcount for sink because the link doesn't point
|
|
|
|
* to it anymore after disconnect, so on next crtc to connector
|
2016-12-07 19:10:05 +00:00
|
|
|
* reshuffle by UMD we will get into unwanted dc_sink release
|
|
|
|
*/
|
2019-02-10 10:13:01 +00:00
|
|
|
dc_sink_release(aconnector->dc_sink);
|
2016-12-07 19:10:05 +00:00
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
aconnector->dc_sink = sink;
|
2019-02-10 10:13:01 +00:00
|
|
|
dc_sink_retain(aconnector->dc_sink);
|
2018-08-21 19:40:28 +00:00
|
|
|
amdgpu_dm_update_freesync_caps(connector,
|
|
|
|
aconnector->edid);
|
2017-09-12 19:58:20 +00:00
|
|
|
} else {
|
2018-08-21 19:40:28 +00:00
|
|
|
amdgpu_dm_update_freesync_caps(connector, NULL);
|
2019-02-10 10:13:01 +00:00
|
|
|
if (!aconnector->dc_sink) {
|
2017-09-12 19:58:20 +00:00
|
|
|
aconnector->dc_sink = aconnector->dc_em_sink;
|
2016-12-07 19:10:05 +00:00
|
|
|
dc_sink_retain(aconnector->dc_sink);
|
2019-02-10 10:13:01 +00:00
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
mutex_unlock(&dev->mode_config.mutex);
|
2019-02-10 10:13:01 +00:00
|
|
|
|
|
|
|
if (sink)
|
|
|
|
dc_sink_release(sink);
|
2017-09-12 19:58:20 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* TODO: temporary guard to look for proper fix
|
|
|
|
* if this sink is MST sink, we should not do anything
|
|
|
|
*/
|
2019-02-10 10:13:01 +00:00
|
|
|
if (sink && sink->sink_signal == SIGNAL_TYPE_DISPLAY_PORT_MST) {
|
|
|
|
dc_sink_release(sink);
|
2017-09-12 19:58:20 +00:00
|
|
|
return;
|
2019-02-10 10:13:01 +00:00
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
if (aconnector->dc_sink == sink) {
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* We got a DP short pulse (Link Loss, DP CTS, etc...).
|
|
|
|
* Do nothing!!
|
|
|
|
*/
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("DCHPD: connector_id=%d: dc_sink didn't change.\n",
|
2017-09-12 19:58:20 +00:00
|
|
|
aconnector->connector_id);
|
2019-02-10 10:13:01 +00:00
|
|
|
if (sink)
|
|
|
|
dc_sink_release(sink);
|
2017-09-12 19:58:20 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("DCHPD: connector_id=%d: Old sink=%p New sink=%p\n",
|
2017-09-12 19:58:20 +00:00
|
|
|
aconnector->connector_id, aconnector->dc_sink, sink);
|
|
|
|
|
|
|
|
mutex_lock(&dev->mode_config.mutex);
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* 1. Update status of the drm connector
|
|
|
|
* 2. Send an event and let userspace tell us what to do
|
|
|
|
*/
|
2017-09-12 19:58:20 +00:00
|
|
|
if (sink) {
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* TODO: check if we still need the S3 mode update workaround.
|
|
|
|
* If yes, put it here.
|
|
|
|
*/
|
2017-09-12 19:58:20 +00:00
|
|
|
if (aconnector->dc_sink)
|
2018-08-21 19:40:28 +00:00
|
|
|
amdgpu_dm_update_freesync_caps(connector, NULL);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
aconnector->dc_sink = sink;
|
2019-02-10 10:13:01 +00:00
|
|
|
dc_sink_retain(aconnector->dc_sink);
|
2017-10-17 12:59:18 +00:00
|
|
|
if (sink->dc_edid.length == 0) {
|
2017-09-12 19:58:20 +00:00
|
|
|
aconnector->edid = NULL;
|
2020-04-22 18:37:33 +00:00
|
|
|
if (aconnector->dc_link->aux_mode) {
|
|
|
|
drm_dp_cec_unset_edid(
|
|
|
|
&aconnector->dm_dp_aux.aux);
|
|
|
|
}
|
2017-10-17 12:59:18 +00:00
|
|
|
} else {
|
2017-09-12 19:58:20 +00:00
|
|
|
aconnector->edid =
|
2020-04-22 18:37:33 +00:00
|
|
|
(struct edid *)sink->dc_edid.raw_edid;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2018-07-09 08:40:06 +00:00
|
|
|
drm_connector_update_edid_property(connector,
|
2020-04-22 18:37:33 +00:00
|
|
|
aconnector->edid);
|
2020-07-28 07:10:35 +00:00
|
|
|
drm_add_edid_modes(connector, aconnector->edid);
|
2020-04-22 18:37:33 +00:00
|
|
|
|
|
|
|
if (aconnector->dc_link->aux_mode)
|
|
|
|
drm_dp_cec_set_edid(&aconnector->dm_dp_aux.aux,
|
|
|
|
aconnector->edid);
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
2020-04-22 18:37:33 +00:00
|
|
|
|
2018-08-21 19:40:28 +00:00
|
|
|
amdgpu_dm_update_freesync_caps(connector, aconnector->edid);
|
2020-01-24 15:44:20 +00:00
|
|
|
update_connector_ext_caps(aconnector);
|
2017-09-12 19:58:20 +00:00
|
|
|
} else {
|
2018-08-27 08:08:18 +00:00
|
|
|
drm_dp_cec_unset_edid(&aconnector->dm_dp_aux.aux);
|
2018-08-21 19:40:28 +00:00
|
|
|
amdgpu_dm_update_freesync_caps(connector, NULL);
|
2018-07-09 08:40:06 +00:00
|
|
|
drm_connector_update_edid_property(connector, NULL);
|
2017-09-12 19:58:20 +00:00
|
|
|
aconnector->num_modes = 0;
|
2019-02-10 10:13:01 +00:00
|
|
|
dc_sink_release(aconnector->dc_sink);
|
2017-09-12 19:58:20 +00:00
|
|
|
aconnector->dc_sink = NULL;
|
2018-04-27 13:09:52 +00:00
|
|
|
aconnector->edid = NULL;
|
2019-09-16 20:52:58 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
|
|
|
/* Set CP to DESIRED if it was ENABLED, so we can re-enable it again on hotplug */
|
|
|
|
if (connector->state->content_protection == DRM_MODE_CONTENT_PROTECTION_ENABLED)
|
|
|
|
connector->state->content_protection = DRM_MODE_CONTENT_PROTECTION_DESIRED;
|
|
|
|
#endif
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
mutex_unlock(&dev->mode_config.mutex);
|
2019-02-10 10:13:01 +00:00
|
|
|
|
|
|
|
if (sink)
|
|
|
|
dc_sink_release(sink);
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void handle_hpd_irq(void *param)
|
|
|
|
{
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector = (struct amdgpu_dm_connector *)param;
|
2017-09-12 19:58:20 +00:00
|
|
|
struct drm_connector *connector = &aconnector->base;
|
|
|
|
struct drm_device *dev = connector->dev;
|
2018-09-26 17:42:10 +00:00
|
|
|
enum dc_connection_type new_connection_type = dc_connection_none;
|
2019-09-16 20:52:58 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
#endif
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* In case of failure or MST no need to update connector status or notify the OS
|
|
|
|
* since (for MST case) MST does this in its own context.
|
2017-09-12 19:58:20 +00:00
|
|
|
*/
|
|
|
|
mutex_lock(&aconnector->hpd_lock);
|
2017-08-17 18:58:07 +00:00
|
|
|
|
2019-09-16 20:52:58 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
2020-02-18 18:20:30 +00:00
|
|
|
if (adev->dm.hdcp_workqueue)
|
2019-06-24 18:54:13 +00:00
|
|
|
hdcp_reset_display(adev->dm.hdcp_workqueue, aconnector->dc_link->link_index);
|
2019-09-16 20:52:58 +00:00
|
|
|
#endif
|
2017-08-17 18:58:07 +00:00
|
|
|
if (aconnector->fake_enable)
|
|
|
|
aconnector->fake_enable = false;
|
|
|
|
|
2018-09-26 17:42:10 +00:00
|
|
|
if (!dc_link_detect_sink(aconnector->dc_link, &new_connection_type))
|
|
|
|
DRM_ERROR("KMS: Failed to detect connector\n");
|
|
|
|
|
|
|
|
if (aconnector->base.force && new_connection_type == dc_connection_none) {
|
|
|
|
emulated_link_detect(aconnector->dc_link);
|
|
|
|
|
|
|
|
|
|
|
|
drm_modeset_lock_all(dev);
|
|
|
|
dm_restore_drm_connector_state(dev, connector);
|
|
|
|
drm_modeset_unlock_all(dev);
|
|
|
|
|
|
|
|
if (aconnector->base.force == DRM_FORCE_UNSPECIFIED)
|
|
|
|
drm_kms_helper_hotplug_event(dev);
|
|
|
|
|
|
|
|
} else if (dc_link_detect(aconnector->dc_link, DETECT_REASON_HPD)) {
|
2017-09-12 19:58:20 +00:00
|
|
|
amdgpu_dm_update_connector_after_detect(aconnector);
|
|
|
|
|
|
|
|
|
|
|
|
drm_modeset_lock_all(dev);
|
|
|
|
dm_restore_drm_connector_state(dev, connector);
|
|
|
|
drm_modeset_unlock_all(dev);
|
|
|
|
|
|
|
|
if (aconnector->base.force == DRM_FORCE_UNSPECIFIED)
|
|
|
|
drm_kms_helper_hotplug_event(dev);
|
|
|
|
}
|
|
|
|
mutex_unlock(&aconnector->hpd_lock);
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2017-09-05 18:16:09 +00:00
|
|
|
static void dm_handle_hpd_rx_irq(struct amdgpu_dm_connector *aconnector)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
|
|
|
uint8_t esi[DP_PSR_ERROR_STATUS - DP_SINK_COUNT_ESI] = { 0 };
|
|
|
|
uint8_t dret;
|
|
|
|
bool new_irq_handled = false;
|
|
|
|
int dpcd_addr;
|
|
|
|
int dpcd_bytes_to_read;
|
|
|
|
|
|
|
|
const int max_process_count = 30;
|
|
|
|
int process_count = 0;
|
|
|
|
|
|
|
|
const struct dc_link_status *link_status = dc_link_get_status(aconnector->dc_link);
|
|
|
|
|
|
|
|
if (link_status->dpcd_caps->dpcd_rev.raw < 0x12) {
|
|
|
|
dpcd_bytes_to_read = DP_LANE0_1_STATUS - DP_SINK_COUNT;
|
|
|
|
/* DPCD 0x200 - 0x201 for downstream IRQ */
|
|
|
|
dpcd_addr = DP_SINK_COUNT;
|
|
|
|
} else {
|
|
|
|
dpcd_bytes_to_read = DP_PSR_ERROR_STATUS - DP_SINK_COUNT_ESI;
|
|
|
|
/* DPCD 0x2002 - 0x2005 for downstream IRQ */
|
|
|
|
dpcd_addr = DP_SINK_COUNT_ESI;
|
|
|
|
}
|
|
|
|
|
|
|
|
dret = drm_dp_dpcd_read(
|
|
|
|
&aconnector->dm_dp_aux.aux,
|
|
|
|
dpcd_addr,
|
|
|
|
esi,
|
|
|
|
dpcd_bytes_to_read);
|
|
|
|
|
|
|
|
while (dret == dpcd_bytes_to_read &&
|
|
|
|
process_count < max_process_count) {
|
|
|
|
uint8_t retry;
|
|
|
|
dret = 0;
|
|
|
|
|
|
|
|
process_count++;
|
|
|
|
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("ESI %02x %02x %02x\n", esi[0], esi[1], esi[2]);
|
2017-09-12 19:58:20 +00:00
|
|
|
/* handle HPD short pulse irq */
|
|
|
|
if (aconnector->mst_mgr.mst_state)
|
|
|
|
drm_dp_mst_hpd_irq(
|
|
|
|
&aconnector->mst_mgr,
|
|
|
|
esi,
|
|
|
|
&new_irq_handled);
|
|
|
|
|
|
|
|
if (new_irq_handled) {
|
|
|
|
/* ACK at DPCD to notify down stream */
|
|
|
|
const int ack_dpcd_bytes_to_write =
|
|
|
|
dpcd_bytes_to_read - 1;
|
|
|
|
|
|
|
|
for (retry = 0; retry < 3; retry++) {
|
|
|
|
uint8_t wret;
|
|
|
|
|
|
|
|
wret = drm_dp_dpcd_write(
|
|
|
|
&aconnector->dm_dp_aux.aux,
|
|
|
|
dpcd_addr + 1,
|
|
|
|
&esi[1],
|
|
|
|
ack_dpcd_bytes_to_write);
|
|
|
|
if (wret == ack_dpcd_bytes_to_write)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/* check if there is new irq to be handled */
|
2017-09-12 19:58:20 +00:00
|
|
|
dret = drm_dp_dpcd_read(
|
|
|
|
&aconnector->dm_dp_aux.aux,
|
|
|
|
dpcd_addr,
|
|
|
|
esi,
|
|
|
|
dpcd_bytes_to_read);
|
|
|
|
|
|
|
|
new_irq_handled = false;
|
2017-10-17 13:00:33 +00:00
|
|
|
} else {
|
2017-09-12 19:58:20 +00:00
|
|
|
break;
|
2017-10-17 13:00:33 +00:00
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (process_count == max_process_count)
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("Loop exceeded max iterations\n");
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void handle_hpd_rx_irq(void *param)
|
|
|
|
{
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector = (struct amdgpu_dm_connector *)param;
|
2017-09-12 19:58:20 +00:00
|
|
|
struct drm_connector *connector = &aconnector->base;
|
|
|
|
struct drm_device *dev = connector->dev;
|
2017-10-17 13:04:25 +00:00
|
|
|
struct dc_link *dc_link = aconnector->dc_link;
|
2017-09-12 19:58:20 +00:00
|
|
|
bool is_mst_root_connector = aconnector->mst_mgr.mst_state;
|
2018-09-26 17:42:10 +00:00
|
|
|
enum dc_connection_type new_connection_type = dc_connection_none;
|
2019-06-10 20:18:38 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
|
|
|
union hpd_irq_data hpd_irq_data;
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
|
|
|
|
memset(&hpd_irq_data, 0, sizeof(hpd_irq_data));
|
|
|
|
#endif
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* TODO:Temporary add mutex to protect hpd interrupt not have a gpio
|
2017-09-12 19:58:20 +00:00
|
|
|
* conflict, after implement i2c helper, this mutex should be
|
|
|
|
* retired.
|
|
|
|
*/
|
2017-10-17 13:04:25 +00:00
|
|
|
if (dc_link->type != dc_connection_mst_branch)
|
2017-09-12 19:58:20 +00:00
|
|
|
mutex_lock(&aconnector->hpd_lock);
|
|
|
|
|
2019-06-10 20:18:38 +00:00
|
|
|
|
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
|
|
|
if (dc_link_handle_hpd_rx_irq(dc_link, &hpd_irq_data, NULL) &&
|
|
|
|
#else
|
2018-06-26 20:40:55 +00:00
|
|
|
if (dc_link_handle_hpd_rx_irq(dc_link, NULL, NULL) &&
|
2019-06-10 20:18:38 +00:00
|
|
|
#endif
|
2017-09-12 19:58:20 +00:00
|
|
|
!is_mst_root_connector) {
|
|
|
|
/* Downstream Port status changed. */
|
2018-09-26 17:42:10 +00:00
|
|
|
if (!dc_link_detect_sink(dc_link, &new_connection_type))
|
|
|
|
DRM_ERROR("KMS: Failed to detect connector\n");
|
|
|
|
|
|
|
|
if (aconnector->base.force && new_connection_type == dc_connection_none) {
|
|
|
|
emulated_link_detect(dc_link);
|
|
|
|
|
|
|
|
if (aconnector->fake_enable)
|
|
|
|
aconnector->fake_enable = false;
|
|
|
|
|
|
|
|
amdgpu_dm_update_connector_after_detect(aconnector);
|
|
|
|
|
|
|
|
|
|
|
|
drm_modeset_lock_all(dev);
|
|
|
|
dm_restore_drm_connector_state(dev, connector);
|
|
|
|
drm_modeset_unlock_all(dev);
|
|
|
|
|
|
|
|
drm_kms_helper_hotplug_event(dev);
|
|
|
|
} else if (dc_link_detect(dc_link, DETECT_REASON_HPDRX)) {
|
2018-02-09 21:57:38 +00:00
|
|
|
|
|
|
|
if (aconnector->fake_enable)
|
|
|
|
aconnector->fake_enable = false;
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
amdgpu_dm_update_connector_after_detect(aconnector);
|
|
|
|
|
|
|
|
|
|
|
|
drm_modeset_lock_all(dev);
|
|
|
|
dm_restore_drm_connector_state(dev, connector);
|
|
|
|
drm_modeset_unlock_all(dev);
|
|
|
|
|
|
|
|
drm_kms_helper_hotplug_event(dev);
|
|
|
|
}
|
|
|
|
}
|
2019-06-10 20:18:38 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
2020-02-24 10:31:20 +00:00
|
|
|
if (hpd_irq_data.bytes.device_service_irq.bits.CP_IRQ) {
|
|
|
|
if (adev->dm.hdcp_workqueue)
|
|
|
|
hdcp_handle_cpirq(adev->dm.hdcp_workqueue, aconnector->base.index);
|
|
|
|
}
|
2019-06-10 20:18:38 +00:00
|
|
|
#endif
|
2017-09-12 19:58:20 +00:00
|
|
|
if ((dc_link->cur_link_settings.lane_count != LANE_COUNT_UNKNOWN) ||
|
2017-10-17 13:04:25 +00:00
|
|
|
(dc_link->type == dc_connection_mst_branch))
|
2017-09-12 19:58:20 +00:00
|
|
|
dm_handle_hpd_rx_irq(aconnector);
|
|
|
|
|
2018-08-27 08:08:18 +00:00
|
|
|
if (dc_link->type != dc_connection_mst_branch) {
|
|
|
|
drm_dp_cec_irq(&aconnector->dm_dp_aux.aux);
|
2017-09-12 19:58:20 +00:00
|
|
|
mutex_unlock(&aconnector->hpd_lock);
|
2018-08-27 08:08:18 +00:00
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void register_hpd_handlers(struct amdgpu_device *adev)
|
|
|
|
{
|
|
|
|
struct drm_device *dev = adev->ddev;
|
|
|
|
struct drm_connector *connector;
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector;
|
2017-09-12 19:58:20 +00:00
|
|
|
const struct dc_link *dc_link;
|
|
|
|
struct dc_interrupt_params int_params = {0};
|
|
|
|
|
|
|
|
int_params.requested_polarity = INTERRUPT_POLARITY_DEFAULT;
|
|
|
|
int_params.current_polarity = INTERRUPT_POLARITY_DEFAULT;
|
|
|
|
|
|
|
|
list_for_each_entry(connector,
|
|
|
|
&dev->mode_config.connector_list, head) {
|
|
|
|
|
2017-09-05 18:16:09 +00:00
|
|
|
aconnector = to_amdgpu_dm_connector(connector);
|
2017-09-12 19:58:20 +00:00
|
|
|
dc_link = aconnector->dc_link;
|
|
|
|
|
|
|
|
if (DC_IRQ_SOURCE_INVALID != dc_link->irq_source_hpd) {
|
|
|
|
int_params.int_context = INTERRUPT_LOW_IRQ_CONTEXT;
|
|
|
|
int_params.irq_source = dc_link->irq_source_hpd;
|
|
|
|
|
|
|
|
amdgpu_dm_irq_register_interrupt(adev, &int_params,
|
|
|
|
handle_hpd_irq,
|
|
|
|
(void *) aconnector);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (DC_IRQ_SOURCE_INVALID != dc_link->irq_source_hpd_rx) {
|
|
|
|
|
|
|
|
/* Also register for DP short pulse (hpd_rx). */
|
|
|
|
int_params.int_context = INTERRUPT_LOW_IRQ_CONTEXT;
|
|
|
|
int_params.irq_source = dc_link->irq_source_hpd_rx;
|
|
|
|
|
|
|
|
amdgpu_dm_irq_register_interrupt(adev, &int_params,
|
|
|
|
handle_hpd_rx_irq,
|
|
|
|
(void *) aconnector);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Register IRQ sources and initialize IRQ callbacks */
|
|
|
|
static int dce110_register_irq_handlers(struct amdgpu_device *adev)
|
|
|
|
{
|
|
|
|
struct dc *dc = adev->dm.dc;
|
|
|
|
struct common_irq_params *c_irq_params;
|
|
|
|
struct dc_interrupt_params int_params = {0};
|
|
|
|
int r;
|
|
|
|
int i;
|
2018-09-17 13:29:28 +00:00
|
|
|
unsigned client_id = AMDGPU_IRQ_CLIENTID_LEGACY;
|
2017-06-15 20:20:24 +00:00
|
|
|
|
2019-07-02 16:39:50 +00:00
|
|
|
if (adev->asic_type >= CHIP_VEGA10)
|
2018-03-08 21:44:47 +00:00
|
|
|
client_id = SOC15_IH_CLIENTID_DCE;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
int_params.requested_polarity = INTERRUPT_POLARITY_DEFAULT;
|
|
|
|
int_params.current_polarity = INTERRUPT_POLARITY_DEFAULT;
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Actions of amdgpu_irq_add_id():
|
2017-09-12 19:58:20 +00:00
|
|
|
* 1. Register a set() function with base driver.
|
|
|
|
* Base driver will call set() function to enable/disable an
|
|
|
|
* interrupt in DC hardware.
|
|
|
|
* 2. Register amdgpu_dm_irq_handler().
|
|
|
|
* Base driver will call amdgpu_dm_irq_handler() for ALL interrupts
|
|
|
|
* coming from DC hardware.
|
|
|
|
* amdgpu_dm_irq_handler() will re-direct the interrupt to DC
|
|
|
|
* for acknowledging and handling. */
|
|
|
|
|
2017-04-19 17:29:11 +00:00
|
|
|
/* Use VBLANK interrupt */
|
2017-03-23 19:30:35 +00:00
|
|
|
for (i = VISLANDS30_IV_SRCID_D1_VERTICAL_INTERRUPT0; i <= VISLANDS30_IV_SRCID_D6_VERTICAL_INTERRUPT0; i++) {
|
2017-06-15 20:20:24 +00:00
|
|
|
r = amdgpu_irq_add_id(adev, client_id, i, &adev->crtc_irq);
|
2017-09-12 19:58:20 +00:00
|
|
|
if (r) {
|
|
|
|
DRM_ERROR("Failed to add crtc irq id!\n");
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
int_params.int_context = INTERRUPT_HIGH_IRQ_CONTEXT;
|
|
|
|
int_params.irq_source =
|
2017-04-19 17:55:35 +00:00
|
|
|
dc_interrupt_to_irq_source(dc, i, 0);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2017-04-19 17:29:11 +00:00
|
|
|
c_irq_params = &adev->dm.vblank_params[int_params.irq_source - DC_IRQ_SOURCE_VBLANK1];
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
c_irq_params->adev = adev;
|
|
|
|
c_irq_params->irq_src = int_params.irq_source;
|
|
|
|
|
|
|
|
amdgpu_dm_irq_register_interrupt(adev, &int_params,
|
|
|
|
dm_crtc_high_irq, c_irq_params);
|
|
|
|
}
|
|
|
|
|
2019-03-29 12:00:56 +00:00
|
|
|
/* Use VUPDATE interrupt */
|
|
|
|
for (i = VISLANDS30_IV_SRCID_D1_V_UPDATE_INT; i <= VISLANDS30_IV_SRCID_D6_V_UPDATE_INT; i += 2) {
|
|
|
|
r = amdgpu_irq_add_id(adev, client_id, i, &adev->vupdate_irq);
|
|
|
|
if (r) {
|
|
|
|
DRM_ERROR("Failed to add vupdate irq id!\n");
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
int_params.int_context = INTERRUPT_HIGH_IRQ_CONTEXT;
|
|
|
|
int_params.irq_source =
|
|
|
|
dc_interrupt_to_irq_source(dc, i, 0);
|
|
|
|
|
|
|
|
c_irq_params = &adev->dm.vupdate_params[int_params.irq_source - DC_IRQ_SOURCE_VUPDATE1];
|
|
|
|
|
|
|
|
c_irq_params->adev = adev;
|
|
|
|
c_irq_params->irq_src = int_params.irq_source;
|
|
|
|
|
|
|
|
amdgpu_dm_irq_register_interrupt(adev, &int_params,
|
|
|
|
dm_vupdate_high_irq, c_irq_params);
|
|
|
|
}
|
|
|
|
|
2017-04-19 17:55:35 +00:00
|
|
|
/* Use GRPH_PFLIP interrupt */
|
2017-09-12 19:58:20 +00:00
|
|
|
for (i = VISLANDS30_IV_SRCID_D1_GRPH_PFLIP;
|
|
|
|
i <= VISLANDS30_IV_SRCID_D6_GRPH_PFLIP; i += 2) {
|
2017-06-15 20:20:24 +00:00
|
|
|
r = amdgpu_irq_add_id(adev, client_id, i, &adev->pageflip_irq);
|
2017-09-12 19:58:20 +00:00
|
|
|
if (r) {
|
|
|
|
DRM_ERROR("Failed to add page flip irq id!\n");
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
int_params.int_context = INTERRUPT_HIGH_IRQ_CONTEXT;
|
|
|
|
int_params.irq_source =
|
|
|
|
dc_interrupt_to_irq_source(dc, i, 0);
|
|
|
|
|
|
|
|
c_irq_params = &adev->dm.pflip_params[int_params.irq_source - DC_IRQ_SOURCE_PFLIP_FIRST];
|
|
|
|
|
|
|
|
c_irq_params->adev = adev;
|
|
|
|
c_irq_params->irq_src = int_params.irq_source;
|
|
|
|
|
|
|
|
amdgpu_dm_irq_register_interrupt(adev, &int_params,
|
|
|
|
dm_pflip_high_irq, c_irq_params);
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
/* HPD */
|
2017-06-15 20:20:24 +00:00
|
|
|
r = amdgpu_irq_add_id(adev, client_id,
|
|
|
|
VISLANDS30_IV_SRCID_HOTPLUG_DETECT_A, &adev->hpd_irq);
|
2017-09-12 19:58:20 +00:00
|
|
|
if (r) {
|
|
|
|
DRM_ERROR("Failed to add hpd irq id!\n");
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
register_hpd_handlers(adev);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-11-06 19:48:35 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN)
|
2017-06-15 20:27:42 +00:00
|
|
|
/* Register IRQ sources and initialize IRQ callbacks */
|
|
|
|
static int dcn10_register_irq_handlers(struct amdgpu_device *adev)
|
|
|
|
{
|
|
|
|
struct dc *dc = adev->dm.dc;
|
|
|
|
struct common_irq_params *c_irq_params;
|
|
|
|
struct dc_interrupt_params int_params = {0};
|
|
|
|
int r;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
int_params.requested_polarity = INTERRUPT_POLARITY_DEFAULT;
|
|
|
|
int_params.current_polarity = INTERRUPT_POLARITY_DEFAULT;
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Actions of amdgpu_irq_add_id():
|
2017-06-15 20:27:42 +00:00
|
|
|
* 1. Register a set() function with base driver.
|
|
|
|
* Base driver will call set() function to enable/disable an
|
|
|
|
* interrupt in DC hardware.
|
|
|
|
* 2. Register amdgpu_dm_irq_handler().
|
|
|
|
* Base driver will call amdgpu_dm_irq_handler() for ALL interrupts
|
|
|
|
* coming from DC hardware.
|
|
|
|
* amdgpu_dm_irq_handler() will re-direct the interrupt to DC
|
|
|
|
* for acknowledging and handling.
|
2018-08-15 18:38:30 +00:00
|
|
|
*/
|
2017-06-15 20:27:42 +00:00
|
|
|
|
|
|
|
/* Use VSTARTUP interrupt */
|
|
|
|
for (i = DCN_1_0__SRCID__DC_D1_OTG_VSTARTUP;
|
|
|
|
i <= DCN_1_0__SRCID__DC_D1_OTG_VSTARTUP + adev->mode_info.num_crtc - 1;
|
|
|
|
i++) {
|
2018-03-08 21:44:47 +00:00
|
|
|
r = amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_DCE, i, &adev->crtc_irq);
|
2017-06-15 20:27:42 +00:00
|
|
|
|
|
|
|
if (r) {
|
|
|
|
DRM_ERROR("Failed to add crtc irq id!\n");
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
int_params.int_context = INTERRUPT_HIGH_IRQ_CONTEXT;
|
|
|
|
int_params.irq_source =
|
|
|
|
dc_interrupt_to_irq_source(dc, i, 0);
|
|
|
|
|
|
|
|
c_irq_params = &adev->dm.vblank_params[int_params.irq_source - DC_IRQ_SOURCE_VBLANK1];
|
|
|
|
|
|
|
|
c_irq_params->adev = adev;
|
|
|
|
c_irq_params->irq_src = int_params.irq_source;
|
|
|
|
|
2020-05-06 19:47:54 +00:00
|
|
|
amdgpu_dm_irq_register_interrupt(
|
|
|
|
adev, &int_params, dm_crtc_high_irq, c_irq_params);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Use VUPDATE_NO_LOCK interrupt on DCN, which seems to correspond to
|
|
|
|
* the regular VUPDATE interrupt on DCE. We want DC_IRQ_SOURCE_VUPDATEx
|
|
|
|
* to trigger at end of each vblank, regardless of state of the lock,
|
|
|
|
* matching DCE behaviour.
|
|
|
|
*/
|
|
|
|
for (i = DCN_1_0__SRCID__OTG0_IHC_V_UPDATE_NO_LOCK_INTERRUPT;
|
|
|
|
i <= DCN_1_0__SRCID__OTG0_IHC_V_UPDATE_NO_LOCK_INTERRUPT + adev->mode_info.num_crtc - 1;
|
|
|
|
i++) {
|
|
|
|
r = amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_DCE, i, &adev->vupdate_irq);
|
|
|
|
|
|
|
|
if (r) {
|
|
|
|
DRM_ERROR("Failed to add vupdate irq id!\n");
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
int_params.int_context = INTERRUPT_HIGH_IRQ_CONTEXT;
|
|
|
|
int_params.irq_source =
|
|
|
|
dc_interrupt_to_irq_source(dc, i, 0);
|
|
|
|
|
|
|
|
c_irq_params = &adev->dm.vupdate_params[int_params.irq_source - DC_IRQ_SOURCE_VUPDATE1];
|
|
|
|
|
|
|
|
c_irq_params->adev = adev;
|
|
|
|
c_irq_params->irq_src = int_params.irq_source;
|
|
|
|
|
2017-06-15 20:27:42 +00:00
|
|
|
amdgpu_dm_irq_register_interrupt(adev, &int_params,
|
2020-05-06 19:47:54 +00:00
|
|
|
dm_vupdate_high_irq, c_irq_params);
|
2019-03-29 12:00:56 +00:00
|
|
|
}
|
|
|
|
|
2017-06-15 20:27:42 +00:00
|
|
|
/* Use GRPH_PFLIP interrupt */
|
|
|
|
for (i = DCN_1_0__SRCID__HUBP0_FLIP_INTERRUPT;
|
|
|
|
i <= DCN_1_0__SRCID__HUBP0_FLIP_INTERRUPT + adev->mode_info.num_crtc - 1;
|
|
|
|
i++) {
|
2018-03-08 21:44:47 +00:00
|
|
|
r = amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_DCE, i, &adev->pageflip_irq);
|
2017-06-15 20:27:42 +00:00
|
|
|
if (r) {
|
|
|
|
DRM_ERROR("Failed to add page flip irq id!\n");
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
int_params.int_context = INTERRUPT_HIGH_IRQ_CONTEXT;
|
|
|
|
int_params.irq_source =
|
|
|
|
dc_interrupt_to_irq_source(dc, i, 0);
|
|
|
|
|
|
|
|
c_irq_params = &adev->dm.pflip_params[int_params.irq_source - DC_IRQ_SOURCE_PFLIP_FIRST];
|
|
|
|
|
|
|
|
c_irq_params->adev = adev;
|
|
|
|
c_irq_params->irq_src = int_params.irq_source;
|
|
|
|
|
|
|
|
amdgpu_dm_irq_register_interrupt(adev, &int_params,
|
|
|
|
dm_pflip_high_irq, c_irq_params);
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
/* HPD */
|
2018-03-08 21:44:47 +00:00
|
|
|
r = amdgpu_irq_add_id(adev, SOC15_IH_CLIENTID_DCE, DCN_1_0__SRCID__DC_HPD1_INT,
|
2017-06-15 20:27:42 +00:00
|
|
|
&adev->hpd_irq);
|
|
|
|
if (r) {
|
|
|
|
DRM_ERROR("Failed to add hpd irq id!\n");
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
register_hpd_handlers(adev);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2018-11-22 17:34:36 +00:00
|
|
|
/*
|
|
|
|
* Acquires the lock for the atomic state object and returns
|
|
|
|
* the new atomic state.
|
|
|
|
*
|
|
|
|
* This should only be called during atomic check.
|
|
|
|
*/
|
|
|
|
static int dm_atomic_get_state(struct drm_atomic_state *state,
|
|
|
|
struct dm_atomic_state **dm_state)
|
|
|
|
{
|
|
|
|
struct drm_device *dev = state->dev;
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
struct amdgpu_display_manager *dm = &adev->dm;
|
|
|
|
struct drm_private_state *priv_state;
|
|
|
|
|
|
|
|
if (*dm_state)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
priv_state = drm_atomic_get_private_obj_state(state, &dm->atomic_obj);
|
|
|
|
if (IS_ERR(priv_state))
|
|
|
|
return PTR_ERR(priv_state);
|
|
|
|
|
|
|
|
*dm_state = to_dm_atomic_state(priv_state);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-06-18 13:07:13 +00:00
|
|
|
static struct dm_atomic_state *
|
2018-11-22 17:34:36 +00:00
|
|
|
dm_atomic_get_new_state(struct drm_atomic_state *state)
|
|
|
|
{
|
|
|
|
struct drm_device *dev = state->dev;
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
struct amdgpu_display_manager *dm = &adev->dm;
|
|
|
|
struct drm_private_obj *obj;
|
|
|
|
struct drm_private_state *new_obj_state;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for_each_new_private_obj_in_state(state, obj, new_obj_state, i) {
|
|
|
|
if (obj->funcs == dm->atomic_obj.funcs)
|
|
|
|
return to_dm_atomic_state(new_obj_state);
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2020-06-18 13:07:13 +00:00
|
|
|
static struct dm_atomic_state *
|
2018-11-22 17:34:36 +00:00
|
|
|
dm_atomic_get_old_state(struct drm_atomic_state *state)
|
|
|
|
{
|
|
|
|
struct drm_device *dev = state->dev;
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
struct amdgpu_display_manager *dm = &adev->dm;
|
|
|
|
struct drm_private_obj *obj;
|
|
|
|
struct drm_private_state *old_obj_state;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for_each_old_private_obj_in_state(state, obj, old_obj_state, i) {
|
|
|
|
if (obj->funcs == dm->atomic_obj.funcs)
|
|
|
|
return to_dm_atomic_state(old_obj_state);
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct drm_private_state *
|
|
|
|
dm_atomic_duplicate_state(struct drm_private_obj *obj)
|
|
|
|
{
|
|
|
|
struct dm_atomic_state *old_state, *new_state;
|
|
|
|
|
|
|
|
new_state = kzalloc(sizeof(*new_state), GFP_KERNEL);
|
|
|
|
if (!new_state)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
__drm_atomic_helper_private_obj_duplicate_state(obj, &new_state->base);
|
|
|
|
|
2019-02-22 18:37:03 +00:00
|
|
|
old_state = to_dm_atomic_state(obj->state);
|
|
|
|
|
|
|
|
if (old_state && old_state->context)
|
|
|
|
new_state->context = dc_copy_state(old_state->context);
|
|
|
|
|
2018-11-22 17:34:36 +00:00
|
|
|
if (!new_state->context) {
|
|
|
|
kfree(new_state);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return &new_state->base;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void dm_atomic_destroy_state(struct drm_private_obj *obj,
|
|
|
|
struct drm_private_state *state)
|
|
|
|
{
|
|
|
|
struct dm_atomic_state *dm_state = to_dm_atomic_state(state);
|
|
|
|
|
|
|
|
if (dm_state && dm_state->context)
|
|
|
|
dc_release_state(dm_state->context);
|
|
|
|
|
|
|
|
kfree(dm_state);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct drm_private_state_funcs dm_atomic_state_funcs = {
|
|
|
|
.atomic_duplicate_state = dm_atomic_duplicate_state,
|
|
|
|
.atomic_destroy_state = dm_atomic_destroy_state,
|
|
|
|
};
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
static int amdgpu_dm_mode_config_init(struct amdgpu_device *adev)
|
|
|
|
{
|
2018-11-22 17:34:36 +00:00
|
|
|
struct dm_atomic_state *state;
|
2017-09-12 19:58:20 +00:00
|
|
|
int r;
|
|
|
|
|
|
|
|
adev->mode_info.mode_config_initialized = true;
|
|
|
|
|
|
|
|
adev->ddev->mode_config.funcs = (void *)&amdgpu_dm_mode_funcs;
|
2017-04-20 19:57:05 +00:00
|
|
|
adev->ddev->mode_config.helper_private = &amdgpu_dm_mode_config_helperfuncs;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
adev->ddev->mode_config.max_width = 16384;
|
|
|
|
adev->ddev->mode_config.max_height = 16384;
|
|
|
|
|
|
|
|
adev->ddev->mode_config.preferred_depth = 24;
|
|
|
|
adev->ddev->mode_config.prefer_shadow = 1;
|
2018-08-15 18:38:30 +00:00
|
|
|
/* indicates support for immediate flip */
|
2017-09-12 19:58:20 +00:00
|
|
|
adev->ddev->mode_config.async_page_flip = true;
|
|
|
|
|
2018-01-12 13:52:22 +00:00
|
|
|
adev->ddev->mode_config.fb_base = adev->gmc.aper_base;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2018-11-22 17:34:36 +00:00
|
|
|
state = kzalloc(sizeof(*state), GFP_KERNEL);
|
|
|
|
if (!state)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2019-02-22 18:37:03 +00:00
|
|
|
state->context = dc_create_state(adev->dm.dc);
|
2018-11-22 17:34:36 +00:00
|
|
|
if (!state->context) {
|
|
|
|
kfree(state);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
dc_resource_state_copy_construct_current(adev->dm.dc, state->context);
|
|
|
|
|
2019-01-09 19:53:51 +00:00
|
|
|
drm_atomic_private_obj_init(adev->ddev,
|
|
|
|
&adev->dm.atomic_obj,
|
2018-11-22 17:34:36 +00:00
|
|
|
&state->base,
|
|
|
|
&dm_atomic_state_funcs);
|
|
|
|
|
2018-01-19 17:47:40 +00:00
|
|
|
r = amdgpu_display_modeset_create_props(adev);
|
2020-08-26 13:24:58 +00:00
|
|
|
if (r) {
|
|
|
|
dc_release_state(state->context);
|
|
|
|
kfree(state);
|
2017-09-12 19:58:20 +00:00
|
|
|
return r;
|
2020-08-26 13:24:58 +00:00
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2019-07-11 19:31:46 +00:00
|
|
|
r = amdgpu_dm_audio_init(adev);
|
2020-08-26 13:24:58 +00:00
|
|
|
if (r) {
|
|
|
|
dc_release_state(state->context);
|
|
|
|
kfree(state);
|
2019-07-11 19:31:46 +00:00
|
|
|
return r;
|
2020-08-26 13:24:58 +00:00
|
|
|
}
|
2019-07-11 19:31:46 +00:00
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-11-26 16:44:06 +00:00
|
|
|
#define AMDGPU_DM_DEFAULT_MIN_BACKLIGHT 12
|
|
|
|
#define AMDGPU_DM_DEFAULT_MAX_BACKLIGHT 255
|
2020-01-24 15:44:20 +00:00
|
|
|
#define AUX_BL_DEFAULT_TRANSITION_TIME_MS 50
|
2018-11-26 16:44:06 +00:00
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
#if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) ||\
|
|
|
|
defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE)
|
|
|
|
|
2018-11-26 16:44:06 +00:00
|
|
|
static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm)
|
|
|
|
{
|
|
|
|
#if defined(CONFIG_ACPI)
|
|
|
|
struct amdgpu_dm_backlight_caps caps;
|
|
|
|
|
2020-08-20 07:52:41 +00:00
|
|
|
memset(&caps, 0, sizeof(caps));
|
|
|
|
|
2018-11-26 16:44:06 +00:00
|
|
|
if (dm->backlight_caps.caps_valid)
|
|
|
|
return;
|
|
|
|
|
|
|
|
amdgpu_acpi_get_backlight_caps(dm->adev, &caps);
|
|
|
|
if (caps.caps_valid) {
|
2020-01-24 15:44:20 +00:00
|
|
|
dm->backlight_caps.caps_valid = true;
|
|
|
|
if (caps.aux_support)
|
|
|
|
return;
|
2018-11-26 16:44:06 +00:00
|
|
|
dm->backlight_caps.min_input_signal = caps.min_input_signal;
|
|
|
|
dm->backlight_caps.max_input_signal = caps.max_input_signal;
|
|
|
|
} else {
|
|
|
|
dm->backlight_caps.min_input_signal =
|
|
|
|
AMDGPU_DM_DEFAULT_MIN_BACKLIGHT;
|
|
|
|
dm->backlight_caps.max_input_signal =
|
|
|
|
AMDGPU_DM_DEFAULT_MAX_BACKLIGHT;
|
|
|
|
}
|
|
|
|
#else
|
2020-01-24 15:44:20 +00:00
|
|
|
if (dm->backlight_caps.aux_support)
|
|
|
|
return;
|
|
|
|
|
2018-11-27 16:10:07 +00:00
|
|
|
dm->backlight_caps.min_input_signal = AMDGPU_DM_DEFAULT_MIN_BACKLIGHT;
|
|
|
|
dm->backlight_caps.max_input_signal = AMDGPU_DM_DEFAULT_MAX_BACKLIGHT;
|
2018-11-26 16:44:06 +00:00
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
2020-01-24 15:44:20 +00:00
|
|
|
static int set_backlight_via_aux(struct dc_link *link, uint32_t brightness)
|
|
|
|
{
|
|
|
|
bool rc;
|
|
|
|
|
|
|
|
if (!link)
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
rc = dc_link_set_backlight_level_nits(link, true, brightness,
|
|
|
|
AUX_BL_DEFAULT_TRANSITION_TIME_MS);
|
|
|
|
|
|
|
|
return rc ? 0 : 1;
|
|
|
|
}
|
|
|
|
|
2020-08-04 20:13:13 +00:00
|
|
|
static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps,
|
|
|
|
unsigned *min, unsigned *max)
|
2020-01-24 15:44:20 +00:00
|
|
|
{
|
|
|
|
if (!caps)
|
2020-08-04 20:13:13 +00:00
|
|
|
return 0;
|
2020-01-24 15:44:20 +00:00
|
|
|
|
2020-08-04 20:13:13 +00:00
|
|
|
if (caps->aux_support) {
|
|
|
|
// Firmware limits are in nits, DC API wants millinits.
|
|
|
|
*max = 1000 * caps->aux_max_input_signal;
|
|
|
|
*min = 1000 * caps->aux_min_input_signal;
|
2020-01-24 15:44:20 +00:00
|
|
|
} else {
|
2020-08-04 20:13:13 +00:00
|
|
|
// Firmware limits are 8-bit, PWM control is 16-bit.
|
|
|
|
*max = 0x101 * caps->max_input_signal;
|
|
|
|
*min = 0x101 * caps->min_input_signal;
|
2020-01-24 15:44:20 +00:00
|
|
|
}
|
2020-08-04 20:13:13 +00:00
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
static u32 convert_brightness_from_user(const struct amdgpu_dm_backlight_caps *caps,
|
|
|
|
uint32_t brightness)
|
|
|
|
{
|
|
|
|
unsigned min, max;
|
2020-01-24 15:44:20 +00:00
|
|
|
|
2020-08-04 20:13:13 +00:00
|
|
|
if (!get_brightness_range(caps, &min, &max))
|
|
|
|
return brightness;
|
|
|
|
|
|
|
|
// Rescale 0..255 to min..max
|
|
|
|
return min + DIV_ROUND_CLOSEST((max - min) * brightness,
|
|
|
|
AMDGPU_MAX_BL_LEVEL);
|
|
|
|
}
|
|
|
|
|
|
|
|
static u32 convert_brightness_to_user(const struct amdgpu_dm_backlight_caps *caps,
|
|
|
|
uint32_t brightness)
|
|
|
|
{
|
|
|
|
unsigned min, max;
|
|
|
|
|
|
|
|
if (!get_brightness_range(caps, &min, &max))
|
|
|
|
return brightness;
|
|
|
|
|
|
|
|
if (brightness < min)
|
|
|
|
return 0;
|
|
|
|
// Rescale min..max to 0..255
|
|
|
|
return DIV_ROUND_CLOSEST(AMDGPU_MAX_BL_LEVEL * (brightness - min),
|
|
|
|
max - min);
|
2020-01-24 15:44:20 +00:00
|
|
|
}
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
static int amdgpu_dm_backlight_update_status(struct backlight_device *bd)
|
|
|
|
{
|
|
|
|
struct amdgpu_display_manager *dm = bl_get_data(bd);
|
2018-11-26 16:44:06 +00:00
|
|
|
struct amdgpu_dm_backlight_caps caps;
|
2020-01-24 15:44:20 +00:00
|
|
|
struct dc_link *link = NULL;
|
|
|
|
u32 brightness;
|
|
|
|
bool rc;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2018-11-26 16:44:06 +00:00
|
|
|
amdgpu_dm_update_backlight_caps(dm);
|
|
|
|
caps = dm->backlight_caps;
|
2020-01-24 15:44:20 +00:00
|
|
|
|
|
|
|
link = (struct dc_link *)dm->backlight_link;
|
|
|
|
|
2020-08-04 20:13:13 +00:00
|
|
|
brightness = convert_brightness_from_user(&caps, bd->props.brightness);
|
2020-01-24 15:44:20 +00:00
|
|
|
// Change brightness based on AUX property
|
|
|
|
if (caps.aux_support)
|
|
|
|
return set_backlight_via_aux(link, brightness);
|
|
|
|
|
|
|
|
rc = dc_link_set_backlight_level(dm->backlight_link, brightness, 0);
|
|
|
|
|
|
|
|
return rc ? 0 : 1;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int amdgpu_dm_backlight_get_brightness(struct backlight_device *bd)
|
|
|
|
{
|
2018-07-19 15:25:05 +00:00
|
|
|
struct amdgpu_display_manager *dm = bl_get_data(bd);
|
|
|
|
int ret = dc_link_get_backlight_level(dm->backlight_link);
|
|
|
|
|
|
|
|
if (ret == DC_ERROR_UNEXPECTED)
|
|
|
|
return bd->props.brightness;
|
2020-08-04 20:13:13 +00:00
|
|
|
return convert_brightness_to_user(&dm->backlight_caps, ret);
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static const struct backlight_ops amdgpu_dm_backlight_ops = {
|
2019-09-02 08:33:42 +00:00
|
|
|
.options = BL_CORE_SUSPENDRESUME,
|
2017-09-12 19:58:20 +00:00
|
|
|
.get_brightness = amdgpu_dm_backlight_get_brightness,
|
|
|
|
.update_status = amdgpu_dm_backlight_update_status,
|
|
|
|
};
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static void
|
|
|
|
amdgpu_dm_register_backlight_device(struct amdgpu_display_manager *dm)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
|
|
|
char bl_name[16];
|
|
|
|
struct backlight_properties props = { 0 };
|
|
|
|
|
2018-11-26 16:44:06 +00:00
|
|
|
amdgpu_dm_update_backlight_caps(dm);
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
props.max_brightness = AMDGPU_MAX_BL_LEVEL;
|
2018-07-18 20:03:30 +00:00
|
|
|
props.brightness = AMDGPU_MAX_BL_LEVEL;
|
2017-09-12 19:58:20 +00:00
|
|
|
props.type = BACKLIGHT_RAW;
|
|
|
|
|
|
|
|
snprintf(bl_name, sizeof(bl_name), "amdgpu_bl%d",
|
|
|
|
dm->adev->ddev->primary->index);
|
|
|
|
|
|
|
|
dm->backlight_dev = backlight_device_register(bl_name,
|
|
|
|
dm->adev->ddev->dev,
|
|
|
|
dm,
|
|
|
|
&amdgpu_dm_backlight_ops,
|
|
|
|
&props);
|
|
|
|
|
2017-11-06 11:43:41 +00:00
|
|
|
if (IS_ERR(dm->backlight_dev))
|
2017-09-12 19:58:20 +00:00
|
|
|
DRM_ERROR("DM: Backlight registration failed!\n");
|
|
|
|
else
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n", bl_name);
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
2018-02-27 09:18:13 +00:00
|
|
|
static int initialize_plane(struct amdgpu_display_manager *dm,
|
2019-01-18 18:42:34 +00:00
|
|
|
struct amdgpu_mode_info *mode_info, int plane_id,
|
2019-03-14 19:58:51 +00:00
|
|
|
enum drm_plane_type plane_type,
|
|
|
|
const struct dc_plane_cap *plane_cap)
|
2018-02-27 09:18:13 +00:00
|
|
|
{
|
2018-10-05 15:58:34 +00:00
|
|
|
struct drm_plane *plane;
|
2018-02-27 09:18:13 +00:00
|
|
|
unsigned long possible_crtcs;
|
|
|
|
int ret = 0;
|
|
|
|
|
2018-10-05 15:58:34 +00:00
|
|
|
plane = kzalloc(sizeof(struct drm_plane), GFP_KERNEL);
|
2018-02-27 09:18:13 +00:00
|
|
|
if (!plane) {
|
|
|
|
DRM_ERROR("KMS: Failed to allocate plane\n");
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
2019-01-18 18:42:34 +00:00
|
|
|
plane->type = plane_type;
|
2018-02-27 09:18:13 +00:00
|
|
|
|
|
|
|
/*
|
2019-01-18 18:42:34 +00:00
|
|
|
* HACK: IGT tests expect that the primary plane for a CRTC
|
|
|
|
* can only have one possible CRTC. Only expose support for
|
|
|
|
* any CRTC if they're not going to be used as a primary plane
|
|
|
|
* for a CRTC - like overlay or underlay planes.
|
2018-02-27 09:18:13 +00:00
|
|
|
*/
|
|
|
|
possible_crtcs = 1 << plane_id;
|
|
|
|
if (plane_id >= dm->dc->caps.max_streams)
|
|
|
|
possible_crtcs = 0xff;
|
|
|
|
|
2019-03-14 19:58:51 +00:00
|
|
|
ret = amdgpu_dm_plane_init(dm, plane, possible_crtcs, plane_cap);
|
2018-02-27 09:18:13 +00:00
|
|
|
|
|
|
|
if (ret) {
|
|
|
|
DRM_ERROR("KMS: Failed to initialize plane\n");
|
2019-03-14 16:53:12 +00:00
|
|
|
kfree(plane);
|
2018-02-27 09:18:13 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2019-03-14 16:53:12 +00:00
|
|
|
if (mode_info)
|
|
|
|
mode_info->planes[plane_id] = plane;
|
|
|
|
|
2018-02-27 09:18:13 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2018-03-12 15:16:47 +00:00
|
|
|
|
|
|
|
static void register_backlight_device(struct amdgpu_display_manager *dm,
|
|
|
|
struct dc_link *link)
|
|
|
|
{
|
|
|
|
#if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) ||\
|
|
|
|
defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE)
|
|
|
|
|
|
|
|
if ((link->connector_signal & (SIGNAL_TYPE_EDP | SIGNAL_TYPE_LVDS)) &&
|
|
|
|
link->type != dc_connection_none) {
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Event if registration failed, we should continue with
|
2018-03-12 15:16:47 +00:00
|
|
|
* DM initialization because not having a backlight control
|
|
|
|
* is better then a black screen.
|
|
|
|
*/
|
|
|
|
amdgpu_dm_register_backlight_device(dm);
|
|
|
|
|
|
|
|
if (dm->backlight_dev)
|
|
|
|
dm->backlight_link = link;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* In this architecture, the association
|
2017-09-12 19:58:20 +00:00
|
|
|
* connector -> encoder -> crtc
|
|
|
|
* id not really requried. The crtc and connector will hold the
|
|
|
|
* display_index as an abstraction to use with DAL component
|
|
|
|
*
|
|
|
|
* Returns 0 on success
|
|
|
|
*/
|
2017-10-10 21:51:02 +00:00
|
|
|
static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_display_manager *dm = &adev->dm;
|
2018-02-27 09:18:13 +00:00
|
|
|
int32_t i;
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector = NULL;
|
2017-04-03 17:36:26 +00:00
|
|
|
struct amdgpu_encoder *aencoder = NULL;
|
2017-06-15 20:24:01 +00:00
|
|
|
struct amdgpu_mode_info *mode_info = &adev->mode_info;
|
2017-09-12 19:58:20 +00:00
|
|
|
uint32_t link_cnt;
|
2019-03-14 19:58:51 +00:00
|
|
|
int32_t primary_planes;
|
2018-09-26 17:42:10 +00:00
|
|
|
enum dc_connection_type new_connection_type = dc_connection_none;
|
2019-03-14 19:58:51 +00:00
|
|
|
const struct dc_plane_cap *plane;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
link_cnt = dm->dc->caps.max_links;
|
|
|
|
if (amdgpu_dm_mode_config_init(dm->adev)) {
|
|
|
|
DRM_ERROR("DM: Failed to initialize mode config\n");
|
2018-09-13 16:01:28 +00:00
|
|
|
return -EINVAL;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
2019-01-18 18:42:34 +00:00
|
|
|
/* There is one primary plane per CRTC */
|
|
|
|
primary_planes = dm->dc->caps.max_streams;
|
2019-03-14 16:53:12 +00:00
|
|
|
ASSERT(primary_planes <= AMDGPU_MAX_PLANES);
|
2017-10-20 12:42:41 +00:00
|
|
|
|
2019-01-18 18:42:34 +00:00
|
|
|
/*
|
|
|
|
* Initialize primary planes, implicit planes for legacy IOCTLS.
|
|
|
|
* Order is reversed to match iteration order in atomic check.
|
|
|
|
*/
|
|
|
|
for (i = (primary_planes - 1); i >= 0; i--) {
|
2019-03-14 19:58:51 +00:00
|
|
|
plane = &dm->dc->caps.planes[i];
|
|
|
|
|
2019-01-18 18:42:34 +00:00
|
|
|
if (initialize_plane(dm, mode_info, i,
|
2019-03-14 19:58:51 +00:00
|
|
|
DRM_PLANE_TYPE_PRIMARY, plane)) {
|
2018-02-27 09:18:13 +00:00
|
|
|
DRM_ERROR("KMS: Failed to initialize primary plane\n");
|
2017-10-20 12:28:59 +00:00
|
|
|
goto fail;
|
2017-06-15 20:24:01 +00:00
|
|
|
}
|
2018-02-27 09:18:13 +00:00
|
|
|
}
|
2017-06-16 19:59:17 +00:00
|
|
|
|
2019-01-18 18:57:14 +00:00
|
|
|
/*
|
|
|
|
* Initialize overlay planes, index starting after primary planes.
|
|
|
|
* These planes have a higher DRM index than the primary planes since
|
|
|
|
* they should be considered as having a higher z-order.
|
|
|
|
* Order is reversed to match iteration order in atomic check.
|
2019-03-14 19:58:51 +00:00
|
|
|
*
|
|
|
|
* Only support DCN for now, and only expose one so we don't encourage
|
|
|
|
* userspace to use up all the pipes.
|
2019-01-18 18:57:14 +00:00
|
|
|
*/
|
2019-03-14 19:58:51 +00:00
|
|
|
for (i = 0; i < dm->dc->caps.max_planes; ++i) {
|
|
|
|
struct dc_plane_cap *plane = &dm->dc->caps.planes[i];
|
|
|
|
|
|
|
|
if (plane->type != DC_PLANE_TYPE_DCN_UNIVERSAL)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!plane->blends_with_above || !plane->blends_with_below)
|
|
|
|
continue;
|
|
|
|
|
2019-03-26 21:32:59 +00:00
|
|
|
if (!plane->pixel_format_support.argb8888)
|
2019-03-14 19:58:51 +00:00
|
|
|
continue;
|
|
|
|
|
2019-03-14 16:53:12 +00:00
|
|
|
if (initialize_plane(dm, NULL, primary_planes + i,
|
2019-03-14 19:58:51 +00:00
|
|
|
DRM_PLANE_TYPE_OVERLAY, plane)) {
|
2019-01-18 18:57:14 +00:00
|
|
|
DRM_ERROR("KMS: Failed to initialize overlay plane\n");
|
2017-10-20 12:28:59 +00:00
|
|
|
goto fail;
|
2017-06-15 20:24:01 +00:00
|
|
|
}
|
2019-03-14 19:58:51 +00:00
|
|
|
|
|
|
|
/* Only create one overlay plane. */
|
|
|
|
break;
|
2017-06-15 20:24:01 +00:00
|
|
|
}
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2017-06-15 20:24:01 +00:00
|
|
|
for (i = 0; i < dm->dc->caps.max_streams; i++)
|
2018-10-05 15:58:34 +00:00
|
|
|
if (amdgpu_dm_crtc_init(dm, mode_info->planes[i], i)) {
|
2017-09-12 19:58:20 +00:00
|
|
|
DRM_ERROR("KMS: Failed to initialize crtc\n");
|
2017-10-20 12:28:59 +00:00
|
|
|
goto fail;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
2016-12-29 20:27:12 +00:00
|
|
|
dm->display_indexes_num = dm->dc->caps.max_streams;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
/* loops over all connectors on the board */
|
|
|
|
for (i = 0; i < link_cnt; i++) {
|
2018-03-12 15:16:47 +00:00
|
|
|
struct dc_link *link = NULL;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
if (i > AMDGPU_DM_MAX_DISPLAY_INDEX) {
|
|
|
|
DRM_ERROR(
|
|
|
|
"KMS: Cannot support more than %d display indexes\n",
|
|
|
|
AMDGPU_DM_MAX_DISPLAY_INDEX);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
aconnector = kzalloc(sizeof(*aconnector), GFP_KERNEL);
|
|
|
|
if (!aconnector)
|
2017-10-20 12:28:59 +00:00
|
|
|
goto fail;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
aencoder = kzalloc(sizeof(*aencoder), GFP_KERNEL);
|
2017-10-17 13:09:42 +00:00
|
|
|
if (!aencoder)
|
2017-10-20 12:28:59 +00:00
|
|
|
goto fail;
|
2017-09-12 19:58:20 +00:00
|
|
|
|
|
|
|
if (amdgpu_dm_encoder_init(dm->ddev, aencoder, i)) {
|
|
|
|
DRM_ERROR("KMS: Failed to initialize encoder\n");
|
2017-10-20 12:28:59 +00:00
|
|
|
goto fail;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (amdgpu_dm_connector_init(dm, aconnector, i, aencoder)) {
|
|
|
|
DRM_ERROR("KMS: Failed to initialize connector\n");
|
2017-10-20 12:28:59 +00:00
|
|
|
goto fail;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
2018-03-12 15:16:47 +00:00
|
|
|
link = dc_get_link_at_index(dm->dc, i);
|
|
|
|
|
2018-09-26 17:42:10 +00:00
|
|
|
if (!dc_link_detect_sink(link, &new_connection_type))
|
|
|
|
DRM_ERROR("KMS: Failed to detect connector\n");
|
|
|
|
|
|
|
|
if (aconnector->base.force && new_connection_type == dc_connection_none) {
|
|
|
|
emulated_link_detect(link);
|
|
|
|
amdgpu_dm_update_connector_after_detect(aconnector);
|
|
|
|
|
|
|
|
} else if (dc_link_detect(link, DETECT_REASON_BOOT)) {
|
2017-09-12 19:58:20 +00:00
|
|
|
amdgpu_dm_update_connector_after_detect(aconnector);
|
2018-03-12 15:16:47 +00:00
|
|
|
register_backlight_device(dm, link);
|
2019-10-01 13:45:38 +00:00
|
|
|
if (amdgpu_dc_feature_mask & DC_PSR_MASK)
|
|
|
|
amdgpu_dm_set_psr_caps(link);
|
2018-03-12 15:16:47 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Software is initialized. Now we can register interrupt handlers. */
|
|
|
|
switch (adev->asic_type) {
|
|
|
|
case CHIP_BONAIRE:
|
|
|
|
case CHIP_HAWAII:
|
2017-08-10 18:39:47 +00:00
|
|
|
case CHIP_KAVERI:
|
|
|
|
case CHIP_KABINI:
|
|
|
|
case CHIP_MULLINS:
|
2017-09-12 19:58:20 +00:00
|
|
|
case CHIP_TONGA:
|
|
|
|
case CHIP_FIJI:
|
|
|
|
case CHIP_CARRIZO:
|
|
|
|
case CHIP_STONEY:
|
|
|
|
case CHIP_POLARIS11:
|
|
|
|
case CHIP_POLARIS10:
|
2016-12-14 20:35:13 +00:00
|
|
|
case CHIP_POLARIS12:
|
2017-11-09 16:51:13 +00:00
|
|
|
case CHIP_VEGAM:
|
2017-06-15 20:20:24 +00:00
|
|
|
case CHIP_VEGA10:
|
2017-09-02 06:01:55 +00:00
|
|
|
case CHIP_VEGA12:
|
2018-04-20 11:50:01 +00:00
|
|
|
case CHIP_VEGA20:
|
2017-09-12 19:58:20 +00:00
|
|
|
if (dce110_register_irq_handlers(dm->adev)) {
|
|
|
|
DRM_ERROR("DM: Failed to initialize IRQ\n");
|
2017-10-20 12:28:59 +00:00
|
|
|
goto fail;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
break;
|
2019-11-06 19:48:35 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN)
|
2017-06-15 20:27:42 +00:00
|
|
|
case CHIP_RAVEN:
|
2019-07-16 21:26:14 +00:00
|
|
|
case CHIP_NAVI12:
|
2019-02-22 21:52:52 +00:00
|
|
|
case CHIP_NAVI10:
|
2019-07-02 15:41:40 +00:00
|
|
|
case CHIP_NAVI14:
|
2019-07-26 21:08:45 +00:00
|
|
|
case CHIP_RENOIR:
|
2020-05-21 16:48:41 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN3_0)
|
|
|
|
case CHIP_SIENNA_CICHLID:
|
2020-07-08 21:11:12 +00:00
|
|
|
case CHIP_NAVY_FLOUNDER:
|
2020-05-21 16:48:41 +00:00
|
|
|
#endif
|
2017-06-15 20:27:42 +00:00
|
|
|
if (dcn10_register_irq_handlers(dm->adev)) {
|
|
|
|
DRM_ERROR("DM: Failed to initialize IRQ\n");
|
2017-10-20 12:28:59 +00:00
|
|
|
goto fail;
|
2017-06-15 20:27:42 +00:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
#endif
|
2017-09-12 19:58:20 +00:00
|
|
|
default:
|
2018-03-30 16:00:47 +00:00
|
|
|
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);
|
2017-10-20 12:28:59 +00:00
|
|
|
goto fail;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
2020-03-02 15:37:43 +00:00
|
|
|
/* No userspace support. */
|
|
|
|
dm->dc->debug.disable_tri_buf = true;
|
|
|
|
|
2017-09-12 19:58:20 +00:00
|
|
|
return 0;
|
2017-10-20 12:28:59 +00:00
|
|
|
fail:
|
2017-09-12 19:58:20 +00:00
|
|
|
kfree(aencoder);
|
|
|
|
kfree(aconnector);
|
2019-03-14 16:53:12 +00:00
|
|
|
|
2018-09-13 16:01:28 +00:00
|
|
|
return -EINVAL;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static void amdgpu_dm_destroy_drm_device(struct amdgpu_display_manager *dm)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
|
|
|
drm_mode_config_cleanup(dm->ddev);
|
2018-11-22 17:34:36 +00:00
|
|
|
drm_atomic_private_obj_fini(&dm->atomic_obj);
|
2017-09-12 19:58:20 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/******************************************************************************
|
|
|
|
* amdgpu_display_funcs functions
|
|
|
|
*****************************************************************************/
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
2017-09-12 19:58:20 +00:00
|
|
|
* dm_bandwidth_update - program display watermarks
|
|
|
|
*
|
|
|
|
* @adev: amdgpu_device pointer
|
|
|
|
*
|
|
|
|
* Calculate and program the display watermarks and line buffer allocation.
|
|
|
|
*/
|
|
|
|
static void dm_bandwidth_update(struct amdgpu_device *adev)
|
|
|
|
{
|
2016-12-05 13:51:26 +00:00
|
|
|
/* TODO: implement later */
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
|
|
|
|
2016-12-13 20:42:48 +00:00
|
|
|
static const struct amdgpu_display_funcs dm_display_funcs = {
|
2017-09-12 19:58:20 +00:00
|
|
|
.bandwidth_update = dm_bandwidth_update, /* called unconditionally */
|
|
|
|
.vblank_get_counter = dm_vblank_get_counter,/* called unconditionally */
|
2018-07-19 18:17:30 +00:00
|
|
|
.backlight_set_level = NULL, /* never called for DC */
|
|
|
|
.backlight_get_level = NULL, /* never called for DC */
|
2017-09-12 19:58:20 +00:00
|
|
|
.hpd_sense = NULL,/* called unconditionally */
|
|
|
|
.hpd_set_polarity = NULL, /* called unconditionally */
|
|
|
|
.hpd_get_gpio_reg = NULL, /* VBIOS parsing. DAL does it. */
|
|
|
|
.page_flip_get_scanoutpos =
|
|
|
|
dm_crtc_get_scanoutpos,/* called unconditionally */
|
|
|
|
.add_encoder = NULL, /* VBIOS parsing. DAL does it. */
|
|
|
|
.add_connector = NULL, /* VBIOS parsing. DAL does it. */
|
|
|
|
};
|
|
|
|
|
|
|
|
#if defined(CONFIG_DEBUG_KERNEL_DC)
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static ssize_t s3_debug_store(struct device *device,
|
|
|
|
struct device_attribute *attr,
|
|
|
|
const char *buf,
|
|
|
|
size_t count)
|
2017-09-12 19:58:20 +00:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
int s3_state;
|
2019-07-23 09:04:22 +00:00
|
|
|
struct drm_device *drm_dev = dev_get_drvdata(device);
|
2017-09-12 19:58:20 +00:00
|
|
|
struct amdgpu_device *adev = drm_dev->dev_private;
|
|
|
|
|
|
|
|
ret = kstrtoint(buf, 0, &s3_state);
|
|
|
|
|
|
|
|
if (ret == 0) {
|
|
|
|
if (s3_state) {
|
|
|
|
dm_resume(adev);
|
|
|
|
drm_kms_helper_hotplug_event(adev->ddev);
|
|
|
|
} else
|
|
|
|
dm_suspend(adev);
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret == 0 ? count : 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
DEVICE_ATTR_WO(s3_debug);
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
static int dm_early_init(void *handle)
|
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
|
|
|
|
|
|
|
|
switch (adev->asic_type) {
|
|
|
|
case CHIP_BONAIRE:
|
|
|
|
case CHIP_HAWAII:
|
|
|
|
adev->mode_info.num_crtc = 6;
|
|
|
|
adev->mode_info.num_hpd = 6;
|
|
|
|
adev->mode_info.num_dig = 6;
|
|
|
|
break;
|
2017-08-10 18:39:47 +00:00
|
|
|
case CHIP_KAVERI:
|
|
|
|
adev->mode_info.num_crtc = 4;
|
|
|
|
adev->mode_info.num_hpd = 6;
|
|
|
|
adev->mode_info.num_dig = 7;
|
|
|
|
break;
|
|
|
|
case CHIP_KABINI:
|
|
|
|
case CHIP_MULLINS:
|
|
|
|
adev->mode_info.num_crtc = 2;
|
|
|
|
adev->mode_info.num_hpd = 6;
|
|
|
|
adev->mode_info.num_dig = 6;
|
|
|
|
break;
|
2017-09-12 19:58:20 +00:00
|
|
|
case CHIP_FIJI:
|
|
|
|
case CHIP_TONGA:
|
|
|
|
adev->mode_info.num_crtc = 6;
|
|
|
|
adev->mode_info.num_hpd = 6;
|
|
|
|
adev->mode_info.num_dig = 7;
|
|
|
|
break;
|
|
|
|
case CHIP_CARRIZO:
|
|
|
|
adev->mode_info.num_crtc = 3;
|
|
|
|
adev->mode_info.num_hpd = 6;
|
|
|
|
adev->mode_info.num_dig = 9;
|
|
|
|
break;
|
|
|
|
case CHIP_STONEY:
|
|
|
|
adev->mode_info.num_crtc = 2;
|
|
|
|
adev->mode_info.num_hpd = 6;
|
|
|
|
adev->mode_info.num_dig = 9;
|
|
|
|
break;
|
|
|
|
case CHIP_POLARIS11:
|
2016-12-14 20:35:13 +00:00
|
|
|
case CHIP_POLARIS12:
|
2017-09-12 19:58:20 +00:00
|
|
|
adev->mode_info.num_crtc = 5;
|
|
|
|
adev->mode_info.num_hpd = 5;
|
|
|
|
adev->mode_info.num_dig = 5;
|
|
|
|
break;
|
|
|
|
case CHIP_POLARIS10:
|
2017-11-09 16:51:13 +00:00
|
|
|
case CHIP_VEGAM:
|
2017-09-12 19:58:20 +00:00
|
|
|
adev->mode_info.num_crtc = 6;
|
|
|
|
adev->mode_info.num_hpd = 6;
|
|
|
|
adev->mode_info.num_dig = 6;
|
|
|
|
break;
|
2017-06-15 20:20:24 +00:00
|
|
|
case CHIP_VEGA10:
|
2017-09-02 06:01:55 +00:00
|
|
|
case CHIP_VEGA12:
|
2018-04-20 11:50:01 +00:00
|
|
|
case CHIP_VEGA20:
|
2017-06-15 20:20:24 +00:00
|
|
|
adev->mode_info.num_crtc = 6;
|
|
|
|
adev->mode_info.num_hpd = 6;
|
|
|
|
adev->mode_info.num_dig = 6;
|
|
|
|
break;
|
2019-11-06 19:48:35 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN)
|
2017-06-15 20:27:42 +00:00
|
|
|
case CHIP_RAVEN:
|
|
|
|
adev->mode_info.num_crtc = 4;
|
|
|
|
adev->mode_info.num_hpd = 4;
|
|
|
|
adev->mode_info.num_dig = 4;
|
|
|
|
break;
|
2019-02-22 21:52:52 +00:00
|
|
|
#endif
|
|
|
|
case CHIP_NAVI10:
|
2019-07-16 21:26:14 +00:00
|
|
|
case CHIP_NAVI12:
|
2020-05-21 16:48:41 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN3_0)
|
|
|
|
case CHIP_SIENNA_CICHLID:
|
2020-07-08 21:11:12 +00:00
|
|
|
case CHIP_NAVY_FLOUNDER:
|
2020-05-21 16:48:41 +00:00
|
|
|
#endif
|
2019-02-22 21:52:52 +00:00
|
|
|
adev->mode_info.num_crtc = 6;
|
|
|
|
adev->mode_info.num_hpd = 6;
|
|
|
|
adev->mode_info.num_dig = 6;
|
|
|
|
break;
|
2019-07-02 15:41:40 +00:00
|
|
|
case CHIP_NAVI14:
|
|
|
|
adev->mode_info.num_crtc = 5;
|
|
|
|
adev->mode_info.num_hpd = 5;
|
|
|
|
adev->mode_info.num_dig = 5;
|
|
|
|
break;
|
2019-07-26 21:08:45 +00:00
|
|
|
case CHIP_RENOIR:
|
|
|
|
adev->mode_info.num_crtc = 4;
|
|
|
|
adev->mode_info.num_hpd = 4;
|
|
|
|
adev->mode_info.num_dig = 4;
|
|
|
|
break;
|
2017-09-12 19:58:20 +00:00
|
|
|
default:
|
2018-03-30 16:00:47 +00:00
|
|
|
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);
|
2017-09-12 19:58:20 +00:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2017-10-24 09:13:34 +00:00
|
|
|
amdgpu_dm_set_irq_funcs(adev);
|
|
|
|
|
2016-12-13 20:42:48 +00:00
|
|
|
if (adev->mode_info.funcs == NULL)
|
|
|
|
adev->mode_info.funcs = &dm_display_funcs;
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Note: Do NOT change adev->audio_endpt_rreg and
|
2017-09-12 19:58:20 +00:00
|
|
|
* adev->audio_endpt_wreg because they are initialised in
|
2018-08-15 18:38:30 +00:00
|
|
|
* amdgpu_device_init()
|
|
|
|
*/
|
2017-09-12 19:58:20 +00:00
|
|
|
#if defined(CONFIG_DEBUG_KERNEL_DC)
|
|
|
|
device_create_file(
|
|
|
|
adev->ddev->dev,
|
|
|
|
&dev_attr_s3_debug);
|
|
|
|
#endif
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-07-28 17:11:00 +00:00
|
|
|
static bool modeset_required(struct drm_crtc_state *crtc_state,
|
2017-07-27 13:33:33 +00:00
|
|
|
struct dc_stream_state *new_stream,
|
|
|
|
struct dc_stream_state *old_stream)
|
2017-07-28 17:11:00 +00:00
|
|
|
{
|
2017-08-10 17:29:07 +00:00
|
|
|
if (!drm_atomic_crtc_needs_modeset(crtc_state))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (!crtc_state->enable)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return crtc_state->active;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool modereset_required(struct drm_crtc_state *crtc_state)
|
|
|
|
{
|
|
|
|
if (!drm_atomic_crtc_needs_modeset(crtc_state))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return !crtc_state->enable || !crtc_state->active;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static void amdgpu_dm_encoder_destroy(struct drm_encoder *encoder)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
drm_encoder_cleanup(encoder);
|
|
|
|
kfree(encoder);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct drm_encoder_funcs amdgpu_dm_encoder_funcs = {
|
|
|
|
.destroy = amdgpu_dm_encoder_destroy,
|
|
|
|
};
|
|
|
|
|
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
static int fill_dc_scaling_info(const struct drm_plane_state *state,
|
|
|
|
struct dc_scaling_info *scaling_info)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2019-04-01 13:43:34 +00:00
|
|
|
int scale_w, scale_h;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
memset(scaling_info, 0, sizeof(*scaling_info));
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
/* Source is fixed 16.16 but we ignore mantissa for now... */
|
|
|
|
scaling_info->src_rect.x = state->src_x >> 16;
|
|
|
|
scaling_info->src_rect.y = state->src_y >> 16;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
scaling_info->src_rect.width = state->src_w >> 16;
|
|
|
|
if (scaling_info->src_rect.width == 0)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
scaling_info->src_rect.height = state->src_h >> 16;
|
|
|
|
if (scaling_info->src_rect.height == 0)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
scaling_info->dst_rect.x = state->crtc_x;
|
|
|
|
scaling_info->dst_rect.y = state->crtc_y;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
if (state->crtc_w == 0)
|
2019-03-28 18:45:19 +00:00
|
|
|
return -EINVAL;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
scaling_info->dst_rect.width = state->crtc_w;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
if (state->crtc_h == 0)
|
2019-03-28 18:45:19 +00:00
|
|
|
return -EINVAL;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
scaling_info->dst_rect.height = state->crtc_h;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
/* DRM doesn't specify clipping on destination output. */
|
|
|
|
scaling_info->clip_rect = scaling_info->dst_rect;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-04-01 13:43:34 +00:00
|
|
|
/* TODO: Validate scaling per-format with DC plane caps */
|
|
|
|
scale_w = scaling_info->dst_rect.width * 1000 /
|
|
|
|
scaling_info->src_rect.width;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-04-01 13:43:34 +00:00
|
|
|
if (scale_w < 250 || scale_w > 16000)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
scale_h = scaling_info->dst_rect.height * 1000 /
|
|
|
|
scaling_info->src_rect.height;
|
|
|
|
|
|
|
|
if (scale_h < 250 || scale_h > 16000)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
/*
|
|
|
|
* The "scaling_quality" can be ignored for now, quality = 0 has DC
|
|
|
|
* assume reasonable defaults based on the format.
|
|
|
|
*/
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
return 0;
|
2017-09-12 19:58:20 +00:00
|
|
|
}
|
2019-03-28 18:45:19 +00:00
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static int get_fb_info(const struct amdgpu_framebuffer *amdgpu_fb,
|
2020-04-22 21:54:55 +00:00
|
|
|
uint64_t *tiling_flags, bool *tmz_surface)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2018-03-30 14:11:38 +00:00
|
|
|
struct amdgpu_bo *rbo = gem_to_amdgpu_bo(amdgpu_fb->base.obj[0]);
|
2017-08-10 17:29:07 +00:00
|
|
|
int r = amdgpu_bo_reserve(rbo, false);
|
2017-07-27 01:03:22 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
if (unlikely(r)) {
|
2018-08-15 18:38:30 +00:00
|
|
|
/* Don't show error message when returning -ERESTARTSYS */
|
2017-10-06 19:08:07 +00:00
|
|
|
if (r != -ERESTARTSYS)
|
|
|
|
DRM_ERROR("Unable to reserve buffer: %d\n", r);
|
2017-08-10 17:29:07 +00:00
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (tiling_flags)
|
|
|
|
amdgpu_bo_get_tiling_flags(rbo, tiling_flags);
|
|
|
|
|
2020-04-22 21:54:55 +00:00
|
|
|
if (tmz_surface)
|
|
|
|
*tmz_surface = amdgpu_bo_encrypted(rbo);
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
amdgpu_bo_unreserve(rbo);
|
|
|
|
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
2019-01-02 20:15:41 +00:00
|
|
|
static inline uint64_t get_dcc_address(uint64_t address, uint64_t tiling_flags)
|
|
|
|
{
|
|
|
|
uint32_t offset = AMDGPU_TILING_GET(tiling_flags, DCC_OFFSET_256B);
|
|
|
|
|
|
|
|
return offset ? (address + offset * 256) : 0;
|
|
|
|
}
|
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
static int
|
|
|
|
fill_plane_dcc_attributes(struct amdgpu_device *adev,
|
|
|
|
const struct amdgpu_framebuffer *afb,
|
|
|
|
const enum surface_pixel_format format,
|
|
|
|
const enum dc_rotation_angle rotation,
|
2019-07-03 20:20:42 +00:00
|
|
|
const struct plane_size *plane_size,
|
2019-03-28 18:45:19 +00:00
|
|
|
const union dc_tiling_info *tiling_info,
|
|
|
|
const uint64_t info,
|
|
|
|
struct dc_plane_dcc_param *dcc,
|
2020-04-22 21:43:26 +00:00
|
|
|
struct dc_plane_address *address,
|
|
|
|
bool force_disable_dcc)
|
2019-01-02 20:15:41 +00:00
|
|
|
{
|
|
|
|
struct dc *dc = adev->dm.dc;
|
2019-02-01 20:12:26 +00:00
|
|
|
struct dc_dcc_surface_param input;
|
|
|
|
struct dc_surface_dcc_cap output;
|
2019-01-02 20:15:41 +00:00
|
|
|
uint32_t offset = AMDGPU_TILING_GET(info, DCC_OFFSET_256B);
|
|
|
|
uint32_t i64b = AMDGPU_TILING_GET(info, DCC_INDEPENDENT_64B) != 0;
|
|
|
|
uint64_t dcc_address;
|
|
|
|
|
2019-02-01 20:12:26 +00:00
|
|
|
memset(&input, 0, sizeof(input));
|
|
|
|
memset(&output, 0, sizeof(output));
|
|
|
|
|
2020-04-22 21:43:26 +00:00
|
|
|
if (force_disable_dcc)
|
|
|
|
return 0;
|
|
|
|
|
2019-01-02 20:15:41 +00:00
|
|
|
if (!offset)
|
2019-01-28 16:02:08 +00:00
|
|
|
return 0;
|
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
if (format >= SURFACE_PIXEL_FORMAT_VIDEO_BEGIN)
|
2019-01-28 16:02:08 +00:00
|
|
|
return 0;
|
2019-01-02 20:15:41 +00:00
|
|
|
|
|
|
|
if (!dc->cap_funcs.get_dcc_compression_cap)
|
2019-01-28 16:02:08 +00:00
|
|
|
return -EINVAL;
|
2019-01-02 20:15:41 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
input.format = format;
|
2019-07-03 20:20:42 +00:00
|
|
|
input.surface_size.width = plane_size->surface_size.width;
|
|
|
|
input.surface_size.height = plane_size->surface_size.height;
|
2019-03-28 18:45:19 +00:00
|
|
|
input.swizzle_mode = tiling_info->gfx9.swizzle;
|
2019-01-02 20:15:41 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
if (rotation == ROTATION_ANGLE_0 || rotation == ROTATION_ANGLE_180)
|
2019-01-02 20:15:41 +00:00
|
|
|
input.scan = SCAN_DIRECTION_HORIZONTAL;
|
2019-03-28 18:45:19 +00:00
|
|
|
else if (rotation == ROTATION_ANGLE_90 || rotation == ROTATION_ANGLE_270)
|
2019-01-02 20:15:41 +00:00
|
|
|
input.scan = SCAN_DIRECTION_VERTICAL;
|
|
|
|
|
|
|
|
if (!dc->cap_funcs.get_dcc_compression_cap(dc, &input, &output))
|
2019-01-28 16:02:08 +00:00
|
|
|
return -EINVAL;
|
2019-01-02 20:15:41 +00:00
|
|
|
|
|
|
|
if (!output.capable)
|
2019-01-28 16:02:08 +00:00
|
|
|
return -EINVAL;
|
2019-01-02 20:15:41 +00:00
|
|
|
|
|
|
|
if (i64b == 0 && output.grph.rgb.independent_64b_blks != 0)
|
2019-01-28 16:02:08 +00:00
|
|
|
return -EINVAL;
|
2019-01-02 20:15:41 +00:00
|
|
|
|
2019-01-28 16:02:08 +00:00
|
|
|
dcc->enable = 1;
|
2019-07-03 20:20:42 +00:00
|
|
|
dcc->meta_pitch =
|
2019-01-02 20:15:41 +00:00
|
|
|
AMDGPU_TILING_GET(info, DCC_PITCH_MAX) + 1;
|
2019-07-03 20:20:42 +00:00
|
|
|
dcc->independent_64b_blks = i64b;
|
2019-01-02 20:15:41 +00:00
|
|
|
|
|
|
|
dcc_address = get_dcc_address(afb->address, info);
|
2019-01-28 16:02:08 +00:00
|
|
|
address->grph.meta_addr.low_part = lower_32_bits(dcc_address);
|
|
|
|
address->grph.meta_addr.high_part = upper_32_bits(dcc_address);
|
2019-01-02 20:15:41 +00:00
|
|
|
|
2019-01-28 16:02:08 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2019-03-28 13:46:23 +00:00
|
|
|
fill_plane_buffer_attributes(struct amdgpu_device *adev,
|
2019-01-28 16:02:08 +00:00
|
|
|
const struct amdgpu_framebuffer *afb,
|
2019-03-28 18:45:19 +00:00
|
|
|
const enum surface_pixel_format format,
|
|
|
|
const enum dc_rotation_angle rotation,
|
|
|
|
const uint64_t tiling_flags,
|
2019-01-28 16:02:08 +00:00
|
|
|
union dc_tiling_info *tiling_info,
|
2019-07-03 20:20:42 +00:00
|
|
|
struct plane_size *plane_size,
|
2019-01-28 16:02:08 +00:00
|
|
|
struct dc_plane_dcc_param *dcc,
|
2020-04-22 21:43:26 +00:00
|
|
|
struct dc_plane_address *address,
|
2020-04-22 21:54:55 +00:00
|
|
|
bool tmz_surface,
|
2020-04-22 21:43:26 +00:00
|
|
|
bool force_disable_dcc)
|
2019-01-28 16:02:08 +00:00
|
|
|
{
|
2019-03-28 13:46:23 +00:00
|
|
|
const struct drm_framebuffer *fb = &afb->base;
|
2019-01-28 16:02:08 +00:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
memset(tiling_info, 0, sizeof(*tiling_info));
|
2019-03-28 13:46:23 +00:00
|
|
|
memset(plane_size, 0, sizeof(*plane_size));
|
2019-01-28 16:02:08 +00:00
|
|
|
memset(dcc, 0, sizeof(*dcc));
|
2019-03-11 13:38:35 +00:00
|
|
|
memset(address, 0, sizeof(*address));
|
|
|
|
|
2020-04-22 21:54:55 +00:00
|
|
|
address->tmz_surface = tmz_surface;
|
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
if (format < SURFACE_PIXEL_FORMAT_VIDEO_BEGIN) {
|
2019-07-03 20:20:42 +00:00
|
|
|
plane_size->surface_size.x = 0;
|
|
|
|
plane_size->surface_size.y = 0;
|
|
|
|
plane_size->surface_size.width = fb->width;
|
|
|
|
plane_size->surface_size.height = fb->height;
|
|
|
|
plane_size->surface_pitch =
|
2019-03-28 13:46:23 +00:00
|
|
|
fb->pitches[0] / fb->format->cpp[0];
|
|
|
|
|
2019-03-11 13:38:35 +00:00
|
|
|
address->type = PLN_ADDR_TYPE_GRAPHICS;
|
|
|
|
address->grph.addr.low_part = lower_32_bits(afb->address);
|
|
|
|
address->grph.addr.high_part = upper_32_bits(afb->address);
|
2019-04-25 15:02:30 +00:00
|
|
|
} else if (format < SURFACE_PIXEL_FORMAT_INVALID) {
|
2019-03-13 16:35:20 +00:00
|
|
|
uint64_t chroma_addr = afb->address + fb->offsets[1];
|
2019-03-11 13:38:35 +00:00
|
|
|
|
2019-07-03 20:20:42 +00:00
|
|
|
plane_size->surface_size.x = 0;
|
|
|
|
plane_size->surface_size.y = 0;
|
|
|
|
plane_size->surface_size.width = fb->width;
|
|
|
|
plane_size->surface_size.height = fb->height;
|
|
|
|
plane_size->surface_pitch =
|
2019-03-28 13:46:23 +00:00
|
|
|
fb->pitches[0] / fb->format->cpp[0];
|
|
|
|
|
2019-07-03 20:20:42 +00:00
|
|
|
plane_size->chroma_size.x = 0;
|
|
|
|
plane_size->chroma_size.y = 0;
|
2019-03-28 13:46:23 +00:00
|
|
|
/* TODO: set these based on surface format */
|
2019-07-03 20:20:42 +00:00
|
|
|
plane_size->chroma_size.width = fb->width / 2;
|
|
|
|
plane_size->chroma_size.height = fb->height / 2;
|
2019-03-28 13:46:23 +00:00
|
|
|
|
2019-07-03 20:20:42 +00:00
|
|
|
plane_size->chroma_pitch =
|
2019-03-28 13:46:23 +00:00
|
|
|
fb->pitches[1] / fb->format->cpp[1];
|
|
|
|
|
2019-03-11 13:38:35 +00:00
|
|
|
address->type = PLN_ADDR_TYPE_VIDEO_PROGRESSIVE;
|
|
|
|
address->video_progressive.luma_addr.low_part =
|
|
|
|
lower_32_bits(afb->address);
|
|
|
|
address->video_progressive.luma_addr.high_part =
|
|
|
|
upper_32_bits(afb->address);
|
|
|
|
address->video_progressive.chroma_addr.low_part =
|
|
|
|
lower_32_bits(chroma_addr);
|
|
|
|
address->video_progressive.chroma_addr.high_part =
|
|
|
|
upper_32_bits(chroma_addr);
|
|
|
|
}
|
2019-01-28 16:02:08 +00:00
|
|
|
|
|
|
|
/* Fill GFX8 params */
|
|
|
|
if (AMDGPU_TILING_GET(tiling_flags, ARRAY_MODE) == DC_ARRAY_2D_TILED_THIN1) {
|
|
|
|
unsigned int bankw, bankh, mtaspect, tile_split, num_banks;
|
|
|
|
|
|
|
|
bankw = AMDGPU_TILING_GET(tiling_flags, BANK_WIDTH);
|
|
|
|
bankh = AMDGPU_TILING_GET(tiling_flags, BANK_HEIGHT);
|
|
|
|
mtaspect = AMDGPU_TILING_GET(tiling_flags, MACRO_TILE_ASPECT);
|
|
|
|
tile_split = AMDGPU_TILING_GET(tiling_flags, TILE_SPLIT);
|
|
|
|
num_banks = AMDGPU_TILING_GET(tiling_flags, NUM_BANKS);
|
|
|
|
|
|
|
|
/* XXX fix me for VI */
|
|
|
|
tiling_info->gfx8.num_banks = num_banks;
|
|
|
|
tiling_info->gfx8.array_mode =
|
|
|
|
DC_ARRAY_2D_TILED_THIN1;
|
|
|
|
tiling_info->gfx8.tile_split = tile_split;
|
|
|
|
tiling_info->gfx8.bank_width = bankw;
|
|
|
|
tiling_info->gfx8.bank_height = bankh;
|
|
|
|
tiling_info->gfx8.tile_aspect = mtaspect;
|
|
|
|
tiling_info->gfx8.tile_mode =
|
|
|
|
DC_ADDR_SURF_MICRO_TILING_DISPLAY;
|
|
|
|
} else if (AMDGPU_TILING_GET(tiling_flags, ARRAY_MODE)
|
|
|
|
== DC_ARRAY_1D_TILED_THIN1) {
|
|
|
|
tiling_info->gfx8.array_mode = DC_ARRAY_1D_TILED_THIN1;
|
|
|
|
}
|
|
|
|
|
|
|
|
tiling_info->gfx8.pipe_config =
|
|
|
|
AMDGPU_TILING_GET(tiling_flags, PIPE_CONFIG);
|
|
|
|
|
|
|
|
if (adev->asic_type == CHIP_VEGA10 ||
|
|
|
|
adev->asic_type == CHIP_VEGA12 ||
|
|
|
|
adev->asic_type == CHIP_VEGA20 ||
|
2019-02-22 21:52:52 +00:00
|
|
|
adev->asic_type == CHIP_NAVI10 ||
|
2019-07-02 15:41:40 +00:00
|
|
|
adev->asic_type == CHIP_NAVI14 ||
|
2019-07-16 21:26:14 +00:00
|
|
|
adev->asic_type == CHIP_NAVI12 ||
|
2020-05-21 16:48:41 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN3_0)
|
|
|
|
adev->asic_type == CHIP_SIENNA_CICHLID ||
|
2020-07-08 21:11:12 +00:00
|
|
|
adev->asic_type == CHIP_NAVY_FLOUNDER ||
|
2020-05-21 16:48:41 +00:00
|
|
|
#endif
|
2019-07-26 21:08:45 +00:00
|
|
|
adev->asic_type == CHIP_RENOIR ||
|
2019-01-28 16:02:08 +00:00
|
|
|
adev->asic_type == CHIP_RAVEN) {
|
|
|
|
/* Fill GFX9 params */
|
|
|
|
tiling_info->gfx9.num_pipes =
|
|
|
|
adev->gfx.config.gb_addr_config_fields.num_pipes;
|
|
|
|
tiling_info->gfx9.num_banks =
|
|
|
|
adev->gfx.config.gb_addr_config_fields.num_banks;
|
|
|
|
tiling_info->gfx9.pipe_interleave =
|
|
|
|
adev->gfx.config.gb_addr_config_fields.pipe_interleave_size;
|
|
|
|
tiling_info->gfx9.num_shader_engines =
|
|
|
|
adev->gfx.config.gb_addr_config_fields.num_se;
|
|
|
|
tiling_info->gfx9.max_compressed_frags =
|
|
|
|
adev->gfx.config.gb_addr_config_fields.max_compress_frags;
|
|
|
|
tiling_info->gfx9.num_rb_per_se =
|
|
|
|
adev->gfx.config.gb_addr_config_fields.num_rb_per_se;
|
|
|
|
tiling_info->gfx9.swizzle =
|
|
|
|
AMDGPU_TILING_GET(tiling_flags, SWIZZLE_MODE);
|
|
|
|
tiling_info->gfx9.shaderEnable = 1;
|
|
|
|
|
2020-05-21 16:48:41 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_DCN3_0
|
2020-07-08 21:11:12 +00:00
|
|
|
if (adev->asic_type == CHIP_SIENNA_CICHLID ||
|
|
|
|
adev->asic_type == CHIP_NAVY_FLOUNDER)
|
2020-05-21 16:48:41 +00:00
|
|
|
tiling_info->gfx9.num_pkrs = adev->gfx.config.gb_addr_config_fields.num_pkrs;
|
|
|
|
#endif
|
2019-03-28 18:45:19 +00:00
|
|
|
ret = fill_plane_dcc_attributes(adev, afb, format, rotation,
|
|
|
|
plane_size, tiling_info,
|
2020-04-22 21:43:26 +00:00
|
|
|
tiling_flags, dcc, address,
|
|
|
|
force_disable_dcc);
|
2019-01-28 16:02:08 +00:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
2019-01-02 20:15:41 +00:00
|
|
|
}
|
|
|
|
|
2019-02-21 19:57:48 +00:00
|
|
|
static void
|
2019-03-28 18:45:19 +00:00
|
|
|
fill_blending_from_plane_state(const struct drm_plane_state *plane_state,
|
2019-02-21 19:57:48 +00:00
|
|
|
bool *per_pixel_alpha, bool *global_alpha,
|
|
|
|
int *global_alpha_value)
|
|
|
|
{
|
|
|
|
*per_pixel_alpha = false;
|
|
|
|
*global_alpha = false;
|
|
|
|
*global_alpha_value = 0xff;
|
|
|
|
|
|
|
|
if (plane_state->plane->type != DRM_PLANE_TYPE_OVERLAY)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (plane_state->pixel_blend_mode == DRM_MODE_BLEND_PREMULTI) {
|
|
|
|
static const uint32_t alpha_formats[] = {
|
|
|
|
DRM_FORMAT_ARGB8888,
|
|
|
|
DRM_FORMAT_RGBA8888,
|
|
|
|
DRM_FORMAT_ABGR8888,
|
|
|
|
};
|
|
|
|
uint32_t format = plane_state->fb->format->format;
|
|
|
|
unsigned int i;
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(alpha_formats); ++i) {
|
|
|
|
if (format == alpha_formats[i]) {
|
|
|
|
*per_pixel_alpha = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (plane_state->alpha < 0xffff) {
|
|
|
|
*global_alpha = true;
|
|
|
|
*global_alpha_value = plane_state->alpha >> 8;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-03-15 14:31:50 +00:00
|
|
|
static int
|
|
|
|
fill_plane_color_attributes(const struct drm_plane_state *plane_state,
|
2019-03-28 18:45:19 +00:00
|
|
|
const enum surface_pixel_format format,
|
2019-03-15 14:31:50 +00:00
|
|
|
enum dc_color_space *color_space)
|
|
|
|
{
|
|
|
|
bool full_range;
|
|
|
|
|
|
|
|
*color_space = COLOR_SPACE_SRGB;
|
|
|
|
|
|
|
|
/* DRM color properties only affect non-RGB formats. */
|
2019-03-28 18:45:19 +00:00
|
|
|
if (format < SURFACE_PIXEL_FORMAT_VIDEO_BEGIN)
|
2019-03-15 14:31:50 +00:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
full_range = (plane_state->color_range == DRM_COLOR_YCBCR_FULL_RANGE);
|
|
|
|
|
|
|
|
switch (plane_state->color_encoding) {
|
|
|
|
case DRM_COLOR_YCBCR_BT601:
|
|
|
|
if (full_range)
|
|
|
|
*color_space = COLOR_SPACE_YCBCR601;
|
|
|
|
else
|
|
|
|
*color_space = COLOR_SPACE_YCBCR601_LIMITED;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case DRM_COLOR_YCBCR_BT709:
|
|
|
|
if (full_range)
|
|
|
|
*color_space = COLOR_SPACE_YCBCR709;
|
|
|
|
else
|
|
|
|
*color_space = COLOR_SPACE_YCBCR709_LIMITED;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case DRM_COLOR_YCBCR_BT2020:
|
|
|
|
if (full_range)
|
|
|
|
*color_space = COLOR_SPACE_2020_YCBCR;
|
|
|
|
else
|
|
|
|
return -EINVAL;
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
static int
|
|
|
|
fill_dc_plane_info_and_addr(struct amdgpu_device *adev,
|
|
|
|
const struct drm_plane_state *plane_state,
|
|
|
|
const uint64_t tiling_flags,
|
|
|
|
struct dc_plane_info *plane_info,
|
2020-04-22 21:43:26 +00:00
|
|
|
struct dc_plane_address *address,
|
2020-04-22 21:54:55 +00:00
|
|
|
bool tmz_surface,
|
2020-04-22 21:43:26 +00:00
|
|
|
bool force_disable_dcc)
|
2019-03-28 18:45:19 +00:00
|
|
|
{
|
|
|
|
const struct drm_framebuffer *fb = plane_state->fb;
|
|
|
|
const struct amdgpu_framebuffer *afb =
|
|
|
|
to_amdgpu_framebuffer(plane_state->fb);
|
|
|
|
struct drm_format_name_buf format_name;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
memset(plane_info, 0, sizeof(*plane_info));
|
|
|
|
|
|
|
|
switch (fb->format->format) {
|
|
|
|
case DRM_FORMAT_C8:
|
|
|
|
plane_info->format =
|
|
|
|
SURFACE_PIXEL_FORMAT_GRPH_PALETA_256_COLORS;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_RGB565:
|
|
|
|
plane_info->format = SURFACE_PIXEL_FORMAT_GRPH_RGB565;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB8888:
|
|
|
|
case DRM_FORMAT_ARGB8888:
|
|
|
|
plane_info->format = SURFACE_PIXEL_FORMAT_GRPH_ARGB8888;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB2101010:
|
|
|
|
case DRM_FORMAT_ARGB2101010:
|
|
|
|
plane_info->format = SURFACE_PIXEL_FORMAT_GRPH_ARGB2101010;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XBGR2101010:
|
|
|
|
case DRM_FORMAT_ABGR2101010:
|
|
|
|
plane_info->format = SURFACE_PIXEL_FORMAT_GRPH_ABGR2101010;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XBGR8888:
|
|
|
|
case DRM_FORMAT_ABGR8888:
|
|
|
|
plane_info->format = SURFACE_PIXEL_FORMAT_GRPH_ABGR8888;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_NV21:
|
|
|
|
plane_info->format = SURFACE_PIXEL_FORMAT_VIDEO_420_YCbCr;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_NV12:
|
|
|
|
plane_info->format = SURFACE_PIXEL_FORMAT_VIDEO_420_YCrCb;
|
|
|
|
break;
|
2020-03-06 14:55:29 +00:00
|
|
|
case DRM_FORMAT_P010:
|
|
|
|
plane_info->format = SURFACE_PIXEL_FORMAT_VIDEO_420_10bpc_YCrCb;
|
|
|
|
break;
|
2020-04-21 12:47:41 +00:00
|
|
|
case DRM_FORMAT_XRGB16161616F:
|
|
|
|
case DRM_FORMAT_ARGB16161616F:
|
|
|
|
plane_info->format = SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616F;
|
|
|
|
break;
|
2020-05-15 05:19:23 +00:00
|
|
|
case DRM_FORMAT_XBGR16161616F:
|
|
|
|
case DRM_FORMAT_ABGR16161616F:
|
|
|
|
plane_info->format = SURFACE_PIXEL_FORMAT_GRPH_ABGR16161616F;
|
|
|
|
break;
|
2019-03-28 18:45:19 +00:00
|
|
|
default:
|
|
|
|
DRM_ERROR(
|
|
|
|
"Unsupported screen format %s\n",
|
|
|
|
drm_get_format_name(fb->format->format, &format_name));
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (plane_state->rotation & DRM_MODE_ROTATE_MASK) {
|
|
|
|
case DRM_MODE_ROTATE_0:
|
|
|
|
plane_info->rotation = ROTATION_ANGLE_0;
|
|
|
|
break;
|
|
|
|
case DRM_MODE_ROTATE_90:
|
|
|
|
plane_info->rotation = ROTATION_ANGLE_90;
|
|
|
|
break;
|
|
|
|
case DRM_MODE_ROTATE_180:
|
|
|
|
plane_info->rotation = ROTATION_ANGLE_180;
|
|
|
|
break;
|
|
|
|
case DRM_MODE_ROTATE_270:
|
|
|
|
plane_info->rotation = ROTATION_ANGLE_270;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
plane_info->rotation = ROTATION_ANGLE_0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
plane_info->visible = true;
|
|
|
|
plane_info->stereo_format = PLANE_STEREO_FORMAT_NONE;
|
|
|
|
|
2019-07-26 16:04:12 +00:00
|
|
|
plane_info->layer_index = 0;
|
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
ret = fill_plane_color_attributes(plane_state, plane_info->format,
|
|
|
|
&plane_info->color_space);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
ret = fill_plane_buffer_attributes(adev, afb, plane_info->format,
|
|
|
|
plane_info->rotation, tiling_flags,
|
|
|
|
&plane_info->tiling_info,
|
|
|
|
&plane_info->plane_size,
|
2020-04-22 21:54:55 +00:00
|
|
|
&plane_info->dcc, address, tmz_surface,
|
2020-04-22 21:43:26 +00:00
|
|
|
force_disable_dcc);
|
2019-03-28 18:45:19 +00:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
fill_blending_from_plane_state(
|
|
|
|
plane_state, &plane_info->per_pixel_alpha,
|
|
|
|
&plane_info->global_alpha, &plane_info->global_alpha_value);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int fill_dc_plane_attributes(struct amdgpu_device *adev,
|
|
|
|
struct dc_plane_state *dc_plane_state,
|
|
|
|
struct drm_plane_state *plane_state,
|
|
|
|
struct drm_crtc_state *crtc_state)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2019-05-09 16:14:58 +00:00
|
|
|
struct dm_crtc_state *dm_crtc_state = to_dm_crtc_state(crtc_state);
|
2017-08-10 17:29:07 +00:00
|
|
|
const struct amdgpu_framebuffer *amdgpu_fb =
|
|
|
|
to_amdgpu_framebuffer(plane_state->fb);
|
2019-03-28 18:45:19 +00:00
|
|
|
struct dc_scaling_info scaling_info;
|
|
|
|
struct dc_plane_info plane_info;
|
|
|
|
uint64_t tiling_flags;
|
|
|
|
int ret;
|
2020-04-22 21:54:55 +00:00
|
|
|
bool tmz_surface = false;
|
2020-04-22 21:43:26 +00:00
|
|
|
bool force_disable_dcc = false;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
ret = fill_dc_scaling_info(plane_state, &scaling_info);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
dc_plane_state->src_rect = scaling_info.src_rect;
|
|
|
|
dc_plane_state->dst_rect = scaling_info.dst_rect;
|
|
|
|
dc_plane_state->clip_rect = scaling_info.clip_rect;
|
|
|
|
dc_plane_state->scaling_quality = scaling_info.scaling_quality;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2020-04-22 21:54:55 +00:00
|
|
|
ret = get_fb_info(amdgpu_fb, &tiling_flags, &tmz_surface);
|
2017-08-10 17:29:07 +00:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2020-04-22 21:43:26 +00:00
|
|
|
force_disable_dcc = adev->asic_type == CHIP_RAVEN && adev->in_suspend;
|
2019-03-28 18:45:19 +00:00
|
|
|
ret = fill_dc_plane_info_and_addr(adev, plane_state, tiling_flags,
|
|
|
|
&plane_info,
|
2020-04-22 21:43:26 +00:00
|
|
|
&dc_plane_state->address,
|
2020-04-22 21:54:55 +00:00
|
|
|
tmz_surface,
|
2020-04-22 21:43:26 +00:00
|
|
|
force_disable_dcc);
|
2019-03-15 14:31:50 +00:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
dc_plane_state->format = plane_info.format;
|
|
|
|
dc_plane_state->color_space = plane_info.color_space;
|
|
|
|
dc_plane_state->format = plane_info.format;
|
|
|
|
dc_plane_state->plane_size = plane_info.plane_size;
|
|
|
|
dc_plane_state->rotation = plane_info.rotation;
|
|
|
|
dc_plane_state->horizontal_mirror = plane_info.horizontal_mirror;
|
|
|
|
dc_plane_state->stereo_format = plane_info.stereo_format;
|
|
|
|
dc_plane_state->tiling_info = plane_info.tiling_info;
|
|
|
|
dc_plane_state->visible = plane_info.visible;
|
|
|
|
dc_plane_state->per_pixel_alpha = plane_info.per_pixel_alpha;
|
|
|
|
dc_plane_state->global_alpha = plane_info.global_alpha;
|
|
|
|
dc_plane_state->global_alpha_value = plane_info.global_alpha_value;
|
|
|
|
dc_plane_state->dcc = plane_info.dcc;
|
2019-07-26 16:04:12 +00:00
|
|
|
dc_plane_state->layer_index = plane_info.layer_index; // Always returns 0
|
2019-03-28 18:45:19 +00:00
|
|
|
|
2018-02-02 15:18:56 +00:00
|
|
|
/*
|
|
|
|
* Always set input transfer function, since plane state is refreshed
|
|
|
|
* every time.
|
|
|
|
*/
|
2019-05-09 16:14:58 +00:00
|
|
|
ret = amdgpu_dm_update_plane_color_mgmt(dm_crtc_state, dc_plane_state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-05-09 16:14:58 +00:00
|
|
|
return 0;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static void update_stream_scaling_settings(const struct drm_display_mode *mode,
|
|
|
|
const struct dm_connector_state *dm_state,
|
|
|
|
struct dc_stream_state *stream)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
enum amdgpu_rmx_type rmx_type;
|
|
|
|
|
|
|
|
struct rect src = { 0 }; /* viewport in composition space*/
|
|
|
|
struct rect dst = { 0 }; /* stream addressable area */
|
|
|
|
|
|
|
|
/* no mode. nothing to be done */
|
|
|
|
if (!mode)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* Full screen scaling by default */
|
|
|
|
src.width = mode->hdisplay;
|
|
|
|
src.height = mode->vdisplay;
|
|
|
|
dst.width = stream->timing.h_addressable;
|
|
|
|
dst.height = stream->timing.v_addressable;
|
|
|
|
|
2017-12-18 18:48:12 +00:00
|
|
|
if (dm_state) {
|
|
|
|
rmx_type = dm_state->scaling;
|
|
|
|
if (rmx_type == RMX_ASPECT || rmx_type == RMX_OFF) {
|
|
|
|
if (src.width * dst.height <
|
|
|
|
src.height * dst.width) {
|
|
|
|
/* height needs less upscaling/more downscaling */
|
|
|
|
dst.width = src.width *
|
|
|
|
dst.height / src.height;
|
|
|
|
} else {
|
|
|
|
/* width needs less upscaling/more downscaling */
|
|
|
|
dst.height = src.height *
|
|
|
|
dst.width / src.width;
|
|
|
|
}
|
|
|
|
} else if (rmx_type == RMX_CENTER) {
|
|
|
|
dst = src;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2017-12-18 18:48:12 +00:00
|
|
|
dst.x = (stream->timing.h_addressable - dst.width) / 2;
|
|
|
|
dst.y = (stream->timing.v_addressable - dst.height) / 2;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-12-18 18:48:12 +00:00
|
|
|
if (dm_state->underscan_enable) {
|
|
|
|
dst.x += dm_state->underscan_hborder / 2;
|
|
|
|
dst.y += dm_state->underscan_vborder / 2;
|
|
|
|
dst.width -= dm_state->underscan_hborder;
|
|
|
|
dst.height -= dm_state->underscan_vborder;
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
stream->src = src;
|
|
|
|
stream->dst = dst;
|
|
|
|
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("Destination Rectangle x:%d y:%d width:%d height:%d\n",
|
2017-08-10 17:29:07 +00:00
|
|
|
dst.x, dst.y, dst.width, dst.height);
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static enum dc_color_depth
|
2019-05-22 16:00:55 +00:00
|
|
|
convert_color_depth_from_display_info(const struct drm_connector *connector,
|
2020-04-30 08:40:09 +00:00
|
|
|
bool is_y420, int requested_bpc)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2019-09-20 07:40:55 +00:00
|
|
|
uint8_t bpc;
|
2019-08-21 15:27:13 +00:00
|
|
|
|
2019-09-20 07:40:55 +00:00
|
|
|
if (is_y420) {
|
|
|
|
bpc = 8;
|
|
|
|
|
|
|
|
/* Cap display bpc based on HDMI 2.0 HF-VSDB */
|
|
|
|
if (connector->display_info.hdmi.y420_dc_modes & DRM_EDID_YCBCR420_DC_48)
|
|
|
|
bpc = 16;
|
|
|
|
else if (connector->display_info.hdmi.y420_dc_modes & DRM_EDID_YCBCR420_DC_36)
|
|
|
|
bpc = 12;
|
|
|
|
else if (connector->display_info.hdmi.y420_dc_modes & DRM_EDID_YCBCR420_DC_30)
|
|
|
|
bpc = 10;
|
|
|
|
} else {
|
|
|
|
bpc = (uint8_t)connector->display_info.bpc;
|
|
|
|
/* Assume 8 bpc by default if no bpc is specified. */
|
|
|
|
bpc = bpc ? bpc : 8;
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2020-04-30 08:40:09 +00:00
|
|
|
if (requested_bpc > 0) {
|
2019-08-21 15:27:13 +00:00
|
|
|
/*
|
|
|
|
* Cap display bpc based on the user requested value.
|
|
|
|
*
|
|
|
|
* The value for state->max_bpc may not correctly updated
|
|
|
|
* depending on when the connector gets added to the state
|
|
|
|
* or if this was called outside of atomic check, so it
|
|
|
|
* can't be used directly.
|
|
|
|
*/
|
2020-04-30 08:40:09 +00:00
|
|
|
bpc = min_t(u8, bpc, requested_bpc);
|
2019-08-21 15:27:13 +00:00
|
|
|
|
2019-05-22 16:00:54 +00:00
|
|
|
/* Round down to the nearest even number. */
|
|
|
|
bpc = bpc - (bpc & 1);
|
|
|
|
}
|
2018-11-15 22:21:34 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
switch (bpc) {
|
|
|
|
case 0:
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Temporary Work around, DRM doesn't parse color depth for
|
2017-08-10 17:29:07 +00:00
|
|
|
* EDID revision before 1.4
|
|
|
|
* TODO: Fix edid parsing
|
|
|
|
*/
|
|
|
|
return COLOR_DEPTH_888;
|
|
|
|
case 6:
|
|
|
|
return COLOR_DEPTH_666;
|
|
|
|
case 8:
|
|
|
|
return COLOR_DEPTH_888;
|
|
|
|
case 10:
|
|
|
|
return COLOR_DEPTH_101010;
|
|
|
|
case 12:
|
|
|
|
return COLOR_DEPTH_121212;
|
|
|
|
case 14:
|
|
|
|
return COLOR_DEPTH_141414;
|
|
|
|
case 16:
|
|
|
|
return COLOR_DEPTH_161616;
|
|
|
|
default:
|
|
|
|
return COLOR_DEPTH_UNDEFINED;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static enum dc_aspect_ratio
|
|
|
|
get_aspect_ratio(const struct drm_display_mode *mode_in)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2018-07-19 12:22:16 +00:00
|
|
|
/* 1-1 mapping, since both enums follow the HDMI spec. */
|
|
|
|
return (enum dc_aspect_ratio) mode_in->picture_aspect_ratio;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static enum dc_color_space
|
|
|
|
get_output_color_space(const struct dc_crtc_timing *dc_crtc_timing)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
enum dc_color_space color_space = COLOR_SPACE_SRGB;
|
|
|
|
|
|
|
|
switch (dc_crtc_timing->pixel_encoding) {
|
|
|
|
case PIXEL_ENCODING_YCBCR422:
|
|
|
|
case PIXEL_ENCODING_YCBCR444:
|
|
|
|
case PIXEL_ENCODING_YCBCR420:
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* 27030khz is the separation point between HDTV and SDTV
|
|
|
|
* according to HDMI spec, we use YCbCr709 and YCbCr601
|
|
|
|
* respectively
|
|
|
|
*/
|
2018-11-06 19:24:12 +00:00
|
|
|
if (dc_crtc_timing->pix_clk_100hz > 270300) {
|
2017-08-10 17:29:07 +00:00
|
|
|
if (dc_crtc_timing->flags.Y_ONLY)
|
|
|
|
color_space =
|
|
|
|
COLOR_SPACE_YCBCR709_LIMITED;
|
|
|
|
else
|
|
|
|
color_space = COLOR_SPACE_YCBCR709;
|
|
|
|
} else {
|
|
|
|
if (dc_crtc_timing->flags.Y_ONLY)
|
|
|
|
color_space =
|
|
|
|
COLOR_SPACE_YCBCR601_LIMITED;
|
|
|
|
else
|
|
|
|
color_space = COLOR_SPACE_YCBCR601;
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case PIXEL_ENCODING_RGB:
|
|
|
|
color_space = COLOR_SPACE_SRGB;
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
WARN_ON(1);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return color_space;
|
|
|
|
}
|
|
|
|
|
2019-12-02 21:47:13 +00:00
|
|
|
static bool adjust_colour_depth_from_display_info(
|
|
|
|
struct dc_crtc_timing *timing_out,
|
|
|
|
const struct drm_display_info *info)
|
2018-07-03 13:42:51 +00:00
|
|
|
{
|
2019-12-02 21:47:13 +00:00
|
|
|
enum dc_color_depth depth = timing_out->display_color_depth;
|
2018-07-03 13:42:51 +00:00
|
|
|
int normalized_clk;
|
|
|
|
do {
|
2018-11-06 19:24:12 +00:00
|
|
|
normalized_clk = timing_out->pix_clk_100hz / 10;
|
2018-07-03 13:42:51 +00:00
|
|
|
/* YCbCr 4:2:0 requires additional adjustment of 1/2 */
|
|
|
|
if (timing_out->pixel_encoding == PIXEL_ENCODING_YCBCR420)
|
|
|
|
normalized_clk /= 2;
|
|
|
|
/* Adjusting pix clock following on HDMI spec based on colour depth */
|
2019-12-02 21:47:13 +00:00
|
|
|
switch (depth) {
|
|
|
|
case COLOR_DEPTH_888:
|
|
|
|
break;
|
2018-07-03 13:42:51 +00:00
|
|
|
case COLOR_DEPTH_101010:
|
|
|
|
normalized_clk = (normalized_clk * 30) / 24;
|
|
|
|
break;
|
|
|
|
case COLOR_DEPTH_121212:
|
|
|
|
normalized_clk = (normalized_clk * 36) / 24;
|
|
|
|
break;
|
|
|
|
case COLOR_DEPTH_161616:
|
|
|
|
normalized_clk = (normalized_clk * 48) / 24;
|
|
|
|
break;
|
|
|
|
default:
|
2019-12-02 21:47:13 +00:00
|
|
|
/* The above depths are the only ones valid for HDMI. */
|
|
|
|
return false;
|
2018-07-03 13:42:51 +00:00
|
|
|
}
|
2019-12-02 21:47:13 +00:00
|
|
|
if (normalized_clk <= info->max_tmds_clock) {
|
|
|
|
timing_out->display_color_depth = depth;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
} while (--depth > COLOR_DEPTH_666);
|
|
|
|
return false;
|
2018-07-03 13:42:51 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-05-22 16:00:55 +00:00
|
|
|
static void fill_stream_properties_from_drm_display_mode(
|
|
|
|
struct dc_stream_state *stream,
|
|
|
|
const struct drm_display_mode *mode_in,
|
|
|
|
const struct drm_connector *connector,
|
|
|
|
const struct drm_connector_state *connector_state,
|
2020-04-30 08:40:09 +00:00
|
|
|
const struct dc_stream_state *old_stream,
|
|
|
|
int requested_bpc)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct dc_crtc_timing *timing_out = &stream->timing;
|
2018-07-04 13:27:02 +00:00
|
|
|
const struct drm_display_info *info = &connector->display_info;
|
2019-08-20 18:48:37 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
|
2019-09-03 22:12:22 +00:00
|
|
|
struct hdmi_vendor_infoframe hv_frame;
|
|
|
|
struct hdmi_avi_infoframe avi_frame;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-10-21 05:24:36 +00:00
|
|
|
memset(&hv_frame, 0, sizeof(hv_frame));
|
|
|
|
memset(&avi_frame, 0, sizeof(avi_frame));
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
timing_out->h_border_left = 0;
|
|
|
|
timing_out->h_border_right = 0;
|
|
|
|
timing_out->v_border_top = 0;
|
|
|
|
timing_out->v_border_bottom = 0;
|
|
|
|
/* TODO: un-hardcode */
|
2018-07-04 13:27:02 +00:00
|
|
|
if (drm_mode_is_420_only(info, mode_in)
|
drm/amd/display: remove sink reference in dc_stream_state
[why]
dc_stream_state containing a pointer to sink is poor design.
Sink describes the display, and the specifications or capabilities
it has. That information is irrelevant for dc_stream_state, which describes
hardware state, and is generally used for hardware programming. It
could further be argued that dc_sink itself is just a convenience dc
provides, and DC should be perfectly capable of programming hardware
without any dc_sinks (for example, emulated sinks).
[how]
Phase 1:
Deprecate use of dc_sink pointer in dc_stream. Most references are trivial
to remove, but some call sites are risky (such as is_timing_changed) with
no obvious logical replacement. These will be removed in follow up change.
Add dc_link pointer to dc_stream. This is the typical reason DC really needed
sink pointer, and most call sites are replaced with this.
DMs also need minor updates, as all 3 DMs leverage stream->sink for
some functionality. this is replaced instead by a pointer to private data
inside dc_stream_state, which is used by DMs as a quality of life improvment
for some key functionality. it allows DMs to set pointers have to their own objects
which associate OS objects to dc_stream_states (such as DisplayTarget
and amdgpu_dm_connector). Without the private pointer, DMs would be
forced to perform a lookup for callbacks.
Signed-off-by: Jun Lei <Jun.Lei@amd.com>
Reviewed-by: Aric Cyr <Aric.Cyr@amd.com>
Acked-by: David Francis <David.Francis@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2018-11-09 14:21:21 +00:00
|
|
|
&& stream->signal == SIGNAL_TYPE_HDMI_TYPE_A)
|
2018-07-04 13:27:02 +00:00
|
|
|
timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420;
|
2019-08-20 18:48:37 +00:00
|
|
|
else if (drm_mode_is_420_also(info, mode_in)
|
|
|
|
&& aconnector->force_yuv420_output)
|
|
|
|
timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420;
|
2018-07-04 13:27:02 +00:00
|
|
|
else if ((connector->display_info.color_formats & DRM_COLOR_FORMAT_YCRCB444)
|
drm/amd/display: remove sink reference in dc_stream_state
[why]
dc_stream_state containing a pointer to sink is poor design.
Sink describes the display, and the specifications or capabilities
it has. That information is irrelevant for dc_stream_state, which describes
hardware state, and is generally used for hardware programming. It
could further be argued that dc_sink itself is just a convenience dc
provides, and DC should be perfectly capable of programming hardware
without any dc_sinks (for example, emulated sinks).
[how]
Phase 1:
Deprecate use of dc_sink pointer in dc_stream. Most references are trivial
to remove, but some call sites are risky (such as is_timing_changed) with
no obvious logical replacement. These will be removed in follow up change.
Add dc_link pointer to dc_stream. This is the typical reason DC really needed
sink pointer, and most call sites are replaced with this.
DMs also need minor updates, as all 3 DMs leverage stream->sink for
some functionality. this is replaced instead by a pointer to private data
inside dc_stream_state, which is used by DMs as a quality of life improvment
for some key functionality. it allows DMs to set pointers have to their own objects
which associate OS objects to dc_stream_states (such as DisplayTarget
and amdgpu_dm_connector). Without the private pointer, DMs would be
forced to perform a lookup for callbacks.
Signed-off-by: Jun Lei <Jun.Lei@amd.com>
Reviewed-by: Aric Cyr <Aric.Cyr@amd.com>
Acked-by: David Francis <David.Francis@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2018-11-09 14:21:21 +00:00
|
|
|
&& stream->signal == SIGNAL_TYPE_HDMI_TYPE_A)
|
2017-08-10 17:29:07 +00:00
|
|
|
timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR444;
|
|
|
|
else
|
|
|
|
timing_out->pixel_encoding = PIXEL_ENCODING_RGB;
|
|
|
|
|
|
|
|
timing_out->timing_3d_format = TIMING_3D_FORMAT_NONE;
|
|
|
|
timing_out->display_color_depth = convert_color_depth_from_display_info(
|
2020-04-30 08:40:09 +00:00
|
|
|
connector,
|
|
|
|
(timing_out->pixel_encoding == PIXEL_ENCODING_YCBCR420),
|
|
|
|
requested_bpc);
|
2017-08-10 17:29:07 +00:00
|
|
|
timing_out->scan_type = SCANNING_TYPE_NODATA;
|
|
|
|
timing_out->hdmi_vic = 0;
|
2018-11-16 16:46:14 +00:00
|
|
|
|
|
|
|
if(old_stream) {
|
|
|
|
timing_out->vic = old_stream->timing.vic;
|
|
|
|
timing_out->flags.HSYNC_POSITIVE_POLARITY = old_stream->timing.flags.HSYNC_POSITIVE_POLARITY;
|
|
|
|
timing_out->flags.VSYNC_POSITIVE_POLARITY = old_stream->timing.flags.VSYNC_POSITIVE_POLARITY;
|
|
|
|
} else {
|
|
|
|
timing_out->vic = drm_match_cea_mode(mode_in);
|
|
|
|
if (mode_in->flags & DRM_MODE_FLAG_PHSYNC)
|
|
|
|
timing_out->flags.HSYNC_POSITIVE_POLARITY = 1;
|
|
|
|
if (mode_in->flags & DRM_MODE_FLAG_PVSYNC)
|
|
|
|
timing_out->flags.VSYNC_POSITIVE_POLARITY = 1;
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-09-03 22:12:22 +00:00
|
|
|
if (stream->signal == SIGNAL_TYPE_HDMI_TYPE_A) {
|
|
|
|
drm_hdmi_avi_infoframe_from_display_mode(&avi_frame, (struct drm_connector *)connector, mode_in);
|
|
|
|
timing_out->vic = avi_frame.video_code;
|
|
|
|
drm_hdmi_vendor_infoframe_from_display_mode(&hv_frame, (struct drm_connector *)connector, mode_in);
|
|
|
|
timing_out->hdmi_vic = hv_frame.vic;
|
|
|
|
}
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
timing_out->h_addressable = mode_in->crtc_hdisplay;
|
|
|
|
timing_out->h_total = mode_in->crtc_htotal;
|
|
|
|
timing_out->h_sync_width =
|
|
|
|
mode_in->crtc_hsync_end - mode_in->crtc_hsync_start;
|
|
|
|
timing_out->h_front_porch =
|
|
|
|
mode_in->crtc_hsync_start - mode_in->crtc_hdisplay;
|
|
|
|
timing_out->v_total = mode_in->crtc_vtotal;
|
|
|
|
timing_out->v_addressable = mode_in->crtc_vdisplay;
|
|
|
|
timing_out->v_front_porch =
|
|
|
|
mode_in->crtc_vsync_start - mode_in->crtc_vdisplay;
|
|
|
|
timing_out->v_sync_width =
|
|
|
|
mode_in->crtc_vsync_end - mode_in->crtc_vsync_start;
|
2018-11-06 19:24:12 +00:00
|
|
|
timing_out->pix_clk_100hz = mode_in->crtc_clock * 10;
|
2017-08-10 17:29:07 +00:00
|
|
|
timing_out->aspect_ratio = get_aspect_ratio(mode_in);
|
|
|
|
|
|
|
|
stream->output_color_space = get_output_color_space(timing_out);
|
|
|
|
|
2018-03-27 20:43:56 +00:00
|
|
|
stream->out_transfer_func->type = TF_TYPE_PREDEFINED;
|
|
|
|
stream->out_transfer_func->tf = TRANSFER_FUNCTION_SRGB;
|
2019-12-02 21:47:13 +00:00
|
|
|
if (stream->signal == SIGNAL_TYPE_HDMI_TYPE_A) {
|
|
|
|
if (!adjust_colour_depth_from_display_info(timing_out, info) &&
|
|
|
|
drm_mode_is_420_also(info, mode_in) &&
|
|
|
|
timing_out->pixel_encoding != PIXEL_ENCODING_YCBCR420) {
|
|
|
|
timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420;
|
|
|
|
adjust_colour_depth_from_display_info(timing_out, info);
|
|
|
|
}
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static void fill_audio_info(struct audio_info *audio_info,
|
|
|
|
const struct drm_connector *drm_connector,
|
|
|
|
const struct dc_sink *dc_sink)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
int i = 0;
|
|
|
|
int cea_revision = 0;
|
|
|
|
const struct dc_edid_caps *edid_caps = &dc_sink->edid_caps;
|
|
|
|
|
|
|
|
audio_info->manufacture_id = edid_caps->manufacturer_id;
|
|
|
|
audio_info->product_id = edid_caps->product_id;
|
|
|
|
|
|
|
|
cea_revision = drm_connector->display_info.cea_rev;
|
|
|
|
|
2018-07-20 14:17:29 +00:00
|
|
|
strscpy(audio_info->display_name,
|
2017-10-17 13:46:54 +00:00
|
|
|
edid_caps->display_name,
|
2018-07-20 14:17:29 +00:00
|
|
|
AUDIO_INFO_DISPLAY_NAME_SIZE_IN_CHARS);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-07-27 01:03:22 +00:00
|
|
|
if (cea_revision >= 3) {
|
2017-08-10 17:29:07 +00:00
|
|
|
audio_info->mode_count = edid_caps->audio_mode_count;
|
|
|
|
|
|
|
|
for (i = 0; i < audio_info->mode_count; ++i) {
|
|
|
|
audio_info->modes[i].format_code =
|
|
|
|
(enum audio_format_code)
|
|
|
|
(edid_caps->audio_modes[i].format_code);
|
|
|
|
audio_info->modes[i].channel_count =
|
|
|
|
edid_caps->audio_modes[i].channel_count;
|
|
|
|
audio_info->modes[i].sample_rates.all =
|
|
|
|
edid_caps->audio_modes[i].sample_rate;
|
|
|
|
audio_info->modes[i].sample_size =
|
|
|
|
edid_caps->audio_modes[i].sample_size;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
audio_info->flags.all = edid_caps->speaker_flags;
|
|
|
|
|
|
|
|
/* TODO: We only check for the progressive mode, check for interlace mode too */
|
2017-07-27 01:03:22 +00:00
|
|
|
if (drm_connector->latency_present[0]) {
|
2017-08-10 17:29:07 +00:00
|
|
|
audio_info->video_latency = drm_connector->video_latency[0];
|
|
|
|
audio_info->audio_latency = drm_connector->audio_latency[0];
|
|
|
|
}
|
|
|
|
|
|
|
|
/* TODO: For DP, video and audio latency should be calculated from DPCD caps */
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static void
|
|
|
|
copy_crtc_timing_for_drm_display_mode(const struct drm_display_mode *src_mode,
|
|
|
|
struct drm_display_mode *dst_mode)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
dst_mode->crtc_hdisplay = src_mode->crtc_hdisplay;
|
|
|
|
dst_mode->crtc_vdisplay = src_mode->crtc_vdisplay;
|
|
|
|
dst_mode->crtc_clock = src_mode->crtc_clock;
|
|
|
|
dst_mode->crtc_hblank_start = src_mode->crtc_hblank_start;
|
|
|
|
dst_mode->crtc_hblank_end = src_mode->crtc_hblank_end;
|
2017-07-27 01:03:22 +00:00
|
|
|
dst_mode->crtc_hsync_start = src_mode->crtc_hsync_start;
|
2017-08-10 17:29:07 +00:00
|
|
|
dst_mode->crtc_hsync_end = src_mode->crtc_hsync_end;
|
|
|
|
dst_mode->crtc_htotal = src_mode->crtc_htotal;
|
|
|
|
dst_mode->crtc_hskew = src_mode->crtc_hskew;
|
|
|
|
dst_mode->crtc_vblank_start = src_mode->crtc_vblank_start;
|
|
|
|
dst_mode->crtc_vblank_end = src_mode->crtc_vblank_end;
|
|
|
|
dst_mode->crtc_vsync_start = src_mode->crtc_vsync_start;
|
|
|
|
dst_mode->crtc_vsync_end = src_mode->crtc_vsync_end;
|
|
|
|
dst_mode->crtc_vtotal = src_mode->crtc_vtotal;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static void
|
|
|
|
decide_crtc_timing_for_drm_display_mode(struct drm_display_mode *drm_mode,
|
|
|
|
const struct drm_display_mode *native_mode,
|
|
|
|
bool scale_enabled)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
if (scale_enabled) {
|
|
|
|
copy_crtc_timing_for_drm_display_mode(native_mode, drm_mode);
|
|
|
|
} else if (native_mode->clock == drm_mode->clock &&
|
|
|
|
native_mode->htotal == drm_mode->htotal &&
|
|
|
|
native_mode->vtotal == drm_mode->vtotal) {
|
|
|
|
copy_crtc_timing_for_drm_display_mode(native_mode, drm_mode);
|
|
|
|
} else {
|
|
|
|
/* no scaling nor amdgpu inserted, no need to patch */
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-05-01 15:33:25 +00:00
|
|
|
static struct dc_sink *
|
|
|
|
create_fake_sink(struct amdgpu_dm_connector *aconnector)
|
2017-08-17 18:58:07 +00:00
|
|
|
{
|
|
|
|
struct dc_sink_init_data sink_init_data = { 0 };
|
2018-05-01 15:33:25 +00:00
|
|
|
struct dc_sink *sink = NULL;
|
2017-08-17 18:58:07 +00:00
|
|
|
sink_init_data.link = aconnector->dc_link;
|
|
|
|
sink_init_data.sink_signal = aconnector->dc_link->connector_signal;
|
|
|
|
|
|
|
|
sink = dc_sink_create(&sink_init_data);
|
2017-11-07 20:06:59 +00:00
|
|
|
if (!sink) {
|
2017-08-17 18:58:07 +00:00
|
|
|
DRM_ERROR("Failed to create sink!\n");
|
2018-05-01 15:33:25 +00:00
|
|
|
return NULL;
|
2017-11-07 20:06:59 +00:00
|
|
|
}
|
2017-08-17 18:58:07 +00:00
|
|
|
sink->sink_signal = SIGNAL_TYPE_VIRTUAL;
|
2017-11-07 20:06:59 +00:00
|
|
|
|
2018-05-01 15:33:25 +00:00
|
|
|
return sink;
|
2017-08-17 18:58:07 +00:00
|
|
|
}
|
|
|
|
|
2017-10-17 19:29:22 +00:00
|
|
|
static void set_multisync_trigger_params(
|
|
|
|
struct dc_stream_state *stream)
|
|
|
|
{
|
|
|
|
if (stream->triggered_crtc_reset.enabled) {
|
|
|
|
stream->triggered_crtc_reset.event = CRTC_EVENT_VSYNC_RISING;
|
|
|
|
stream->triggered_crtc_reset.delay = TRIGGER_DELAY_NEXT_LINE;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void set_master_stream(struct dc_stream_state *stream_set[],
|
|
|
|
int stream_count)
|
|
|
|
{
|
|
|
|
int j, highest_rfr = 0, master_stream = 0;
|
|
|
|
|
|
|
|
for (j = 0; j < stream_count; j++) {
|
|
|
|
if (stream_set[j] && stream_set[j]->triggered_crtc_reset.enabled) {
|
|
|
|
int refresh_rate = 0;
|
|
|
|
|
2018-11-06 19:24:12 +00:00
|
|
|
refresh_rate = (stream_set[j]->timing.pix_clk_100hz*100)/
|
2017-10-17 19:29:22 +00:00
|
|
|
(stream_set[j]->timing.h_total*stream_set[j]->timing.v_total);
|
|
|
|
if (refresh_rate > highest_rfr) {
|
|
|
|
highest_rfr = refresh_rate;
|
|
|
|
master_stream = j;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
for (j = 0; j < stream_count; j++) {
|
2017-12-18 15:34:56 +00:00
|
|
|
if (stream_set[j])
|
2017-10-17 19:29:22 +00:00
|
|
|
stream_set[j]->triggered_crtc_reset.event_source = stream_set[master_stream];
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void dm_enable_per_frame_crtc_master_sync(struct dc_state *context)
|
|
|
|
{
|
|
|
|
int i = 0;
|
|
|
|
|
|
|
|
if (context->stream_count < 2)
|
|
|
|
return;
|
|
|
|
for (i = 0; i < context->stream_count ; i++) {
|
|
|
|
if (!context->streams[i])
|
|
|
|
continue;
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* TODO: add a function to read AMD VSDB bits and set
|
2017-10-17 19:29:22 +00:00
|
|
|
* crtc_sync_master.multi_sync_enabled flag
|
2018-08-15 18:38:30 +00:00
|
|
|
* For now it's set to false
|
2017-10-17 19:29:22 +00:00
|
|
|
*/
|
|
|
|
set_multisync_trigger_params(context->streams[i]);
|
|
|
|
}
|
|
|
|
set_master_stream(context->streams, context->stream_count);
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static struct dc_stream_state *
|
|
|
|
create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
|
|
|
|
const struct drm_display_mode *drm_mode,
|
2018-11-16 16:46:14 +00:00
|
|
|
const struct dm_connector_state *dm_state,
|
2020-04-30 08:40:09 +00:00
|
|
|
const struct dc_stream_state *old_stream,
|
|
|
|
int requested_bpc)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct drm_display_mode *preferred_mode = NULL;
|
2017-12-01 18:26:05 +00:00
|
|
|
struct drm_connector *drm_connector;
|
2019-05-22 16:00:55 +00:00
|
|
|
const struct drm_connector_state *con_state =
|
|
|
|
dm_state ? &dm_state->base : NULL;
|
2017-07-27 13:33:33 +00:00
|
|
|
struct dc_stream_state *stream = NULL;
|
2017-08-10 17:29:07 +00:00
|
|
|
struct drm_display_mode mode = *drm_mode;
|
|
|
|
bool native_mode_found = false;
|
2018-11-16 16:46:14 +00:00
|
|
|
bool scale = dm_state ? (dm_state->scaling != RMX_OFF) : false;
|
|
|
|
int mode_refresh;
|
2018-11-27 15:51:12 +00:00
|
|
|
int preferred_refresh = 0;
|
2019-11-07 01:51:14 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN)
|
2019-06-19 18:30:59 +00:00
|
|
|
struct dsc_dec_dpcd_caps dsc_caps;
|
|
|
|
#endif
|
|
|
|
uint32_t link_bandwidth_kbps;
|
2018-11-16 16:46:14 +00:00
|
|
|
|
2018-05-01 15:33:25 +00:00
|
|
|
struct dc_sink *sink = NULL;
|
2017-07-27 01:03:22 +00:00
|
|
|
if (aconnector == NULL) {
|
2017-08-10 17:29:07 +00:00
|
|
|
DRM_ERROR("aconnector is NULL!\n");
|
2017-12-18 18:46:19 +00:00
|
|
|
return stream;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
drm_connector = &aconnector->base;
|
2017-08-17 18:58:07 +00:00
|
|
|
|
2017-09-08 15:52:45 +00:00
|
|
|
if (!aconnector->dc_sink) {
|
2019-01-23 16:41:18 +00:00
|
|
|
sink = create_fake_sink(aconnector);
|
|
|
|
if (!sink)
|
|
|
|
return stream;
|
2018-05-01 15:33:25 +00:00
|
|
|
} else {
|
|
|
|
sink = aconnector->dc_sink;
|
2019-02-10 10:13:01 +00:00
|
|
|
dc_sink_retain(sink);
|
2017-09-08 15:52:45 +00:00
|
|
|
}
|
2017-08-17 18:58:07 +00:00
|
|
|
|
2018-05-01 15:33:25 +00:00
|
|
|
stream = dc_create_stream_for_sink(sink);
|
2017-09-12 19:58:20 +00:00
|
|
|
|
2017-07-27 01:03:22 +00:00
|
|
|
if (stream == NULL) {
|
2017-08-10 17:29:07 +00:00
|
|
|
DRM_ERROR("Failed to create stream for sink!\n");
|
2018-05-01 15:33:25 +00:00
|
|
|
goto finish;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
drm/amd/display: remove sink reference in dc_stream_state
[why]
dc_stream_state containing a pointer to sink is poor design.
Sink describes the display, and the specifications or capabilities
it has. That information is irrelevant for dc_stream_state, which describes
hardware state, and is generally used for hardware programming. It
could further be argued that dc_sink itself is just a convenience dc
provides, and DC should be perfectly capable of programming hardware
without any dc_sinks (for example, emulated sinks).
[how]
Phase 1:
Deprecate use of dc_sink pointer in dc_stream. Most references are trivial
to remove, but some call sites are risky (such as is_timing_changed) with
no obvious logical replacement. These will be removed in follow up change.
Add dc_link pointer to dc_stream. This is the typical reason DC really needed
sink pointer, and most call sites are replaced with this.
DMs also need minor updates, as all 3 DMs leverage stream->sink for
some functionality. this is replaced instead by a pointer to private data
inside dc_stream_state, which is used by DMs as a quality of life improvment
for some key functionality. it allows DMs to set pointers have to their own objects
which associate OS objects to dc_stream_states (such as DisplayTarget
and amdgpu_dm_connector). Without the private pointer, DMs would be
forced to perform a lookup for callbacks.
Signed-off-by: Jun Lei <Jun.Lei@amd.com>
Reviewed-by: Aric Cyr <Aric.Cyr@amd.com>
Acked-by: David Francis <David.Francis@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2018-11-09 14:21:21 +00:00
|
|
|
stream->dm_stream_context = aconnector;
|
|
|
|
|
2019-09-19 09:41:02 +00:00
|
|
|
stream->timing.flags.LTE_340MCSC_SCRAMBLE =
|
|
|
|
drm_connector->display_info.hdmi.scdc.scrambling.low_rates;
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
list_for_each_entry(preferred_mode, &aconnector->base.modes, head) {
|
|
|
|
/* Search for preferred mode */
|
|
|
|
if (preferred_mode->type & DRM_MODE_TYPE_PREFERRED) {
|
|
|
|
native_mode_found = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!native_mode_found)
|
|
|
|
preferred_mode = list_first_entry_or_null(
|
|
|
|
&aconnector->base.modes,
|
|
|
|
struct drm_display_mode,
|
|
|
|
head);
|
|
|
|
|
2018-11-16 16:46:14 +00:00
|
|
|
mode_refresh = drm_mode_vrefresh(&mode);
|
|
|
|
|
2017-07-27 01:03:22 +00:00
|
|
|
if (preferred_mode == NULL) {
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* This may not be an error, the use case is when we have no
|
2017-08-10 17:29:07 +00:00
|
|
|
* usermode calls to reset and set mode upon hotplug. In this
|
|
|
|
* case, we call set mode ourselves to restore the previous mode
|
|
|
|
* and the modelist may not be filled in in time.
|
|
|
|
*/
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("No preferred mode found\n");
|
2017-08-10 17:29:07 +00:00
|
|
|
} else {
|
|
|
|
decide_crtc_timing_for_drm_display_mode(
|
|
|
|
&mode, preferred_mode,
|
2017-12-18 18:48:12 +00:00
|
|
|
dm_state ? (dm_state->scaling != RMX_OFF) : false);
|
2018-11-27 15:51:12 +00:00
|
|
|
preferred_refresh = drm_mode_vrefresh(preferred_mode);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2018-01-17 18:24:28 +00:00
|
|
|
if (!dm_state)
|
|
|
|
drm_mode_set_crtcinfo(&mode, 0);
|
|
|
|
|
2018-11-16 16:46:14 +00:00
|
|
|
/*
|
|
|
|
* If scaling is enabled and refresh rate didn't change
|
|
|
|
* we copy the vic and polarities of the old timings
|
|
|
|
*/
|
|
|
|
if (!scale || mode_refresh != preferred_refresh)
|
|
|
|
fill_stream_properties_from_drm_display_mode(stream,
|
2020-04-30 08:40:09 +00:00
|
|
|
&mode, &aconnector->base, con_state, NULL, requested_bpc);
|
2018-11-16 16:46:14 +00:00
|
|
|
else
|
|
|
|
fill_stream_properties_from_drm_display_mode(stream,
|
2020-04-30 08:40:09 +00:00
|
|
|
&mode, &aconnector->base, con_state, old_stream, requested_bpc);
|
2018-11-16 16:46:14 +00:00
|
|
|
|
2019-06-19 18:30:59 +00:00
|
|
|
stream->timing.flags.DSC = 0;
|
|
|
|
|
|
|
|
if (aconnector->dc_link && sink->sink_signal == SIGNAL_TYPE_DISPLAY_PORT) {
|
2019-11-07 01:51:14 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN)
|
2019-12-03 22:01:12 +00:00
|
|
|
dc_dsc_parse_dsc_dpcd(aconnector->dc_link->ctx->dc,
|
|
|
|
aconnector->dc_link->dpcd_caps.dsc_caps.dsc_basic_caps.raw,
|
2020-07-07 20:59:31 +00:00
|
|
|
aconnector->dc_link->dpcd_caps.dsc_caps.dsc_branch_decoder_caps.raw,
|
2019-06-19 18:30:59 +00:00
|
|
|
&dsc_caps);
|
2019-11-07 01:51:14 +00:00
|
|
|
#endif
|
2019-06-19 18:30:59 +00:00
|
|
|
link_bandwidth_kbps = dc_link_bandwidth_kbps(aconnector->dc_link,
|
|
|
|
dc_link_get_link_cap(aconnector->dc_link));
|
|
|
|
|
2019-11-07 01:51:14 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN)
|
2019-06-19 18:30:59 +00:00
|
|
|
if (dsc_caps.is_dsc_supported)
|
2019-08-19 19:18:43 +00:00
|
|
|
if (dc_dsc_compute_config(aconnector->dc_link->ctx->dc->res_pool->dscs[0],
|
2019-06-19 18:30:59 +00:00
|
|
|
&dsc_caps,
|
2019-08-19 19:18:43 +00:00
|
|
|
aconnector->dc_link->ctx->dc->debug.dsc_min_slice_height_override,
|
2019-06-19 18:30:59 +00:00
|
|
|
link_bandwidth_kbps,
|
|
|
|
&stream->timing,
|
|
|
|
&stream->timing.dsc_cfg))
|
|
|
|
stream->timing.flags.DSC = 1;
|
2019-05-16 17:01:51 +00:00
|
|
|
#endif
|
2019-06-19 18:30:59 +00:00
|
|
|
}
|
2019-05-16 17:01:51 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
update_stream_scaling_settings(&mode, dm_state, stream);
|
|
|
|
|
|
|
|
fill_audio_info(
|
|
|
|
&stream->audio_info,
|
|
|
|
drm_connector,
|
2018-05-01 15:33:25 +00:00
|
|
|
sink);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
drm/amd/display: remove sink reference in dc_stream_state
[why]
dc_stream_state containing a pointer to sink is poor design.
Sink describes the display, and the specifications or capabilities
it has. That information is irrelevant for dc_stream_state, which describes
hardware state, and is generally used for hardware programming. It
could further be argued that dc_sink itself is just a convenience dc
provides, and DC should be perfectly capable of programming hardware
without any dc_sinks (for example, emulated sinks).
[how]
Phase 1:
Deprecate use of dc_sink pointer in dc_stream. Most references are trivial
to remove, but some call sites are risky (such as is_timing_changed) with
no obvious logical replacement. These will be removed in follow up change.
Add dc_link pointer to dc_stream. This is the typical reason DC really needed
sink pointer, and most call sites are replaced with this.
DMs also need minor updates, as all 3 DMs leverage stream->sink for
some functionality. this is replaced instead by a pointer to private data
inside dc_stream_state, which is used by DMs as a quality of life improvment
for some key functionality. it allows DMs to set pointers have to their own objects
which associate OS objects to dc_stream_states (such as DisplayTarget
and amdgpu_dm_connector). Without the private pointer, DMs would be
forced to perform a lookup for callbacks.
Signed-off-by: Jun Lei <Jun.Lei@amd.com>
Reviewed-by: Aric Cyr <Aric.Cyr@amd.com>
Acked-by: David Francis <David.Francis@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2018-11-09 14:21:21 +00:00
|
|
|
update_stream_signal(stream, sink);
|
2017-12-18 17:01:30 +00:00
|
|
|
|
2019-09-03 21:31:16 +00:00
|
|
|
if (stream->signal == SIGNAL_TYPE_HDMI_TYPE_A)
|
|
|
|
mod_build_hf_vsif_infopacket(stream, &stream->vsp_infopacket, false, false);
|
2020-06-26 14:27:31 +00:00
|
|
|
if (stream->link->psr_settings.psr_feature_enabled) {
|
|
|
|
//
|
|
|
|
// should decide stream support vsc sdp colorimetry capability
|
|
|
|
// before building vsc info packet
|
|
|
|
//
|
|
|
|
stream->use_vsc_sdp_for_colorimetry = false;
|
|
|
|
if (aconnector->dc_sink->sink_signal == SIGNAL_TYPE_DISPLAY_PORT_MST) {
|
|
|
|
stream->use_vsc_sdp_for_colorimetry =
|
|
|
|
aconnector->dc_sink->is_vsc_sdp_colorimetry_supported;
|
|
|
|
} else {
|
|
|
|
if (stream->link->dpcd_caps.dprx_feature.bits.VSC_SDP_COLORIMETRY_SUPPORTED)
|
|
|
|
stream->use_vsc_sdp_for_colorimetry = true;
|
2019-09-20 23:03:17 +00:00
|
|
|
}
|
2020-06-26 14:27:31 +00:00
|
|
|
mod_build_vsc_infopacket(stream, &stream->vsc_infopacket);
|
2019-09-20 23:03:17 +00:00
|
|
|
}
|
2018-05-01 15:33:25 +00:00
|
|
|
finish:
|
2019-02-10 10:13:01 +00:00
|
|
|
dc_sink_release(sink);
|
2018-03-15 19:08:04 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
return stream;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static void amdgpu_dm_crtc_destroy(struct drm_crtc *crtc)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
drm_crtc_cleanup(crtc);
|
|
|
|
kfree(crtc);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void dm_crtc_destroy_state(struct drm_crtc *crtc,
|
2017-10-10 21:44:52 +00:00
|
|
|
struct drm_crtc_state *state)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct dm_crtc_state *cur = to_dm_crtc_state(state);
|
|
|
|
|
|
|
|
/* TODO Destroy dc_stream objects are stream object is flattened */
|
|
|
|
if (cur->stream)
|
|
|
|
dc_stream_release(cur->stream);
|
|
|
|
|
|
|
|
|
|
|
|
__drm_atomic_helper_crtc_destroy_state(state);
|
|
|
|
|
|
|
|
|
|
|
|
kfree(state);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void dm_crtc_reset_state(struct drm_crtc *crtc)
|
|
|
|
{
|
|
|
|
struct dm_crtc_state *state;
|
|
|
|
|
|
|
|
if (crtc->state)
|
|
|
|
dm_crtc_destroy_state(crtc, crtc->state);
|
|
|
|
|
|
|
|
state = kzalloc(sizeof(*state), GFP_KERNEL);
|
|
|
|
if (WARN_ON(!state))
|
|
|
|
return;
|
|
|
|
|
2020-06-12 16:00:50 +00:00
|
|
|
__drm_atomic_helper_crtc_reset(crtc, &state->base);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct drm_crtc_state *
|
|
|
|
dm_crtc_duplicate_state(struct drm_crtc *crtc)
|
|
|
|
{
|
|
|
|
struct dm_crtc_state *state, *cur;
|
|
|
|
|
|
|
|
cur = to_dm_crtc_state(crtc->state);
|
|
|
|
|
|
|
|
if (WARN_ON(!crtc->state))
|
|
|
|
return NULL;
|
|
|
|
|
2017-09-27 14:53:50 +00:00
|
|
|
state = kzalloc(sizeof(*state), GFP_KERNEL);
|
2017-11-07 20:06:58 +00:00
|
|
|
if (!state)
|
|
|
|
return NULL;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
__drm_atomic_helper_crtc_duplicate_state(crtc, &state->base);
|
|
|
|
|
|
|
|
if (cur->stream) {
|
|
|
|
state->stream = cur->stream;
|
|
|
|
dc_stream_retain(state->stream);
|
|
|
|
}
|
|
|
|
|
2019-04-05 13:35:14 +00:00
|
|
|
state->active_planes = cur->active_planes;
|
2018-12-05 17:08:56 +00:00
|
|
|
state->vrr_params = cur->vrr_params;
|
2018-08-21 19:40:28 +00:00
|
|
|
state->vrr_infopacket = cur->vrr_infopacket;
|
2018-11-26 20:51:09 +00:00
|
|
|
state->abm_level = cur->abm_level;
|
2018-10-04 17:03:30 +00:00
|
|
|
state->vrr_supported = cur->vrr_supported;
|
|
|
|
state->freesync_config = cur->freesync_config;
|
2019-05-15 21:15:05 +00:00
|
|
|
state->crc_src = cur->crc_src;
|
2019-05-09 16:14:58 +00:00
|
|
|
state->cm_has_degamma = cur->cm_has_degamma;
|
|
|
|
state->cm_is_degamma_srgb = cur->cm_is_degamma_srgb;
|
2018-08-21 19:40:28 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
/* TODO Duplicate dc_stream after objects are stream object is flattened */
|
|
|
|
|
|
|
|
return &state->base;
|
|
|
|
}
|
|
|
|
|
2019-03-29 12:00:56 +00:00
|
|
|
static inline int dm_set_vupdate_irq(struct drm_crtc *crtc, bool enable)
|
|
|
|
{
|
|
|
|
enum dc_irq_source irq_source;
|
|
|
|
struct amdgpu_crtc *acrtc = to_amdgpu_crtc(crtc);
|
|
|
|
struct amdgpu_device *adev = crtc->dev->dev_private;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
irq_source = IRQ_TYPE_VUPDATE + acrtc->otg_inst;
|
|
|
|
|
|
|
|
rc = dc_interrupt_set(adev->dm.dc, irq_source, enable) ? 0 : -EBUSY;
|
|
|
|
|
|
|
|
DRM_DEBUG_DRIVER("crtc %d - vupdate irq %sabling: r=%d\n",
|
|
|
|
acrtc->crtc_id, enable ? "en" : "dis", rc);
|
|
|
|
return rc;
|
|
|
|
}
|
2018-02-13 15:54:26 +00:00
|
|
|
|
|
|
|
static inline int dm_set_vblank(struct drm_crtc *crtc, bool enable)
|
|
|
|
{
|
|
|
|
enum dc_irq_source irq_source;
|
|
|
|
struct amdgpu_crtc *acrtc = to_amdgpu_crtc(crtc);
|
|
|
|
struct amdgpu_device *adev = crtc->dev->dev_private;
|
2019-03-29 12:00:56 +00:00
|
|
|
struct dm_crtc_state *acrtc_state = to_dm_crtc_state(crtc->state);
|
|
|
|
int rc = 0;
|
|
|
|
|
|
|
|
if (enable) {
|
|
|
|
/* vblank irq on -> Only need vupdate irq in vrr mode */
|
|
|
|
if (amdgpu_dm_vrr_active(acrtc_state))
|
|
|
|
rc = dm_set_vupdate_irq(crtc, true);
|
|
|
|
} else {
|
|
|
|
/* vblank irq off -> vupdate irq off */
|
|
|
|
rc = dm_set_vupdate_irq(crtc, false);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (rc)
|
|
|
|
return rc;
|
2018-02-13 15:54:26 +00:00
|
|
|
|
|
|
|
irq_source = IRQ_TYPE_VBLANK + acrtc->otg_inst;
|
2018-02-13 16:03:01 +00:00
|
|
|
return dc_interrupt_set(adev->dm.dc, irq_source, enable) ? 0 : -EBUSY;
|
2018-02-13 15:54:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int dm_enable_vblank(struct drm_crtc *crtc)
|
|
|
|
{
|
|
|
|
return dm_set_vblank(crtc, true);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void dm_disable_vblank(struct drm_crtc *crtc)
|
|
|
|
{
|
|
|
|
dm_set_vblank(crtc, false);
|
|
|
|
}
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
/* Implemented only the options currently availible for the driver */
|
|
|
|
static const struct drm_crtc_funcs amdgpu_dm_crtc_funcs = {
|
|
|
|
.reset = dm_crtc_reset_state,
|
|
|
|
.destroy = amdgpu_dm_crtc_destroy,
|
|
|
|
.gamma_set = drm_atomic_helper_legacy_gamma_set,
|
|
|
|
.set_config = drm_atomic_helper_set_config,
|
|
|
|
.page_flip = drm_atomic_helper_page_flip,
|
|
|
|
.atomic_duplicate_state = dm_crtc_duplicate_state,
|
|
|
|
.atomic_destroy_state = dm_crtc_destroy_state,
|
2017-12-18 19:20:39 +00:00
|
|
|
.set_crc_source = amdgpu_dm_crtc_set_crc_source,
|
2018-07-13 13:59:36 +00:00
|
|
|
.verify_crc_source = amdgpu_dm_crtc_verify_crc_source,
|
2019-05-29 22:52:52 +00:00
|
|
|
.get_crc_sources = amdgpu_dm_crtc_get_crc_sources,
|
2020-01-23 13:59:26 +00:00
|
|
|
.get_vblank_counter = amdgpu_get_vblank_counter_kms,
|
2018-02-13 15:54:26 +00:00
|
|
|
.enable_vblank = dm_enable_vblank,
|
|
|
|
.disable_vblank = dm_disable_vblank,
|
2020-01-23 13:59:26 +00:00
|
|
|
.get_vblank_timestamp = drm_crtc_vblank_helper_get_vblank_timestamp,
|
2017-08-10 17:29:07 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static enum drm_connector_status
|
|
|
|
amdgpu_dm_connector_detect(struct drm_connector *connector, bool force)
|
|
|
|
{
|
|
|
|
bool connected;
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Notes:
|
2017-08-10 17:29:07 +00:00
|
|
|
* 1. This interface is NOT called in context of HPD irq.
|
|
|
|
* 2. This interface *is called* in context of user-mode ioctl. Which
|
2018-08-15 18:38:30 +00:00
|
|
|
* makes it a bad place for *any* MST-related activity.
|
|
|
|
*/
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-08-17 18:58:07 +00:00
|
|
|
if (aconnector->base.force == DRM_FORCE_UNSPECIFIED &&
|
|
|
|
!aconnector->fake_enable)
|
2017-08-10 17:29:07 +00:00
|
|
|
connected = (aconnector->dc_sink != NULL);
|
|
|
|
else
|
|
|
|
connected = (aconnector->base.force == DRM_FORCE_ON);
|
|
|
|
|
|
|
|
return (connected ? connector_status_connected :
|
|
|
|
connector_status_disconnected);
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
int amdgpu_dm_connector_atomic_set_property(struct drm_connector *connector,
|
|
|
|
struct drm_connector_state *connector_state,
|
|
|
|
struct drm_property *property,
|
|
|
|
uint64_t val)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct drm_device *dev = connector->dev;
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
struct dm_connector_state *dm_old_state =
|
|
|
|
to_dm_connector_state(connector->state);
|
|
|
|
struct dm_connector_state *dm_new_state =
|
|
|
|
to_dm_connector_state(connector_state);
|
|
|
|
|
|
|
|
int ret = -EINVAL;
|
|
|
|
|
|
|
|
if (property == dev->mode_config.scaling_mode_property) {
|
|
|
|
enum amdgpu_rmx_type rmx_type;
|
|
|
|
|
|
|
|
switch (val) {
|
|
|
|
case DRM_MODE_SCALE_CENTER:
|
|
|
|
rmx_type = RMX_CENTER;
|
|
|
|
break;
|
|
|
|
case DRM_MODE_SCALE_ASPECT:
|
|
|
|
rmx_type = RMX_ASPECT;
|
|
|
|
break;
|
|
|
|
case DRM_MODE_SCALE_FULLSCREEN:
|
|
|
|
rmx_type = RMX_FULL;
|
|
|
|
break;
|
|
|
|
case DRM_MODE_SCALE_NONE:
|
|
|
|
default:
|
|
|
|
rmx_type = RMX_OFF;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (dm_old_state->scaling == rmx_type)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
dm_new_state->scaling = rmx_type;
|
|
|
|
ret = 0;
|
|
|
|
} else if (property == adev->mode_info.underscan_hborder_property) {
|
|
|
|
dm_new_state->underscan_hborder = val;
|
|
|
|
ret = 0;
|
|
|
|
} else if (property == adev->mode_info.underscan_vborder_property) {
|
|
|
|
dm_new_state->underscan_vborder = val;
|
|
|
|
ret = 0;
|
|
|
|
} else if (property == adev->mode_info.underscan_property) {
|
|
|
|
dm_new_state->underscan_enable = val;
|
|
|
|
ret = 0;
|
2018-11-26 20:51:09 +00:00
|
|
|
} else if (property == adev->mode_info.abm_level_property) {
|
|
|
|
dm_new_state->abm_level = val;
|
|
|
|
ret = 0;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
int amdgpu_dm_connector_atomic_get_property(struct drm_connector *connector,
|
|
|
|
const struct drm_connector_state *state,
|
|
|
|
struct drm_property *property,
|
|
|
|
uint64_t *val)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct drm_device *dev = connector->dev;
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
struct dm_connector_state *dm_state =
|
|
|
|
to_dm_connector_state(state);
|
|
|
|
int ret = -EINVAL;
|
|
|
|
|
|
|
|
if (property == dev->mode_config.scaling_mode_property) {
|
|
|
|
switch (dm_state->scaling) {
|
|
|
|
case RMX_CENTER:
|
|
|
|
*val = DRM_MODE_SCALE_CENTER;
|
|
|
|
break;
|
|
|
|
case RMX_ASPECT:
|
|
|
|
*val = DRM_MODE_SCALE_ASPECT;
|
|
|
|
break;
|
|
|
|
case RMX_FULL:
|
|
|
|
*val = DRM_MODE_SCALE_FULLSCREEN;
|
|
|
|
break;
|
|
|
|
case RMX_OFF:
|
|
|
|
default:
|
|
|
|
*val = DRM_MODE_SCALE_NONE;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
} else if (property == adev->mode_info.underscan_hborder_property) {
|
|
|
|
*val = dm_state->underscan_hborder;
|
|
|
|
ret = 0;
|
|
|
|
} else if (property == adev->mode_info.underscan_vborder_property) {
|
|
|
|
*val = dm_state->underscan_vborder;
|
|
|
|
ret = 0;
|
|
|
|
} else if (property == adev->mode_info.underscan_property) {
|
|
|
|
*val = dm_state->underscan_enable;
|
|
|
|
ret = 0;
|
2018-11-26 20:51:09 +00:00
|
|
|
} else if (property == adev->mode_info.abm_level_property) {
|
|
|
|
*val = dm_state->abm_level;
|
|
|
|
ret = 0;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
2018-11-26 20:51:09 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2019-05-31 09:35:27 +00:00
|
|
|
static void amdgpu_dm_connector_unregister(struct drm_connector *connector)
|
|
|
|
{
|
|
|
|
struct amdgpu_dm_connector *amdgpu_dm_connector = to_amdgpu_dm_connector(connector);
|
|
|
|
|
|
|
|
drm_dp_aux_unregister(&amdgpu_dm_connector->dm_dp_aux.aux);
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static void amdgpu_dm_connector_destroy(struct drm_connector *connector)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
|
2017-08-10 17:29:07 +00:00
|
|
|
const struct dc_link *link = aconnector->dc_link;
|
|
|
|
struct amdgpu_device *adev = connector->dev->dev_private;
|
|
|
|
struct amdgpu_display_manager *dm = &adev->dm;
|
2018-04-20 14:53:50 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
#if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) ||\
|
|
|
|
defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE)
|
|
|
|
|
2018-03-12 15:16:47 +00:00
|
|
|
if ((link->connector_signal & (SIGNAL_TYPE_EDP | SIGNAL_TYPE_LVDS)) &&
|
2018-03-12 15:48:26 +00:00
|
|
|
link->type != dc_connection_none &&
|
|
|
|
dm->backlight_dev) {
|
|
|
|
backlight_device_unregister(dm->backlight_dev);
|
|
|
|
dm->backlight_dev = NULL;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
#endif
|
2019-02-10 10:13:01 +00:00
|
|
|
|
|
|
|
if (aconnector->dc_em_sink)
|
|
|
|
dc_sink_release(aconnector->dc_em_sink);
|
|
|
|
aconnector->dc_em_sink = NULL;
|
|
|
|
if (aconnector->dc_sink)
|
|
|
|
dc_sink_release(aconnector->dc_sink);
|
|
|
|
aconnector->dc_sink = NULL;
|
|
|
|
|
2018-08-27 08:08:18 +00:00
|
|
|
drm_dp_cec_unregister_connector(&aconnector->dm_dp_aux.aux);
|
2017-08-10 17:29:07 +00:00
|
|
|
drm_connector_unregister(connector);
|
|
|
|
drm_connector_cleanup(connector);
|
2019-05-31 09:35:27 +00:00
|
|
|
if (aconnector->i2c) {
|
|
|
|
i2c_del_adapter(&aconnector->i2c->base);
|
|
|
|
kfree(aconnector->i2c);
|
|
|
|
}
|
2020-04-16 18:44:52 +00:00
|
|
|
kfree(aconnector->dm_dp_aux.aux.name);
|
2019-05-31 09:35:27 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
kfree(connector);
|
|
|
|
}
|
|
|
|
|
|
|
|
void amdgpu_dm_connector_funcs_reset(struct drm_connector *connector)
|
|
|
|
{
|
|
|
|
struct dm_connector_state *state =
|
|
|
|
to_dm_connector_state(connector->state);
|
|
|
|
|
2018-05-16 14:31:30 +00:00
|
|
|
if (connector->state)
|
|
|
|
__drm_atomic_helper_connector_destroy_state(connector->state);
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
kfree(state);
|
|
|
|
|
|
|
|
state = kzalloc(sizeof(*state), GFP_KERNEL);
|
|
|
|
|
|
|
|
if (state) {
|
|
|
|
state->scaling = RMX_OFF;
|
|
|
|
state->underscan_enable = false;
|
|
|
|
state->underscan_hborder = 0;
|
|
|
|
state->underscan_vborder = 0;
|
2019-06-05 16:33:59 +00:00
|
|
|
state->base.max_requested_bpc = 8;
|
2019-11-06 19:23:55 +00:00
|
|
|
state->vcpi_slots = 0;
|
|
|
|
state->pbn = 0;
|
2019-06-06 12:53:12 +00:00
|
|
|
if (connector->connector_type == DRM_MODE_CONNECTOR_eDP)
|
|
|
|
state->abm_level = amdgpu_dm_abm_level;
|
|
|
|
|
2018-05-16 14:31:30 +00:00
|
|
|
__drm_atomic_helper_connector_reset(connector, &state->base);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
struct drm_connector_state *
|
|
|
|
amdgpu_dm_connector_atomic_duplicate_state(struct drm_connector *connector)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct dm_connector_state *state =
|
|
|
|
to_dm_connector_state(connector->state);
|
|
|
|
|
|
|
|
struct dm_connector_state *new_state =
|
|
|
|
kmemdup(state, sizeof(*state), GFP_KERNEL);
|
|
|
|
|
2018-08-21 19:40:28 +00:00
|
|
|
if (!new_state)
|
|
|
|
return NULL;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-08-21 19:40:28 +00:00
|
|
|
__drm_atomic_helper_connector_duplicate_state(connector, &new_state->base);
|
|
|
|
|
|
|
|
new_state->freesync_capable = state->freesync_capable;
|
2018-11-26 20:51:09 +00:00
|
|
|
new_state->abm_level = state->abm_level;
|
2018-12-07 15:07:09 +00:00
|
|
|
new_state->scaling = state->scaling;
|
|
|
|
new_state->underscan_enable = state->underscan_enable;
|
|
|
|
new_state->underscan_hborder = state->underscan_hborder;
|
|
|
|
new_state->underscan_vborder = state->underscan_vborder;
|
2019-11-06 19:23:55 +00:00
|
|
|
new_state->vcpi_slots = state->vcpi_slots;
|
|
|
|
new_state->pbn = state->pbn;
|
2018-08-21 19:40:28 +00:00
|
|
|
return &new_state->base;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2020-02-04 22:11:18 +00:00
|
|
|
static int
|
|
|
|
amdgpu_dm_connector_late_register(struct drm_connector *connector)
|
|
|
|
{
|
|
|
|
struct amdgpu_dm_connector *amdgpu_dm_connector =
|
|
|
|
to_amdgpu_dm_connector(connector);
|
2020-04-16 18:20:58 +00:00
|
|
|
int r;
|
2020-02-04 22:11:18 +00:00
|
|
|
|
2020-04-16 18:20:58 +00:00
|
|
|
if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) ||
|
|
|
|
(connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
|
|
|
|
amdgpu_dm_connector->dm_dp_aux.aux.dev = connector->kdev;
|
|
|
|
r = drm_dp_aux_register(&amdgpu_dm_connector->dm_dp_aux.aux);
|
|
|
|
if (r)
|
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
|
|
|
#if defined(CONFIG_DEBUG_FS)
|
2020-02-04 22:11:18 +00:00
|
|
|
connector_debugfs_init(amdgpu_dm_connector);
|
|
|
|
#endif
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
static const struct drm_connector_funcs amdgpu_dm_connector_funcs = {
|
|
|
|
.reset = amdgpu_dm_connector_funcs_reset,
|
|
|
|
.detect = amdgpu_dm_connector_detect,
|
|
|
|
.fill_modes = drm_helper_probe_single_connector_modes,
|
|
|
|
.destroy = amdgpu_dm_connector_destroy,
|
|
|
|
.atomic_duplicate_state = amdgpu_dm_connector_atomic_duplicate_state,
|
|
|
|
.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
|
|
|
|
.atomic_set_property = amdgpu_dm_connector_atomic_set_property,
|
2019-05-31 09:35:27 +00:00
|
|
|
.atomic_get_property = amdgpu_dm_connector_atomic_get_property,
|
2020-02-04 22:11:18 +00:00
|
|
|
.late_register = amdgpu_dm_connector_late_register,
|
2019-05-31 09:35:27 +00:00
|
|
|
.early_unregister = amdgpu_dm_connector_unregister
|
2017-08-10 17:29:07 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static int get_modes(struct drm_connector *connector)
|
|
|
|
{
|
|
|
|
return amdgpu_dm_connector_get_modes(connector);
|
|
|
|
}
|
|
|
|
|
2017-09-05 18:16:09 +00:00
|
|
|
static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct dc_sink_init_data init_params = {
|
|
|
|
.link = aconnector->dc_link,
|
|
|
|
.sink_signal = SIGNAL_TYPE_VIRTUAL
|
|
|
|
};
|
2017-11-10 16:19:02 +00:00
|
|
|
struct edid *edid;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-12-15 10:53:43 +00:00
|
|
|
if (!aconnector->base.edid_blob_ptr) {
|
2017-08-10 17:29:07 +00:00
|
|
|
DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
|
|
|
|
aconnector->base.name);
|
|
|
|
|
|
|
|
aconnector->base.force = DRM_FORCE_OFF;
|
|
|
|
aconnector->base.override_edid = false;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2017-11-10 16:19:02 +00:00
|
|
|
edid = (struct edid *) aconnector->base.edid_blob_ptr->data;
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
aconnector->edid = edid;
|
|
|
|
|
|
|
|
aconnector->dc_em_sink = dc_link_add_remote_sink(
|
|
|
|
aconnector->dc_link,
|
|
|
|
(uint8_t *)edid,
|
|
|
|
(edid->extensions + 1) * EDID_LENGTH,
|
|
|
|
&init_params);
|
|
|
|
|
2019-02-10 10:13:01 +00:00
|
|
|
if (aconnector->base.force == DRM_FORCE_ON) {
|
2017-08-10 17:29:07 +00:00
|
|
|
aconnector->dc_sink = aconnector->dc_link->local_sink ?
|
|
|
|
aconnector->dc_link->local_sink :
|
|
|
|
aconnector->dc_em_sink;
|
2019-02-10 10:13:01 +00:00
|
|
|
dc_sink_retain(aconnector->dc_sink);
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2017-09-05 18:16:09 +00:00
|
|
|
static void handle_edid_mgmt(struct amdgpu_dm_connector *aconnector)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct dc_link *link = (struct dc_link *)aconnector->dc_link;
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* In case of headless boot with force on for DP managed connector
|
2017-08-10 17:29:07 +00:00
|
|
|
* Those settings have to be != 0 to get initial modeset
|
|
|
|
*/
|
|
|
|
if (link->connector_signal == SIGNAL_TYPE_DISPLAY_PORT) {
|
|
|
|
link->verified_link_cap.lane_count = LANE_COUNT_FOUR;
|
|
|
|
link->verified_link_cap.link_rate = LINK_RATE_HIGH2;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
aconnector->base.override_edid = true;
|
|
|
|
create_eml_sink(aconnector);
|
|
|
|
}
|
|
|
|
|
2020-04-30 08:40:09 +00:00
|
|
|
static struct dc_stream_state *
|
|
|
|
create_validate_stream_for_sink(struct amdgpu_dm_connector *aconnector,
|
|
|
|
const struct drm_display_mode *drm_mode,
|
|
|
|
const struct dm_connector_state *dm_state,
|
|
|
|
const struct dc_stream_state *old_stream)
|
|
|
|
{
|
|
|
|
struct drm_connector *connector = &aconnector->base;
|
|
|
|
struct amdgpu_device *adev = connector->dev->dev_private;
|
|
|
|
struct dc_stream_state *stream;
|
2020-06-12 11:04:18 +00:00
|
|
|
const struct drm_connector_state *drm_state = dm_state ? &dm_state->base : NULL;
|
|
|
|
int requested_bpc = drm_state ? drm_state->max_requested_bpc : 8;
|
2020-04-30 08:40:09 +00:00
|
|
|
enum dc_status dc_result = DC_OK;
|
|
|
|
|
|
|
|
do {
|
|
|
|
stream = create_stream_for_sink(aconnector, drm_mode,
|
|
|
|
dm_state, old_stream,
|
|
|
|
requested_bpc);
|
|
|
|
if (stream == NULL) {
|
|
|
|
DRM_ERROR("Failed to create stream for sink!\n");
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
dc_result = dc_validate_stream(adev->dm.dc, stream);
|
|
|
|
|
|
|
|
if (dc_result != DC_OK) {
|
2020-05-26 20:53:38 +00:00
|
|
|
DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation with error %d (%s)\n",
|
2020-04-30 08:40:09 +00:00
|
|
|
drm_mode->hdisplay,
|
|
|
|
drm_mode->vdisplay,
|
|
|
|
drm_mode->clock,
|
2020-05-26 20:53:38 +00:00
|
|
|
dc_result,
|
|
|
|
dc_status_to_str(dc_result));
|
2020-04-30 08:40:09 +00:00
|
|
|
|
|
|
|
dc_stream_release(stream);
|
|
|
|
stream = NULL;
|
|
|
|
requested_bpc -= 2; /* lower bpc to retry validation */
|
|
|
|
}
|
|
|
|
|
|
|
|
} while (stream == NULL && requested_bpc >= 6);
|
|
|
|
|
|
|
|
return stream;
|
|
|
|
}
|
|
|
|
|
2018-04-24 13:14:18 +00:00
|
|
|
enum drm_mode_status amdgpu_dm_connector_mode_valid(struct drm_connector *connector,
|
2017-10-10 21:44:52 +00:00
|
|
|
struct drm_display_mode *mode)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
int result = MODE_ERROR;
|
|
|
|
struct dc_sink *dc_sink;
|
|
|
|
/* TODO: Unhardcode stream count */
|
2017-07-27 13:33:33 +00:00
|
|
|
struct dc_stream_state *stream;
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
if ((mode->flags & DRM_MODE_FLAG_INTERLACE) ||
|
|
|
|
(mode->flags & DRM_MODE_FLAG_DBLSCAN))
|
|
|
|
return result;
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Only run this the first time mode_valid is called to initilialize
|
2017-08-10 17:29:07 +00:00
|
|
|
* EDID mgmt
|
|
|
|
*/
|
|
|
|
if (aconnector->base.force != DRM_FORCE_UNSPECIFIED &&
|
|
|
|
!aconnector->dc_em_sink)
|
|
|
|
handle_edid_mgmt(aconnector);
|
|
|
|
|
2017-09-05 18:16:09 +00:00
|
|
|
dc_sink = to_amdgpu_dm_connector(connector)->dc_sink;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-07-27 01:03:22 +00:00
|
|
|
if (dc_sink == NULL) {
|
2017-08-10 17:29:07 +00:00
|
|
|
DRM_ERROR("dc_sink is NULL!\n");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2020-04-30 08:40:09 +00:00
|
|
|
stream = create_validate_stream_for_sink(aconnector, mode, NULL, NULL);
|
|
|
|
if (stream) {
|
|
|
|
dc_stream_release(stream);
|
2017-08-10 17:29:07 +00:00
|
|
|
result = MODE_OK;
|
2020-04-30 08:40:09 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
fail:
|
|
|
|
/* TODO: error handling*/
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2019-05-28 19:08:35 +00:00
|
|
|
static int fill_hdr_info_packet(const struct drm_connector_state *state,
|
|
|
|
struct dc_info_packet *out)
|
|
|
|
{
|
|
|
|
struct hdmi_drm_infoframe frame;
|
|
|
|
unsigned char buf[30]; /* 26 + 4 */
|
|
|
|
ssize_t len;
|
|
|
|
int ret, i;
|
|
|
|
|
|
|
|
memset(out, 0, sizeof(*out));
|
|
|
|
|
|
|
|
if (!state->hdr_output_metadata)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
ret = drm_hdmi_infoframe_set_hdr_metadata(&frame, state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
len = hdmi_drm_infoframe_pack_only(&frame, buf, sizeof(buf));
|
|
|
|
if (len < 0)
|
|
|
|
return (int)len;
|
|
|
|
|
|
|
|
/* Static metadata is a fixed 26 bytes + 4 byte header. */
|
|
|
|
if (len != 30)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
/* Prepare the infopacket for DC. */
|
|
|
|
switch (state->connector->connector_type) {
|
|
|
|
case DRM_MODE_CONNECTOR_HDMIA:
|
|
|
|
out->hb0 = 0x87; /* type */
|
|
|
|
out->hb1 = 0x01; /* version */
|
|
|
|
out->hb2 = 0x1A; /* length */
|
|
|
|
out->sb[0] = buf[3]; /* checksum */
|
|
|
|
i = 1;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case DRM_MODE_CONNECTOR_DisplayPort:
|
|
|
|
case DRM_MODE_CONNECTOR_eDP:
|
|
|
|
out->hb0 = 0x00; /* sdp id, zero */
|
|
|
|
out->hb1 = 0x87; /* type */
|
|
|
|
out->hb2 = 0x1D; /* payload len - 1 */
|
|
|
|
out->hb3 = (0x13 << 2); /* sdp version */
|
|
|
|
out->sb[0] = 0x01; /* version */
|
|
|
|
out->sb[1] = 0x1A; /* length */
|
|
|
|
i = 2;
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
memcpy(&out->sb[i], &buf[4], 26);
|
|
|
|
out->valid = true;
|
|
|
|
|
|
|
|
print_hex_dump(KERN_DEBUG, "HDR SB:", DUMP_PREFIX_NONE, 16, 1, out->sb,
|
|
|
|
sizeof(out->sb), false);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool
|
|
|
|
is_hdr_metadata_different(const struct drm_connector_state *old_state,
|
|
|
|
const struct drm_connector_state *new_state)
|
|
|
|
{
|
|
|
|
struct drm_property_blob *old_blob = old_state->hdr_output_metadata;
|
|
|
|
struct drm_property_blob *new_blob = new_state->hdr_output_metadata;
|
|
|
|
|
|
|
|
if (old_blob != new_blob) {
|
|
|
|
if (old_blob && new_blob &&
|
|
|
|
old_blob->length == new_blob->length)
|
|
|
|
return memcmp(old_blob->data, new_blob->data,
|
|
|
|
old_blob->length);
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
amdgpu_dm_connector_atomic_check(struct drm_connector *conn,
|
2019-06-14 00:27:00 +00:00
|
|
|
struct drm_atomic_state *state)
|
2019-05-28 19:08:35 +00:00
|
|
|
{
|
2019-06-14 00:27:00 +00:00
|
|
|
struct drm_connector_state *new_con_state =
|
|
|
|
drm_atomic_get_new_connector_state(state, conn);
|
2019-05-28 19:08:35 +00:00
|
|
|
struct drm_connector_state *old_con_state =
|
|
|
|
drm_atomic_get_old_connector_state(state, conn);
|
|
|
|
struct drm_crtc *crtc = new_con_state->crtc;
|
|
|
|
struct drm_crtc_state *new_crtc_state;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (!crtc)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (is_hdr_metadata_different(old_con_state, new_con_state)) {
|
|
|
|
struct dc_info_packet hdr_infopacket;
|
|
|
|
|
|
|
|
ret = fill_hdr_info_packet(new_con_state, &hdr_infopacket);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
new_crtc_state = drm_atomic_get_crtc_state(state, crtc);
|
|
|
|
if (IS_ERR(new_crtc_state))
|
|
|
|
return PTR_ERR(new_crtc_state);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* DC considers the stream backends changed if the
|
|
|
|
* static metadata changes. Forcing the modeset also
|
|
|
|
* gives a simple way for userspace to switch from
|
2019-05-28 19:08:36 +00:00
|
|
|
* 8bpc to 10bpc when setting the metadata to enter
|
|
|
|
* or exit HDR.
|
|
|
|
*
|
|
|
|
* Changing the static metadata after it's been
|
|
|
|
* set is permissible, however. So only force a
|
|
|
|
* modeset if we're entering or exiting HDR.
|
2019-05-28 19:08:35 +00:00
|
|
|
*/
|
2019-05-28 19:08:36 +00:00
|
|
|
new_crtc_state->mode_changed =
|
|
|
|
!old_con_state->hdr_output_metadata ||
|
|
|
|
!new_con_state->hdr_output_metadata;
|
2019-05-28 19:08:35 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
static const struct drm_connector_helper_funcs
|
|
|
|
amdgpu_dm_connector_helper_funcs = {
|
|
|
|
/*
|
2018-08-15 18:38:30 +00:00
|
|
|
* If hotplugging a second bigger display in FB Con mode, bigger resolution
|
2017-07-27 01:03:22 +00:00
|
|
|
* modes will be filtered by drm_mode_validate_size(), and those modes
|
2018-08-15 18:38:30 +00:00
|
|
|
* are missing after user start lightdm. So we need to renew modes list.
|
2017-07-27 01:03:22 +00:00
|
|
|
* in get_modes call back, not just return the modes count
|
|
|
|
*/
|
2017-08-10 17:29:07 +00:00
|
|
|
.get_modes = get_modes,
|
|
|
|
.mode_valid = amdgpu_dm_connector_mode_valid,
|
2019-05-28 19:08:35 +00:00
|
|
|
.atomic_check = amdgpu_dm_connector_atomic_check,
|
2017-08-10 17:29:07 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static void dm_crtc_helper_disable(struct drm_crtc *crtc)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
2019-04-05 13:35:14 +00:00
|
|
|
static int count_crtc_active_planes(struct drm_crtc_state *new_crtc_state)
|
2019-03-29 18:58:32 +00:00
|
|
|
{
|
|
|
|
struct drm_atomic_state *state = new_crtc_state->state;
|
|
|
|
struct drm_plane *plane;
|
|
|
|
int num_active = 0;
|
|
|
|
|
|
|
|
drm_for_each_plane_mask(plane, state->dev, new_crtc_state->plane_mask) {
|
|
|
|
struct drm_plane_state *new_plane_state;
|
|
|
|
|
|
|
|
/* Cursor planes are "fake". */
|
|
|
|
if (plane->type == DRM_PLANE_TYPE_CURSOR)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
new_plane_state = drm_atomic_get_new_plane_state(state, plane);
|
|
|
|
|
|
|
|
if (!new_plane_state) {
|
|
|
|
/*
|
|
|
|
* The plane is enable on the CRTC and hasn't changed
|
|
|
|
* state. This means that it previously passed
|
|
|
|
* validation and is therefore enabled.
|
|
|
|
*/
|
|
|
|
num_active += 1;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* We need a framebuffer to be considered enabled. */
|
|
|
|
num_active += (new_plane_state->fb != NULL);
|
|
|
|
}
|
|
|
|
|
2019-04-05 13:35:14 +00:00
|
|
|
return num_active;
|
|
|
|
}
|
|
|
|
|
2020-07-13 14:41:23 +00:00
|
|
|
static void dm_update_crtc_active_planes(struct drm_crtc *crtc,
|
|
|
|
struct drm_crtc_state *new_crtc_state)
|
2019-04-05 13:35:14 +00:00
|
|
|
{
|
|
|
|
struct dm_crtc_state *dm_new_crtc_state =
|
|
|
|
to_dm_crtc_state(new_crtc_state);
|
|
|
|
|
|
|
|
dm_new_crtc_state->active_planes = 0;
|
|
|
|
|
|
|
|
if (!dm_new_crtc_state->stream)
|
|
|
|
return;
|
|
|
|
|
|
|
|
dm_new_crtc_state->active_planes =
|
|
|
|
count_crtc_active_planes(new_crtc_state);
|
2019-03-29 18:58:32 +00:00
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static int dm_crtc_helper_atomic_check(struct drm_crtc *crtc,
|
|
|
|
struct drm_crtc_state *state)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = crtc->dev->dev_private;
|
|
|
|
struct dc *dc = adev->dm.dc;
|
|
|
|
struct dm_crtc_state *dm_crtc_state = to_dm_crtc_state(state);
|
|
|
|
int ret = -EINVAL;
|
|
|
|
|
2020-07-13 14:41:23 +00:00
|
|
|
dm_update_crtc_active_planes(crtc, state);
|
2019-04-05 13:35:14 +00:00
|
|
|
|
2017-07-28 17:11:00 +00:00
|
|
|
if (unlikely(!dm_crtc_state->stream &&
|
|
|
|
modeset_required(state, NULL, dm_crtc_state->stream))) {
|
2017-08-10 17:29:07 +00:00
|
|
|
WARN_ON(1);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2019-04-04 15:00:53 +00:00
|
|
|
/*
|
2020-09-04 10:43:04 +00:00
|
|
|
* We require the primary plane to be enabled whenever the CRTC is, otherwise
|
|
|
|
* drm_mode_cursor_universal may end up trying to enable the cursor plane while all other
|
|
|
|
* planes are disabled, which is not supported by the hardware. And there is legacy
|
|
|
|
* userspace which stops using the HW cursor altogether in response to the resulting EINVAL.
|
2019-04-04 15:00:53 +00:00
|
|
|
*/
|
2020-09-04 10:43:04 +00:00
|
|
|
if (state->enable &&
|
|
|
|
!(state->plane_mask & drm_plane_mask(crtc->primary)))
|
2019-03-29 18:58:32 +00:00
|
|
|
return -EINVAL;
|
|
|
|
|
2020-09-04 10:43:04 +00:00
|
|
|
/* In some use cases, like reset, no stream is attached */
|
|
|
|
if (!dm_crtc_state->stream)
|
|
|
|
return 0;
|
|
|
|
|
2017-10-10 18:01:33 +00:00
|
|
|
if (dc_validate_stream(dc, dm_crtc_state->stream) == DC_OK)
|
2017-08-10 17:29:07 +00:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static bool dm_crtc_helper_mode_fixup(struct drm_crtc *crtc,
|
|
|
|
const struct drm_display_mode *mode,
|
|
|
|
struct drm_display_mode *adjusted_mode)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct drm_crtc_helper_funcs amdgpu_dm_crtc_helper_funcs = {
|
|
|
|
.disable = dm_crtc_helper_disable,
|
|
|
|
.atomic_check = dm_crtc_helper_atomic_check,
|
2020-01-23 13:59:25 +00:00
|
|
|
.mode_fixup = dm_crtc_helper_mode_fixup,
|
|
|
|
.get_scanout_position = amdgpu_crtc_get_scanout_position,
|
2017-08-10 17:29:07 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static void dm_encoder_helper_disable(struct drm_encoder *encoder)
|
|
|
|
{
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2019-11-06 19:23:55 +00:00
|
|
|
static int convert_dc_color_depth_into_bpc (enum dc_color_depth display_color_depth)
|
|
|
|
{
|
|
|
|
switch (display_color_depth) {
|
|
|
|
case COLOR_DEPTH_666:
|
|
|
|
return 6;
|
|
|
|
case COLOR_DEPTH_888:
|
|
|
|
return 8;
|
|
|
|
case COLOR_DEPTH_101010:
|
|
|
|
return 10;
|
|
|
|
case COLOR_DEPTH_121212:
|
|
|
|
return 12;
|
|
|
|
case COLOR_DEPTH_141414:
|
|
|
|
return 14;
|
|
|
|
case COLOR_DEPTH_161616:
|
|
|
|
return 16;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static int dm_encoder_helper_atomic_check(struct drm_encoder *encoder,
|
|
|
|
struct drm_crtc_state *crtc_state,
|
|
|
|
struct drm_connector_state *conn_state)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2019-11-06 19:23:55 +00:00
|
|
|
struct drm_atomic_state *state = crtc_state->state;
|
|
|
|
struct drm_connector *connector = conn_state->connector;
|
|
|
|
struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
|
|
|
|
struct dm_connector_state *dm_new_connector_state = to_dm_connector_state(conn_state);
|
|
|
|
const struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode;
|
|
|
|
struct drm_dp_mst_topology_mgr *mst_mgr;
|
|
|
|
struct drm_dp_mst_port *mst_port;
|
|
|
|
enum dc_color_depth color_depth;
|
|
|
|
int clock, bpp = 0;
|
2019-09-20 07:40:55 +00:00
|
|
|
bool is_y420 = false;
|
2019-11-06 19:23:55 +00:00
|
|
|
|
|
|
|
if (!aconnector->port || !aconnector->dc_sink)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
mst_port = aconnector->port;
|
|
|
|
mst_mgr = &aconnector->mst_port->mst_mgr;
|
|
|
|
|
|
|
|
if (!crtc_state->connectors_changed && !crtc_state->mode_changed)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (!state->duplicated) {
|
2020-04-30 08:40:09 +00:00
|
|
|
int max_bpc = conn_state->max_requested_bpc;
|
2019-09-20 07:40:55 +00:00
|
|
|
is_y420 = drm_mode_is_420_also(&connector->display_info, adjusted_mode) &&
|
|
|
|
aconnector->force_yuv420_output;
|
2020-04-30 08:40:09 +00:00
|
|
|
color_depth = convert_color_depth_from_display_info(connector,
|
|
|
|
is_y420,
|
|
|
|
max_bpc);
|
2019-11-06 19:23:55 +00:00
|
|
|
bpp = convert_dc_color_depth_into_bpc(color_depth) * 3;
|
|
|
|
clock = adjusted_mode->clock;
|
2019-08-21 14:33:26 +00:00
|
|
|
dm_new_connector_state->pbn = drm_dp_calc_pbn_mode(clock, bpp, false);
|
2019-11-06 19:23:55 +00:00
|
|
|
}
|
|
|
|
dm_new_connector_state->vcpi_slots = drm_dp_atomic_find_vcpi_slots(state,
|
|
|
|
mst_mgr,
|
|
|
|
mst_port,
|
2019-11-14 21:24:29 +00:00
|
|
|
dm_new_connector_state->pbn,
|
2020-06-01 14:26:11 +00:00
|
|
|
dm_mst_get_pbn_divider(aconnector->dc_link));
|
2019-11-06 19:23:55 +00:00
|
|
|
if (dm_new_connector_state->vcpi_slots < 0) {
|
|
|
|
DRM_DEBUG_ATOMIC("failed finding vcpi slots: %d\n", (int)dm_new_connector_state->vcpi_slots);
|
|
|
|
return dm_new_connector_state->vcpi_slots;
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
const struct drm_encoder_helper_funcs amdgpu_dm_encoder_helper_funcs = {
|
|
|
|
.disable = dm_encoder_helper_disable,
|
|
|
|
.atomic_check = dm_encoder_helper_atomic_check
|
|
|
|
};
|
|
|
|
|
2020-01-08 04:04:04 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN)
|
2019-11-12 19:52:14 +00:00
|
|
|
static int dm_update_mst_vcpi_slots_for_dsc(struct drm_atomic_state *state,
|
|
|
|
struct dc_state *dc_state)
|
|
|
|
{
|
|
|
|
struct dc_stream_state *stream = NULL;
|
|
|
|
struct drm_connector *connector;
|
|
|
|
struct drm_connector_state *new_con_state, *old_con_state;
|
|
|
|
struct amdgpu_dm_connector *aconnector;
|
|
|
|
struct dm_connector_state *dm_conn_state;
|
|
|
|
int i, j, clock, bpp;
|
|
|
|
int vcpi, pbn_div, pbn = 0;
|
|
|
|
|
|
|
|
for_each_oldnew_connector_in_state(state, connector, old_con_state, new_con_state, i) {
|
|
|
|
|
|
|
|
aconnector = to_amdgpu_dm_connector(connector);
|
|
|
|
|
|
|
|
if (!aconnector->port)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!new_con_state || !new_con_state->crtc)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
dm_conn_state = to_dm_connector_state(new_con_state);
|
|
|
|
|
|
|
|
for (j = 0; j < dc_state->stream_count; j++) {
|
|
|
|
stream = dc_state->streams[j];
|
|
|
|
if (!stream)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if ((struct amdgpu_dm_connector*)stream->dm_stream_context == aconnector)
|
|
|
|
break;
|
|
|
|
|
|
|
|
stream = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!stream)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (stream->timing.flags.DSC != 1) {
|
|
|
|
drm_dp_mst_atomic_enable_dsc(state,
|
|
|
|
aconnector->port,
|
|
|
|
dm_conn_state->pbn,
|
|
|
|
0,
|
|
|
|
false);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
pbn_div = dm_mst_get_pbn_divider(stream->link);
|
|
|
|
bpp = stream->timing.dsc_cfg.bits_per_pixel;
|
|
|
|
clock = stream->timing.pix_clk_100hz / 10;
|
|
|
|
pbn = drm_dp_calc_pbn_mode(clock, bpp, true);
|
|
|
|
vcpi = drm_dp_mst_atomic_enable_dsc(state,
|
|
|
|
aconnector->port,
|
|
|
|
pbn, pbn_div,
|
|
|
|
true);
|
|
|
|
if (vcpi < 0)
|
|
|
|
return vcpi;
|
|
|
|
|
|
|
|
dm_conn_state->pbn = pbn;
|
|
|
|
dm_conn_state->vcpi_slots = vcpi;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
2020-01-08 04:04:04 +00:00
|
|
|
#endif
|
2019-11-12 19:52:14 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
static void dm_drm_plane_reset(struct drm_plane *plane)
|
|
|
|
{
|
|
|
|
struct dm_plane_state *amdgpu_state = NULL;
|
|
|
|
|
|
|
|
if (plane->state)
|
|
|
|
plane->funcs->atomic_destroy_state(plane, plane->state);
|
|
|
|
|
|
|
|
amdgpu_state = kzalloc(sizeof(*amdgpu_state), GFP_KERNEL);
|
2017-10-17 14:16:39 +00:00
|
|
|
WARN_ON(amdgpu_state == NULL);
|
2018-08-15 18:38:30 +00:00
|
|
|
|
2019-02-28 18:38:13 +00:00
|
|
|
if (amdgpu_state)
|
|
|
|
__drm_atomic_helper_plane_reset(plane, &amdgpu_state->base);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct drm_plane_state *
|
|
|
|
dm_drm_plane_duplicate_state(struct drm_plane *plane)
|
|
|
|
{
|
|
|
|
struct dm_plane_state *dm_plane_state, *old_dm_plane_state;
|
|
|
|
|
|
|
|
old_dm_plane_state = to_dm_plane_state(plane->state);
|
|
|
|
dm_plane_state = kzalloc(sizeof(*dm_plane_state), GFP_KERNEL);
|
|
|
|
if (!dm_plane_state)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
__drm_atomic_helper_plane_duplicate_state(plane, &dm_plane_state->base);
|
|
|
|
|
2017-07-27 13:55:38 +00:00
|
|
|
if (old_dm_plane_state->dc_state) {
|
|
|
|
dm_plane_state->dc_state = old_dm_plane_state->dc_state;
|
|
|
|
dc_plane_state_retain(dm_plane_state->dc_state);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return &dm_plane_state->base;
|
|
|
|
}
|
|
|
|
|
2020-06-18 13:07:13 +00:00
|
|
|
static void dm_drm_plane_destroy_state(struct drm_plane *plane,
|
2017-10-10 21:44:52 +00:00
|
|
|
struct drm_plane_state *state)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct dm_plane_state *dm_plane_state = to_dm_plane_state(state);
|
|
|
|
|
2017-07-27 13:55:38 +00:00
|
|
|
if (dm_plane_state->dc_state)
|
|
|
|
dc_plane_state_release(dm_plane_state->dc_state);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-08-05 14:30:11 +00:00
|
|
|
drm_atomic_helper_plane_destroy_state(plane, state);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static const struct drm_plane_funcs dm_plane_funcs = {
|
|
|
|
.update_plane = drm_atomic_helper_update_plane,
|
|
|
|
.disable_plane = drm_atomic_helper_disable_plane,
|
2018-10-07 14:01:23 +00:00
|
|
|
.destroy = drm_primary_helper_destroy,
|
2017-08-10 17:29:07 +00:00
|
|
|
.reset = dm_drm_plane_reset,
|
|
|
|
.atomic_duplicate_state = dm_drm_plane_duplicate_state,
|
|
|
|
.atomic_destroy_state = dm_drm_plane_destroy_state,
|
|
|
|
};
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static int dm_plane_helper_prepare_fb(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *new_state)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_framebuffer *afb;
|
|
|
|
struct drm_gem_object *obj;
|
2017-10-26 16:06:23 +00:00
|
|
|
struct amdgpu_device *adev;
|
2017-08-10 17:29:07 +00:00
|
|
|
struct amdgpu_bo *rbo;
|
|
|
|
struct dm_plane_state *dm_plane_state_new, *dm_plane_state_old;
|
2019-05-07 11:45:31 +00:00
|
|
|
struct list_head list;
|
|
|
|
struct ttm_validate_buffer tv;
|
|
|
|
struct ww_acquire_ctx ticket;
|
2019-03-11 13:38:35 +00:00
|
|
|
uint64_t tiling_flags;
|
2017-10-26 16:06:23 +00:00
|
|
|
uint32_t domain;
|
|
|
|
int r;
|
2020-04-22 21:54:55 +00:00
|
|
|
bool tmz_surface = false;
|
2020-04-22 21:43:26 +00:00
|
|
|
bool force_disable_dcc = false;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
dm_plane_state_old = to_dm_plane_state(plane->state);
|
|
|
|
dm_plane_state_new = to_dm_plane_state(new_state);
|
|
|
|
|
|
|
|
if (!new_state->fb) {
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("No FB bound\n");
|
2017-08-10 17:29:07 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
afb = to_amdgpu_framebuffer(new_state->fb);
|
2018-03-30 14:11:38 +00:00
|
|
|
obj = new_state->fb->obj[0];
|
2017-08-10 17:29:07 +00:00
|
|
|
rbo = gem_to_amdgpu_bo(obj);
|
2017-10-26 16:06:23 +00:00
|
|
|
adev = amdgpu_ttm_adev(rbo->tbo.bdev);
|
2019-05-07 11:45:31 +00:00
|
|
|
INIT_LIST_HEAD(&list);
|
|
|
|
|
|
|
|
tv.bo = &rbo->tbo;
|
|
|
|
tv.num_shared = 1;
|
|
|
|
list_add(&tv.head, &list);
|
|
|
|
|
2019-09-19 10:56:15 +00:00
|
|
|
r = ttm_eu_reserve_buffers(&ticket, &list, false, NULL);
|
2019-05-07 11:45:31 +00:00
|
|
|
if (r) {
|
|
|
|
dev_err(adev->dev, "fail to reserve bo (%d)\n", r);
|
2017-08-10 17:29:07 +00:00
|
|
|
return r;
|
2019-05-07 11:45:31 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-10-26 16:06:23 +00:00
|
|
|
if (plane->type != DRM_PLANE_TYPE_CURSOR)
|
2019-07-26 13:24:35 +00:00
|
|
|
domain = amdgpu_display_supported_domains(adev, rbo->flags);
|
2017-10-26 16:06:23 +00:00
|
|
|
else
|
|
|
|
domain = AMDGPU_GEM_DOMAIN_VRAM;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-06-25 04:51:14 +00:00
|
|
|
r = amdgpu_bo_pin(rbo, domain);
|
2017-08-10 17:29:07 +00:00
|
|
|
if (unlikely(r != 0)) {
|
2017-10-26 19:35:14 +00:00
|
|
|
if (r != -ERESTARTSYS)
|
|
|
|
DRM_ERROR("Failed to pin framebuffer with error %d\n", r);
|
2019-05-07 11:45:31 +00:00
|
|
|
ttm_eu_backoff_reservation(&ticket, &list);
|
2017-08-10 17:29:07 +00:00
|
|
|
return r;
|
|
|
|
}
|
|
|
|
|
2018-06-25 05:32:24 +00:00
|
|
|
r = amdgpu_ttm_alloc_gart(&rbo->tbo);
|
|
|
|
if (unlikely(r != 0)) {
|
|
|
|
amdgpu_bo_unpin(rbo);
|
2019-05-07 11:45:31 +00:00
|
|
|
ttm_eu_backoff_reservation(&ticket, &list);
|
2018-06-25 05:32:24 +00:00
|
|
|
DRM_ERROR("%p bind failed\n", rbo);
|
2017-08-10 17:29:07 +00:00
|
|
|
return r;
|
|
|
|
}
|
2019-01-02 20:15:41 +00:00
|
|
|
|
|
|
|
amdgpu_bo_get_tiling_flags(rbo, &tiling_flags);
|
|
|
|
|
2020-04-22 21:54:55 +00:00
|
|
|
tmz_surface = amdgpu_bo_encrypted(rbo);
|
|
|
|
|
2019-05-07 11:45:31 +00:00
|
|
|
ttm_eu_backoff_reservation(&ticket, &list);
|
2018-06-25 05:32:24 +00:00
|
|
|
|
2018-06-25 04:51:14 +00:00
|
|
|
afb->address = amdgpu_bo_gpu_offset(rbo);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
amdgpu_bo_ref(rbo);
|
|
|
|
|
2017-07-27 13:55:38 +00:00
|
|
|
if (dm_plane_state_new->dc_state &&
|
|
|
|
dm_plane_state_old->dc_state != dm_plane_state_new->dc_state) {
|
|
|
|
struct dc_plane_state *plane_state = dm_plane_state_new->dc_state;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2020-04-22 21:43:26 +00:00
|
|
|
force_disable_dcc = adev->asic_type == CHIP_RAVEN && adev->in_suspend;
|
2019-03-28 13:46:23 +00:00
|
|
|
fill_plane_buffer_attributes(
|
2019-03-28 18:45:19 +00:00
|
|
|
adev, afb, plane_state->format, plane_state->rotation,
|
|
|
|
tiling_flags, &plane_state->tiling_info,
|
2019-03-28 13:46:23 +00:00
|
|
|
&plane_state->plane_size, &plane_state->dcc,
|
2020-04-22 21:54:55 +00:00
|
|
|
&plane_state->address, tmz_surface,
|
2020-04-22 21:43:26 +00:00
|
|
|
force_disable_dcc);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static void dm_plane_helper_cleanup_fb(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *old_state)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_bo *rbo;
|
|
|
|
int r;
|
|
|
|
|
|
|
|
if (!old_state->fb)
|
|
|
|
return;
|
|
|
|
|
2018-03-30 14:11:38 +00:00
|
|
|
rbo = gem_to_amdgpu_bo(old_state->fb->obj[0]);
|
2017-08-10 17:29:07 +00:00
|
|
|
r = amdgpu_bo_reserve(rbo, false);
|
|
|
|
if (unlikely(r)) {
|
|
|
|
DRM_ERROR("failed to reserve rbo before unpin\n");
|
|
|
|
return;
|
2017-07-27 01:03:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
amdgpu_bo_unpin(rbo);
|
|
|
|
amdgpu_bo_unreserve(rbo);
|
|
|
|
amdgpu_bo_unref(&rbo);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2020-06-04 19:54:39 +00:00
|
|
|
static int dm_plane_helper_check_state(struct drm_plane_state *state,
|
|
|
|
struct drm_crtc_state *new_crtc_state)
|
|
|
|
{
|
|
|
|
int max_downscale = 0;
|
|
|
|
int max_upscale = INT_MAX;
|
|
|
|
|
|
|
|
/* TODO: These should be checked against DC plane caps */
|
|
|
|
return drm_atomic_helper_check_plane_state(
|
|
|
|
state, new_crtc_state, max_downscale, max_upscale, true, true);
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static int dm_plane_atomic_check(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *state)
|
2017-07-26 19:52:28 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = plane->dev->dev_private;
|
|
|
|
struct dc *dc = adev->dm.dc;
|
2019-03-25 16:06:23 +00:00
|
|
|
struct dm_plane_state *dm_plane_state;
|
2019-03-28 18:45:19 +00:00
|
|
|
struct dc_scaling_info scaling_info;
|
2020-06-04 19:54:39 +00:00
|
|
|
struct drm_crtc_state *new_crtc_state;
|
2019-03-28 18:45:19 +00:00
|
|
|
int ret;
|
2019-03-25 16:06:23 +00:00
|
|
|
|
|
|
|
dm_plane_state = to_dm_plane_state(state);
|
2017-07-26 19:52:28 +00:00
|
|
|
|
2017-07-27 13:55:38 +00:00
|
|
|
if (!dm_plane_state->dc_state)
|
2017-07-31 17:15:04 +00:00
|
|
|
return 0;
|
2017-07-26 19:52:28 +00:00
|
|
|
|
2020-06-04 19:54:39 +00:00
|
|
|
new_crtc_state =
|
|
|
|
drm_atomic_get_new_crtc_state(state->state, state->crtc);
|
|
|
|
if (!new_crtc_state)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
ret = dm_plane_helper_check_state(state, new_crtc_state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
ret = fill_dc_scaling_info(state, &scaling_info);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2018-02-13 08:45:17 +00:00
|
|
|
|
2017-10-10 18:01:33 +00:00
|
|
|
if (dc_validate_plane(dc, dm_plane_state->dc_state) == DC_OK)
|
2017-07-26 19:52:28 +00:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2018-12-05 19:59:07 +00:00
|
|
|
static int dm_plane_atomic_async_check(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *new_plane_state)
|
|
|
|
{
|
|
|
|
/* Only support async updates on cursor planes. */
|
|
|
|
if (plane->type != DRM_PLANE_TYPE_CURSOR)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void dm_plane_atomic_async_update(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *new_state)
|
|
|
|
{
|
|
|
|
struct drm_plane_state *old_state =
|
|
|
|
drm_atomic_get_old_plane_state(new_state->state, plane);
|
|
|
|
|
2019-06-03 16:56:07 +00:00
|
|
|
swap(plane->state->fb, new_state->fb);
|
2018-12-05 19:59:07 +00:00
|
|
|
|
|
|
|
plane->state->src_x = new_state->src_x;
|
|
|
|
plane->state->src_y = new_state->src_y;
|
|
|
|
plane->state->src_w = new_state->src_w;
|
|
|
|
plane->state->src_h = new_state->src_h;
|
|
|
|
plane->state->crtc_x = new_state->crtc_x;
|
|
|
|
plane->state->crtc_y = new_state->crtc_y;
|
|
|
|
plane->state->crtc_w = new_state->crtc_w;
|
|
|
|
plane->state->crtc_h = new_state->crtc_h;
|
|
|
|
|
|
|
|
handle_cursor_update(plane, old_state);
|
|
|
|
}
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
static const struct drm_plane_helper_funcs dm_plane_helper_funcs = {
|
|
|
|
.prepare_fb = dm_plane_helper_prepare_fb,
|
|
|
|
.cleanup_fb = dm_plane_helper_cleanup_fb,
|
2017-07-26 19:52:28 +00:00
|
|
|
.atomic_check = dm_plane_atomic_check,
|
2018-12-05 19:59:07 +00:00
|
|
|
.atomic_async_check = dm_plane_atomic_async_check,
|
|
|
|
.atomic_async_update = dm_plane_atomic_async_update
|
2017-08-10 17:29:07 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* TODO: these are currently initialized to rgb formats only.
|
|
|
|
* For future use cases we should either initialize them dynamically based on
|
|
|
|
* plane capabilities, or initialize this array to all formats, so internal drm
|
2018-08-15 18:38:30 +00:00
|
|
|
* check will succeed, and let DC implement proper check
|
2017-08-10 17:29:07 +00:00
|
|
|
*/
|
2017-09-29 00:32:24 +00:00
|
|
|
static const uint32_t rgb_formats[] = {
|
2017-08-10 17:29:07 +00:00
|
|
|
DRM_FORMAT_XRGB8888,
|
|
|
|
DRM_FORMAT_ARGB8888,
|
|
|
|
DRM_FORMAT_RGBA8888,
|
|
|
|
DRM_FORMAT_XRGB2101010,
|
|
|
|
DRM_FORMAT_XBGR2101010,
|
|
|
|
DRM_FORMAT_ARGB2101010,
|
|
|
|
DRM_FORMAT_ABGR2101010,
|
2018-08-12 19:43:01 +00:00
|
|
|
DRM_FORMAT_XBGR8888,
|
|
|
|
DRM_FORMAT_ABGR8888,
|
2019-04-15 14:27:50 +00:00
|
|
|
DRM_FORMAT_RGB565,
|
2017-08-10 17:29:07 +00:00
|
|
|
};
|
|
|
|
|
2019-01-18 18:57:14 +00:00
|
|
|
static const uint32_t overlay_formats[] = {
|
|
|
|
DRM_FORMAT_XRGB8888,
|
|
|
|
DRM_FORMAT_ARGB8888,
|
|
|
|
DRM_FORMAT_RGBA8888,
|
|
|
|
DRM_FORMAT_XBGR8888,
|
|
|
|
DRM_FORMAT_ABGR8888,
|
2019-04-23 13:26:43 +00:00
|
|
|
DRM_FORMAT_RGB565
|
2017-08-10 17:29:07 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static const u32 cursor_formats[] = {
|
|
|
|
DRM_FORMAT_ARGB8888
|
|
|
|
};
|
|
|
|
|
2019-03-15 19:45:34 +00:00
|
|
|
static int get_plane_formats(const struct drm_plane *plane,
|
|
|
|
const struct dc_plane_cap *plane_cap,
|
|
|
|
uint32_t *formats, int max_formats)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2019-03-15 19:45:34 +00:00
|
|
|
int i, num_formats = 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* TODO: Query support for each group of formats directly from
|
|
|
|
* DC plane caps. This will require adding more formats to the
|
|
|
|
* caps list.
|
|
|
|
*/
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-10-05 15:58:34 +00:00
|
|
|
switch (plane->type) {
|
2017-08-10 17:29:07 +00:00
|
|
|
case DRM_PLANE_TYPE_PRIMARY:
|
2019-03-15 19:45:34 +00:00
|
|
|
for (i = 0; i < ARRAY_SIZE(rgb_formats); ++i) {
|
|
|
|
if (num_formats >= max_formats)
|
|
|
|
break;
|
|
|
|
|
|
|
|
formats[num_formats++] = rgb_formats[i];
|
|
|
|
}
|
|
|
|
|
2019-03-26 21:32:59 +00:00
|
|
|
if (plane_cap && plane_cap->pixel_format_support.nv12)
|
2019-03-15 19:45:34 +00:00
|
|
|
formats[num_formats++] = DRM_FORMAT_NV12;
|
2020-03-06 14:55:29 +00:00
|
|
|
if (plane_cap && plane_cap->pixel_format_support.p010)
|
|
|
|
formats[num_formats++] = DRM_FORMAT_P010;
|
2020-04-21 12:47:41 +00:00
|
|
|
if (plane_cap && plane_cap->pixel_format_support.fp16) {
|
|
|
|
formats[num_formats++] = DRM_FORMAT_XRGB16161616F;
|
|
|
|
formats[num_formats++] = DRM_FORMAT_ARGB16161616F;
|
2020-05-15 05:19:23 +00:00
|
|
|
formats[num_formats++] = DRM_FORMAT_XBGR16161616F;
|
|
|
|
formats[num_formats++] = DRM_FORMAT_ABGR16161616F;
|
2020-04-21 12:47:41 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
break;
|
2019-03-15 19:45:34 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
case DRM_PLANE_TYPE_OVERLAY:
|
2019-03-15 19:45:34 +00:00
|
|
|
for (i = 0; i < ARRAY_SIZE(overlay_formats); ++i) {
|
|
|
|
if (num_formats >= max_formats)
|
|
|
|
break;
|
|
|
|
|
|
|
|
formats[num_formats++] = overlay_formats[i];
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
break;
|
2019-03-15 19:45:34 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
case DRM_PLANE_TYPE_CURSOR:
|
2019-03-15 19:45:34 +00:00
|
|
|
for (i = 0; i < ARRAY_SIZE(cursor_formats); ++i) {
|
|
|
|
if (num_formats >= max_formats)
|
|
|
|
break;
|
|
|
|
|
|
|
|
formats[num_formats++] = cursor_formats[i];
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2019-03-15 19:45:34 +00:00
|
|
|
return num_formats;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int amdgpu_dm_plane_init(struct amdgpu_display_manager *dm,
|
|
|
|
struct drm_plane *plane,
|
|
|
|
unsigned long possible_crtcs,
|
|
|
|
const struct dc_plane_cap *plane_cap)
|
|
|
|
{
|
|
|
|
uint32_t formats[32];
|
|
|
|
int num_formats;
|
|
|
|
int res = -EPERM;
|
2019-09-12 16:44:04 +00:00
|
|
|
unsigned int supported_rotations;
|
2019-03-15 19:45:34 +00:00
|
|
|
|
|
|
|
num_formats = get_plane_formats(plane, plane_cap, formats,
|
|
|
|
ARRAY_SIZE(formats));
|
|
|
|
|
|
|
|
res = drm_universal_plane_init(dm->adev->ddev, plane, possible_crtcs,
|
|
|
|
&dm_plane_funcs, formats, num_formats,
|
|
|
|
NULL, plane->type, NULL);
|
|
|
|
if (res)
|
|
|
|
return res;
|
|
|
|
|
2019-03-14 19:58:51 +00:00
|
|
|
if (plane->type == DRM_PLANE_TYPE_OVERLAY &&
|
|
|
|
plane_cap && plane_cap->per_pixel_alpha) {
|
2019-02-21 19:57:48 +00:00
|
|
|
unsigned int blend_caps = BIT(DRM_MODE_BLEND_PIXEL_NONE) |
|
|
|
|
BIT(DRM_MODE_BLEND_PREMULTI);
|
|
|
|
|
|
|
|
drm_plane_create_alpha_property(plane);
|
|
|
|
drm_plane_create_blend_mode_property(plane, blend_caps);
|
|
|
|
}
|
|
|
|
|
2019-03-15 19:55:43 +00:00
|
|
|
if (plane->type == DRM_PLANE_TYPE_PRIMARY &&
|
2020-03-13 14:21:38 +00:00
|
|
|
plane_cap &&
|
|
|
|
(plane_cap->pixel_format_support.nv12 ||
|
|
|
|
plane_cap->pixel_format_support.p010)) {
|
2019-03-15 19:55:43 +00:00
|
|
|
/* This only affects YUV formats. */
|
|
|
|
drm_plane_create_color_properties(
|
|
|
|
plane,
|
|
|
|
BIT(DRM_COLOR_YCBCR_BT601) |
|
2020-03-13 14:21:38 +00:00
|
|
|
BIT(DRM_COLOR_YCBCR_BT709) |
|
|
|
|
BIT(DRM_COLOR_YCBCR_BT2020),
|
2019-03-15 19:55:43 +00:00
|
|
|
BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) |
|
|
|
|
BIT(DRM_COLOR_YCBCR_FULL_RANGE),
|
|
|
|
DRM_COLOR_YCBCR_BT709, DRM_COLOR_YCBCR_LIMITED_RANGE);
|
|
|
|
}
|
|
|
|
|
2019-09-12 16:44:04 +00:00
|
|
|
supported_rotations =
|
|
|
|
DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_90 |
|
|
|
|
DRM_MODE_ROTATE_180 | DRM_MODE_ROTATE_270;
|
|
|
|
|
|
|
|
drm_plane_create_rotation_property(plane, DRM_MODE_ROTATE_0,
|
|
|
|
supported_rotations);
|
|
|
|
|
2018-10-05 15:58:34 +00:00
|
|
|
drm_plane_helper_add(plane, &dm_plane_helper_funcs);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-10-20 12:43:40 +00:00
|
|
|
/* Create (reset) the plane state */
|
2018-10-05 15:58:34 +00:00
|
|
|
if (plane->funcs->reset)
|
|
|
|
plane->funcs->reset(plane);
|
2017-10-20 12:43:40 +00:00
|
|
|
|
2019-03-15 19:45:34 +00:00
|
|
|
return 0;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static int amdgpu_dm_crtc_init(struct amdgpu_display_manager *dm,
|
|
|
|
struct drm_plane *plane,
|
|
|
|
uint32_t crtc_index)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_crtc *acrtc = NULL;
|
2018-10-05 15:58:34 +00:00
|
|
|
struct drm_plane *cursor_plane;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
int res = -ENOMEM;
|
|
|
|
|
|
|
|
cursor_plane = kzalloc(sizeof(*cursor_plane), GFP_KERNEL);
|
|
|
|
if (!cursor_plane)
|
|
|
|
goto fail;
|
|
|
|
|
2018-10-05 15:58:34 +00:00
|
|
|
cursor_plane->type = DRM_PLANE_TYPE_CURSOR;
|
2019-03-14 19:58:51 +00:00
|
|
|
res = amdgpu_dm_plane_init(dm, cursor_plane, 0, NULL);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
acrtc = kzalloc(sizeof(struct amdgpu_crtc), GFP_KERNEL);
|
|
|
|
if (!acrtc)
|
|
|
|
goto fail;
|
|
|
|
|
|
|
|
res = drm_crtc_init_with_planes(
|
|
|
|
dm->ddev,
|
|
|
|
&acrtc->base,
|
|
|
|
plane,
|
2018-10-05 15:58:34 +00:00
|
|
|
cursor_plane,
|
2017-08-10 17:29:07 +00:00
|
|
|
&amdgpu_dm_crtc_funcs, NULL);
|
|
|
|
|
|
|
|
if (res)
|
|
|
|
goto fail;
|
|
|
|
|
|
|
|
drm_crtc_helper_add(&acrtc->base, &amdgpu_dm_crtc_helper_funcs);
|
|
|
|
|
2017-10-20 12:43:40 +00:00
|
|
|
/* Create (reset) the plane state */
|
|
|
|
if (acrtc->base.funcs->reset)
|
|
|
|
acrtc->base.funcs->reset(&acrtc->base);
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
acrtc->max_cursor_width = dm->adev->dm.dc->caps.max_cursor_size;
|
|
|
|
acrtc->max_cursor_height = dm->adev->dm.dc->caps.max_cursor_size;
|
|
|
|
|
|
|
|
acrtc->crtc_id = crtc_index;
|
|
|
|
acrtc->base.enabled = false;
|
2018-09-12 20:38:57 +00:00
|
|
|
acrtc->otg_inst = -1;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
dm->adev->mode_info.crtcs[crtc_index] = acrtc;
|
2018-01-30 16:14:27 +00:00
|
|
|
drm_crtc_enable_color_mgmt(&acrtc->base, MAX_COLOR_LUT_ENTRIES,
|
|
|
|
true, MAX_COLOR_LUT_ENTRIES);
|
2018-02-12 18:20:56 +00:00
|
|
|
drm_mode_crtc_set_gamma_size(&acrtc->base, MAX_COLOR_LEGACY_LUT_ENTRIES);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
fail:
|
2017-07-27 01:03:22 +00:00
|
|
|
kfree(acrtc);
|
|
|
|
kfree(cursor_plane);
|
2017-08-10 17:29:07 +00:00
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int to_drm_connector_type(enum signal_type st)
|
|
|
|
{
|
|
|
|
switch (st) {
|
|
|
|
case SIGNAL_TYPE_HDMI_TYPE_A:
|
|
|
|
return DRM_MODE_CONNECTOR_HDMIA;
|
|
|
|
case SIGNAL_TYPE_EDP:
|
|
|
|
return DRM_MODE_CONNECTOR_eDP;
|
2018-08-14 19:53:52 +00:00
|
|
|
case SIGNAL_TYPE_LVDS:
|
|
|
|
return DRM_MODE_CONNECTOR_LVDS;
|
2017-08-10 17:29:07 +00:00
|
|
|
case SIGNAL_TYPE_RGB:
|
|
|
|
return DRM_MODE_CONNECTOR_VGA;
|
|
|
|
case SIGNAL_TYPE_DISPLAY_PORT:
|
|
|
|
case SIGNAL_TYPE_DISPLAY_PORT_MST:
|
|
|
|
return DRM_MODE_CONNECTOR_DisplayPort;
|
|
|
|
case SIGNAL_TYPE_DVI_DUAL_LINK:
|
|
|
|
case SIGNAL_TYPE_DVI_SINGLE_LINK:
|
|
|
|
return DRM_MODE_CONNECTOR_DVID;
|
|
|
|
case SIGNAL_TYPE_VIRTUAL:
|
|
|
|
return DRM_MODE_CONNECTOR_VIRTUAL;
|
|
|
|
|
|
|
|
default:
|
|
|
|
return DRM_MODE_CONNECTOR_Unknown;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-10-04 20:24:26 +00:00
|
|
|
static struct drm_encoder *amdgpu_dm_connector_to_encoder(struct drm_connector *connector)
|
|
|
|
{
|
2019-09-13 23:28:57 +00:00
|
|
|
struct drm_encoder *encoder;
|
|
|
|
|
|
|
|
/* There is only one encoder per connector */
|
|
|
|
drm_connector_for_each_possible_encoder(connector, encoder)
|
|
|
|
return encoder;
|
|
|
|
|
|
|
|
return NULL;
|
2018-10-04 20:24:26 +00:00
|
|
|
}
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
static void amdgpu_dm_get_native_mode(struct drm_connector *connector)
|
|
|
|
{
|
|
|
|
struct drm_encoder *encoder;
|
|
|
|
struct amdgpu_encoder *amdgpu_encoder;
|
|
|
|
|
2018-10-04 20:24:26 +00:00
|
|
|
encoder = amdgpu_dm_connector_to_encoder(connector);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
if (encoder == NULL)
|
|
|
|
return;
|
|
|
|
|
|
|
|
amdgpu_encoder = to_amdgpu_encoder(encoder);
|
|
|
|
|
|
|
|
amdgpu_encoder->native_mode.clock = 0;
|
|
|
|
|
|
|
|
if (!list_empty(&connector->probed_modes)) {
|
|
|
|
struct drm_display_mode *preferred_mode = NULL;
|
2017-07-27 01:03:22 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
list_for_each_entry(preferred_mode,
|
2017-07-27 01:03:22 +00:00
|
|
|
&connector->probed_modes,
|
|
|
|
head) {
|
|
|
|
if (preferred_mode->type & DRM_MODE_TYPE_PREFERRED)
|
|
|
|
amdgpu_encoder->native_mode = *preferred_mode;
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static struct drm_display_mode *
|
|
|
|
amdgpu_dm_create_common_mode(struct drm_encoder *encoder,
|
|
|
|
char *name,
|
|
|
|
int hdisplay, int vdisplay)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct drm_device *dev = encoder->dev;
|
|
|
|
struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
|
|
|
|
struct drm_display_mode *mode = NULL;
|
|
|
|
struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
|
|
|
|
|
|
|
|
mode = drm_mode_duplicate(dev, native_mode);
|
|
|
|
|
2017-07-27 01:03:22 +00:00
|
|
|
if (mode == NULL)
|
2017-08-10 17:29:07 +00:00
|
|
|
return NULL;
|
|
|
|
|
|
|
|
mode->hdisplay = hdisplay;
|
|
|
|
mode->vdisplay = vdisplay;
|
|
|
|
mode->type &= ~DRM_MODE_TYPE_PREFERRED;
|
2018-07-20 14:17:29 +00:00
|
|
|
strscpy(mode->name, name, DRM_DISPLAY_MODE_LEN);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
return mode;
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
static void amdgpu_dm_connector_add_common_modes(struct drm_encoder *encoder,
|
2017-10-10 21:44:52 +00:00
|
|
|
struct drm_connector *connector)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
|
|
|
|
struct drm_display_mode *mode = NULL;
|
|
|
|
struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *amdgpu_dm_connector =
|
|
|
|
to_amdgpu_dm_connector(connector);
|
2017-08-10 17:29:07 +00:00
|
|
|
int i;
|
|
|
|
int n;
|
|
|
|
struct mode_size {
|
|
|
|
char name[DRM_DISPLAY_MODE_LEN];
|
|
|
|
int w;
|
|
|
|
int h;
|
2017-07-27 01:03:22 +00:00
|
|
|
} common_modes[] = {
|
2017-08-10 17:29:07 +00:00
|
|
|
{ "640x480", 640, 480},
|
|
|
|
{ "800x600", 800, 600},
|
|
|
|
{ "1024x768", 1024, 768},
|
|
|
|
{ "1280x720", 1280, 720},
|
|
|
|
{ "1280x800", 1280, 800},
|
|
|
|
{"1280x1024", 1280, 1024},
|
|
|
|
{ "1440x900", 1440, 900},
|
|
|
|
{"1680x1050", 1680, 1050},
|
|
|
|
{"1600x1200", 1600, 1200},
|
|
|
|
{"1920x1080", 1920, 1080},
|
|
|
|
{"1920x1200", 1920, 1200}
|
|
|
|
};
|
|
|
|
|
2017-07-27 01:03:22 +00:00
|
|
|
n = ARRAY_SIZE(common_modes);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
for (i = 0; i < n; i++) {
|
|
|
|
struct drm_display_mode *curmode = NULL;
|
|
|
|
bool mode_existed = false;
|
|
|
|
|
|
|
|
if (common_modes[i].w > native_mode->hdisplay ||
|
2017-07-27 01:03:22 +00:00
|
|
|
common_modes[i].h > native_mode->vdisplay ||
|
|
|
|
(common_modes[i].w == native_mode->hdisplay &&
|
|
|
|
common_modes[i].h == native_mode->vdisplay))
|
|
|
|
continue;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
list_for_each_entry(curmode, &connector->probed_modes, head) {
|
|
|
|
if (common_modes[i].w == curmode->hdisplay &&
|
2017-07-27 01:03:22 +00:00
|
|
|
common_modes[i].h == curmode->vdisplay) {
|
2017-08-10 17:29:07 +00:00
|
|
|
mode_existed = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (mode_existed)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
mode = amdgpu_dm_create_common_mode(encoder,
|
|
|
|
common_modes[i].name, common_modes[i].w,
|
|
|
|
common_modes[i].h);
|
|
|
|
drm_mode_probed_add(connector, mode);
|
2017-09-05 18:16:09 +00:00
|
|
|
amdgpu_dm_connector->num_modes++;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static void amdgpu_dm_connector_ddc_get_modes(struct drm_connector *connector,
|
|
|
|
struct edid *edid)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *amdgpu_dm_connector =
|
|
|
|
to_amdgpu_dm_connector(connector);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
if (edid) {
|
|
|
|
/* empty probed_modes */
|
|
|
|
INIT_LIST_HEAD(&connector->probed_modes);
|
2017-09-05 18:16:09 +00:00
|
|
|
amdgpu_dm_connector->num_modes =
|
2017-08-10 17:29:07 +00:00
|
|
|
drm_add_edid_modes(connector, edid);
|
|
|
|
|
2019-05-17 10:16:58 +00:00
|
|
|
/* sorting the probed modes before calling function
|
|
|
|
* amdgpu_dm_get_native_mode() since EDID can have
|
|
|
|
* more than one preferred mode. The modes that are
|
|
|
|
* later in the probed mode list could be of higher
|
|
|
|
* and preferred resolution. For example, 3840x2160
|
|
|
|
* resolution in base EDID preferred timing and 4096x2160
|
|
|
|
* preferred resolution in DID extension block later.
|
|
|
|
*/
|
|
|
|
drm_mode_sort(&connector->probed_modes);
|
2017-08-10 17:29:07 +00:00
|
|
|
amdgpu_dm_get_native_mode(connector);
|
2017-10-17 14:38:27 +00:00
|
|
|
} else {
|
2017-09-05 18:16:09 +00:00
|
|
|
amdgpu_dm_connector->num_modes = 0;
|
2017-10-17 14:38:27 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static int amdgpu_dm_connector_get_modes(struct drm_connector *connector)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *amdgpu_dm_connector =
|
|
|
|
to_amdgpu_dm_connector(connector);
|
2017-08-10 17:29:07 +00:00
|
|
|
struct drm_encoder *encoder;
|
2017-09-05 18:16:09 +00:00
|
|
|
struct edid *edid = amdgpu_dm_connector->edid;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-10-04 20:24:26 +00:00
|
|
|
encoder = amdgpu_dm_connector_to_encoder(connector);
|
2018-02-06 23:47:26 +00:00
|
|
|
|
2018-05-28 14:08:30 +00:00
|
|
|
if (!edid || !drm_edid_is_valid(edid)) {
|
2018-07-26 20:27:48 +00:00
|
|
|
amdgpu_dm_connector->num_modes =
|
|
|
|
drm_add_modes_noedid(connector, 640, 480);
|
2018-05-28 14:08:30 +00:00
|
|
|
} else {
|
|
|
|
amdgpu_dm_connector_ddc_get_modes(connector, edid);
|
|
|
|
amdgpu_dm_connector_add_common_modes(encoder, connector);
|
|
|
|
}
|
2018-02-06 23:47:26 +00:00
|
|
|
amdgpu_dm_fbc_init(connector);
|
2018-05-31 14:09:59 +00:00
|
|
|
|
2017-09-05 18:16:09 +00:00
|
|
|
return amdgpu_dm_connector->num_modes;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
void amdgpu_dm_connector_init_helper(struct amdgpu_display_manager *dm,
|
|
|
|
struct amdgpu_dm_connector *aconnector,
|
|
|
|
int connector_type,
|
|
|
|
struct dc_link *link,
|
|
|
|
int link_index)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = dm->ddev->dev_private;
|
|
|
|
|
2019-06-04 19:21:14 +00:00
|
|
|
/*
|
|
|
|
* Some of the properties below require access to state, like bpc.
|
|
|
|
* Allocate some default initial connector state with our reset helper.
|
|
|
|
*/
|
|
|
|
if (aconnector->base.funcs->reset)
|
|
|
|
aconnector->base.funcs->reset(&aconnector->base);
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
aconnector->connector_id = link_index;
|
|
|
|
aconnector->dc_link = link;
|
|
|
|
aconnector->base.interlace_allowed = false;
|
|
|
|
aconnector->base.doublescan_allowed = false;
|
|
|
|
aconnector->base.stereo_allowed = false;
|
|
|
|
aconnector->base.dpms = DRM_MODE_DPMS_OFF;
|
|
|
|
aconnector->hpd.hpd = AMDGPU_HPD_NONE; /* not used */
|
2019-07-11 19:31:46 +00:00
|
|
|
aconnector->audio_inst = -1;
|
2017-08-10 17:29:07 +00:00
|
|
|
mutex_init(&aconnector->hpd_lock);
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* configure support HPD hot plug connector_>polled default value is 0
|
2017-07-27 01:03:22 +00:00
|
|
|
* which means HPD hot plug not supported
|
|
|
|
*/
|
2017-08-10 17:29:07 +00:00
|
|
|
switch (connector_type) {
|
|
|
|
case DRM_MODE_CONNECTOR_HDMIA:
|
|
|
|
aconnector->base.polled = DRM_CONNECTOR_POLL_HPD;
|
2018-06-22 21:12:47 +00:00
|
|
|
aconnector->base.ycbcr_420_allowed =
|
2018-09-25 19:56:41 +00:00
|
|
|
link->link_enc->features.hdmi_ycbcr420_supported ? true : false;
|
2017-08-10 17:29:07 +00:00
|
|
|
break;
|
|
|
|
case DRM_MODE_CONNECTOR_DisplayPort:
|
|
|
|
aconnector->base.polled = DRM_CONNECTOR_POLL_HPD;
|
2018-06-22 21:12:47 +00:00
|
|
|
aconnector->base.ycbcr_420_allowed =
|
2018-09-25 19:56:41 +00:00
|
|
|
link->link_enc->features.dp_ycbcr420_supported ? true : false;
|
2017-08-10 17:29:07 +00:00
|
|
|
break;
|
|
|
|
case DRM_MODE_CONNECTOR_DVID:
|
|
|
|
aconnector->base.polled = DRM_CONNECTOR_POLL_HPD;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
drm_object_attach_property(&aconnector->base.base,
|
|
|
|
dm->ddev->mode_config.scaling_mode_property,
|
|
|
|
DRM_MODE_SCALE_NONE);
|
|
|
|
|
|
|
|
drm_object_attach_property(&aconnector->base.base,
|
|
|
|
adev->mode_info.underscan_property,
|
|
|
|
UNDERSCAN_OFF);
|
|
|
|
drm_object_attach_property(&aconnector->base.base,
|
|
|
|
adev->mode_info.underscan_hborder_property,
|
|
|
|
0);
|
|
|
|
drm_object_attach_property(&aconnector->base.base,
|
|
|
|
adev->mode_info.underscan_vborder_property,
|
|
|
|
0);
|
2019-05-22 16:00:54 +00:00
|
|
|
|
2020-04-05 20:41:09 +00:00
|
|
|
if (!aconnector->mst_port)
|
|
|
|
drm_connector_attach_max_bpc_property(&aconnector->base, 8, 16);
|
2019-05-22 16:00:54 +00:00
|
|
|
|
2019-11-22 15:58:10 +00:00
|
|
|
/* This defaults to the max in the range, but we want 8bpc for non-edp. */
|
|
|
|
aconnector->base.state->max_bpc = (connector_type == DRM_MODE_CONNECTOR_eDP) ? 16 : 8;
|
|
|
|
aconnector->base.state->max_requested_bpc = aconnector->base.state->max_bpc;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-11-26 20:51:09 +00:00
|
|
|
if (connector_type == DRM_MODE_CONNECTOR_eDP &&
|
2020-07-10 14:33:05 +00:00
|
|
|
(dc_is_dmcu_initialized(adev->dm.dc) || adev->dm.dc->ctx->dmub_srv)) {
|
2018-11-26 20:51:09 +00:00
|
|
|
drm_object_attach_property(&aconnector->base.base,
|
|
|
|
adev->mode_info.abm_level_property, 0);
|
|
|
|
}
|
2018-10-04 17:03:30 +00:00
|
|
|
|
|
|
|
if (connector_type == DRM_MODE_CONNECTOR_HDMIA ||
|
2019-01-31 18:58:21 +00:00
|
|
|
connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
|
|
|
|
connector_type == DRM_MODE_CONNECTOR_eDP) {
|
2019-05-28 19:08:35 +00:00
|
|
|
drm_object_attach_property(
|
|
|
|
&aconnector->base.base,
|
|
|
|
dm->ddev->mode_config.hdr_output_metadata_property, 0);
|
|
|
|
|
2020-04-05 20:41:09 +00:00
|
|
|
if (!aconnector->mst_port)
|
|
|
|
drm_connector_attach_vrr_capable_property(&aconnector->base);
|
|
|
|
|
2019-09-16 20:52:58 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
2020-02-18 18:20:30 +00:00
|
|
|
if (adev->dm.hdcp_workqueue)
|
2019-08-16 18:49:05 +00:00
|
|
|
drm_connector_attach_content_protection_property(&aconnector->base, true);
|
2019-09-16 20:52:58 +00:00
|
|
|
#endif
|
2018-10-04 17:03:30 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static int amdgpu_dm_i2c_xfer(struct i2c_adapter *i2c_adap,
|
|
|
|
struct i2c_msg *msgs, int num)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_i2c_adapter *i2c = i2c_get_adapdata(i2c_adap);
|
|
|
|
struct ddc_service *ddc_service = i2c->ddc_service;
|
|
|
|
struct i2c_command cmd;
|
|
|
|
int i;
|
|
|
|
int result = -EIO;
|
|
|
|
|
2017-07-27 01:03:22 +00:00
|
|
|
cmd.payloads = kcalloc(num, sizeof(struct i2c_payload), GFP_KERNEL);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
if (!cmd.payloads)
|
|
|
|
return result;
|
|
|
|
|
|
|
|
cmd.number_of_payloads = num;
|
|
|
|
cmd.engine = I2C_COMMAND_ENGINE_DEFAULT;
|
|
|
|
cmd.speed = 100;
|
|
|
|
|
|
|
|
for (i = 0; i < num; i++) {
|
|
|
|
cmd.payloads[i].write = !(msgs[i].flags & I2C_M_RD);
|
|
|
|
cmd.payloads[i].address = msgs[i].addr;
|
|
|
|
cmd.payloads[i].length = msgs[i].len;
|
|
|
|
cmd.payloads[i].data = msgs[i].buf;
|
|
|
|
}
|
|
|
|
|
2018-07-23 18:12:10 +00:00
|
|
|
if (dc_submit_i2c(
|
|
|
|
ddc_service->ctx->dc,
|
|
|
|
ddc_service->ddc_pin->hw_info.ddc_channel,
|
2017-08-10 17:29:07 +00:00
|
|
|
&cmd))
|
|
|
|
result = num;
|
|
|
|
|
|
|
|
kfree(cmd.payloads);
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static u32 amdgpu_dm_i2c_func(struct i2c_adapter *adap)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct i2c_algorithm amdgpu_dm_i2c_algo = {
|
|
|
|
.master_xfer = amdgpu_dm_i2c_xfer,
|
|
|
|
.functionality = amdgpu_dm_i2c_func,
|
|
|
|
};
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static struct amdgpu_i2c_adapter *
|
|
|
|
create_i2c(struct ddc_service *ddc_service,
|
|
|
|
int link_index,
|
|
|
|
int *res)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = ddc_service->ctx->driver_context;
|
|
|
|
struct amdgpu_i2c_adapter *i2c;
|
|
|
|
|
2017-07-27 01:03:22 +00:00
|
|
|
i2c = kzalloc(sizeof(struct amdgpu_i2c_adapter), GFP_KERNEL);
|
2017-11-07 20:06:58 +00:00
|
|
|
if (!i2c)
|
|
|
|
return NULL;
|
2017-08-10 17:29:07 +00:00
|
|
|
i2c->base.owner = THIS_MODULE;
|
|
|
|
i2c->base.class = I2C_CLASS_DDC;
|
|
|
|
i2c->base.dev.parent = &adev->pdev->dev;
|
|
|
|
i2c->base.algo = &amdgpu_dm_i2c_algo;
|
2017-07-27 01:03:22 +00:00
|
|
|
snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index);
|
2017-08-10 17:29:07 +00:00
|
|
|
i2c_set_adapdata(&i2c->base, i2c);
|
|
|
|
i2c->ddc_service = ddc_service;
|
2018-07-23 18:12:10 +00:00
|
|
|
i2c->ddc_service->ddc_pin->hw_info.ddc_channel = link_index;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
return i2c;
|
|
|
|
}
|
|
|
|
|
2018-03-12 15:16:47 +00:00
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Note: this function assumes that dc_link_detect() was called for the
|
2017-07-27 01:03:22 +00:00
|
|
|
* dc_link which will be represented by this aconnector.
|
|
|
|
*/
|
2017-10-10 21:51:02 +00:00
|
|
|
static int amdgpu_dm_connector_init(struct amdgpu_display_manager *dm,
|
|
|
|
struct amdgpu_dm_connector *aconnector,
|
|
|
|
uint32_t link_index,
|
|
|
|
struct amdgpu_encoder *aencoder)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
int res = 0;
|
|
|
|
int connector_type;
|
|
|
|
struct dc *dc = dm->dc;
|
|
|
|
struct dc_link *link = dc_get_link_at_index(dc, link_index);
|
|
|
|
struct amdgpu_i2c_adapter *i2c;
|
2017-10-17 14:40:08 +00:00
|
|
|
|
|
|
|
link->priv = aconnector;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("%s()\n", __func__);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
i2c = create_i2c(link->ddc, link->link_index, &res);
|
2017-11-07 20:06:58 +00:00
|
|
|
if (!i2c) {
|
|
|
|
DRM_ERROR("Failed to create i2c adapter data\n");
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
aconnector->i2c = i2c;
|
|
|
|
res = i2c_add_adapter(&i2c->base);
|
|
|
|
|
|
|
|
if (res) {
|
|
|
|
DRM_ERROR("Failed to register hw i2c %d\n", link->link_index);
|
|
|
|
goto out_free;
|
|
|
|
}
|
|
|
|
|
|
|
|
connector_type = to_drm_connector_type(link->connector_signal);
|
|
|
|
|
2019-08-26 19:25:45 +00:00
|
|
|
res = drm_connector_init_with_ddc(
|
2017-08-10 17:29:07 +00:00
|
|
|
dm->ddev,
|
|
|
|
&aconnector->base,
|
|
|
|
&amdgpu_dm_connector_funcs,
|
2019-08-26 19:25:45 +00:00
|
|
|
connector_type,
|
|
|
|
&i2c->base);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
if (res) {
|
|
|
|
DRM_ERROR("connector_init failed\n");
|
|
|
|
aconnector->connector_id = -1;
|
|
|
|
goto out_free;
|
|
|
|
}
|
|
|
|
|
|
|
|
drm_connector_helper_add(
|
|
|
|
&aconnector->base,
|
|
|
|
&amdgpu_dm_connector_helper_funcs);
|
|
|
|
|
|
|
|
amdgpu_dm_connector_init_helper(
|
|
|
|
dm,
|
|
|
|
aconnector,
|
|
|
|
connector_type,
|
|
|
|
link,
|
|
|
|
link_index);
|
|
|
|
|
2018-07-09 08:40:07 +00:00
|
|
|
drm_connector_attach_encoder(
|
2017-08-10 17:29:07 +00:00
|
|
|
&aconnector->base, &aencoder->base);
|
|
|
|
|
|
|
|
if (connector_type == DRM_MODE_CONNECTOR_DisplayPort
|
|
|
|
|| connector_type == DRM_MODE_CONNECTOR_eDP)
|
2020-04-16 18:44:52 +00:00
|
|
|
amdgpu_dm_initialize_dp_connector(dm, aconnector, link->link_index);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
out_free:
|
|
|
|
if (res) {
|
|
|
|
kfree(i2c);
|
|
|
|
aconnector->i2c = NULL;
|
|
|
|
}
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
int amdgpu_dm_get_encoder_crtc_mask(struct amdgpu_device *adev)
|
|
|
|
{
|
|
|
|
switch (adev->mode_info.num_crtc) {
|
|
|
|
case 1:
|
|
|
|
return 0x1;
|
|
|
|
case 2:
|
|
|
|
return 0x3;
|
|
|
|
case 3:
|
|
|
|
return 0x7;
|
|
|
|
case 4:
|
|
|
|
return 0xf;
|
|
|
|
case 5:
|
|
|
|
return 0x1f;
|
|
|
|
case 6:
|
|
|
|
default:
|
|
|
|
return 0x3f;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static int amdgpu_dm_encoder_init(struct drm_device *dev,
|
|
|
|
struct amdgpu_encoder *aencoder,
|
|
|
|
uint32_t link_index)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
|
|
|
|
int res = drm_encoder_init(dev,
|
|
|
|
&aencoder->base,
|
|
|
|
&amdgpu_dm_encoder_funcs,
|
|
|
|
DRM_MODE_ENCODER_TMDS,
|
|
|
|
NULL);
|
|
|
|
|
|
|
|
aencoder->base.possible_crtcs = amdgpu_dm_get_encoder_crtc_mask(adev);
|
|
|
|
|
|
|
|
if (!res)
|
|
|
|
aencoder->encoder_id = link_index;
|
|
|
|
else
|
|
|
|
aencoder->encoder_id = -1;
|
|
|
|
|
|
|
|
drm_encoder_helper_add(&aencoder->base, &amdgpu_dm_encoder_helper_funcs);
|
|
|
|
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static void manage_dm_interrupts(struct amdgpu_device *adev,
|
|
|
|
struct amdgpu_crtc *acrtc,
|
|
|
|
bool enable)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
/*
|
2020-07-13 14:41:23 +00:00
|
|
|
* We have no guarantee that the frontend index maps to the same
|
|
|
|
* backend index - some even map to more than one.
|
|
|
|
*
|
|
|
|
* TODO: Use a different interrupt or check DC itself for the mapping.
|
2017-08-10 17:29:07 +00:00
|
|
|
*/
|
|
|
|
int irq_type =
|
2018-01-19 21:06:41 +00:00
|
|
|
amdgpu_display_crtc_idx_to_irq_type(
|
2017-08-10 17:29:07 +00:00
|
|
|
adev,
|
|
|
|
acrtc->crtc_id);
|
|
|
|
|
|
|
|
if (enable) {
|
|
|
|
drm_crtc_vblank_on(&acrtc->base);
|
|
|
|
amdgpu_irq_get(
|
|
|
|
adev,
|
|
|
|
&adev->pageflip_irq,
|
|
|
|
irq_type);
|
|
|
|
} else {
|
|
|
|
|
|
|
|
amdgpu_irq_put(
|
|
|
|
adev,
|
|
|
|
&adev->pageflip_irq,
|
|
|
|
irq_type);
|
|
|
|
drm_crtc_vblank_off(&acrtc->base);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-07-13 14:41:23 +00:00
|
|
|
static void dm_update_pflip_irq_state(struct amdgpu_device *adev,
|
|
|
|
struct amdgpu_crtc *acrtc)
|
|
|
|
{
|
|
|
|
int irq_type =
|
|
|
|
amdgpu_display_crtc_idx_to_irq_type(adev, acrtc->crtc_id);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This reads the current state for the IRQ and force reapplies
|
|
|
|
* the setting to hardware.
|
|
|
|
*/
|
|
|
|
amdgpu_irq_update(adev, &adev->pageflip_irq, irq_type);
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static bool
|
|
|
|
is_scaling_state_different(const struct dm_connector_state *dm_state,
|
|
|
|
const struct dm_connector_state *old_dm_state)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
if (dm_state->scaling != old_dm_state->scaling)
|
|
|
|
return true;
|
|
|
|
if (!dm_state->underscan_enable && old_dm_state->underscan_enable) {
|
|
|
|
if (old_dm_state->underscan_hborder != 0 && old_dm_state->underscan_vborder != 0)
|
|
|
|
return true;
|
|
|
|
} else if (dm_state->underscan_enable && !old_dm_state->underscan_enable) {
|
|
|
|
if (dm_state->underscan_hborder != 0 && dm_state->underscan_vborder != 0)
|
|
|
|
return true;
|
2017-07-27 01:03:22 +00:00
|
|
|
} else if (dm_state->underscan_hborder != old_dm_state->underscan_hborder ||
|
|
|
|
dm_state->underscan_vborder != old_dm_state->underscan_vborder)
|
|
|
|
return true;
|
2017-08-10 17:29:07 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2019-09-16 20:52:58 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
|
|
|
static bool is_content_protection_different(struct drm_connector_state *state,
|
|
|
|
const struct drm_connector_state *old_state,
|
|
|
|
const struct drm_connector *connector, struct hdcp_workqueue *hdcp_w)
|
|
|
|
{
|
|
|
|
struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
|
|
|
|
|
2019-08-16 18:49:05 +00:00
|
|
|
if (old_state->hdcp_content_type != state->hdcp_content_type &&
|
|
|
|
state->content_protection != DRM_MODE_CONTENT_PROTECTION_UNDESIRED) {
|
|
|
|
state->content_protection = DRM_MODE_CONTENT_PROTECTION_DESIRED;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-09-16 20:52:58 +00:00
|
|
|
/* CP is being re enabled, ignore this */
|
|
|
|
if (old_state->content_protection == DRM_MODE_CONTENT_PROTECTION_ENABLED &&
|
|
|
|
state->content_protection == DRM_MODE_CONTENT_PROTECTION_DESIRED) {
|
|
|
|
state->content_protection = DRM_MODE_CONTENT_PROTECTION_ENABLED;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* S3 resume case, since old state will always be 0 (UNDESIRED) and the restored state will be ENABLED */
|
|
|
|
if (old_state->content_protection == DRM_MODE_CONTENT_PROTECTION_UNDESIRED &&
|
|
|
|
state->content_protection == DRM_MODE_CONTENT_PROTECTION_ENABLED)
|
|
|
|
state->content_protection = DRM_MODE_CONTENT_PROTECTION_DESIRED;
|
|
|
|
|
|
|
|
/* Check if something is connected/enabled, otherwise we start hdcp but nothing is connected/enabled
|
|
|
|
* hot-plug, headless s3, dpms
|
|
|
|
*/
|
|
|
|
if (state->content_protection == DRM_MODE_CONTENT_PROTECTION_DESIRED && connector->dpms == DRM_MODE_DPMS_ON &&
|
|
|
|
aconnector->dc_sink != NULL)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
if (old_state->content_protection == state->content_protection)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (state->content_protection == DRM_MODE_CONTENT_PROTECTION_UNDESIRED)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif
|
2017-10-10 21:44:52 +00:00
|
|
|
static void remove_stream(struct amdgpu_device *adev,
|
|
|
|
struct amdgpu_crtc *acrtc,
|
|
|
|
struct dc_stream_state *stream)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
/* this is the update mode case */
|
|
|
|
|
|
|
|
acrtc->otg_inst = -1;
|
|
|
|
acrtc->enabled = false;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static int get_cursor_position(struct drm_plane *plane, struct drm_crtc *crtc,
|
|
|
|
struct dc_cursor_position *position)
|
2017-07-31 20:32:18 +00:00
|
|
|
{
|
2018-05-02 14:43:16 +00:00
|
|
|
struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
|
2017-07-31 20:32:18 +00:00
|
|
|
int x, y;
|
|
|
|
int xorigin = 0, yorigin = 0;
|
|
|
|
|
2019-04-18 16:42:32 +00:00
|
|
|
position->enable = false;
|
|
|
|
position->x = 0;
|
|
|
|
position->y = 0;
|
|
|
|
|
|
|
|
if (!crtc || !plane->state->fb)
|
2017-07-31 20:32:18 +00:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
if ((plane->state->crtc_w > amdgpu_crtc->max_cursor_width) ||
|
|
|
|
(plane->state->crtc_h > amdgpu_crtc->max_cursor_height)) {
|
|
|
|
DRM_ERROR("%s: bad cursor width or height %d x %d\n",
|
|
|
|
__func__,
|
|
|
|
plane->state->crtc_w,
|
|
|
|
plane->state->crtc_h);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
x = plane->state->crtc_x;
|
|
|
|
y = plane->state->crtc_y;
|
2019-03-29 18:58:32 +00:00
|
|
|
|
2019-04-18 16:42:32 +00:00
|
|
|
if (x <= -amdgpu_crtc->max_cursor_width ||
|
|
|
|
y <= -amdgpu_crtc->max_cursor_height)
|
|
|
|
return 0;
|
|
|
|
|
2017-07-31 20:32:18 +00:00
|
|
|
if (x < 0) {
|
|
|
|
xorigin = min(-x, amdgpu_crtc->max_cursor_width - 1);
|
|
|
|
x = 0;
|
|
|
|
}
|
|
|
|
if (y < 0) {
|
|
|
|
yorigin = min(-y, amdgpu_crtc->max_cursor_height - 1);
|
|
|
|
y = 0;
|
|
|
|
}
|
|
|
|
position->enable = true;
|
drm/amd/display: Make cursor source translation adjustment optional
[Why]
In some usecases, like tiled display, the stream and plane configuration
can be setup in a way where the caller expects DAL to perform the
clipping, eg:
P0:
src_rect(0, 0, w, h)
dst_rect(0, 0, w, h)
P1:
src_rect(w, 0, w, h)
dst_rect(0, 0, w, h)
Cursor is enabled on both streams with the same position.
This can result in double cursor on tiled display, even though this
behavior is technically correct from the DC interface point of view.
We need a mechanism to control this dynamically.
[How]
This is something that should live in the DM layer based on detection
of the specified configuration but it's not something that we really
have enough information to deal with today.
Add a flag to the cursor position state that specifies whether we
want DC to do the translation or not and make it opt-in and let
the DM decide when to do it.
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2020-04-05 20:41:08 +00:00
|
|
|
position->translate_by_source = true;
|
2017-07-31 20:32:18 +00:00
|
|
|
position->x = x;
|
|
|
|
position->y = y;
|
|
|
|
position->x_hotspot = xorigin;
|
|
|
|
position->y_hotspot = yorigin;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static void handle_cursor_update(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *old_plane_state)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2018-12-05 19:59:07 +00:00
|
|
|
struct amdgpu_device *adev = plane->dev->dev_private;
|
2017-07-31 20:32:18 +00:00
|
|
|
struct amdgpu_framebuffer *afb = to_amdgpu_framebuffer(plane->state->fb);
|
|
|
|
struct drm_crtc *crtc = afb ? plane->state->crtc : old_plane_state->crtc;
|
|
|
|
struct dm_crtc_state *crtc_state = crtc ? to_dm_crtc_state(crtc->state) : NULL;
|
|
|
|
struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
|
|
|
|
uint64_t address = afb ? afb->address : 0;
|
|
|
|
struct dc_cursor_position position;
|
|
|
|
struct dc_cursor_attributes attributes;
|
|
|
|
int ret;
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
if (!plane->state->fb && !old_plane_state->fb)
|
|
|
|
return;
|
|
|
|
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("%s: crtc_id=%d with size %d to %d\n",
|
2017-09-13 00:04:48 +00:00
|
|
|
__func__,
|
|
|
|
amdgpu_crtc->crtc_id,
|
|
|
|
plane->state->crtc_w,
|
|
|
|
plane->state->crtc_h);
|
2017-07-31 20:32:18 +00:00
|
|
|
|
|
|
|
ret = get_cursor_position(plane, crtc, &position);
|
|
|
|
if (ret)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (!position.enable) {
|
|
|
|
/* turn off cursor */
|
2018-12-05 19:59:07 +00:00
|
|
|
if (crtc_state && crtc_state->stream) {
|
|
|
|
mutex_lock(&adev->dm.dc_lock);
|
2017-07-31 20:32:18 +00:00
|
|
|
dc_stream_set_cursor_position(crtc_state->stream,
|
|
|
|
&position);
|
2018-12-05 19:59:07 +00:00
|
|
|
mutex_unlock(&adev->dm.dc_lock);
|
|
|
|
}
|
2017-07-31 20:32:18 +00:00
|
|
|
return;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2017-07-31 20:32:18 +00:00
|
|
|
amdgpu_crtc->cursor_width = plane->state->crtc_w;
|
|
|
|
amdgpu_crtc->cursor_height = plane->state->crtc_h;
|
|
|
|
|
2019-04-01 02:15:31 +00:00
|
|
|
memset(&attributes, 0, sizeof(attributes));
|
2017-07-31 20:32:18 +00:00
|
|
|
attributes.address.high_part = upper_32_bits(address);
|
|
|
|
attributes.address.low_part = lower_32_bits(address);
|
|
|
|
attributes.width = plane->state->crtc_w;
|
|
|
|
attributes.height = plane->state->crtc_h;
|
|
|
|
attributes.color_format = CURSOR_MODE_COLOR_PRE_MULTIPLIED_ALPHA;
|
|
|
|
attributes.rotation_angle = 0;
|
|
|
|
attributes.attribute_flags.value = 0;
|
|
|
|
|
|
|
|
attributes.pitch = attributes.width;
|
|
|
|
|
2017-10-05 19:37:46 +00:00
|
|
|
if (crtc_state->stream) {
|
2018-12-05 19:59:07 +00:00
|
|
|
mutex_lock(&adev->dm.dc_lock);
|
2017-10-05 19:37:46 +00:00
|
|
|
if (!dc_stream_set_cursor_attributes(crtc_state->stream,
|
|
|
|
&attributes))
|
|
|
|
DRM_ERROR("DC failed to set cursor attributes\n");
|
2017-07-31 20:32:18 +00:00
|
|
|
|
|
|
|
if (!dc_stream_set_cursor_position(crtc_state->stream,
|
|
|
|
&position))
|
|
|
|
DRM_ERROR("DC failed to set cursor position\n");
|
2018-12-05 19:59:07 +00:00
|
|
|
mutex_unlock(&adev->dm.dc_lock);
|
2017-10-05 19:37:46 +00:00
|
|
|
}
|
2017-07-31 20:32:18 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
static void prepare_flip_isr(struct amdgpu_crtc *acrtc)
|
|
|
|
{
|
|
|
|
|
|
|
|
assert_spin_locked(&acrtc->base.dev->event_lock);
|
|
|
|
WARN_ON(acrtc->event);
|
|
|
|
|
|
|
|
acrtc->event = acrtc->base.state->event;
|
|
|
|
|
|
|
|
/* Set the flip status */
|
|
|
|
acrtc->pflip_status = AMDGPU_FLIP_SUBMITTED;
|
|
|
|
|
|
|
|
/* Mark this event as consumed */
|
|
|
|
acrtc->base.state->event = NULL;
|
|
|
|
|
|
|
|
DRM_DEBUG_DRIVER("crtc:%d, pflip_stat:AMDGPU_FLIP_SUBMITTED\n",
|
|
|
|
acrtc->crtc_id);
|
|
|
|
}
|
|
|
|
|
2018-10-04 17:03:30 +00:00
|
|
|
static void update_freesync_state_on_stream(
|
|
|
|
struct amdgpu_display_manager *dm,
|
|
|
|
struct dm_crtc_state *new_crtc_state,
|
2018-12-05 17:08:56 +00:00
|
|
|
struct dc_stream_state *new_stream,
|
|
|
|
struct dc_plane_state *surface,
|
|
|
|
u32 flip_timestamp_in_us)
|
2018-10-04 17:03:30 +00:00
|
|
|
{
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
struct mod_vrr_params vrr_params;
|
2018-10-04 17:03:30 +00:00
|
|
|
struct dc_info_packet vrr_infopacket = {0};
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
struct amdgpu_device *adev = dm->adev;
|
|
|
|
unsigned long flags;
|
2018-10-04 17:03:30 +00:00
|
|
|
|
|
|
|
if (!new_stream)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* TODO: Determine why min/max totals and vrefresh can be 0 here.
|
|
|
|
* For now it's sufficient to just guard against these conditions.
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (!new_stream->timing.h_total || !new_stream->timing.v_total)
|
|
|
|
return;
|
|
|
|
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
spin_lock_irqsave(&adev->ddev->event_lock, flags);
|
|
|
|
vrr_params = new_crtc_state->vrr_params;
|
|
|
|
|
2018-12-05 17:08:56 +00:00
|
|
|
if (surface) {
|
|
|
|
mod_freesync_handle_preflip(
|
|
|
|
dm->freesync_module,
|
|
|
|
surface,
|
|
|
|
new_stream,
|
|
|
|
flip_timestamp_in_us,
|
|
|
|
&vrr_params);
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
|
|
|
|
if (adev->family < AMDGPU_FAMILY_AI &&
|
|
|
|
amdgpu_dm_vrr_active(new_crtc_state)) {
|
|
|
|
mod_freesync_handle_v_update(dm->freesync_module,
|
|
|
|
new_stream, &vrr_params);
|
2019-04-23 15:53:52 +00:00
|
|
|
|
|
|
|
/* Need to call this before the frame ends. */
|
|
|
|
dc_stream_adjust_vmin_vmax(dm->dc,
|
|
|
|
new_crtc_state->stream,
|
|
|
|
&vrr_params.adjust);
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
}
|
2018-12-05 17:08:56 +00:00
|
|
|
}
|
2018-10-04 17:03:30 +00:00
|
|
|
|
|
|
|
mod_freesync_build_vrr_infopacket(
|
|
|
|
dm->freesync_module,
|
|
|
|
new_stream,
|
2018-12-05 17:08:56 +00:00
|
|
|
&vrr_params,
|
2018-11-05 22:55:53 +00:00
|
|
|
PACKET_TYPE_VRR,
|
|
|
|
TRANSFER_FUNC_UNKNOWN,
|
2018-10-04 17:03:30 +00:00
|
|
|
&vrr_infopacket);
|
|
|
|
|
2018-12-11 20:17:15 +00:00
|
|
|
new_crtc_state->freesync_timing_changed |=
|
2018-12-05 17:08:56 +00:00
|
|
|
(memcmp(&new_crtc_state->vrr_params.adjust,
|
|
|
|
&vrr_params.adjust,
|
|
|
|
sizeof(vrr_params.adjust)) != 0);
|
2018-10-04 17:03:30 +00:00
|
|
|
|
2018-12-11 20:17:15 +00:00
|
|
|
new_crtc_state->freesync_vrr_info_changed |=
|
2018-10-04 17:03:30 +00:00
|
|
|
(memcmp(&new_crtc_state->vrr_infopacket,
|
|
|
|
&vrr_infopacket,
|
|
|
|
sizeof(vrr_infopacket)) != 0);
|
|
|
|
|
2018-12-05 17:08:56 +00:00
|
|
|
new_crtc_state->vrr_params = vrr_params;
|
2018-10-04 17:03:30 +00:00
|
|
|
new_crtc_state->vrr_infopacket = vrr_infopacket;
|
|
|
|
|
2018-12-05 17:08:56 +00:00
|
|
|
new_stream->adjust = new_crtc_state->vrr_params.adjust;
|
2018-10-04 17:03:30 +00:00
|
|
|
new_stream->vrr_infopacket = vrr_infopacket;
|
|
|
|
|
|
|
|
if (new_crtc_state->freesync_vrr_info_changed)
|
|
|
|
DRM_DEBUG_KMS("VRR packet update: crtc=%u enabled=%d state=%d",
|
|
|
|
new_crtc_state->base.crtc->base.id,
|
|
|
|
(int)new_crtc_state->base.vrr_enabled,
|
2018-12-05 17:08:56 +00:00
|
|
|
(int)vrr_params.state);
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
|
|
|
|
spin_unlock_irqrestore(&adev->ddev->event_lock, flags);
|
2018-10-04 17:03:30 +00:00
|
|
|
}
|
|
|
|
|
2019-03-29 12:00:53 +00:00
|
|
|
static void pre_update_freesync_state_on_stream(
|
|
|
|
struct amdgpu_display_manager *dm,
|
|
|
|
struct dm_crtc_state *new_crtc_state)
|
|
|
|
{
|
|
|
|
struct dc_stream_state *new_stream = new_crtc_state->stream;
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
struct mod_vrr_params vrr_params;
|
2019-03-29 12:00:53 +00:00
|
|
|
struct mod_freesync_config config = new_crtc_state->freesync_config;
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
struct amdgpu_device *adev = dm->adev;
|
|
|
|
unsigned long flags;
|
2019-03-29 12:00:53 +00:00
|
|
|
|
|
|
|
if (!new_stream)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* TODO: Determine why min/max totals and vrefresh can be 0 here.
|
|
|
|
* For now it's sufficient to just guard against these conditions.
|
|
|
|
*/
|
|
|
|
if (!new_stream->timing.h_total || !new_stream->timing.v_total)
|
|
|
|
return;
|
|
|
|
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
spin_lock_irqsave(&adev->ddev->event_lock, flags);
|
|
|
|
vrr_params = new_crtc_state->vrr_params;
|
|
|
|
|
2019-03-29 12:00:53 +00:00
|
|
|
if (new_crtc_state->vrr_supported &&
|
|
|
|
config.min_refresh_in_uhz &&
|
|
|
|
config.max_refresh_in_uhz) {
|
|
|
|
config.state = new_crtc_state->base.vrr_enabled ?
|
|
|
|
VRR_STATE_ACTIVE_VARIABLE :
|
|
|
|
VRR_STATE_INACTIVE;
|
|
|
|
} else {
|
|
|
|
config.state = VRR_STATE_UNSUPPORTED;
|
|
|
|
}
|
|
|
|
|
|
|
|
mod_freesync_build_vrr_params(dm->freesync_module,
|
|
|
|
new_stream,
|
|
|
|
&config, &vrr_params);
|
|
|
|
|
|
|
|
new_crtc_state->freesync_timing_changed |=
|
|
|
|
(memcmp(&new_crtc_state->vrr_params.adjust,
|
|
|
|
&vrr_params.adjust,
|
|
|
|
sizeof(vrr_params.adjust)) != 0);
|
|
|
|
|
|
|
|
new_crtc_state->vrr_params = vrr_params;
|
drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations. (v3)
Pre-DCE12 needs special treatment for BTR / low framerate
compensation for more stable behaviour:
According to comments in the code and some testing on DCE-8
and DCE-11, DCE-11 and earlier only apply VTOTAL_MIN/MAX
programming with a lag of one frame, so the special BTR hw
programming for intermediate fixed duration frames must be
done inside the current frame at flip submission in atomic
commit tail, ie. one vblank earlier, and the fixed refresh
intermediate frame mode must be also terminated one vblank
earlier on pre-DCE12 display engines.
To achieve proper termination on < DCE-12 shift the point
when the switch-back from fixed vblank duration to variable
vblank duration happens from the start of VBLANK (vblank irq,
as done on DCE-12+) to back-porch or end of VBLANK (handled
by vupdate irq handler). We must leave the switch-back code
inside VBLANK irq for DCE12+, as before.
Doing this, we get much better behaviour of BTR for up-sweeps,
ie. going from short to long frame durations (~high to low fps)
and for constant framerate flips, as tested on DCE-8 and
DCE-11. Behaviour is still not quite as good as on DCN-1
though.
On down-sweeps, going from long to short frame durations
(low fps to high fps) < DCE-12 is a little bit improved,
although by far not as much as for up-sweeps and constant
fps.
v2: Fix some wrong locking, as pointed out by Nicholas.
v3: Simplify if-condition in vupdate-irq - nit by Nicholas.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-26 21:40:16 +00:00
|
|
|
spin_unlock_irqrestore(&adev->ddev->event_lock, flags);
|
2019-03-29 12:00:53 +00:00
|
|
|
}
|
|
|
|
|
2019-03-29 12:00:54 +00:00
|
|
|
static void amdgpu_dm_handle_vrr_transition(struct dm_crtc_state *old_state,
|
|
|
|
struct dm_crtc_state *new_state)
|
|
|
|
{
|
|
|
|
bool old_vrr_active = amdgpu_dm_vrr_active(old_state);
|
|
|
|
bool new_vrr_active = amdgpu_dm_vrr_active(new_state);
|
|
|
|
|
|
|
|
if (!old_vrr_active && new_vrr_active) {
|
|
|
|
/* Transition VRR inactive -> active:
|
|
|
|
* While VRR is active, we must not disable vblank irq, as a
|
|
|
|
* reenable after disable would compute bogus vblank/pflip
|
|
|
|
* timestamps if it likely happened inside display front-porch.
|
2019-03-29 12:00:56 +00:00
|
|
|
*
|
|
|
|
* We also need vupdate irq for the actual core vblank handling
|
|
|
|
* at end of vblank.
|
2019-03-29 12:00:54 +00:00
|
|
|
*/
|
2019-03-29 12:00:56 +00:00
|
|
|
dm_set_vupdate_irq(new_state->base.crtc, true);
|
2019-03-29 12:00:54 +00:00
|
|
|
drm_crtc_vblank_get(new_state->base.crtc);
|
|
|
|
DRM_DEBUG_DRIVER("%s: crtc=%u VRR off->on: Get vblank ref\n",
|
|
|
|
__func__, new_state->base.crtc->base.id);
|
|
|
|
} else if (old_vrr_active && !new_vrr_active) {
|
|
|
|
/* Transition VRR active -> inactive:
|
|
|
|
* Allow vblank irq disable again for fixed refresh rate.
|
|
|
|
*/
|
2019-03-29 12:00:56 +00:00
|
|
|
dm_set_vupdate_irq(new_state->base.crtc, false);
|
2019-03-29 12:00:54 +00:00
|
|
|
drm_crtc_vblank_put(new_state->base.crtc);
|
|
|
|
DRM_DEBUG_DRIVER("%s: crtc=%u VRR on->off: Drop vblank ref\n",
|
|
|
|
__func__, new_state->base.crtc->base.id);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-04-08 14:37:44 +00:00
|
|
|
static void amdgpu_dm_commit_cursors(struct drm_atomic_state *state)
|
|
|
|
{
|
|
|
|
struct drm_plane *plane;
|
|
|
|
struct drm_plane_state *old_plane_state, *new_plane_state;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* TODO: Make this per-stream so we don't issue redundant updates for
|
|
|
|
* commits with multiple streams.
|
|
|
|
*/
|
|
|
|
for_each_oldnew_plane_in_state(state, plane, old_plane_state,
|
|
|
|
new_plane_state, i)
|
|
|
|
if (plane->type == DRM_PLANE_TYPE_CURSOR)
|
|
|
|
handle_cursor_update(plane, old_plane_state);
|
|
|
|
}
|
|
|
|
|
2017-07-27 13:55:38 +00:00
|
|
|
static void amdgpu_dm_commit_planes(struct drm_atomic_state *state,
|
2018-11-22 17:34:36 +00:00
|
|
|
struct dc_state *dc_state,
|
2017-10-10 21:44:52 +00:00
|
|
|
struct drm_device *dev,
|
|
|
|
struct amdgpu_display_manager *dm,
|
|
|
|
struct drm_crtc *pcrtc,
|
2019-03-01 23:15:26 +00:00
|
|
|
bool wait_for_vblank)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2019-05-02 13:14:27 +00:00
|
|
|
uint32_t i;
|
2018-12-11 20:17:15 +00:00
|
|
|
uint64_t timestamp_ns;
|
2017-08-10 17:29:07 +00:00
|
|
|
struct drm_plane *plane;
|
2017-10-12 21:15:07 +00:00
|
|
|
struct drm_plane_state *old_plane_state, *new_plane_state;
|
2017-08-10 17:29:07 +00:00
|
|
|
struct amdgpu_crtc *acrtc_attach = to_amdgpu_crtc(pcrtc);
|
2017-10-12 21:15:07 +00:00
|
|
|
struct drm_crtc_state *new_pcrtc_state =
|
|
|
|
drm_atomic_get_new_crtc_state(state, pcrtc);
|
|
|
|
struct dm_crtc_state *acrtc_state = to_dm_crtc_state(new_pcrtc_state);
|
2018-03-15 18:29:24 +00:00
|
|
|
struct dm_crtc_state *dm_old_crtc_state =
|
|
|
|
to_dm_crtc_state(drm_atomic_get_old_crtc_state(state, pcrtc));
|
2019-03-01 23:22:07 +00:00
|
|
|
int planes_count = 0, vpos, hpos;
|
2019-05-02 13:14:27 +00:00
|
|
|
long r;
|
2017-08-10 17:29:07 +00:00
|
|
|
unsigned long flags;
|
2018-12-11 20:17:15 +00:00
|
|
|
struct amdgpu_bo *abo;
|
2019-01-28 16:02:08 +00:00
|
|
|
uint64_t tiling_flags;
|
2020-04-22 21:54:55 +00:00
|
|
|
bool tmz_surface = false;
|
drm/amd/display: Rework vrr flip throttling for late vblank irq.
For throttling to work correctly, we always need a baseline vblank
count last_flip_vblank that increments at start of front-porch.
This is the case for drm_crtc_vblank_count() in non-VRR mode, where
the vblank irq fires at start of front-porch and triggers DRM core
vblank handling, but it is no longer the case in VRR mode, where
core vblank handling is done later, after end of front-porch.
Therefore drm_crtc_vblank_count() is no longer useful for this.
We also can't use drm_crtc_accurate_vblank_count(), as that would
screw up vblank timestamps in VRR mode when called in front-porch.
To solve this, use the cooked hardware vblank counter returned by
amdgpu_get_vblank_counter_kms() instead, as that one is cooked to
always increment at start of front-porch, independent of when
vblank related irq's fire.
This patch allows vblank irq handling to happen anywhere within
vblank of even after it, without a negative impact on flip
throttling, so followup patches can shift the vblank core
handling trigger point wherever they need it.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-02 22:00:06 +00:00
|
|
|
uint32_t target_vblank, last_flip_vblank;
|
|
|
|
bool vrr_active = amdgpu_dm_vrr_active(acrtc_state);
|
2019-03-01 23:22:07 +00:00
|
|
|
bool pflip_present = false;
|
2018-12-19 15:45:16 +00:00
|
|
|
struct {
|
|
|
|
struct dc_surface_update surface_updates[MAX_SURFACES];
|
|
|
|
struct dc_plane_info plane_infos[MAX_SURFACES];
|
|
|
|
struct dc_scaling_info scaling_infos[MAX_SURFACES];
|
2019-03-01 23:22:07 +00:00
|
|
|
struct dc_flip_addrs flip_addrs[MAX_SURFACES];
|
2018-12-19 15:45:16 +00:00
|
|
|
struct dc_stream_update stream_update;
|
2019-03-01 23:22:07 +00:00
|
|
|
} *bundle;
|
2018-12-19 15:45:16 +00:00
|
|
|
|
2019-03-01 23:22:07 +00:00
|
|
|
bundle = kzalloc(sizeof(*bundle), GFP_KERNEL);
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-03-01 23:22:07 +00:00
|
|
|
if (!bundle) {
|
|
|
|
dm_error("Failed to allocate update bundle\n");
|
2019-01-28 14:00:52 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-04-08 14:37:44 +00:00
|
|
|
/*
|
|
|
|
* Disable the cursor first if we're disabling all the planes.
|
|
|
|
* It'll remain on the screen after the planes are re-enabled
|
|
|
|
* if we don't.
|
|
|
|
*/
|
|
|
|
if (acrtc_state->active_planes == 0)
|
|
|
|
amdgpu_dm_commit_cursors(state);
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
/* update planes when needed */
|
2017-10-12 21:15:07 +00:00
|
|
|
for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i) {
|
|
|
|
struct drm_crtc *crtc = new_plane_state->crtc;
|
2017-10-27 18:34:46 +00:00
|
|
|
struct drm_crtc_state *new_crtc_state;
|
2017-10-12 21:15:07 +00:00
|
|
|
struct drm_framebuffer *fb = new_plane_state->fb;
|
2019-02-06 19:01:29 +00:00
|
|
|
bool plane_needs_flip;
|
2019-01-10 14:51:54 +00:00
|
|
|
struct dc_plane_state *dc_plane;
|
2017-10-12 21:15:09 +00:00
|
|
|
struct dm_plane_state *dm_new_plane_state = to_dm_plane_state(new_plane_state);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-01-25 20:30:24 +00:00
|
|
|
/* Cursor plane is handled after stream updates */
|
|
|
|
if (plane->type == DRM_PLANE_TYPE_CURSOR)
|
2017-08-10 17:29:07 +00:00
|
|
|
continue;
|
|
|
|
|
2017-10-27 18:34:46 +00:00
|
|
|
if (!fb || !crtc || pcrtc != crtc)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
new_crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
|
|
|
|
if (!new_crtc_state->active)
|
2017-08-10 17:29:07 +00:00
|
|
|
continue;
|
|
|
|
|
2018-12-19 15:45:16 +00:00
|
|
|
dc_plane = dm_new_plane_state->dc_state;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-03-01 23:22:07 +00:00
|
|
|
bundle->surface_updates[planes_count].surface = dc_plane;
|
2018-12-19 15:45:16 +00:00
|
|
|
if (new_pcrtc_state->color_mgmt_changed) {
|
2019-03-01 23:22:07 +00:00
|
|
|
bundle->surface_updates[planes_count].gamma = dc_plane->gamma_correction;
|
|
|
|
bundle->surface_updates[planes_count].in_transfer_func = dc_plane->in_transfer_func;
|
2020-03-26 15:19:44 +00:00
|
|
|
bundle->surface_updates[planes_count].gamut_remap_matrix = &dc_plane->gamut_remap_matrix;
|
2018-12-19 15:45:16 +00:00
|
|
|
}
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
fill_dc_scaling_info(new_plane_state,
|
|
|
|
&bundle->scaling_infos[planes_count]);
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
bundle->surface_updates[planes_count].scaling_info =
|
|
|
|
&bundle->scaling_infos[planes_count];
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-02-13 18:20:11 +00:00
|
|
|
plane_needs_flip = old_plane_state->fb && new_plane_state->fb;
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-02-13 18:20:11 +00:00
|
|
|
pflip_present = pflip_present || plane_needs_flip;
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-02-13 18:20:11 +00:00
|
|
|
if (!plane_needs_flip) {
|
|
|
|
planes_count += 1;
|
|
|
|
continue;
|
|
|
|
}
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-04-02 14:28:13 +00:00
|
|
|
abo = gem_to_amdgpu_bo(fb->obj[0]);
|
|
|
|
|
2019-04-15 14:57:14 +00:00
|
|
|
/*
|
|
|
|
* Wait for all fences on this FB. Do limited wait to avoid
|
|
|
|
* deadlock during GPU reset when this fence will not signal
|
|
|
|
* but we hold reservation lock for the BO.
|
|
|
|
*/
|
2019-08-11 08:06:32 +00:00
|
|
|
r = dma_resv_wait_timeout_rcu(abo->tbo.base.resv, true,
|
2019-04-02 14:28:13 +00:00
|
|
|
false,
|
2019-04-15 14:57:14 +00:00
|
|
|
msecs_to_jiffies(5000));
|
|
|
|
if (unlikely(r <= 0))
|
2019-08-26 14:11:50 +00:00
|
|
|
DRM_ERROR("Waiting for fences timed out!");
|
2019-04-02 14:28:13 +00:00
|
|
|
|
2019-02-13 18:20:11 +00:00
|
|
|
/*
|
|
|
|
* TODO This might fail and hence better not used, wait
|
|
|
|
* explicitly on fences instead
|
|
|
|
* and in general should be called for
|
|
|
|
* blocking commit to as per framework helpers
|
|
|
|
*/
|
|
|
|
r = amdgpu_bo_reserve(abo, true);
|
2019-04-15 14:57:14 +00:00
|
|
|
if (unlikely(r != 0))
|
2019-02-13 18:20:11 +00:00
|
|
|
DRM_ERROR("failed to reserve buffer before flip\n");
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-02-13 18:20:11 +00:00
|
|
|
amdgpu_bo_get_tiling_flags(abo, &tiling_flags);
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2020-04-22 21:54:55 +00:00
|
|
|
tmz_surface = amdgpu_bo_encrypted(abo);
|
|
|
|
|
2019-02-13 18:20:11 +00:00
|
|
|
amdgpu_bo_unreserve(abo);
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
fill_dc_plane_info_and_addr(
|
|
|
|
dm->adev, new_plane_state, tiling_flags,
|
|
|
|
&bundle->plane_infos[planes_count],
|
2020-04-22 21:43:26 +00:00
|
|
|
&bundle->flip_addrs[planes_count].address,
|
2020-04-22 21:54:55 +00:00
|
|
|
tmz_surface,
|
2020-04-22 21:43:26 +00:00
|
|
|
false);
|
|
|
|
|
|
|
|
DRM_DEBUG_DRIVER("plane: id=%d dcc_en=%d\n",
|
|
|
|
new_plane_state->plane->index,
|
|
|
|
bundle->plane_infos[planes_count].dcc.enable);
|
2019-03-28 18:45:19 +00:00
|
|
|
|
|
|
|
bundle->surface_updates[planes_count].plane_info =
|
|
|
|
&bundle->plane_infos[planes_count];
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-08-02 14:45:11 +00:00
|
|
|
/*
|
|
|
|
* Only allow immediate flips for fast updates that don't
|
|
|
|
* change FB pitch, DCC state, rotation or mirroing.
|
|
|
|
*/
|
2019-02-13 18:20:11 +00:00
|
|
|
bundle->flip_addrs[planes_count].flip_immediate =
|
2019-09-03 19:06:42 +00:00
|
|
|
crtc->state->async_flip &&
|
2019-08-02 14:45:11 +00:00
|
|
|
acrtc_state->update_type == UPDATE_TYPE_FAST;
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-02-13 18:20:11 +00:00
|
|
|
timestamp_ns = ktime_get_ns();
|
|
|
|
bundle->flip_addrs[planes_count].flip_timestamp_in_us = div_u64(timestamp_ns, 1000);
|
|
|
|
bundle->surface_updates[planes_count].flip_addr = &bundle->flip_addrs[planes_count];
|
|
|
|
bundle->surface_updates[planes_count].surface = dc_plane;
|
2018-12-11 20:17:15 +00:00
|
|
|
|
2019-02-13 18:20:11 +00:00
|
|
|
if (!bundle->surface_updates[planes_count].surface) {
|
|
|
|
DRM_ERROR("No surface for CRTC: id=%d\n",
|
|
|
|
acrtc_attach->crtc_id);
|
|
|
|
continue;
|
2018-12-19 15:45:16 +00:00
|
|
|
}
|
|
|
|
|
2019-02-13 18:20:11 +00:00
|
|
|
if (plane == pcrtc->primary)
|
|
|
|
update_freesync_state_on_stream(
|
|
|
|
dm,
|
|
|
|
acrtc_state,
|
|
|
|
acrtc_state->stream,
|
|
|
|
dc_plane,
|
|
|
|
bundle->flip_addrs[planes_count].flip_timestamp_in_us);
|
2018-12-19 15:45:16 +00:00
|
|
|
|
2019-02-13 18:20:11 +00:00
|
|
|
DRM_DEBUG_DRIVER("%s Flipping to hi: 0x%x, low: 0x%x\n",
|
|
|
|
__func__,
|
|
|
|
bundle->flip_addrs[planes_count].address.grph.addr.high_part,
|
|
|
|
bundle->flip_addrs[planes_count].address.grph.addr.low_part);
|
2018-12-19 15:45:16 +00:00
|
|
|
|
|
|
|
planes_count += 1;
|
|
|
|
|
2018-12-11 20:17:15 +00:00
|
|
|
}
|
|
|
|
|
2019-03-01 23:22:07 +00:00
|
|
|
if (pflip_present) {
|
drm/amd/display: Use vrr friendly pageflip throttling in DC.
In VRR mode, keep track of the vblank count of the last
completed pageflip in amdgpu_crtc->last_flip_vblank, as
recorded in the pageflip completion handler after each
completed flip.
Use that count to prevent mmio programming a new pageflip
within the same vblank in which the last pageflip completed,
iow. to throttle pageflips to at most one flip per video
frame, while at the same time allowing to request a flip
not only before start of vblank, but also anywhere within
vblank.
The old logic did the same, and made sense for regular fixed
refresh rate flipping, but in vrr mode it prevents requesting
a flip anywhere inside the possibly huge vblank, thereby
reducing framerate in vrr mode instead of improving it, by
delaying a slightly delayed flip requests up to a maximum
vblank duration + 1 scanout duration. This would limit VRR
usefulness to only help applications with a very high GPU
demand, which can submit the flip request before start of
vblank, but then have to wait long for fences to complete.
With this method a flip can be both requested and - after
fences have completed - executed, ie. it doesn't matter if
the request (amdgpu_dm_do_flip()) gets delayed until deep
into the extended vblank due to cpu execution delays. This
also allows clients which want to regulate framerate within
the vrr range a much more fine-grained control of flip timing,
a feature that might be useful for video playback, and is
very useful for neuroscience/vision research applications.
In regular non-VRR mode, retain the old flip submission
behavior. This to keep flip scheduling for fullscreen X11/GLX
OpenGL clients intact, if they use the GLX_OML_sync_control
extensions glXSwapBufferMscOML(, ..., target_msc,...) function
with a specific target_msc target vblank count.
glXSwapBuffersMscOML() or DRI3/Present PresentPixmap() will
not flip at the proper target_msc for a non-zero target_msc
if VRR mode is active with this patch. They'd often flip one
frame too early. However, this limitation should not matter
much in VRR mode, as scheduling based on vblank counts is
pretty futile/unusable under variable refresh duration
anyway, so no real extra harm is done.
According to some testing already done with this patch by
Nicholas on top of my tests, IGT tests didn't report any
problems. If fixes stuttering and flickering when flipping
at rates below the minimum vrr refresh rate.
Fixes: bb47de736661 ("drm/amdgpu: Set FreeSync state using drm VRR
properties")
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: <stable@vger.kernel.org>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Michel Dänzer <michel@daenzer.net>
Tested-by: Bruno Filipe <bmilreu@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2019-02-09 06:52:55 +00:00
|
|
|
if (!vrr_active) {
|
|
|
|
/* Use old throttling in non-vrr fixed refresh rate mode
|
|
|
|
* to keep flip scheduling based on target vblank counts
|
|
|
|
* working in a backwards compatible way, e.g., for
|
|
|
|
* clients using the GLX_OML_sync_control extension or
|
|
|
|
* DRI3/Present extension with defined target_msc.
|
|
|
|
*/
|
2020-01-23 13:59:26 +00:00
|
|
|
last_flip_vblank = amdgpu_get_vblank_counter_kms(pcrtc);
|
drm/amd/display: Use vrr friendly pageflip throttling in DC.
In VRR mode, keep track of the vblank count of the last
completed pageflip in amdgpu_crtc->last_flip_vblank, as
recorded in the pageflip completion handler after each
completed flip.
Use that count to prevent mmio programming a new pageflip
within the same vblank in which the last pageflip completed,
iow. to throttle pageflips to at most one flip per video
frame, while at the same time allowing to request a flip
not only before start of vblank, but also anywhere within
vblank.
The old logic did the same, and made sense for regular fixed
refresh rate flipping, but in vrr mode it prevents requesting
a flip anywhere inside the possibly huge vblank, thereby
reducing framerate in vrr mode instead of improving it, by
delaying a slightly delayed flip requests up to a maximum
vblank duration + 1 scanout duration. This would limit VRR
usefulness to only help applications with a very high GPU
demand, which can submit the flip request before start of
vblank, but then have to wait long for fences to complete.
With this method a flip can be both requested and - after
fences have completed - executed, ie. it doesn't matter if
the request (amdgpu_dm_do_flip()) gets delayed until deep
into the extended vblank due to cpu execution delays. This
also allows clients which want to regulate framerate within
the vrr range a much more fine-grained control of flip timing,
a feature that might be useful for video playback, and is
very useful for neuroscience/vision research applications.
In regular non-VRR mode, retain the old flip submission
behavior. This to keep flip scheduling for fullscreen X11/GLX
OpenGL clients intact, if they use the GLX_OML_sync_control
extensions glXSwapBufferMscOML(, ..., target_msc,...) function
with a specific target_msc target vblank count.
glXSwapBuffersMscOML() or DRI3/Present PresentPixmap() will
not flip at the proper target_msc for a non-zero target_msc
if VRR mode is active with this patch. They'd often flip one
frame too early. However, this limitation should not matter
much in VRR mode, as scheduling based on vblank counts is
pretty futile/unusable under variable refresh duration
anyway, so no real extra harm is done.
According to some testing already done with this patch by
Nicholas on top of my tests, IGT tests didn't report any
problems. If fixes stuttering and flickering when flipping
at rates below the minimum vrr refresh rate.
Fixes: bb47de736661 ("drm/amdgpu: Set FreeSync state using drm VRR
properties")
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: <stable@vger.kernel.org>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Michel Dänzer <michel@daenzer.net>
Tested-by: Bruno Filipe <bmilreu@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2019-02-09 06:52:55 +00:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
/* For variable refresh rate mode only:
|
|
|
|
* Get vblank of last completed flip to avoid > 1 vrr
|
|
|
|
* flips per video frame by use of throttling, but allow
|
|
|
|
* flip programming anywhere in the possibly large
|
|
|
|
* variable vrr vblank interval for fine-grained flip
|
|
|
|
* timing control and more opportunity to avoid stutter
|
|
|
|
* on late submission of flips.
|
|
|
|
*/
|
|
|
|
spin_lock_irqsave(&pcrtc->dev->event_lock, flags);
|
|
|
|
last_flip_vblank = acrtc_attach->last_flip_vblank;
|
|
|
|
spin_unlock_irqrestore(&pcrtc->dev->event_lock, flags);
|
|
|
|
}
|
|
|
|
|
drm/amd/display: Rework vrr flip throttling for late vblank irq.
For throttling to work correctly, we always need a baseline vblank
count last_flip_vblank that increments at start of front-porch.
This is the case for drm_crtc_vblank_count() in non-VRR mode, where
the vblank irq fires at start of front-porch and triggers DRM core
vblank handling, but it is no longer the case in VRR mode, where
core vblank handling is done later, after end of front-porch.
Therefore drm_crtc_vblank_count() is no longer useful for this.
We also can't use drm_crtc_accurate_vblank_count(), as that would
screw up vblank timestamps in VRR mode when called in front-porch.
To solve this, use the cooked hardware vblank counter returned by
amdgpu_get_vblank_counter_kms() instead, as that one is cooked to
always increment at start of front-porch, independent of when
vblank related irq's fire.
This patch allows vblank irq handling to happen anywhere within
vblank of even after it, without a negative impact on flip
throttling, so followup patches can shift the vblank core
handling trigger point wherever they need it.
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-04-02 22:00:06 +00:00
|
|
|
target_vblank = last_flip_vblank + wait_for_vblank;
|
2018-12-11 20:17:15 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Wait until we're out of the vertical blank period before the one
|
|
|
|
* targeted by the flip
|
|
|
|
*/
|
|
|
|
while ((acrtc_attach->enabled &&
|
|
|
|
(amdgpu_display_get_crtc_scanoutpos(dm->ddev, acrtc_attach->crtc_id,
|
|
|
|
0, &vpos, &hpos, NULL,
|
|
|
|
NULL, &pcrtc->hwmode)
|
|
|
|
& (DRM_SCANOUTPOS_VALID | DRM_SCANOUTPOS_IN_VBLANK)) ==
|
|
|
|
(DRM_SCANOUTPOS_VALID | DRM_SCANOUTPOS_IN_VBLANK) &&
|
|
|
|
(int)(target_vblank -
|
2020-01-23 13:59:26 +00:00
|
|
|
amdgpu_get_vblank_counter_kms(pcrtc)) > 0)) {
|
2018-12-11 20:17:15 +00:00
|
|
|
usleep_range(1000, 1100);
|
|
|
|
}
|
|
|
|
|
2020-07-13 14:41:23 +00:00
|
|
|
/**
|
|
|
|
* Prepare the flip event for the pageflip interrupt to handle.
|
|
|
|
*
|
|
|
|
* This only works in the case where we've already turned on the
|
|
|
|
* appropriate hardware blocks (eg. HUBP) so in the transition case
|
|
|
|
* from 0 -> n planes we have to skip a hardware generated event
|
|
|
|
* and rely on sending it from software.
|
|
|
|
*/
|
|
|
|
if (acrtc_attach->base.state->event &&
|
|
|
|
acrtc_state->active_planes > 0) {
|
2018-12-11 20:17:15 +00:00
|
|
|
drm_crtc_vblank_get(pcrtc);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&pcrtc->dev->event_lock, flags);
|
|
|
|
|
|
|
|
WARN_ON(acrtc_attach->pflip_status != AMDGPU_FLIP_NONE);
|
|
|
|
prepare_flip_isr(acrtc_attach);
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&pcrtc->dev->event_lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (acrtc_state->stream) {
|
|
|
|
if (acrtc_state->freesync_vrr_info_changed)
|
2019-03-01 23:22:07 +00:00
|
|
|
bundle->stream_update.vrr_infopacket =
|
2018-12-11 20:17:15 +00:00
|
|
|
&acrtc_state->stream->vrr_infopacket;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-04-04 15:00:53 +00:00
|
|
|
/* Update the planes if changed or disable if we don't have any. */
|
2019-06-24 15:15:42 +00:00
|
|
|
if ((planes_count || acrtc_state->active_planes == 0) &&
|
|
|
|
acrtc_state->stream) {
|
2019-09-13 23:00:28 +00:00
|
|
|
bundle->stream_update.stream = acrtc_state->stream;
|
2018-12-19 15:45:16 +00:00
|
|
|
if (new_pcrtc_state->mode_changed) {
|
2019-03-01 23:22:07 +00:00
|
|
|
bundle->stream_update.src = acrtc_state->stream->src;
|
|
|
|
bundle->stream_update.dst = acrtc_state->stream->dst;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2019-05-09 16:14:58 +00:00
|
|
|
if (new_pcrtc_state->color_mgmt_changed) {
|
|
|
|
/*
|
|
|
|
* TODO: This isn't fully correct since we've actually
|
|
|
|
* already modified the stream in place.
|
|
|
|
*/
|
|
|
|
bundle->stream_update.gamut_remap =
|
|
|
|
&acrtc_state->stream->gamut_remap_matrix;
|
|
|
|
bundle->stream_update.output_csc_transform =
|
|
|
|
&acrtc_state->stream->csc_color_matrix;
|
|
|
|
bundle->stream_update.out_transfer_func =
|
|
|
|
acrtc_state->stream->out_transfer_func;
|
|
|
|
}
|
2018-12-19 15:45:16 +00:00
|
|
|
|
2018-12-11 20:17:15 +00:00
|
|
|
acrtc_state->stream->abm_level = acrtc_state->abm_level;
|
2018-12-19 15:45:16 +00:00
|
|
|
if (acrtc_state->abm_level != dm_old_crtc_state->abm_level)
|
2019-03-01 23:22:07 +00:00
|
|
|
bundle->stream_update.abm_level = &acrtc_state->abm_level;
|
2018-03-15 18:29:24 +00:00
|
|
|
|
2019-04-23 15:53:52 +00:00
|
|
|
/*
|
|
|
|
* If FreeSync state on the stream has changed then we need to
|
|
|
|
* re-adjust the min/max bounds now that DC doesn't handle this
|
|
|
|
* as part of commit.
|
|
|
|
*/
|
|
|
|
if (amdgpu_dm_vrr_active(dm_old_crtc_state) !=
|
|
|
|
amdgpu_dm_vrr_active(acrtc_state)) {
|
|
|
|
spin_lock_irqsave(&pcrtc->dev->event_lock, flags);
|
|
|
|
dc_stream_adjust_vmin_vmax(
|
|
|
|
dm->dc, acrtc_state->stream,
|
|
|
|
&acrtc_state->vrr_params.adjust);
|
|
|
|
spin_unlock_irqrestore(&pcrtc->dev->event_lock, flags);
|
|
|
|
}
|
2018-12-19 15:45:16 +00:00
|
|
|
mutex_lock(&dm->dc_lock);
|
2019-09-20 23:03:17 +00:00
|
|
|
if ((acrtc_state->update_type > UPDATE_TYPE_FAST) &&
|
2020-03-31 13:31:16 +00:00
|
|
|
acrtc_state->stream->link->psr_settings.psr_allow_active)
|
2019-09-20 23:03:17 +00:00
|
|
|
amdgpu_dm_psr_disable(acrtc_state->stream);
|
|
|
|
|
2018-12-19 15:45:16 +00:00
|
|
|
dc_commit_updates_for_stream(dm->dc,
|
2019-03-01 23:22:07 +00:00
|
|
|
bundle->surface_updates,
|
2018-12-19 15:45:16 +00:00
|
|
|
planes_count,
|
|
|
|
acrtc_state->stream,
|
2019-03-01 23:22:07 +00:00
|
|
|
&bundle->stream_update,
|
2018-12-19 15:45:16 +00:00
|
|
|
dc_state);
|
2019-09-20 23:03:17 +00:00
|
|
|
|
2020-07-13 14:41:23 +00:00
|
|
|
/**
|
|
|
|
* Enable or disable the interrupts on the backend.
|
|
|
|
*
|
|
|
|
* Most pipes are put into power gating when unused.
|
|
|
|
*
|
|
|
|
* When power gating is enabled on a pipe we lose the
|
|
|
|
* interrupt enablement state when power gating is disabled.
|
|
|
|
*
|
|
|
|
* So we need to update the IRQ control state in hardware
|
|
|
|
* whenever the pipe turns on (since it could be previously
|
|
|
|
* power gated) or off (since some pipes can't be power gated
|
|
|
|
* on some ASICs).
|
|
|
|
*/
|
|
|
|
if (dm_old_crtc_state->active_planes != acrtc_state->active_planes)
|
|
|
|
dm_update_pflip_irq_state(
|
|
|
|
(struct amdgpu_device *)dev->dev_private,
|
|
|
|
acrtc_attach);
|
|
|
|
|
2019-09-20 23:03:17 +00:00
|
|
|
if ((acrtc_state->update_type > UPDATE_TYPE_FAST) &&
|
2020-04-22 02:01:30 +00:00
|
|
|
acrtc_state->stream->link->psr_settings.psr_version != DC_PSR_VERSION_UNSUPPORTED &&
|
2020-03-31 13:31:16 +00:00
|
|
|
!acrtc_state->stream->link->psr_settings.psr_feature_enabled)
|
2019-09-20 23:03:17 +00:00
|
|
|
amdgpu_dm_link_setup_psr(acrtc_state->stream);
|
|
|
|
else if ((acrtc_state->update_type == UPDATE_TYPE_FAST) &&
|
2020-03-31 13:31:16 +00:00
|
|
|
acrtc_state->stream->link->psr_settings.psr_feature_enabled &&
|
|
|
|
!acrtc_state->stream->link->psr_settings.psr_allow_active) {
|
2019-09-20 23:03:17 +00:00
|
|
|
amdgpu_dm_psr_enable(acrtc_state->stream);
|
|
|
|
}
|
|
|
|
|
2018-12-19 15:45:16 +00:00
|
|
|
mutex_unlock(&dm->dc_lock);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
2019-01-28 14:00:52 +00:00
|
|
|
|
2019-04-08 14:37:44 +00:00
|
|
|
/*
|
|
|
|
* Update cursor state *after* programming all the planes.
|
|
|
|
* This avoids redundant programming in the case where we're going
|
|
|
|
* to be disabling a single plane - those pipes are being disabled.
|
|
|
|
*/
|
|
|
|
if (acrtc_state->active_planes)
|
|
|
|
amdgpu_dm_commit_cursors(state);
|
2019-01-25 20:30:24 +00:00
|
|
|
|
2019-01-28 14:00:52 +00:00
|
|
|
cleanup:
|
2019-03-01 23:22:07 +00:00
|
|
|
kfree(bundle);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2019-07-11 19:31:46 +00:00
|
|
|
static void amdgpu_dm_commit_audio(struct drm_device *dev,
|
|
|
|
struct drm_atomic_state *state)
|
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
struct amdgpu_dm_connector *aconnector;
|
|
|
|
struct drm_connector *connector;
|
|
|
|
struct drm_connector_state *old_con_state, *new_con_state;
|
|
|
|
struct drm_crtc_state *new_crtc_state;
|
|
|
|
struct dm_crtc_state *new_dm_crtc_state;
|
|
|
|
const struct dc_stream_status *status;
|
|
|
|
int i, inst;
|
|
|
|
|
|
|
|
/* Notify device removals. */
|
|
|
|
for_each_oldnew_connector_in_state(state, connector, old_con_state, new_con_state, i) {
|
|
|
|
if (old_con_state->crtc != new_con_state->crtc) {
|
|
|
|
/* CRTC changes require notification. */
|
|
|
|
goto notify;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!new_con_state->crtc)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
new_crtc_state = drm_atomic_get_new_crtc_state(
|
|
|
|
state, new_con_state->crtc);
|
|
|
|
|
|
|
|
if (!new_crtc_state)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!drm_atomic_crtc_needs_modeset(new_crtc_state))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
notify:
|
|
|
|
aconnector = to_amdgpu_dm_connector(connector);
|
|
|
|
|
|
|
|
mutex_lock(&adev->dm.audio_lock);
|
|
|
|
inst = aconnector->audio_inst;
|
|
|
|
aconnector->audio_inst = -1;
|
|
|
|
mutex_unlock(&adev->dm.audio_lock);
|
|
|
|
|
|
|
|
amdgpu_dm_audio_eld_notify(adev, inst);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Notify audio device additions. */
|
|
|
|
for_each_new_connector_in_state(state, connector, new_con_state, i) {
|
|
|
|
if (!new_con_state->crtc)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
new_crtc_state = drm_atomic_get_new_crtc_state(
|
|
|
|
state, new_con_state->crtc);
|
|
|
|
|
|
|
|
if (!new_crtc_state)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!drm_atomic_crtc_needs_modeset(new_crtc_state))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
new_dm_crtc_state = to_dm_crtc_state(new_crtc_state);
|
|
|
|
if (!new_dm_crtc_state->stream)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
status = dc_stream_get_status(new_dm_crtc_state->stream);
|
|
|
|
if (!status)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
aconnector = to_amdgpu_dm_connector(connector);
|
|
|
|
|
|
|
|
mutex_lock(&adev->dm.audio_lock);
|
|
|
|
inst = status->audio_inst;
|
|
|
|
aconnector->audio_inst = inst;
|
|
|
|
mutex_unlock(&adev->dm.audio_lock);
|
|
|
|
|
|
|
|
amdgpu_dm_audio_eld_notify(adev, inst);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
2017-11-10 21:12:08 +00:00
|
|
|
* amdgpu_dm_crtc_copy_transient_flags - copy mirrored flags from DRM to DC
|
|
|
|
* @crtc_state: the DRM CRTC state
|
|
|
|
* @stream_state: the DC stream state.
|
|
|
|
*
|
|
|
|
* Copy the mirrored transient state flags from DRM, to DC. It is used to bring
|
|
|
|
* a dc_stream_state's flags in sync with a drm_crtc_state's flags.
|
|
|
|
*/
|
|
|
|
static void amdgpu_dm_crtc_copy_transient_flags(struct drm_crtc_state *crtc_state,
|
|
|
|
struct dc_stream_state *stream_state)
|
|
|
|
{
|
2019-02-08 18:21:05 +00:00
|
|
|
stream_state->mode_changed = drm_atomic_crtc_needs_modeset(crtc_state);
|
2017-11-10 21:12:08 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-10-10 21:51:02 +00:00
|
|
|
static int amdgpu_dm_atomic_commit(struct drm_device *dev,
|
|
|
|
struct drm_atomic_state *state,
|
|
|
|
bool nonblock)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct drm_crtc *crtc;
|
2017-10-12 21:15:08 +00:00
|
|
|
struct drm_crtc_state *old_crtc_state, *new_crtc_state;
|
2017-08-10 17:29:07 +00:00
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/*
|
2019-04-05 13:35:14 +00:00
|
|
|
* We evade vblank and pflip interrupts on CRTCs that are undergoing
|
|
|
|
* a modeset, being disabled, or have no active planes.
|
|
|
|
*
|
|
|
|
* It's done in atomic commit rather than commit tail for now since
|
|
|
|
* some of these interrupt handlers access the current CRTC state and
|
|
|
|
* potentially the stream pointer itself.
|
|
|
|
*
|
|
|
|
* Since the atomic state is swapped within atomic commit and not within
|
|
|
|
* commit tail this would leave to new state (that hasn't been committed yet)
|
|
|
|
* being accesssed from within the handlers.
|
|
|
|
*
|
|
|
|
* TODO: Fix this so we can do this in commit tail and not have to block
|
|
|
|
* in atomic check.
|
2017-08-10 17:29:07 +00:00
|
|
|
*/
|
2017-10-12 21:15:08 +00:00
|
|
|
for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
|
2017-08-10 17:29:07 +00:00
|
|
|
struct amdgpu_crtc *acrtc = to_amdgpu_crtc(crtc);
|
|
|
|
|
2020-07-13 14:41:23 +00:00
|
|
|
if (old_crtc_state->active &&
|
|
|
|
(!new_crtc_state->active ||
|
2019-08-20 14:16:14 +00:00
|
|
|
drm_atomic_crtc_needs_modeset(new_crtc_state)))
|
2017-08-10 17:29:07 +00:00
|
|
|
manage_dm_interrupts(adev, acrtc, false);
|
|
|
|
}
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Add check here for SoC's that support hardware cursor plane, to
|
|
|
|
* unset legacy_cursor_update
|
|
|
|
*/
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
return drm_atomic_helper_commit(dev, state, nonblock);
|
|
|
|
|
|
|
|
/*TODO Handle EINTR, reenable IRQ*/
|
|
|
|
}
|
|
|
|
|
2018-09-14 15:20:08 +00:00
|
|
|
/**
|
|
|
|
* amdgpu_dm_atomic_commit_tail() - AMDgpu DM's commit tail implementation.
|
|
|
|
* @state: The atomic state to commit
|
|
|
|
*
|
|
|
|
* This will tell DC to commit the constructed DC state from atomic_check,
|
|
|
|
* programming the hardware. Any failures here implies a hardware failure, since
|
|
|
|
* atomic check should have filtered anything non-kosher.
|
|
|
|
*/
|
2017-10-10 21:51:02 +00:00
|
|
|
static void amdgpu_dm_atomic_commit_tail(struct drm_atomic_state *state)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct drm_device *dev = state->dev;
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
|
|
|
struct amdgpu_display_manager *dm = &adev->dm;
|
|
|
|
struct dm_atomic_state *dm_state;
|
2018-11-22 17:34:36 +00:00
|
|
|
struct dc_state *dc_state = NULL, *dc_state_temp = NULL;
|
2017-08-10 17:29:07 +00:00
|
|
|
uint32_t i, j;
|
2017-10-12 21:15:11 +00:00
|
|
|
struct drm_crtc *crtc;
|
2017-10-12 21:15:07 +00:00
|
|
|
struct drm_crtc_state *old_crtc_state, *new_crtc_state;
|
2017-08-10 17:29:07 +00:00
|
|
|
unsigned long flags;
|
|
|
|
bool wait_for_vblank = true;
|
|
|
|
struct drm_connector *connector;
|
2017-10-12 21:15:08 +00:00
|
|
|
struct drm_connector_state *old_con_state, *new_con_state;
|
2017-10-12 21:15:09 +00:00
|
|
|
struct dm_crtc_state *dm_old_crtc_state, *dm_new_crtc_state;
|
2018-06-21 20:48:26 +00:00
|
|
|
int crtc_disable_count = 0;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
drm_atomic_helper_update_legacy_modeset_state(dev, state);
|
|
|
|
|
2018-11-22 17:34:36 +00:00
|
|
|
dm_state = dm_atomic_get_new_state(state);
|
|
|
|
if (dm_state && dm_state->context) {
|
|
|
|
dc_state = dm_state->context;
|
|
|
|
} else {
|
|
|
|
/* No state changes, retain current state. */
|
2019-02-22 18:37:03 +00:00
|
|
|
dc_state_temp = dc_create_state(dm->dc);
|
2018-11-22 17:34:36 +00:00
|
|
|
ASSERT(dc_state_temp);
|
|
|
|
dc_state = dc_state_temp;
|
|
|
|
dc_resource_state_copy_construct_current(dm->dc, dc_state);
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
/* update changed items */
|
2017-10-12 21:15:07 +00:00
|
|
|
for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
|
2017-08-10 17:29:07 +00:00
|
|
|
struct amdgpu_crtc *acrtc = to_amdgpu_crtc(crtc);
|
2017-07-27 01:03:22 +00:00
|
|
|
|
2017-10-12 21:15:09 +00:00
|
|
|
dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
|
|
|
|
dm_old_crtc_state = to_dm_crtc_state(old_crtc_state);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER(
|
2017-08-10 17:29:07 +00:00
|
|
|
"amdgpu_crtc id:%d crtc_state_flags: enable:%d, active:%d, "
|
|
|
|
"planes_changed:%d, mode_changed:%d,active_changed:%d,"
|
|
|
|
"connectors_changed:%d\n",
|
|
|
|
acrtc->crtc_id,
|
2017-10-12 21:15:07 +00:00
|
|
|
new_crtc_state->enable,
|
|
|
|
new_crtc_state->active,
|
|
|
|
new_crtc_state->planes_changed,
|
|
|
|
new_crtc_state->mode_changed,
|
|
|
|
new_crtc_state->active_changed,
|
|
|
|
new_crtc_state->connectors_changed);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-11-10 21:12:08 +00:00
|
|
|
/* Copy all transient state flags into dc state */
|
|
|
|
if (dm_new_crtc_state->stream) {
|
|
|
|
amdgpu_dm_crtc_copy_transient_flags(&dm_new_crtc_state->base,
|
|
|
|
dm_new_crtc_state->stream);
|
|
|
|
}
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
/* handles headless hotplug case, updating new_state and
|
|
|
|
* aconnector as needed
|
|
|
|
*/
|
|
|
|
|
2017-10-12 21:15:09 +00:00
|
|
|
if (modeset_required(new_crtc_state, dm_new_crtc_state->stream, dm_old_crtc_state->stream)) {
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("Atomic commit: SET crtc id %d: [%p]\n", acrtc->crtc_id, acrtc);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-10-12 21:15:09 +00:00
|
|
|
if (!dm_new_crtc_state->stream) {
|
2017-08-10 17:29:07 +00:00
|
|
|
/*
|
2017-07-27 01:03:22 +00:00
|
|
|
* this could happen because of issues with
|
|
|
|
* userspace notifications delivery.
|
|
|
|
* In this case userspace tries to set mode on
|
2018-08-15 18:38:30 +00:00
|
|
|
* display which is disconnected in fact.
|
|
|
|
* dc_sink is NULL in this case on aconnector.
|
2017-07-27 01:03:22 +00:00
|
|
|
* We expect reset mode will come soon.
|
|
|
|
*
|
|
|
|
* This can also happen when unplug is done
|
|
|
|
* during resume sequence ended
|
|
|
|
*
|
|
|
|
* In this case, we want to pretend we still
|
|
|
|
* have a sink to keep the pipe running so that
|
|
|
|
* hw state is consistent with the sw state
|
|
|
|
*/
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("%s: Failed to create new stream for crtc %d\n",
|
2017-08-10 17:29:07 +00:00
|
|
|
__func__, acrtc->base.base.id);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2017-10-12 21:15:09 +00:00
|
|
|
if (dm_old_crtc_state->stream)
|
|
|
|
remove_stream(adev, acrtc, dm_old_crtc_state->stream);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()
So, unfortunately I recently made the discovery that in the upstream
kernel, the only reason that amdgpu is not currently suffering from
issues with runtime PM putting the GPU into suspend while it's driving
displays is due to the fact that on most prime systems, we have sound
devices associated with the GPU that hold their own runtime PM ref for
the GPU.
What this means however, is that in the event that there isn't any kind
of sound device active (which can easily be reproduced by building a
kernel with sound drivers disabled), the GPU will fall asleep even when
there's displays active. This appears to be in part due to the fact that
amdgpu has not actually ever relied on it's rpm_idle() function to be
the only thing keeping it running, and normally grabs it's own power
references whenever there are displays active (as can be seen with the
original pre-DC codepath in amdgpu_display_crtc_set_config() in
amdgpu_display.c). This means it's very likely that this bug was
introduced during the switch over the DC.
So to fix this, we start grabbing runtime PM references every time we
enable a previously disabled CRTC in atomic_commit_tail(). This appears
to be the correct solution, as it matches up with what i915 does in
i915/intel_runtime_pm.c.
The one sideaffect of this is that we ignore the variable that the
pre-DC code used to use for tracking when it needed runtime PM refs,
adev->have_disp_power_ref. This is mainly because there's no way for a
driver to tell whether or not all of it's CRTCs are enabled or disabled
when we've begun committing an atomic state, as there may be CRTC
commits happening in parallel that aren't contained within the atomic
state being committed. So, it's safer to just get/put a reference for
each CRTC being enabled or disabled in the new atomic state.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Acked-by: Christian König <christian.koenig@amd.com>.
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
2018-06-04 19:35:03 +00:00
|
|
|
pm_runtime_get_noresume(dev->dev);
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
acrtc->enabled = true;
|
2017-10-12 21:15:07 +00:00
|
|
|
acrtc->hw_mode = new_crtc_state->mode;
|
|
|
|
crtc->hwmode = new_crtc_state->mode;
|
|
|
|
} else if (modereset_required(new_crtc_state)) {
|
2017-09-13 00:04:48 +00:00
|
|
|
DRM_DEBUG_DRIVER("Atomic commit: RESET. crtc id %d:[%p]\n", acrtc->crtc_id, acrtc);
|
2017-08-10 17:29:07 +00:00
|
|
|
/* i.e. reset mode */
|
2019-09-20 23:03:17 +00:00
|
|
|
if (dm_old_crtc_state->stream) {
|
2020-03-31 13:31:16 +00:00
|
|
|
if (dm_old_crtc_state->stream->link->psr_settings.psr_allow_active)
|
2019-09-20 23:03:17 +00:00
|
|
|
amdgpu_dm_psr_disable(dm_old_crtc_state->stream);
|
|
|
|
|
2017-10-12 21:15:09 +00:00
|
|
|
remove_stream(adev, acrtc, dm_old_crtc_state->stream);
|
2019-09-20 23:03:17 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
} /* for_each_crtc_in_state() */
|
|
|
|
|
2018-11-22 17:34:36 +00:00
|
|
|
if (dc_state) {
|
|
|
|
dm_enable_per_frame_crtc_master_sync(dc_state);
|
2018-12-05 19:59:07 +00:00
|
|
|
mutex_lock(&dm->dc_lock);
|
2018-11-22 17:34:36 +00:00
|
|
|
WARN_ON(!dc_commit_state(dm->dc, dc_state));
|
2018-12-05 19:59:07 +00:00
|
|
|
mutex_unlock(&dm->dc_lock);
|
2017-10-17 19:29:22 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-10-12 21:15:07 +00:00
|
|
|
for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
|
2017-08-10 17:29:07 +00:00
|
|
|
struct amdgpu_crtc *acrtc = to_amdgpu_crtc(crtc);
|
2017-07-27 01:03:22 +00:00
|
|
|
|
2017-10-12 21:15:09 +00:00
|
|
|
dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-10-12 21:15:09 +00:00
|
|
|
if (dm_new_crtc_state->stream != NULL) {
|
2017-08-10 17:29:07 +00:00
|
|
|
const struct dc_stream_status *status =
|
2017-10-12 21:15:09 +00:00
|
|
|
dc_stream_get_status(dm_new_crtc_state->stream);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-11-22 17:34:36 +00:00
|
|
|
if (!status)
|
2018-11-27 20:05:12 +00:00
|
|
|
status = dc_stream_get_status_from_state(dc_state,
|
|
|
|
dm_new_crtc_state->stream);
|
2018-11-22 17:34:36 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
if (!status)
|
2017-10-12 21:15:09 +00:00
|
|
|
DC_ERR("got no status for stream %p on acrtc%p\n", dm_new_crtc_state->stream, acrtc);
|
2017-08-10 17:29:07 +00:00
|
|
|
else
|
|
|
|
acrtc->otg_inst = status->primary_otg_inst;
|
|
|
|
}
|
|
|
|
}
|
2019-09-16 20:52:58 +00:00
|
|
|
#ifdef CONFIG_DRM_AMD_DC_HDCP
|
|
|
|
for_each_oldnew_connector_in_state(state, connector, old_con_state, new_con_state, i) {
|
|
|
|
struct dm_connector_state *dm_new_con_state = to_dm_connector_state(new_con_state);
|
|
|
|
struct amdgpu_crtc *acrtc = to_amdgpu_crtc(dm_new_con_state->base.crtc);
|
|
|
|
struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
|
|
|
|
|
|
|
|
new_crtc_state = NULL;
|
|
|
|
|
|
|
|
if (acrtc)
|
|
|
|
new_crtc_state = drm_atomic_get_new_crtc_state(state, &acrtc->base);
|
|
|
|
|
|
|
|
dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
|
|
|
|
|
|
|
|
if (dm_new_crtc_state && dm_new_crtc_state->stream == NULL &&
|
|
|
|
connector->state->content_protection == DRM_MODE_CONTENT_PROTECTION_ENABLED) {
|
|
|
|
hdcp_reset_display(adev->dm.hdcp_workqueue, aconnector->dc_link->link_index);
|
|
|
|
new_con_state->content_protection = DRM_MODE_CONTENT_PROTECTION_DESIRED;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (is_content_protection_different(new_con_state, old_con_state, connector, adev->dm.hdcp_workqueue))
|
2019-08-28 19:10:03 +00:00
|
|
|
hdcp_update_display(
|
|
|
|
adev->dm.hdcp_workqueue, aconnector->dc_link->link_index, aconnector,
|
2019-08-29 19:26:54 +00:00
|
|
|
new_con_state->hdcp_content_type,
|
2019-08-28 19:10:03 +00:00
|
|
|
new_con_state->content_protection == DRM_MODE_CONTENT_PROTECTION_DESIRED ? true
|
|
|
|
: false);
|
2019-09-16 20:52:58 +00:00
|
|
|
}
|
|
|
|
#endif
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-12-18 20:30:19 +00:00
|
|
|
/* Handle connector state changes */
|
2017-10-12 21:15:08 +00:00
|
|
|
for_each_oldnew_connector_in_state(state, connector, old_con_state, new_con_state, i) {
|
2017-10-12 21:15:09 +00:00
|
|
|
struct dm_connector_state *dm_new_con_state = to_dm_connector_state(new_con_state);
|
|
|
|
struct dm_connector_state *dm_old_con_state = to_dm_connector_state(old_con_state);
|
|
|
|
struct amdgpu_crtc *acrtc = to_amdgpu_crtc(dm_new_con_state->base.crtc);
|
2019-02-01 20:14:28 +00:00
|
|
|
struct dc_surface_update dummy_updates[MAX_SURFACES];
|
|
|
|
struct dc_stream_update stream_update;
|
2019-05-28 19:08:36 +00:00
|
|
|
struct dc_info_packet hdr_packet;
|
2017-08-10 17:29:07 +00:00
|
|
|
struct dc_stream_status *status = NULL;
|
2019-05-28 19:08:36 +00:00
|
|
|
bool abm_changed, hdr_changed, scaling_changed;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-02-01 20:14:28 +00:00
|
|
|
memset(&dummy_updates, 0, sizeof(dummy_updates));
|
|
|
|
memset(&stream_update, 0, sizeof(stream_update));
|
|
|
|
|
2018-03-15 18:29:24 +00:00
|
|
|
if (acrtc) {
|
2017-10-12 21:15:07 +00:00
|
|
|
new_crtc_state = drm_atomic_get_new_crtc_state(state, &acrtc->base);
|
2018-03-15 18:29:24 +00:00
|
|
|
old_crtc_state = drm_atomic_get_old_crtc_state(state, &acrtc->base);
|
|
|
|
}
|
2017-10-12 21:15:07 +00:00
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
/* Skip any modesets/resets */
|
2017-10-12 21:15:07 +00:00
|
|
|
if (!acrtc || drm_atomic_crtc_needs_modeset(new_crtc_state))
|
2017-08-10 17:29:07 +00:00
|
|
|
continue;
|
|
|
|
|
2017-10-12 21:15:09 +00:00
|
|
|
dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
|
2018-11-26 20:51:09 +00:00
|
|
|
dm_old_crtc_state = to_dm_crtc_state(old_crtc_state);
|
|
|
|
|
2019-05-28 19:08:36 +00:00
|
|
|
scaling_changed = is_scaling_state_different(dm_new_con_state,
|
|
|
|
dm_old_con_state);
|
|
|
|
|
|
|
|
abm_changed = dm_new_crtc_state->abm_level !=
|
|
|
|
dm_old_crtc_state->abm_level;
|
|
|
|
|
|
|
|
hdr_changed =
|
|
|
|
is_hdr_metadata_different(old_con_state, new_con_state);
|
|
|
|
|
|
|
|
if (!scaling_changed && !abm_changed && !hdr_changed)
|
2018-11-26 20:51:09 +00:00
|
|
|
continue;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-09-13 23:00:28 +00:00
|
|
|
stream_update.stream = dm_new_crtc_state->stream;
|
2019-05-28 19:08:36 +00:00
|
|
|
if (scaling_changed) {
|
2018-12-18 20:30:19 +00:00
|
|
|
update_stream_scaling_settings(&dm_new_con_state->base.crtc->mode,
|
2019-09-13 23:00:28 +00:00
|
|
|
dm_new_con_state, dm_new_crtc_state->stream);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-12-18 20:30:19 +00:00
|
|
|
stream_update.src = dm_new_crtc_state->stream->src;
|
|
|
|
stream_update.dst = dm_new_crtc_state->stream->dst;
|
|
|
|
}
|
|
|
|
|
2019-05-28 19:08:36 +00:00
|
|
|
if (abm_changed) {
|
2018-12-18 20:30:19 +00:00
|
|
|
dm_new_crtc_state->stream->abm_level = dm_new_crtc_state->abm_level;
|
|
|
|
|
|
|
|
stream_update.abm_level = &dm_new_crtc_state->abm_level;
|
|
|
|
}
|
2017-11-10 16:19:02 +00:00
|
|
|
|
2019-05-28 19:08:36 +00:00
|
|
|
if (hdr_changed) {
|
|
|
|
fill_hdr_info_packet(new_con_state, &hdr_packet);
|
|
|
|
stream_update.hdr_static_metadata = &hdr_packet;
|
|
|
|
}
|
|
|
|
|
2017-10-12 21:15:09 +00:00
|
|
|
status = dc_stream_get_status(dm_new_crtc_state->stream);
|
2017-08-10 17:29:07 +00:00
|
|
|
WARN_ON(!status);
|
2017-07-27 13:55:38 +00:00
|
|
|
WARN_ON(!status->plane_count);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-12-18 20:30:19 +00:00
|
|
|
/*
|
|
|
|
* TODO: DC refuses to perform stream updates without a dc_surface_update.
|
|
|
|
* Here we create an empty update on each plane.
|
|
|
|
* To fix this, DC should permit updating only stream properties.
|
|
|
|
*/
|
|
|
|
for (j = 0; j < status->plane_count; j++)
|
|
|
|
dummy_updates[j].surface = status->plane_states[0];
|
|
|
|
|
|
|
|
|
|
|
|
mutex_lock(&dm->dc_lock);
|
|
|
|
dc_commit_updates_for_stream(dm->dc,
|
|
|
|
dummy_updates,
|
|
|
|
status->plane_count,
|
|
|
|
dm_new_crtc_state->stream,
|
|
|
|
&stream_update,
|
|
|
|
dc_state);
|
|
|
|
mutex_unlock(&dm->dc_lock);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2019-04-08 15:18:31 +00:00
|
|
|
/* Count number of newly disabled CRTCs for dropping PM refs later. */
|
2017-10-18 19:32:41 +00:00
|
|
|
for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state,
|
2019-04-15 16:18:53 +00:00
|
|
|
new_crtc_state, i) {
|
2018-06-21 20:48:26 +00:00
|
|
|
if (old_crtc_state->active && !new_crtc_state->active)
|
|
|
|
crtc_disable_count++;
|
|
|
|
|
2017-10-12 21:15:09 +00:00
|
|
|
dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
|
2017-10-18 19:32:41 +00:00
|
|
|
dm_old_crtc_state = to_dm_crtc_state(old_crtc_state);
|
2019-03-29 12:00:54 +00:00
|
|
|
|
2019-04-15 16:18:53 +00:00
|
|
|
/* Update freesync active state. */
|
|
|
|
pre_update_freesync_state_on_stream(dm, dm_new_crtc_state);
|
|
|
|
|
2019-03-29 12:00:54 +00:00
|
|
|
/* Handle vrr on->off / off->on transitions */
|
|
|
|
amdgpu_dm_handle_vrr_transition(dm_old_crtc_state,
|
|
|
|
dm_new_crtc_state);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2020-07-13 14:41:23 +00:00
|
|
|
/**
|
|
|
|
* Enable interrupts for CRTCs that are newly enabled or went through
|
|
|
|
* a modeset. It was intentionally deferred until after the front end
|
|
|
|
* state was modified to wait until the OTG was on and so the IRQ
|
|
|
|
* handlers didn't access stale or invalid state.
|
|
|
|
*/
|
|
|
|
for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
|
|
|
|
struct amdgpu_crtc *acrtc = to_amdgpu_crtc(crtc);
|
|
|
|
|
|
|
|
if (new_crtc_state->active &&
|
|
|
|
(!old_crtc_state->active ||
|
|
|
|
drm_atomic_crtc_needs_modeset(new_crtc_state))) {
|
|
|
|
manage_dm_interrupts(adev, acrtc, true);
|
|
|
|
#ifdef CONFIG_DEBUG_FS
|
|
|
|
/**
|
|
|
|
* Frontend may have changed so reapply the CRC capture
|
|
|
|
* settings for the stream.
|
|
|
|
*/
|
|
|
|
dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
|
|
|
|
|
|
|
|
if (amdgpu_dm_is_valid_crc_source(dm_new_crtc_state->crc_src)) {
|
|
|
|
amdgpu_dm_crtc_configure_crc_source(
|
|
|
|
crtc, dm_new_crtc_state,
|
|
|
|
dm_new_crtc_state->crc_src);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
}
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2019-03-01 23:15:26 +00:00
|
|
|
for_each_new_crtc_in_state(state, crtc, new_crtc_state, j)
|
2019-09-03 19:06:42 +00:00
|
|
|
if (new_crtc_state->async_flip)
|
2019-03-01 23:15:26 +00:00
|
|
|
wait_for_vblank = false;
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
/* update planes when needed per crtc*/
|
2017-10-12 21:15:11 +00:00
|
|
|
for_each_new_crtc_in_state(state, crtc, new_crtc_state, j) {
|
2017-10-12 21:15:09 +00:00
|
|
|
dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-10-12 21:15:09 +00:00
|
|
|
if (dm_new_crtc_state->stream)
|
2018-11-22 17:34:36 +00:00
|
|
|
amdgpu_dm_commit_planes(state, dc_state, dev,
|
2019-03-01 23:15:26 +00:00
|
|
|
dm, crtc, wait_for_vblank);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2019-07-11 19:31:46 +00:00
|
|
|
/* Update audio instances for each connector. */
|
|
|
|
amdgpu_dm_commit_audio(dev, state);
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
/*
|
|
|
|
* send vblank event on all events not handled in flip and
|
|
|
|
* mark consumed event for drm_atomic_helper_commit_hw_done
|
|
|
|
*/
|
|
|
|
spin_lock_irqsave(&adev->ddev->event_lock, flags);
|
2017-10-12 21:15:07 +00:00
|
|
|
for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-10-12 21:15:07 +00:00
|
|
|
if (new_crtc_state->event)
|
|
|
|
drm_send_event_locked(dev, &new_crtc_state->event->base);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-10-12 21:15:07 +00:00
|
|
|
new_crtc_state->event = NULL;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&adev->ddev->event_lock, flags);
|
|
|
|
|
2019-01-07 18:28:54 +00:00
|
|
|
/* Signal HW programming completion */
|
|
|
|
drm_atomic_helper_commit_hw_done(state);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
if (wait_for_vblank)
|
2017-11-15 01:45:52 +00:00
|
|
|
drm_atomic_helper_wait_for_flip_done(dev, state);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
drm_atomic_helper_cleanup_planes(dev, state);
|
drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()
So, unfortunately I recently made the discovery that in the upstream
kernel, the only reason that amdgpu is not currently suffering from
issues with runtime PM putting the GPU into suspend while it's driving
displays is due to the fact that on most prime systems, we have sound
devices associated with the GPU that hold their own runtime PM ref for
the GPU.
What this means however, is that in the event that there isn't any kind
of sound device active (which can easily be reproduced by building a
kernel with sound drivers disabled), the GPU will fall asleep even when
there's displays active. This appears to be in part due to the fact that
amdgpu has not actually ever relied on it's rpm_idle() function to be
the only thing keeping it running, and normally grabs it's own power
references whenever there are displays active (as can be seen with the
original pre-DC codepath in amdgpu_display_crtc_set_config() in
amdgpu_display.c). This means it's very likely that this bug was
introduced during the switch over the DC.
So to fix this, we start grabbing runtime PM references every time we
enable a previously disabled CRTC in atomic_commit_tail(). This appears
to be the correct solution, as it matches up with what i915 does in
i915/intel_runtime_pm.c.
The one sideaffect of this is that we ignore the variable that the
pre-DC code used to use for tracking when it needed runtime PM refs,
adev->have_disp_power_ref. This is mainly because there's no way for a
driver to tell whether or not all of it's CRTCs are enabled or disabled
when we've begun committing an atomic state, as there may be CRTC
commits happening in parallel that aren't contained within the atomic
state being committed. So, it's safer to just get/put a reference for
each CRTC being enabled or disabled in the new atomic state.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Acked-by: Christian König <christian.koenig@amd.com>.
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
2018-06-04 19:35:03 +00:00
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Finally, drop a runtime PM reference for each newly disabled CRTC,
|
drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()
So, unfortunately I recently made the discovery that in the upstream
kernel, the only reason that amdgpu is not currently suffering from
issues with runtime PM putting the GPU into suspend while it's driving
displays is due to the fact that on most prime systems, we have sound
devices associated with the GPU that hold their own runtime PM ref for
the GPU.
What this means however, is that in the event that there isn't any kind
of sound device active (which can easily be reproduced by building a
kernel with sound drivers disabled), the GPU will fall asleep even when
there's displays active. This appears to be in part due to the fact that
amdgpu has not actually ever relied on it's rpm_idle() function to be
the only thing keeping it running, and normally grabs it's own power
references whenever there are displays active (as can be seen with the
original pre-DC codepath in amdgpu_display_crtc_set_config() in
amdgpu_display.c). This means it's very likely that this bug was
introduced during the switch over the DC.
So to fix this, we start grabbing runtime PM references every time we
enable a previously disabled CRTC in atomic_commit_tail(). This appears
to be the correct solution, as it matches up with what i915 does in
i915/intel_runtime_pm.c.
The one sideaffect of this is that we ignore the variable that the
pre-DC code used to use for tracking when it needed runtime PM refs,
adev->have_disp_power_ref. This is mainly because there's no way for a
driver to tell whether or not all of it's CRTCs are enabled or disabled
when we've begun committing an atomic state, as there may be CRTC
commits happening in parallel that aren't contained within the atomic
state being committed. So, it's safer to just get/put a reference for
each CRTC being enabled or disabled in the new atomic state.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Acked-by: Christian König <christian.koenig@amd.com>.
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
2018-06-04 19:35:03 +00:00
|
|
|
* so we can put the GPU into runtime suspend if we're not driving any
|
|
|
|
* displays anymore
|
|
|
|
*/
|
2018-06-21 20:48:26 +00:00
|
|
|
for (i = 0; i < crtc_disable_count; i++)
|
|
|
|
pm_runtime_put_autosuspend(dev->dev);
|
drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()
So, unfortunately I recently made the discovery that in the upstream
kernel, the only reason that amdgpu is not currently suffering from
issues with runtime PM putting the GPU into suspend while it's driving
displays is due to the fact that on most prime systems, we have sound
devices associated with the GPU that hold their own runtime PM ref for
the GPU.
What this means however, is that in the event that there isn't any kind
of sound device active (which can easily be reproduced by building a
kernel with sound drivers disabled), the GPU will fall asleep even when
there's displays active. This appears to be in part due to the fact that
amdgpu has not actually ever relied on it's rpm_idle() function to be
the only thing keeping it running, and normally grabs it's own power
references whenever there are displays active (as can be seen with the
original pre-DC codepath in amdgpu_display_crtc_set_config() in
amdgpu_display.c). This means it's very likely that this bug was
introduced during the switch over the DC.
So to fix this, we start grabbing runtime PM references every time we
enable a previously disabled CRTC in atomic_commit_tail(). This appears
to be the correct solution, as it matches up with what i915 does in
i915/intel_runtime_pm.c.
The one sideaffect of this is that we ignore the variable that the
pre-DC code used to use for tracking when it needed runtime PM refs,
adev->have_disp_power_ref. This is mainly because there's no way for a
driver to tell whether or not all of it's CRTCs are enabled or disabled
when we've begun committing an atomic state, as there may be CRTC
commits happening in parallel that aren't contained within the atomic
state being committed. So, it's safer to just get/put a reference for
each CRTC being enabled or disabled in the new atomic state.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Acked-by: Christian König <christian.koenig@amd.com>.
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
2018-06-04 19:35:03 +00:00
|
|
|
pm_runtime_mark_last_busy(dev->dev);
|
2018-11-22 17:34:36 +00:00
|
|
|
|
|
|
|
if (dc_state_temp)
|
|
|
|
dc_release_state(dc_state_temp);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int dm_force_atomic_commit(struct drm_connector *connector)
|
|
|
|
{
|
|
|
|
int ret = 0;
|
|
|
|
struct drm_device *ddev = connector->dev;
|
|
|
|
struct drm_atomic_state *state = drm_atomic_state_alloc(ddev);
|
|
|
|
struct amdgpu_crtc *disconnected_acrtc = to_amdgpu_crtc(connector->encoder->crtc);
|
|
|
|
struct drm_plane *plane = disconnected_acrtc->base.primary;
|
|
|
|
struct drm_connector_state *conn_state;
|
|
|
|
struct drm_crtc_state *crtc_state;
|
|
|
|
struct drm_plane_state *plane_state;
|
|
|
|
|
|
|
|
if (!state)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
state->acquire_ctx = ddev->mode_config.acquire_ctx;
|
|
|
|
|
|
|
|
/* Construct an atomic state to restore previous display setting */
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Attach connectors to drm_atomic_state
|
|
|
|
*/
|
|
|
|
conn_state = drm_atomic_get_connector_state(state, connector);
|
|
|
|
|
|
|
|
ret = PTR_ERR_OR_ZERO(conn_state);
|
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
/* Attach crtc to drm_atomic_state*/
|
|
|
|
crtc_state = drm_atomic_get_crtc_state(state, &disconnected_acrtc->base);
|
|
|
|
|
|
|
|
ret = PTR_ERR_OR_ZERO(crtc_state);
|
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
/* force a restore */
|
|
|
|
crtc_state->mode_changed = true;
|
|
|
|
|
|
|
|
/* Attach plane to drm_atomic_state */
|
|
|
|
plane_state = drm_atomic_get_plane_state(state, plane);
|
|
|
|
|
|
|
|
ret = PTR_ERR_OR_ZERO(plane_state);
|
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
|
|
|
|
/* Call commit internally with the state we just constructed */
|
|
|
|
ret = drm_atomic_commit(state);
|
|
|
|
if (!ret)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
err:
|
|
|
|
DRM_ERROR("Restoring old state failed with %i\n", ret);
|
|
|
|
drm_atomic_state_put(state);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2018-08-15 18:38:30 +00:00
|
|
|
* This function handles all cases when set mode does not come upon hotplug.
|
|
|
|
* This includes when a display is unplugged then plugged back into the
|
|
|
|
* same port and when running without usermode desktop manager supprot
|
2017-08-10 17:29:07 +00:00
|
|
|
*/
|
2017-10-10 21:44:52 +00:00
|
|
|
void dm_restore_drm_connector_state(struct drm_device *dev,
|
|
|
|
struct drm_connector *connector)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
|
2017-08-10 17:29:07 +00:00
|
|
|
struct amdgpu_crtc *disconnected_acrtc;
|
|
|
|
struct dm_crtc_state *acrtc_state;
|
|
|
|
|
|
|
|
if (!aconnector->dc_sink || !connector->state || !connector->encoder)
|
|
|
|
return;
|
|
|
|
|
|
|
|
disconnected_acrtc = to_amdgpu_crtc(connector->encoder->crtc);
|
2017-11-10 16:19:02 +00:00
|
|
|
if (!disconnected_acrtc)
|
|
|
|
return;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-11-10 16:19:02 +00:00
|
|
|
acrtc_state = to_dm_crtc_state(disconnected_acrtc->base.state);
|
|
|
|
if (!acrtc_state->stream)
|
2017-08-10 17:29:07 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the previous sink is not released and different from the current,
|
|
|
|
* we deduce we are in a state where we can not rely on usermode call
|
|
|
|
* to turn on the display, so we do it here
|
|
|
|
*/
|
|
|
|
if (acrtc_state->stream->sink != aconnector->dc_sink)
|
|
|
|
dm_force_atomic_commit(&aconnector->base);
|
|
|
|
}
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
2017-08-10 17:29:07 +00:00
|
|
|
* Grabs all modesetting locks to serialize against any blocking commits,
|
|
|
|
* Waits for completion of all non blocking commits.
|
|
|
|
*/
|
2017-10-10 21:44:52 +00:00
|
|
|
static int do_aquire_global_lock(struct drm_device *dev,
|
|
|
|
struct drm_atomic_state *state)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
struct drm_crtc *crtc;
|
|
|
|
struct drm_crtc_commit *commit;
|
|
|
|
long ret;
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Adding all modeset locks to aquire_ctx will
|
2017-08-10 17:29:07 +00:00
|
|
|
* ensure that when the framework release it the
|
|
|
|
* extra locks we are locking here will get released to
|
|
|
|
*/
|
|
|
|
ret = drm_modeset_lock_all_ctx(dev, state->acquire_ctx);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
|
|
|
|
spin_lock(&crtc->commit_lock);
|
|
|
|
commit = list_first_entry_or_null(&crtc->commit_list,
|
|
|
|
struct drm_crtc_commit, commit_entry);
|
|
|
|
if (commit)
|
|
|
|
drm_crtc_commit_get(commit);
|
|
|
|
spin_unlock(&crtc->commit_lock);
|
|
|
|
|
|
|
|
if (!commit)
|
|
|
|
continue;
|
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* Make sure all pending HW programming completed and
|
2017-08-10 17:29:07 +00:00
|
|
|
* page flips done
|
|
|
|
*/
|
|
|
|
ret = wait_for_completion_interruptible_timeout(&commit->hw_done, 10*HZ);
|
|
|
|
|
|
|
|
if (ret > 0)
|
|
|
|
ret = wait_for_completion_interruptible_timeout(
|
|
|
|
&commit->flip_done, 10*HZ);
|
|
|
|
|
|
|
|
if (ret == 0)
|
|
|
|
DRM_ERROR("[CRTC:%d:%s] hw_done or flip_done "
|
2017-07-27 01:03:22 +00:00
|
|
|
"timed out\n", crtc->base.id, crtc->name);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
drm_crtc_commit_put(commit);
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret < 0 ? ret : 0;
|
|
|
|
}
|
|
|
|
|
2018-10-04 17:03:30 +00:00
|
|
|
static void get_freesync_config_for_crtc(
|
|
|
|
struct dm_crtc_state *new_crtc_state,
|
|
|
|
struct dm_connector_state *new_con_state)
|
2018-08-21 19:40:28 +00:00
|
|
|
{
|
|
|
|
struct mod_freesync_config config = {0};
|
|
|
|
struct amdgpu_dm_connector *aconnector =
|
|
|
|
to_amdgpu_dm_connector(new_con_state->base.connector);
|
2019-01-17 18:40:34 +00:00
|
|
|
struct drm_display_mode *mode = &new_crtc_state->base.mode;
|
2019-03-21 15:53:45 +00:00
|
|
|
int vrefresh = drm_mode_vrefresh(mode);
|
2018-08-21 19:40:28 +00:00
|
|
|
|
2019-01-17 18:40:34 +00:00
|
|
|
new_crtc_state->vrr_supported = new_con_state->freesync_capable &&
|
2019-03-21 15:53:45 +00:00
|
|
|
vrefresh >= aconnector->min_vfreq &&
|
|
|
|
vrefresh <= aconnector->max_vfreq;
|
2018-10-04 17:03:30 +00:00
|
|
|
|
2019-01-17 18:40:34 +00:00
|
|
|
if (new_crtc_state->vrr_supported) {
|
|
|
|
new_crtc_state->stream->ignore_msa_timing_param = true;
|
2018-10-04 17:03:30 +00:00
|
|
|
config.state = new_crtc_state->base.vrr_enabled ?
|
2018-08-21 19:40:28 +00:00
|
|
|
VRR_STATE_ACTIVE_VARIABLE :
|
|
|
|
VRR_STATE_INACTIVE;
|
|
|
|
config.min_refresh_in_uhz =
|
|
|
|
aconnector->min_vfreq * 1000000;
|
|
|
|
config.max_refresh_in_uhz =
|
|
|
|
aconnector->max_vfreq * 1000000;
|
2018-05-08 21:09:49 +00:00
|
|
|
config.vsif_supported = true;
|
2018-12-05 17:08:56 +00:00
|
|
|
config.btr = true;
|
2018-08-21 19:40:28 +00:00
|
|
|
}
|
|
|
|
|
2018-10-04 17:03:30 +00:00
|
|
|
new_crtc_state->freesync_config = config;
|
|
|
|
}
|
2018-08-21 19:40:28 +00:00
|
|
|
|
2018-10-04 17:03:30 +00:00
|
|
|
static void reset_freesync_config_for_crtc(
|
|
|
|
struct dm_crtc_state *new_crtc_state)
|
|
|
|
{
|
|
|
|
new_crtc_state->vrr_supported = false;
|
2018-08-21 19:40:28 +00:00
|
|
|
|
2018-12-05 17:08:56 +00:00
|
|
|
memset(&new_crtc_state->vrr_params, 0,
|
|
|
|
sizeof(new_crtc_state->vrr_params));
|
2018-10-04 17:03:30 +00:00
|
|
|
memset(&new_crtc_state->vrr_infopacket, 0,
|
|
|
|
sizeof(new_crtc_state->vrr_infopacket));
|
2018-08-21 19:40:28 +00:00
|
|
|
}
|
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
static int dm_update_crtc_state(struct amdgpu_display_manager *dm,
|
|
|
|
struct drm_atomic_state *state,
|
|
|
|
struct drm_crtc *crtc,
|
|
|
|
struct drm_crtc_state *old_crtc_state,
|
|
|
|
struct drm_crtc_state *new_crtc_state,
|
|
|
|
bool enable,
|
|
|
|
bool *lock_and_validation_needed)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
2018-11-22 17:34:36 +00:00
|
|
|
struct dm_atomic_state *dm_state = NULL;
|
2017-10-12 21:15:09 +00:00
|
|
|
struct dm_crtc_state *dm_old_crtc_state, *dm_new_crtc_state;
|
2017-09-12 16:10:25 +00:00
|
|
|
struct dc_stream_state *new_stream;
|
2017-08-18 14:52:20 +00:00
|
|
|
int ret = 0;
|
2017-09-21 20:13:00 +00:00
|
|
|
|
2018-08-15 18:38:30 +00:00
|
|
|
/*
|
|
|
|
* TODO Move this code into dm_crtc_atomic_check once we get rid of dc_validation_set
|
|
|
|
* update changed items
|
|
|
|
*/
|
2018-11-11 16:35:13 +00:00
|
|
|
struct amdgpu_crtc *acrtc = NULL;
|
|
|
|
struct amdgpu_dm_connector *aconnector = NULL;
|
|
|
|
struct drm_connector_state *drm_new_conn_state = NULL, *drm_old_conn_state = NULL;
|
|
|
|
struct dm_connector_state *dm_new_conn_state = NULL, *dm_old_conn_state = NULL;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
new_stream = NULL;
|
2017-09-12 16:10:25 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
dm_old_crtc_state = to_dm_crtc_state(old_crtc_state);
|
|
|
|
dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
|
|
|
|
acrtc = to_amdgpu_crtc(crtc);
|
|
|
|
aconnector = amdgpu_dm_find_first_crtc_matching_connector(state, crtc);
|
2017-08-11 14:43:45 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
/* TODO This hack should go away */
|
|
|
|
if (aconnector && enable) {
|
|
|
|
/* Make sure fake sink is created in plug-in scenario */
|
|
|
|
drm_new_conn_state = drm_atomic_get_new_connector_state(state,
|
|
|
|
&aconnector->base);
|
|
|
|
drm_old_conn_state = drm_atomic_get_old_connector_state(state,
|
|
|
|
&aconnector->base);
|
2017-08-11 14:43:45 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
if (IS_ERR(drm_new_conn_state)) {
|
|
|
|
ret = PTR_ERR_OR_ZERO(drm_new_conn_state);
|
|
|
|
goto fail;
|
|
|
|
}
|
2017-08-11 14:43:45 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
dm_new_conn_state = to_dm_connector_state(drm_new_conn_state);
|
|
|
|
dm_old_conn_state = to_dm_connector_state(drm_old_conn_state);
|
2017-08-11 14:43:45 +00:00
|
|
|
|
2019-01-11 21:34:31 +00:00
|
|
|
if (!drm_atomic_crtc_needs_modeset(new_crtc_state))
|
|
|
|
goto skip_modeset;
|
|
|
|
|
2020-04-30 08:40:09 +00:00
|
|
|
new_stream = create_validate_stream_for_sink(aconnector,
|
|
|
|
&new_crtc_state->mode,
|
|
|
|
dm_new_conn_state,
|
|
|
|
dm_old_crtc_state->stream);
|
2017-08-11 14:43:45 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
/*
|
|
|
|
* we can have no stream on ACTION_SET if a display
|
|
|
|
* was disconnected during S3, in this case it is not an
|
|
|
|
* error, the OS will be updated after detection, and
|
|
|
|
* will do the right thing on next atomic commit
|
|
|
|
*/
|
2017-08-11 14:43:45 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
if (!new_stream) {
|
|
|
|
DRM_DEBUG_DRIVER("%s: Failed to create new stream for crtc %d\n",
|
|
|
|
__func__, acrtc->base.base.id);
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto fail;
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
dm_new_crtc_state->abm_level = dm_new_conn_state->abm_level;
|
2018-08-21 19:40:28 +00:00
|
|
|
|
2019-05-28 19:08:35 +00:00
|
|
|
ret = fill_hdr_info_packet(drm_new_conn_state,
|
|
|
|
&new_stream->hdr_static_metadata);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
|
|
|
|
2019-06-11 16:54:05 +00:00
|
|
|
/*
|
|
|
|
* If we already removed the old stream from the context
|
|
|
|
* (and set the new stream to NULL) then we can't reuse
|
|
|
|
* the old stream even if the stream and scaling are unchanged.
|
|
|
|
* We'll hit the BUG_ON and black screen.
|
|
|
|
*
|
|
|
|
* TODO: Refactor this function to allow this check to work
|
|
|
|
* in all conditions.
|
|
|
|
*/
|
|
|
|
if (dm_new_crtc_state->stream &&
|
|
|
|
dc_is_stream_unchanged(new_stream, dm_old_crtc_state->stream) &&
|
2018-11-11 16:35:13 +00:00
|
|
|
dc_is_stream_scaling_unchanged(new_stream, dm_old_crtc_state->stream)) {
|
|
|
|
new_crtc_state->mode_changed = false;
|
|
|
|
DRM_DEBUG_DRIVER("Mode change not required, setting mode_changed to %d",
|
|
|
|
new_crtc_state->mode_changed);
|
2017-08-18 14:52:20 +00:00
|
|
|
}
|
2018-11-11 16:35:13 +00:00
|
|
|
}
|
2017-07-27 01:03:22 +00:00
|
|
|
|
2019-01-11 21:34:31 +00:00
|
|
|
/* mode_changed flag may get updated above, need to check again */
|
2018-11-11 16:35:13 +00:00
|
|
|
if (!drm_atomic_crtc_needs_modeset(new_crtc_state))
|
|
|
|
goto skip_modeset;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
DRM_DEBUG_DRIVER(
|
|
|
|
"amdgpu_crtc id:%d crtc_state_flags: enable:%d, active:%d, "
|
|
|
|
"planes_changed:%d, mode_changed:%d,active_changed:%d,"
|
|
|
|
"connectors_changed:%d\n",
|
|
|
|
acrtc->crtc_id,
|
|
|
|
new_crtc_state->enable,
|
|
|
|
new_crtc_state->active,
|
|
|
|
new_crtc_state->planes_changed,
|
|
|
|
new_crtc_state->mode_changed,
|
|
|
|
new_crtc_state->active_changed,
|
|
|
|
new_crtc_state->connectors_changed);
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
/* Remove stream for any changed/disabled CRTC */
|
|
|
|
if (!enable) {
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
if (!dm_old_crtc_state->stream)
|
|
|
|
goto skip_modeset;
|
2018-11-22 17:34:36 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
ret = dm_atomic_get_state(state, &dm_state);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
DRM_DEBUG_DRIVER("Disabling DRM crtc: %d\n",
|
|
|
|
crtc->base.id);
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
/* i.e. reset mode */
|
|
|
|
if (dc_remove_stream_from_ctx(
|
|
|
|
dm->dc,
|
|
|
|
dm_state->context,
|
|
|
|
dm_old_crtc_state->stream) != DC_OK) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto fail;
|
|
|
|
}
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
dc_stream_release(dm_old_crtc_state->stream);
|
|
|
|
dm_new_crtc_state->stream = NULL;
|
2018-10-04 17:03:30 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
reset_freesync_config_for_crtc(dm_new_crtc_state);
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
*lock_and_validation_needed = true;
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
} else {/* Add stream for any updated/enabled CRTC */
|
|
|
|
/*
|
|
|
|
* Quick fix to prevent NULL pointer on new_stream when
|
|
|
|
* added MST connectors not found in existing crtc_state in the chained mode
|
|
|
|
* TODO: need to dig out the root cause of that
|
|
|
|
*/
|
|
|
|
if (!aconnector || (!aconnector->dc_sink && aconnector->mst_port))
|
|
|
|
goto skip_modeset;
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
if (modereset_required(new_crtc_state))
|
|
|
|
goto skip_modeset;
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
if (modeset_required(new_crtc_state, new_stream,
|
|
|
|
dm_old_crtc_state->stream)) {
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
WARN_ON(dm_new_crtc_state->stream);
|
2018-11-22 17:34:36 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
ret = dm_atomic_get_state(state, &dm_state);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-11-10 21:12:08 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
dm_new_crtc_state->stream = new_stream;
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
dc_stream_retain(new_stream);
|
2017-07-31 15:29:25 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
DRM_DEBUG_DRIVER("Enabling DRM crtc: %d\n",
|
|
|
|
crtc->base.id);
|
2017-07-31 15:29:25 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
if (dc_add_stream_to_ctx(
|
|
|
|
dm->dc,
|
|
|
|
dm_state->context,
|
|
|
|
dm_new_crtc_state->stream) != DC_OK) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto fail;
|
2017-07-28 17:11:00 +00:00
|
|
|
}
|
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
*lock_and_validation_needed = true;
|
|
|
|
}
|
|
|
|
}
|
2018-02-02 15:18:56 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
skip_modeset:
|
|
|
|
/* Release extra reference */
|
|
|
|
if (new_stream)
|
|
|
|
dc_stream_release(new_stream);
|
2018-02-02 15:18:56 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
/*
|
|
|
|
* We want to do dc stream updates that do not require a
|
|
|
|
* full modeset below.
|
|
|
|
*/
|
|
|
|
if (!(enable && aconnector && new_crtc_state->enable &&
|
|
|
|
new_crtc_state->active))
|
|
|
|
return 0;
|
|
|
|
/*
|
|
|
|
* Given above conditions, the dc state cannot be NULL because:
|
|
|
|
* 1. We're in the process of enabling CRTCs (just been added
|
|
|
|
* to the dc context, or already is on the context)
|
|
|
|
* 2. Has a valid connector attached, and
|
|
|
|
* 3. Is currently active and enabled.
|
|
|
|
* => The dc stream state currently exists.
|
|
|
|
*/
|
|
|
|
BUG_ON(dm_new_crtc_state->stream == NULL);
|
2018-05-31 17:48:31 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
/* Scaling or underscan settings */
|
|
|
|
if (is_scaling_state_different(dm_old_conn_state, dm_new_conn_state))
|
|
|
|
update_stream_scaling_settings(
|
|
|
|
&new_crtc_state->mode, dm_new_conn_state, dm_new_crtc_state->stream);
|
2018-08-21 19:40:28 +00:00
|
|
|
|
2019-03-04 15:31:31 +00:00
|
|
|
/* ABM settings */
|
|
|
|
dm_new_crtc_state->abm_level = dm_new_conn_state->abm_level;
|
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
/*
|
|
|
|
* Color management settings. We also update color properties
|
|
|
|
* when a modeset is needed, to ensure it gets reprogrammed.
|
|
|
|
*/
|
|
|
|
if (dm_new_crtc_state->base.color_mgmt_changed ||
|
|
|
|
drm_atomic_crtc_needs_modeset(new_crtc_state)) {
|
2019-05-09 16:14:58 +00:00
|
|
|
ret = amdgpu_dm_update_crtc_color_mgmt(dm_new_crtc_state);
|
2018-11-11 16:35:13 +00:00
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-08-18 14:52:20 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-11-11 16:35:13 +00:00
|
|
|
/* Update Freesync settings. */
|
|
|
|
get_freesync_config_for_crtc(dm_new_crtc_state,
|
|
|
|
dm_new_conn_state);
|
|
|
|
|
2017-08-18 14:52:20 +00:00
|
|
|
return ret;
|
2017-09-12 16:10:25 +00:00
|
|
|
|
|
|
|
fail:
|
|
|
|
if (new_stream)
|
|
|
|
dc_stream_release(new_stream);
|
|
|
|
return ret;
|
2017-08-18 14:52:20 +00:00
|
|
|
}
|
2017-07-28 17:11:00 +00:00
|
|
|
|
2019-03-25 16:17:14 +00:00
|
|
|
static bool should_reset_plane(struct drm_atomic_state *state,
|
|
|
|
struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *old_plane_state,
|
|
|
|
struct drm_plane_state *new_plane_state)
|
|
|
|
{
|
|
|
|
struct drm_plane *other;
|
|
|
|
struct drm_plane_state *old_other_state, *new_other_state;
|
|
|
|
struct drm_crtc_state *new_crtc_state;
|
|
|
|
int i;
|
|
|
|
|
2019-06-20 12:30:09 +00:00
|
|
|
/*
|
|
|
|
* TODO: Remove this hack once the checks below are sufficient
|
|
|
|
* enough to determine when we need to reset all the planes on
|
|
|
|
* the stream.
|
|
|
|
*/
|
|
|
|
if (state->allow_modeset)
|
|
|
|
return true;
|
|
|
|
|
2019-03-25 16:17:14 +00:00
|
|
|
/* Exit early if we know that we're adding or removing the plane. */
|
|
|
|
if (old_plane_state->crtc != new_plane_state->crtc)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
/* old crtc == new_crtc == NULL, plane not in context. */
|
|
|
|
if (!new_plane_state->crtc)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
new_crtc_state =
|
|
|
|
drm_atomic_get_new_crtc_state(state, new_plane_state->crtc);
|
|
|
|
|
|
|
|
if (!new_crtc_state)
|
|
|
|
return true;
|
|
|
|
|
2019-05-01 14:26:09 +00:00
|
|
|
/* CRTC Degamma changes currently require us to recreate planes. */
|
|
|
|
if (new_crtc_state->color_mgmt_changed)
|
|
|
|
return true;
|
|
|
|
|
2019-03-25 16:17:14 +00:00
|
|
|
if (drm_atomic_crtc_needs_modeset(new_crtc_state))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If there are any new primary or overlay planes being added or
|
|
|
|
* removed then the z-order can potentially change. To ensure
|
|
|
|
* correct z-order and pipe acquisition the current DC architecture
|
|
|
|
* requires us to remove and recreate all existing planes.
|
|
|
|
*
|
|
|
|
* TODO: Come up with a more elegant solution for this.
|
|
|
|
*/
|
|
|
|
for_each_oldnew_plane_in_state(state, other, old_other_state, new_other_state, i) {
|
|
|
|
if (other->type == DRM_PLANE_TYPE_CURSOR)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (old_other_state->crtc != new_plane_state->crtc &&
|
|
|
|
new_other_state->crtc != new_plane_state->crtc)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (old_other_state->crtc != new_other_state->crtc)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
/* TODO: Remove this once we can handle fast format changes. */
|
|
|
|
if (old_other_state->fb && new_other_state->fb &&
|
|
|
|
old_other_state->fb->format != new_other_state->fb->format)
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
static int dm_update_plane_state(struct dc *dc,
|
|
|
|
struct drm_atomic_state *state,
|
|
|
|
struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *old_plane_state,
|
|
|
|
struct drm_plane_state *new_plane_state,
|
|
|
|
bool enable,
|
|
|
|
bool *lock_and_validation_needed)
|
2017-08-18 14:52:20 +00:00
|
|
|
{
|
2018-11-22 17:34:36 +00:00
|
|
|
|
|
|
|
struct dm_atomic_state *dm_state = NULL;
|
2017-08-18 14:52:20 +00:00
|
|
|
struct drm_crtc *new_plane_crtc, *old_plane_crtc;
|
2017-10-12 21:15:07 +00:00
|
|
|
struct drm_crtc_state *old_crtc_state, *new_crtc_state;
|
2017-10-12 21:15:09 +00:00
|
|
|
struct dm_crtc_state *dm_new_crtc_state, *dm_old_crtc_state;
|
|
|
|
struct dm_plane_state *dm_new_plane_state, *dm_old_plane_state;
|
2020-03-30 09:23:21 +00:00
|
|
|
struct amdgpu_crtc *new_acrtc;
|
2019-03-25 16:17:14 +00:00
|
|
|
bool needs_reset;
|
2017-08-18 14:52:20 +00:00
|
|
|
int ret = 0;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-07-28 17:11:00 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
new_plane_crtc = new_plane_state->crtc;
|
|
|
|
old_plane_crtc = old_plane_state->crtc;
|
|
|
|
dm_new_plane_state = to_dm_plane_state(new_plane_state);
|
|
|
|
dm_old_plane_state = to_dm_plane_state(old_plane_state);
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2020-03-30 09:23:21 +00:00
|
|
|
/*TODO Implement better atomic check for cursor plane */
|
|
|
|
if (plane->type == DRM_PLANE_TYPE_CURSOR) {
|
|
|
|
if (!enable || !new_plane_crtc ||
|
|
|
|
drm_atomic_plane_disabling(plane->state, new_plane_state))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
new_acrtc = to_amdgpu_crtc(new_plane_crtc);
|
|
|
|
|
|
|
|
if ((new_plane_state->crtc_w > new_acrtc->max_cursor_width) ||
|
|
|
|
(new_plane_state->crtc_h > new_acrtc->max_cursor_height)) {
|
|
|
|
DRM_DEBUG_ATOMIC("Bad cursor size %d x %d\n",
|
|
|
|
new_plane_state->crtc_w, new_plane_state->crtc_h);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
return 0;
|
2020-03-30 09:23:21 +00:00
|
|
|
}
|
2017-07-28 17:11:00 +00:00
|
|
|
|
2019-03-25 16:17:14 +00:00
|
|
|
needs_reset = should_reset_plane(state, plane, old_plane_state,
|
|
|
|
new_plane_state);
|
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
/* Remove any changed/removed planes */
|
|
|
|
if (!enable) {
|
2019-03-25 16:17:14 +00:00
|
|
|
if (!needs_reset)
|
2018-11-11 16:11:52 +00:00
|
|
|
return 0;
|
2017-07-31 16:09:02 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
if (!old_plane_crtc)
|
|
|
|
return 0;
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
old_crtc_state = drm_atomic_get_old_crtc_state(
|
|
|
|
state, old_plane_crtc);
|
|
|
|
dm_old_crtc_state = to_dm_crtc_state(old_crtc_state);
|
2017-07-28 17:11:00 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
if (!dm_old_crtc_state->stream)
|
|
|
|
return 0;
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
DRM_DEBUG_ATOMIC("Disabling DRM plane: %d on DRM crtc %d\n",
|
|
|
|
plane->base.id, old_plane_crtc->base.id);
|
2017-07-28 17:11:00 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
ret = dm_atomic_get_state(state, &dm_state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2018-11-22 17:34:36 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
if (!dc_remove_plane_from_context(
|
|
|
|
dc,
|
|
|
|
dm_old_crtc_state->stream,
|
|
|
|
dm_old_plane_state->dc_state,
|
|
|
|
dm_state->context)) {
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
ret = EINVAL;
|
|
|
|
return ret;
|
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-07-28 17:11:00 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
dc_plane_state_release(dm_old_plane_state->dc_state);
|
|
|
|
dm_new_plane_state->dc_state = NULL;
|
2017-07-31 15:29:25 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
*lock_and_validation_needed = true;
|
2017-07-31 15:29:25 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
} else { /* Add new planes */
|
|
|
|
struct dc_plane_state *dc_new_plane_state;
|
2017-07-31 15:29:25 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
if (drm_atomic_plane_disabling(plane->state, new_plane_state))
|
|
|
|
return 0;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
if (!new_plane_crtc)
|
|
|
|
return 0;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
new_crtc_state = drm_atomic_get_new_crtc_state(state, new_plane_crtc);
|
|
|
|
dm_new_crtc_state = to_dm_crtc_state(new_crtc_state);
|
2017-07-31 15:29:25 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
if (!dm_new_crtc_state->stream)
|
|
|
|
return 0;
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2019-03-25 16:17:14 +00:00
|
|
|
if (!needs_reset)
|
2018-11-11 16:11:52 +00:00
|
|
|
return 0;
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2020-06-04 19:54:39 +00:00
|
|
|
ret = dm_plane_helper_check_state(new_plane_state, new_crtc_state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
WARN_ON(dm_new_plane_state->dc_state);
|
2017-07-28 17:11:00 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
dc_new_plane_state = dc_create_plane_state(dc);
|
|
|
|
if (!dc_new_plane_state)
|
|
|
|
return -ENOMEM;
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
DRM_DEBUG_DRIVER("Enabling DRM plane: %d on DRM crtc %d\n",
|
|
|
|
plane->base.id, new_plane_crtc->base.id);
|
2018-02-20 20:46:09 +00:00
|
|
|
|
2019-03-28 18:45:19 +00:00
|
|
|
ret = fill_dc_plane_attributes(
|
2018-11-11 16:11:52 +00:00
|
|
|
new_plane_crtc->dev->dev_private,
|
|
|
|
dc_new_plane_state,
|
|
|
|
new_plane_state,
|
|
|
|
new_crtc_state);
|
|
|
|
if (ret) {
|
|
|
|
dc_plane_state_release(dc_new_plane_state);
|
|
|
|
return ret;
|
|
|
|
}
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
ret = dm_atomic_get_state(state, &dm_state);
|
|
|
|
if (ret) {
|
|
|
|
dc_plane_state_release(dc_new_plane_state);
|
|
|
|
return ret;
|
|
|
|
}
|
2018-11-22 17:34:36 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
/*
|
|
|
|
* Any atomic check errors that occur after this will
|
|
|
|
* not need a release. The plane state will be attached
|
|
|
|
* to the stream, and therefore part of the atomic
|
|
|
|
* state. It'll be released when the atomic state is
|
|
|
|
* cleaned.
|
|
|
|
*/
|
|
|
|
if (!dc_add_plane_to_context(
|
|
|
|
dc,
|
|
|
|
dm_new_crtc_state->stream,
|
|
|
|
dc_new_plane_state,
|
|
|
|
dm_state->context)) {
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
dc_plane_state_release(dc_new_plane_state);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
2018-02-20 20:46:09 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
dm_new_plane_state->dc_state = dc_new_plane_state;
|
2017-11-09 20:33:43 +00:00
|
|
|
|
2018-11-11 16:11:52 +00:00
|
|
|
/* Tell DC to do a full surface update every time there
|
|
|
|
* is a plane change. Inefficient, but works for now.
|
|
|
|
*/
|
|
|
|
dm_new_plane_state->dc_state->update_flags.bits.full_update = 1;
|
|
|
|
|
|
|
|
*lock_and_validation_needed = true;
|
2017-08-18 14:52:20 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
|
2017-08-18 14:52:20 +00:00
|
|
|
return ret;
|
|
|
|
}
|
2018-08-20 17:32:07 +00:00
|
|
|
|
2018-11-22 17:34:36 +00:00
|
|
|
static int
|
2019-01-10 14:32:31 +00:00
|
|
|
dm_determine_update_type_for_commit(struct amdgpu_display_manager *dm,
|
2018-11-22 17:34:36 +00:00
|
|
|
struct drm_atomic_state *state,
|
|
|
|
enum surface_update_type *out_type)
|
|
|
|
{
|
2019-01-10 14:32:31 +00:00
|
|
|
struct dc *dc = dm->dc;
|
2018-11-22 17:34:36 +00:00
|
|
|
struct dm_atomic_state *dm_state = NULL, *old_dm_state = NULL;
|
|
|
|
int i, j, num_plane, ret = 0;
|
2018-08-20 17:32:07 +00:00
|
|
|
struct drm_plane_state *old_plane_state, *new_plane_state;
|
|
|
|
struct dm_plane_state *new_dm_plane_state, *old_dm_plane_state;
|
2019-11-14 12:36:24 +00:00
|
|
|
struct drm_crtc *new_plane_crtc;
|
2018-08-20 17:32:07 +00:00
|
|
|
struct drm_plane *plane;
|
|
|
|
|
|
|
|
struct drm_crtc *crtc;
|
|
|
|
struct drm_crtc_state *new_crtc_state, *old_crtc_state;
|
|
|
|
struct dm_crtc_state *new_dm_crtc_state, *old_dm_crtc_state;
|
|
|
|
struct dc_stream_status *status = NULL;
|
|
|
|
enum surface_update_type update_type = UPDATE_TYPE_FAST;
|
2020-01-13 15:26:19 +00:00
|
|
|
struct surface_info_bundle {
|
|
|
|
struct dc_surface_update surface_updates[MAX_SURFACES];
|
|
|
|
struct dc_plane_info plane_infos[MAX_SURFACES];
|
|
|
|
struct dc_scaling_info scaling_infos[MAX_SURFACES];
|
|
|
|
struct dc_flip_addrs flip_addrs[MAX_SURFACES];
|
|
|
|
struct dc_stream_update stream_update;
|
|
|
|
} *bundle;
|
2018-08-20 17:32:07 +00:00
|
|
|
|
2020-01-13 15:26:19 +00:00
|
|
|
bundle = kzalloc(sizeof(*bundle), GFP_KERNEL);
|
2019-01-15 05:22:02 +00:00
|
|
|
|
2020-01-13 15:26:19 +00:00
|
|
|
if (!bundle) {
|
|
|
|
DRM_ERROR("Failed to allocate update bundle\n");
|
2018-10-09 17:47:34 +00:00
|
|
|
/* Set type to FULL to avoid crashing in DC*/
|
|
|
|
update_type = UPDATE_TYPE_FULL;
|
2018-11-22 17:34:36 +00:00
|
|
|
goto cleanup;
|
2018-10-09 17:47:34 +00:00
|
|
|
}
|
2018-08-20 17:32:07 +00:00
|
|
|
|
|
|
|
for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
|
2019-03-22 13:59:32 +00:00
|
|
|
|
2020-01-13 15:26:19 +00:00
|
|
|
memset(bundle, 0, sizeof(struct surface_info_bundle));
|
2019-01-10 16:52:11 +00:00
|
|
|
|
2018-08-20 17:32:07 +00:00
|
|
|
new_dm_crtc_state = to_dm_crtc_state(new_crtc_state);
|
|
|
|
old_dm_crtc_state = to_dm_crtc_state(old_crtc_state);
|
|
|
|
num_plane = 0;
|
|
|
|
|
2019-01-22 19:09:34 +00:00
|
|
|
if (new_dm_crtc_state->stream != old_dm_crtc_state->stream) {
|
|
|
|
update_type = UPDATE_TYPE_FULL;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2018-08-20 17:32:07 +00:00
|
|
|
|
2019-01-22 19:09:34 +00:00
|
|
|
if (!new_dm_crtc_state->stream)
|
2019-01-10 14:14:49 +00:00
|
|
|
continue;
|
2018-11-22 17:34:36 +00:00
|
|
|
|
2019-01-10 14:14:49 +00:00
|
|
|
for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, j) {
|
2019-08-02 14:31:29 +00:00
|
|
|
const struct amdgpu_framebuffer *amdgpu_fb =
|
|
|
|
to_amdgpu_framebuffer(new_plane_state->fb);
|
2020-01-13 15:26:19 +00:00
|
|
|
struct dc_plane_info *plane_info = &bundle->plane_infos[num_plane];
|
|
|
|
struct dc_flip_addrs *flip_addr = &bundle->flip_addrs[num_plane];
|
|
|
|
struct dc_scaling_info *scaling_info = &bundle->scaling_infos[num_plane];
|
2019-08-02 14:31:29 +00:00
|
|
|
uint64_t tiling_flags;
|
2020-04-22 21:54:55 +00:00
|
|
|
bool tmz_surface = false;
|
2019-08-02 14:31:29 +00:00
|
|
|
|
2019-01-10 14:14:49 +00:00
|
|
|
new_plane_crtc = new_plane_state->crtc;
|
|
|
|
new_dm_plane_state = to_dm_plane_state(new_plane_state);
|
|
|
|
old_dm_plane_state = to_dm_plane_state(old_plane_state);
|
2018-11-22 17:34:36 +00:00
|
|
|
|
2019-01-10 14:14:49 +00:00
|
|
|
if (plane->type == DRM_PLANE_TYPE_CURSOR)
|
|
|
|
continue;
|
2018-11-22 17:34:36 +00:00
|
|
|
|
2019-01-22 19:09:34 +00:00
|
|
|
if (new_dm_plane_state->dc_state != old_dm_plane_state->dc_state) {
|
|
|
|
update_type = UPDATE_TYPE_FULL;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2019-01-10 14:14:49 +00:00
|
|
|
if (crtc != new_plane_crtc)
|
|
|
|
continue;
|
|
|
|
|
2020-01-13 15:26:19 +00:00
|
|
|
bundle->surface_updates[num_plane].surface =
|
|
|
|
new_dm_plane_state->dc_state;
|
2019-01-10 14:14:49 +00:00
|
|
|
|
|
|
|
if (new_crtc_state->mode_changed) {
|
2020-01-13 15:26:19 +00:00
|
|
|
bundle->stream_update.dst = new_dm_crtc_state->stream->dst;
|
|
|
|
bundle->stream_update.src = new_dm_crtc_state->stream->src;
|
2019-01-10 14:14:49 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (new_crtc_state->color_mgmt_changed) {
|
2020-01-13 15:26:19 +00:00
|
|
|
bundle->surface_updates[num_plane].gamma =
|
2019-01-10 14:14:49 +00:00
|
|
|
new_dm_plane_state->dc_state->gamma_correction;
|
2020-01-13 15:26:19 +00:00
|
|
|
bundle->surface_updates[num_plane].in_transfer_func =
|
2019-01-10 14:14:49 +00:00
|
|
|
new_dm_plane_state->dc_state->in_transfer_func;
|
2020-03-26 15:19:44 +00:00
|
|
|
bundle->surface_updates[num_plane].gamut_remap_matrix =
|
|
|
|
&new_dm_plane_state->dc_state->gamut_remap_matrix;
|
2020-01-13 15:26:19 +00:00
|
|
|
bundle->stream_update.gamut_remap =
|
2019-01-10 14:14:49 +00:00
|
|
|
&new_dm_crtc_state->stream->gamut_remap_matrix;
|
2020-01-13 15:26:19 +00:00
|
|
|
bundle->stream_update.output_csc_transform =
|
2019-05-09 16:14:58 +00:00
|
|
|
&new_dm_crtc_state->stream->csc_color_matrix;
|
2020-01-13 15:26:19 +00:00
|
|
|
bundle->stream_update.out_transfer_func =
|
2019-01-10 14:14:49 +00:00
|
|
|
new_dm_crtc_state->stream->out_transfer_func;
|
2018-08-20 17:32:07 +00:00
|
|
|
}
|
|
|
|
|
2019-03-28 19:50:06 +00:00
|
|
|
ret = fill_dc_scaling_info(new_plane_state,
|
2020-01-13 15:26:19 +00:00
|
|
|
scaling_info);
|
2019-03-28 19:50:06 +00:00
|
|
|
if (ret)
|
|
|
|
goto cleanup;
|
|
|
|
|
2020-01-13 15:26:19 +00:00
|
|
|
bundle->surface_updates[num_plane].scaling_info = scaling_info;
|
2019-03-28 19:50:06 +00:00
|
|
|
|
2019-08-02 14:31:29 +00:00
|
|
|
if (amdgpu_fb) {
|
2020-04-22 21:54:55 +00:00
|
|
|
ret = get_fb_info(amdgpu_fb, &tiling_flags, &tmz_surface);
|
2019-08-02 14:31:29 +00:00
|
|
|
if (ret)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
ret = fill_dc_plane_info_and_addr(
|
|
|
|
dm->adev, new_plane_state, tiling_flags,
|
2020-01-13 15:26:19 +00:00
|
|
|
plane_info,
|
2020-04-22 21:54:55 +00:00
|
|
|
&flip_addr->address, tmz_surface,
|
2020-04-22 21:43:26 +00:00
|
|
|
false);
|
2019-08-02 14:31:29 +00:00
|
|
|
if (ret)
|
|
|
|
goto cleanup;
|
|
|
|
|
2020-01-13 15:26:19 +00:00
|
|
|
bundle->surface_updates[num_plane].plane_info = plane_info;
|
|
|
|
bundle->surface_updates[num_plane].flip_addr = flip_addr;
|
2019-08-02 14:31:29 +00:00
|
|
|
}
|
|
|
|
|
2019-01-10 14:14:49 +00:00
|
|
|
num_plane++;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (num_plane == 0)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
ret = dm_atomic_get_state(state, &dm_state);
|
|
|
|
if (ret)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
old_dm_state = dm_atomic_get_old_state(state);
|
|
|
|
if (!old_dm_state) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
status = dc_stream_get_status_from_state(old_dm_state->context,
|
|
|
|
new_dm_crtc_state->stream);
|
2020-01-13 15:26:19 +00:00
|
|
|
bundle->stream_update.stream = new_dm_crtc_state->stream;
|
2019-01-10 14:32:31 +00:00
|
|
|
/*
|
|
|
|
* TODO: DC modifies the surface during this call so we need
|
|
|
|
* to lock here - find a way to do this without locking.
|
|
|
|
*/
|
|
|
|
mutex_lock(&dm->dc_lock);
|
2020-01-13 15:26:19 +00:00
|
|
|
update_type = dc_check_update_surfaces_for_stream(
|
|
|
|
dc, bundle->surface_updates, num_plane,
|
|
|
|
&bundle->stream_update, status);
|
2019-01-10 14:32:31 +00:00
|
|
|
mutex_unlock(&dm->dc_lock);
|
2019-01-10 14:14:49 +00:00
|
|
|
|
|
|
|
if (update_type > UPDATE_TYPE_MED) {
|
2018-08-20 17:32:07 +00:00
|
|
|
update_type = UPDATE_TYPE_FULL;
|
2018-11-22 17:34:36 +00:00
|
|
|
goto cleanup;
|
2018-08-20 17:32:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-11-22 17:34:36 +00:00
|
|
|
cleanup:
|
2020-01-13 15:26:19 +00:00
|
|
|
kfree(bundle);
|
2018-08-20 17:32:07 +00:00
|
|
|
|
2018-11-22 17:34:36 +00:00
|
|
|
*out_type = update_type;
|
|
|
|
return ret;
|
2018-08-20 17:32:07 +00:00
|
|
|
}
|
2020-07-03 16:37:35 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN)
|
2019-11-12 14:14:15 +00:00
|
|
|
static int add_affected_mst_dsc_crtcs(struct drm_atomic_state *state, struct drm_crtc *crtc)
|
|
|
|
{
|
|
|
|
struct drm_connector *connector;
|
|
|
|
struct drm_connector_state *conn_state;
|
|
|
|
struct amdgpu_dm_connector *aconnector = NULL;
|
|
|
|
int i;
|
|
|
|
for_each_new_connector_in_state(state, connector, conn_state, i) {
|
|
|
|
if (conn_state->crtc != crtc)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
aconnector = to_amdgpu_dm_connector(connector);
|
|
|
|
if (!aconnector->port || !aconnector->mst_port)
|
|
|
|
aconnector = NULL;
|
|
|
|
else
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!aconnector)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
return drm_dp_mst_add_affected_dsc_crtcs(state, &aconnector->mst_port->mst_mgr);
|
|
|
|
}
|
2020-07-03 16:37:35 +00:00
|
|
|
#endif
|
2019-11-12 14:14:15 +00:00
|
|
|
|
2018-09-14 15:20:08 +00:00
|
|
|
/**
|
|
|
|
* amdgpu_dm_atomic_check() - Atomic check implementation for AMDgpu DM.
|
|
|
|
* @dev: The DRM device
|
|
|
|
* @state: The atomic state to commit
|
|
|
|
*
|
|
|
|
* Validate that the given atomic state is programmable by DC into hardware.
|
|
|
|
* This involves constructing a &struct dc_state reflecting the new hardware
|
|
|
|
* state we wish to commit, then querying DC to see if it is programmable. It's
|
|
|
|
* important not to modify the existing DC state. Otherwise, atomic_check
|
|
|
|
* may unexpectedly commit hardware changes.
|
|
|
|
*
|
|
|
|
* When validating the DC state, it's important that the right locks are
|
|
|
|
* acquired. For full updates case which removes/adds/updates streams on one
|
|
|
|
* CRTC while flipping on another CRTC, acquiring global lock will guarantee
|
|
|
|
* that any such full update commit will wait for completion of any outstanding
|
|
|
|
* flip using DRMs synchronization events. See
|
|
|
|
* dm_determine_update_type_for_commit()
|
|
|
|
*
|
|
|
|
* Note that DM adds the affected connectors for all CRTCs in state, when that
|
|
|
|
* might not seem necessary. This is because DC stream creation requires the
|
|
|
|
* DC sink, which is tied to the DRM connector state. Cleaning this up should
|
|
|
|
* be possible but non-trivial - a possible TODO item.
|
|
|
|
*
|
|
|
|
* Return: -Error code if validation failed.
|
|
|
|
*/
|
2017-10-10 21:51:02 +00:00
|
|
|
static int amdgpu_dm_atomic_check(struct drm_device *dev,
|
|
|
|
struct drm_atomic_state *state)
|
2017-08-18 14:52:20 +00:00
|
|
|
{
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
2018-11-22 17:34:36 +00:00
|
|
|
struct dm_atomic_state *dm_state = NULL;
|
2017-08-18 14:52:20 +00:00
|
|
|
struct dc *dc = adev->dm.dc;
|
|
|
|
struct drm_connector *connector;
|
2017-10-12 21:15:08 +00:00
|
|
|
struct drm_connector_state *old_con_state, *new_con_state;
|
2017-08-18 14:52:20 +00:00
|
|
|
struct drm_crtc *crtc;
|
2017-09-27 09:45:38 +00:00
|
|
|
struct drm_crtc_state *old_crtc_state, *new_crtc_state;
|
2018-11-11 16:11:52 +00:00
|
|
|
struct drm_plane *plane;
|
|
|
|
struct drm_plane_state *old_plane_state, *new_plane_state;
|
2018-08-20 17:32:07 +00:00
|
|
|
enum surface_update_type update_type = UPDATE_TYPE_FAST;
|
|
|
|
enum surface_update_type overall_update_type = UPDATE_TYPE_FAST;
|
2020-05-26 20:53:38 +00:00
|
|
|
enum dc_status status;
|
2017-12-01 06:27:04 +00:00
|
|
|
int ret, i;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2017-08-18 14:52:20 +00:00
|
|
|
/*
|
|
|
|
* This bool will be set for true for any modeset/reset
|
|
|
|
* or plane update which implies non fast surface update.
|
|
|
|
*/
|
|
|
|
bool lock_and_validation_needed = false;
|
|
|
|
|
|
|
|
ret = drm_atomic_helper_check_modeset(dev, state);
|
2017-11-09 17:38:09 +00:00
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2020-06-30 09:55:29 +00:00
|
|
|
/* Check connector changes */
|
|
|
|
for_each_oldnew_connector_in_state(state, connector, old_con_state, new_con_state, i) {
|
|
|
|
struct dm_connector_state *dm_old_con_state = to_dm_connector_state(old_con_state);
|
|
|
|
struct dm_connector_state *dm_new_con_state = to_dm_connector_state(new_con_state);
|
|
|
|
|
|
|
|
/* Skip connectors that are disabled or part of modeset already. */
|
|
|
|
if (!old_con_state->crtc && !new_con_state->crtc)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!new_con_state->crtc)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
new_crtc_state = drm_atomic_get_crtc_state(state, new_con_state->crtc);
|
|
|
|
if (IS_ERR(new_crtc_state)) {
|
|
|
|
ret = PTR_ERR(new_crtc_state);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (dm_old_con_state->abm_level !=
|
|
|
|
dm_new_con_state->abm_level)
|
|
|
|
new_crtc_state->connectors_changed = true;
|
|
|
|
}
|
|
|
|
|
2020-07-03 16:37:35 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN)
|
2019-11-12 14:14:15 +00:00
|
|
|
if (adev->asic_type >= CHIP_NAVI10) {
|
|
|
|
for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
|
|
|
|
if (drm_atomic_crtc_needs_modeset(new_crtc_state)) {
|
|
|
|
ret = add_affected_mst_dsc_crtcs(state, crtc);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2020-07-03 16:37:35 +00:00
|
|
|
#endif
|
2017-12-01 06:27:04 +00:00
|
|
|
for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
|
|
|
|
if (!drm_atomic_crtc_needs_modeset(new_crtc_state) &&
|
2018-08-21 19:40:28 +00:00
|
|
|
!new_crtc_state->color_mgmt_changed &&
|
2019-01-10 20:12:48 +00:00
|
|
|
old_crtc_state->vrr_enabled == new_crtc_state->vrr_enabled)
|
2017-12-01 06:27:04 +00:00
|
|
|
continue;
|
2017-10-27 03:25:55 +00:00
|
|
|
|
2017-12-01 06:27:04 +00:00
|
|
|
if (!new_crtc_state->enable)
|
|
|
|
continue;
|
2017-09-27 09:45:38 +00:00
|
|
|
|
2017-12-01 06:27:04 +00:00
|
|
|
ret = drm_atomic_add_affected_connectors(state, crtc);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2017-09-27 09:45:38 +00:00
|
|
|
|
2017-12-01 06:27:04 +00:00
|
|
|
ret = drm_atomic_add_affected_planes(state, crtc);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2019-01-18 18:17:55 +00:00
|
|
|
/*
|
|
|
|
* Add all primary and overlay planes on the CRTC to the state
|
|
|
|
* whenever a plane is enabled to maintain correct z-ordering
|
|
|
|
* and to enable fast surface updates.
|
|
|
|
*/
|
|
|
|
drm_for_each_crtc(crtc, dev) {
|
|
|
|
bool modified = false;
|
|
|
|
|
|
|
|
for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i) {
|
|
|
|
if (plane->type == DRM_PLANE_TYPE_CURSOR)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (new_plane_state->crtc == crtc ||
|
|
|
|
old_plane_state->crtc == crtc) {
|
|
|
|
modified = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!modified)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
drm_for_each_plane_mask(plane, state->dev, crtc->state->plane_mask) {
|
|
|
|
if (plane->type == DRM_PLANE_TYPE_CURSOR)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
new_plane_state =
|
|
|
|
drm_atomic_get_plane_state(state, plane);
|
|
|
|
|
|
|
|
if (IS_ERR(new_plane_state)) {
|
|
|
|
ret = PTR_ERR(new_plane_state);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-08-18 14:52:20 +00:00
|
|
|
/* Remove exiting planes if they are modified */
|
2018-11-11 16:11:52 +00:00
|
|
|
for_each_oldnew_plane_in_state_reverse(state, plane, old_plane_state, new_plane_state, i) {
|
|
|
|
ret = dm_update_plane_state(dc, state, plane,
|
|
|
|
old_plane_state,
|
|
|
|
new_plane_state,
|
|
|
|
false,
|
|
|
|
&lock_and_validation_needed);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-08-18 14:52:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Disable all crtcs which require disable */
|
2018-11-11 16:35:13 +00:00
|
|
|
for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
|
|
|
|
ret = dm_update_crtc_state(&adev->dm, state, crtc,
|
|
|
|
old_crtc_state,
|
|
|
|
new_crtc_state,
|
|
|
|
false,
|
|
|
|
&lock_and_validation_needed);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-08-18 14:52:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Enable all crtcs which require enable */
|
2018-11-11 16:35:13 +00:00
|
|
|
for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
|
|
|
|
ret = dm_update_crtc_state(&adev->dm, state, crtc,
|
|
|
|
old_crtc_state,
|
|
|
|
new_crtc_state,
|
|
|
|
true,
|
|
|
|
&lock_and_validation_needed);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-08-18 14:52:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Add new/modified planes */
|
2018-11-11 16:11:52 +00:00
|
|
|
for_each_oldnew_plane_in_state_reverse(state, plane, old_plane_state, new_plane_state, i) {
|
|
|
|
ret = dm_update_plane_state(dc, state, plane,
|
|
|
|
old_plane_state,
|
|
|
|
new_plane_state,
|
|
|
|
true,
|
|
|
|
&lock_and_validation_needed);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-08-18 14:52:20 +00:00
|
|
|
}
|
|
|
|
|
2017-11-07 20:06:57 +00:00
|
|
|
/* Run this here since we want to validate the streams we created */
|
|
|
|
ret = drm_atomic_helper_check_planes(dev, state);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-08-18 14:52:20 +00:00
|
|
|
|
2019-07-31 13:45:16 +00:00
|
|
|
if (state->legacy_cursor_update) {
|
|
|
|
/*
|
|
|
|
* This is a fast cursor update coming from the plane update
|
|
|
|
* helper, check if it can be done asynchronously for better
|
|
|
|
* performance.
|
|
|
|
*/
|
|
|
|
state->async_update =
|
|
|
|
!drm_atomic_helper_async_check(dev, state);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Skip the remaining global validation if this is an async
|
|
|
|
* update. Cursor updates can be done without affecting
|
|
|
|
* state or bandwidth calcs and this avoids the performance
|
|
|
|
* penalty of locking the private state object and
|
|
|
|
* allocating a new dc_state.
|
|
|
|
*/
|
|
|
|
if (state->async_update)
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-10-12 21:15:10 +00:00
|
|
|
/* Check scaling and underscan changes*/
|
2018-08-15 18:38:30 +00:00
|
|
|
/* TODO Removed scaling changes validation due to inability to commit
|
2017-08-10 17:29:07 +00:00
|
|
|
* new stream into context w\o causing full reset. Need to
|
|
|
|
* decide how to handle.
|
|
|
|
*/
|
2017-10-12 21:15:08 +00:00
|
|
|
for_each_oldnew_connector_in_state(state, connector, old_con_state, new_con_state, i) {
|
2017-10-12 21:15:09 +00:00
|
|
|
struct dm_connector_state *dm_old_con_state = to_dm_connector_state(old_con_state);
|
|
|
|
struct dm_connector_state *dm_new_con_state = to_dm_connector_state(new_con_state);
|
|
|
|
struct amdgpu_crtc *acrtc = to_amdgpu_crtc(dm_new_con_state->base.crtc);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
/* Skip any modesets/resets */
|
2017-10-12 21:15:07 +00:00
|
|
|
if (!acrtc || drm_atomic_crtc_needs_modeset(
|
|
|
|
drm_atomic_get_new_crtc_state(state, &acrtc->base)))
|
2017-08-10 17:29:07 +00:00
|
|
|
continue;
|
|
|
|
|
2017-07-27 01:03:22 +00:00
|
|
|
/* Skip any thing not scale or underscan changes */
|
2017-10-12 21:15:09 +00:00
|
|
|
if (!is_scaling_state_different(dm_new_con_state, dm_old_con_state))
|
2017-08-10 17:29:07 +00:00
|
|
|
continue;
|
|
|
|
|
2018-08-20 17:32:07 +00:00
|
|
|
overall_update_type = UPDATE_TYPE_FULL;
|
2017-08-10 17:29:07 +00:00
|
|
|
lock_and_validation_needed = true;
|
|
|
|
}
|
|
|
|
|
2019-01-10 14:32:31 +00:00
|
|
|
ret = dm_determine_update_type_for_commit(&adev->dm, state, &update_type);
|
2018-11-22 17:34:36 +00:00
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2018-08-20 17:32:07 +00:00
|
|
|
|
|
|
|
if (overall_update_type < update_type)
|
|
|
|
overall_update_type = update_type;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* lock_and_validation_needed was an old way to determine if we need to set
|
|
|
|
* the global lock. Leaving it in to check if we broke any corner cases
|
|
|
|
* lock_and_validation_needed true = UPDATE_TYPE_FULL or UPDATE_TYPE_MED
|
|
|
|
* lock_and_validation_needed false = UPDATE_TYPE_FAST
|
|
|
|
*/
|
|
|
|
if (lock_and_validation_needed && overall_update_type <= UPDATE_TYPE_FAST)
|
|
|
|
WARN(1, "Global lock should be Set, overall_update_type should be UPDATE_TYPE_MED or UPDATE_TYPE_FULL");
|
2017-08-10 17:29:07 +00:00
|
|
|
|
2018-08-20 17:32:07 +00:00
|
|
|
if (overall_update_type > UPDATE_TYPE_FAST) {
|
2018-11-22 17:34:36 +00:00
|
|
|
ret = dm_atomic_get_state(state, &dm_state);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
ret = do_aquire_global_lock(dev, state);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2017-07-31 15:29:25 +00:00
|
|
|
|
2020-01-08 04:04:04 +00:00
|
|
|
#if defined(CONFIG_DRM_AMD_DC_DCN)
|
drm/amd/display: MST DSC compute fair share
If there is limited link bandwidth on a MST network,
it must be divided fairly between the streams on that network
Implement an algorithm to determine the correct DSC config
for each stream
The algorithm:
This
[ ] ( )
represents the range of bandwidths possible for a given stream.
The [] area represents the range of DSC configs, and the ()
represents no DSC. The bandwidth used increases from left to right.
First, try disabling DSC on all streams
[ ] (|)
[ ] (|)
Check this against the bandwidth limits of the link and each branch
(including each endpoint). If it passes, the job is done
Second, try maximum DSC compression on all streams
that support DSC
[| ] ( )
[| ] ( )
If this does not pass, then enabling this combination of streams
is impossible
Otherwise, divide the remaining bandwidth evenly amongst the streams
[ | ] ( )
[ | ] ( )
If one or more of the streams reach minimum compression, evenly
divide the reamining bandwidth amongst the remaining streams
[ |] ( )
[ |] ( )
[ | ] ( )
[ | ] ( )
If all streams can reach minimum compression, disable compression
greedily
[ |] ( )
[ |] ( )
[ ] (|)
Perform this algorithm on each full update, on each MST link
with at least one DSC stream on it
After the configs are computed, call
dcn20_add_dsc_to_stream_resource on each stream with DSC enabled.
It is only after all streams are created that we can know which
of them will need DSC.
Do all of this at the end of amdgpu atomic check. If it fails,
fail check; This combination of timings cannot be supported.
v2: Use drm_dp_mst_atomic_check to validate bw for certain dsc
configurations
v3: Use dc_dsc_policy structure to get min and max bpp rate
for DSC configuration
Acked-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Wenjing Liu <Wenjing.Liu@amd.com>
Signed-off-by: David Francis <David.Francis@amd.com>
Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-06-19 18:49:19 +00:00
|
|
|
if (!compute_mst_dsc_configs_for_state(state, dm_state->context))
|
|
|
|
goto fail;
|
|
|
|
|
2019-11-12 19:52:14 +00:00
|
|
|
ret = dm_update_mst_vcpi_slots_for_dsc(state, dm_state->context);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2020-01-08 04:04:04 +00:00
|
|
|
#endif
|
2019-11-12 19:52:14 +00:00
|
|
|
|
2020-01-28 21:38:53 +00:00
|
|
|
/*
|
|
|
|
* Perform validation of MST topology in the state:
|
|
|
|
* We need to perform MST atomic check before calling
|
|
|
|
* dc_validate_global_state(), or there is a chance
|
|
|
|
* to get stuck in an infinite loop and hang eventually.
|
|
|
|
*/
|
|
|
|
ret = drm_dp_mst_atomic_check(state);
|
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2020-05-26 20:53:38 +00:00
|
|
|
status = dc_validate_global_state(dc, dm_state->context, false);
|
|
|
|
if (status != DC_OK) {
|
|
|
|
DC_LOG_WARNING("DC global validation failure: %s (%d)",
|
|
|
|
dc_status_to_str(status), status);
|
2017-08-10 17:29:07 +00:00
|
|
|
ret = -EINVAL;
|
|
|
|
goto fail;
|
|
|
|
}
|
drm/amd/display: Don't replace the dc_state for fast updates
[Why]
DRM private objects have no hw_done/flip_done fencing mechanism on their
own and cannot be used to sequence commits accordingly.
When issuing commits that don't touch the same set of hardware resources
like page-flips on different CRTCs we can run into the issue below
because of this:
1. Client requests non-blocking Commit #1, has a new dc_state #1,
state is swapped, commit tail is deferred to work queue
2. Client requests non-blocking Commit #2, has a new dc_state #2,
state is swapped, commit tail is deferred to work queue
3. Commit #2 work starts, commit tail finishes,
atomic state is cleared, dc_state #1 is freed
4. Commit #1 work starts,
commit tail encounters null pointer deref on dc_state #1
In order to change the DC state as in the private object we need to
ensure that we wait for all outstanding commits to finish and that
any other pending commits must wait for the current one to finish as
well.
We do this for MEDIUM and FULL updates. But not for FAST updates, nor
would we want to since it would cause stuttering from the delays.
FAST updates that go through dm_determine_update_type_for_commit always
create a new dc_state and lock the DRM private object if there are
any changed planes.
We need the old state to validate, but we don't actually need the new
state here.
[How]
If the commit isn't a full update then the use after free can be
resolved by simply discarding the new state entirely and retaining
the existing one instead.
With this change the sequence above can be reexamined. Commit #2 will
still free Commit #1's reference, but before this happens we actually
added an additional reference as part of Commit #2.
If an update comes in during this that needs to change the dc_state
it will need to wait on Commit #1 and Commit #2 to finish. Then it'll
swap the state, finish the work in commit tail and drop the last
reference on Commit #2's dc_state.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204181
Fixes: 004b3938e637 ("drm/amd/display: Check scaling info when determing update type")
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: David Francis <david.francis@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-07-31 14:33:54 +00:00
|
|
|
} else {
|
2018-12-05 19:59:07 +00:00
|
|
|
/*
|
drm/amd/display: Don't replace the dc_state for fast updates
[Why]
DRM private objects have no hw_done/flip_done fencing mechanism on their
own and cannot be used to sequence commits accordingly.
When issuing commits that don't touch the same set of hardware resources
like page-flips on different CRTCs we can run into the issue below
because of this:
1. Client requests non-blocking Commit #1, has a new dc_state #1,
state is swapped, commit tail is deferred to work queue
2. Client requests non-blocking Commit #2, has a new dc_state #2,
state is swapped, commit tail is deferred to work queue
3. Commit #2 work starts, commit tail finishes,
atomic state is cleared, dc_state #1 is freed
4. Commit #1 work starts,
commit tail encounters null pointer deref on dc_state #1
In order to change the DC state as in the private object we need to
ensure that we wait for all outstanding commits to finish and that
any other pending commits must wait for the current one to finish as
well.
We do this for MEDIUM and FULL updates. But not for FAST updates, nor
would we want to since it would cause stuttering from the delays.
FAST updates that go through dm_determine_update_type_for_commit always
create a new dc_state and lock the DRM private object if there are
any changed planes.
We need the old state to validate, but we don't actually need the new
state here.
[How]
If the commit isn't a full update then the use after free can be
resolved by simply discarding the new state entirely and retaining
the existing one instead.
With this change the sequence above can be reexamined. Commit #2 will
still free Commit #1's reference, but before this happens we actually
added an additional reference as part of Commit #2.
If an update comes in during this that needs to change the dc_state
it will need to wait on Commit #1 and Commit #2 to finish. Then it'll
swap the state, finish the work in commit tail and drop the last
reference on Commit #2's dc_state.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204181
Fixes: 004b3938e637 ("drm/amd/display: Check scaling info when determing update type")
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: David Francis <david.francis@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-07-31 14:33:54 +00:00
|
|
|
* The commit is a fast update. Fast updates shouldn't change
|
|
|
|
* the DC context, affect global validation, and can have their
|
|
|
|
* commit work done in parallel with other commits not touching
|
|
|
|
* the same resource. If we have a new DC context as part of
|
|
|
|
* the DM atomic state from validation we need to free it and
|
|
|
|
* retain the existing one instead.
|
2020-07-27 05:40:46 +00:00
|
|
|
*
|
|
|
|
* Furthermore, since the DM atomic state only contains the DC
|
|
|
|
* context and can safely be annulled, we can free the state
|
|
|
|
* and clear the associated private object now to free
|
|
|
|
* some memory and avoid a possible use-after-free later.
|
2018-12-05 19:59:07 +00:00
|
|
|
*/
|
drm/amd/display: Don't replace the dc_state for fast updates
[Why]
DRM private objects have no hw_done/flip_done fencing mechanism on their
own and cannot be used to sequence commits accordingly.
When issuing commits that don't touch the same set of hardware resources
like page-flips on different CRTCs we can run into the issue below
because of this:
1. Client requests non-blocking Commit #1, has a new dc_state #1,
state is swapped, commit tail is deferred to work queue
2. Client requests non-blocking Commit #2, has a new dc_state #2,
state is swapped, commit tail is deferred to work queue
3. Commit #2 work starts, commit tail finishes,
atomic state is cleared, dc_state #1 is freed
4. Commit #1 work starts,
commit tail encounters null pointer deref on dc_state #1
In order to change the DC state as in the private object we need to
ensure that we wait for all outstanding commits to finish and that
any other pending commits must wait for the current one to finish as
well.
We do this for MEDIUM and FULL updates. But not for FAST updates, nor
would we want to since it would cause stuttering from the delays.
FAST updates that go through dm_determine_update_type_for_commit always
create a new dc_state and lock the DRM private object if there are
any changed planes.
We need the old state to validate, but we don't actually need the new
state here.
[How]
If the commit isn't a full update then the use after free can be
resolved by simply discarding the new state entirely and retaining
the existing one instead.
With this change the sequence above can be reexamined. Commit #2 will
still free Commit #1's reference, but before this happens we actually
added an additional reference as part of Commit #2.
If an update comes in during this that needs to change the dc_state
it will need to wait on Commit #1 and Commit #2 to finish. Then it'll
swap the state, finish the work in commit tail and drop the last
reference on Commit #2's dc_state.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204181
Fixes: 004b3938e637 ("drm/amd/display: Check scaling info when determing update type")
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: David Francis <david.francis@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-07-31 14:33:54 +00:00
|
|
|
|
2020-07-27 05:40:46 +00:00
|
|
|
for (i = 0; i < state->num_private_objs; i++) {
|
|
|
|
struct drm_private_obj *obj = state->private_objs[i].ptr;
|
drm/amd/display: Don't replace the dc_state for fast updates
[Why]
DRM private objects have no hw_done/flip_done fencing mechanism on their
own and cannot be used to sequence commits accordingly.
When issuing commits that don't touch the same set of hardware resources
like page-flips on different CRTCs we can run into the issue below
because of this:
1. Client requests non-blocking Commit #1, has a new dc_state #1,
state is swapped, commit tail is deferred to work queue
2. Client requests non-blocking Commit #2, has a new dc_state #2,
state is swapped, commit tail is deferred to work queue
3. Commit #2 work starts, commit tail finishes,
atomic state is cleared, dc_state #1 is freed
4. Commit #1 work starts,
commit tail encounters null pointer deref on dc_state #1
In order to change the DC state as in the private object we need to
ensure that we wait for all outstanding commits to finish and that
any other pending commits must wait for the current one to finish as
well.
We do this for MEDIUM and FULL updates. But not for FAST updates, nor
would we want to since it would cause stuttering from the delays.
FAST updates that go through dm_determine_update_type_for_commit always
create a new dc_state and lock the DRM private object if there are
any changed planes.
We need the old state to validate, but we don't actually need the new
state here.
[How]
If the commit isn't a full update then the use after free can be
resolved by simply discarding the new state entirely and retaining
the existing one instead.
With this change the sequence above can be reexamined. Commit #2 will
still free Commit #1's reference, but before this happens we actually
added an additional reference as part of Commit #2.
If an update comes in during this that needs to change the dc_state
it will need to wait on Commit #1 and Commit #2 to finish. Then it'll
swap the state, finish the work in commit tail and drop the last
reference on Commit #2's dc_state.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204181
Fixes: 004b3938e637 ("drm/amd/display: Check scaling info when determing update type")
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: David Francis <david.francis@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-07-31 14:33:54 +00:00
|
|
|
|
2020-07-27 05:40:46 +00:00
|
|
|
if (obj->funcs == adev->dm.atomic_obj.funcs) {
|
|
|
|
int j = state->num_private_objs-1;
|
drm/amd/display: Don't replace the dc_state for fast updates
[Why]
DRM private objects have no hw_done/flip_done fencing mechanism on their
own and cannot be used to sequence commits accordingly.
When issuing commits that don't touch the same set of hardware resources
like page-flips on different CRTCs we can run into the issue below
because of this:
1. Client requests non-blocking Commit #1, has a new dc_state #1,
state is swapped, commit tail is deferred to work queue
2. Client requests non-blocking Commit #2, has a new dc_state #2,
state is swapped, commit tail is deferred to work queue
3. Commit #2 work starts, commit tail finishes,
atomic state is cleared, dc_state #1 is freed
4. Commit #1 work starts,
commit tail encounters null pointer deref on dc_state #1
In order to change the DC state as in the private object we need to
ensure that we wait for all outstanding commits to finish and that
any other pending commits must wait for the current one to finish as
well.
We do this for MEDIUM and FULL updates. But not for FAST updates, nor
would we want to since it would cause stuttering from the delays.
FAST updates that go through dm_determine_update_type_for_commit always
create a new dc_state and lock the DRM private object if there are
any changed planes.
We need the old state to validate, but we don't actually need the new
state here.
[How]
If the commit isn't a full update then the use after free can be
resolved by simply discarding the new state entirely and retaining
the existing one instead.
With this change the sequence above can be reexamined. Commit #2 will
still free Commit #1's reference, but before this happens we actually
added an additional reference as part of Commit #2.
If an update comes in during this that needs to change the dc_state
it will need to wait on Commit #1 and Commit #2 to finish. Then it'll
swap the state, finish the work in commit tail and drop the last
reference on Commit #2's dc_state.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204181
Fixes: 004b3938e637 ("drm/amd/display: Check scaling info when determing update type")
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: David Francis <david.francis@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-07-31 14:33:54 +00:00
|
|
|
|
2020-07-27 05:40:46 +00:00
|
|
|
dm_atomic_destroy_state(obj,
|
|
|
|
state->private_objs[i].state);
|
|
|
|
|
|
|
|
/* If i is not at the end of the array then the
|
|
|
|
* last element needs to be moved to where i was
|
|
|
|
* before the array can safely be truncated.
|
|
|
|
*/
|
|
|
|
if (i != j)
|
|
|
|
state->private_objs[i] =
|
|
|
|
state->private_objs[j];
|
drm/amd/display: Don't replace the dc_state for fast updates
[Why]
DRM private objects have no hw_done/flip_done fencing mechanism on their
own and cannot be used to sequence commits accordingly.
When issuing commits that don't touch the same set of hardware resources
like page-flips on different CRTCs we can run into the issue below
because of this:
1. Client requests non-blocking Commit #1, has a new dc_state #1,
state is swapped, commit tail is deferred to work queue
2. Client requests non-blocking Commit #2, has a new dc_state #2,
state is swapped, commit tail is deferred to work queue
3. Commit #2 work starts, commit tail finishes,
atomic state is cleared, dc_state #1 is freed
4. Commit #1 work starts,
commit tail encounters null pointer deref on dc_state #1
In order to change the DC state as in the private object we need to
ensure that we wait for all outstanding commits to finish and that
any other pending commits must wait for the current one to finish as
well.
We do this for MEDIUM and FULL updates. But not for FAST updates, nor
would we want to since it would cause stuttering from the delays.
FAST updates that go through dm_determine_update_type_for_commit always
create a new dc_state and lock the DRM private object if there are
any changed planes.
We need the old state to validate, but we don't actually need the new
state here.
[How]
If the commit isn't a full update then the use after free can be
resolved by simply discarding the new state entirely and retaining
the existing one instead.
With this change the sequence above can be reexamined. Commit #2 will
still free Commit #1's reference, but before this happens we actually
added an additional reference as part of Commit #2.
If an update comes in during this that needs to change the dc_state
it will need to wait on Commit #1 and Commit #2 to finish. Then it'll
swap the state, finish the work in commit tail and drop the last
reference on Commit #2's dc_state.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204181
Fixes: 004b3938e637 ("drm/amd/display: Check scaling info when determing update type")
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: David Francis <david.francis@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-07-31 14:33:54 +00:00
|
|
|
|
2020-07-27 05:40:46 +00:00
|
|
|
state->private_objs[j].ptr = NULL;
|
|
|
|
state->private_objs[j].state = NULL;
|
|
|
|
state->private_objs[j].old_state = NULL;
|
|
|
|
state->private_objs[j].new_state = NULL;
|
|
|
|
|
|
|
|
state->num_private_objs = j;
|
|
|
|
break;
|
|
|
|
}
|
drm/amd/display: Don't replace the dc_state for fast updates
[Why]
DRM private objects have no hw_done/flip_done fencing mechanism on their
own and cannot be used to sequence commits accordingly.
When issuing commits that don't touch the same set of hardware resources
like page-flips on different CRTCs we can run into the issue below
because of this:
1. Client requests non-blocking Commit #1, has a new dc_state #1,
state is swapped, commit tail is deferred to work queue
2. Client requests non-blocking Commit #2, has a new dc_state #2,
state is swapped, commit tail is deferred to work queue
3. Commit #2 work starts, commit tail finishes,
atomic state is cleared, dc_state #1 is freed
4. Commit #1 work starts,
commit tail encounters null pointer deref on dc_state #1
In order to change the DC state as in the private object we need to
ensure that we wait for all outstanding commits to finish and that
any other pending commits must wait for the current one to finish as
well.
We do this for MEDIUM and FULL updates. But not for FAST updates, nor
would we want to since it would cause stuttering from the delays.
FAST updates that go through dm_determine_update_type_for_commit always
create a new dc_state and lock the DRM private object if there are
any changed planes.
We need the old state to validate, but we don't actually need the new
state here.
[How]
If the commit isn't a full update then the use after free can be
resolved by simply discarding the new state entirely and retaining
the existing one instead.
With this change the sequence above can be reexamined. Commit #2 will
still free Commit #1's reference, but before this happens we actually
added an additional reference as part of Commit #2.
If an update comes in during this that needs to change the dc_state
it will need to wait on Commit #1 and Commit #2 to finish. Then it'll
swap the state, finish the work in commit tail and drop the last
reference on Commit #2's dc_state.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204181
Fixes: 004b3938e637 ("drm/amd/display: Check scaling info when determing update type")
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: David Francis <david.francis@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-07-31 14:33:54 +00:00
|
|
|
}
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2019-08-02 14:45:11 +00:00
|
|
|
/* Store the overall update type for use later in atomic check. */
|
|
|
|
for_each_new_crtc_in_state (state, crtc, new_crtc_state, i) {
|
|
|
|
struct dm_crtc_state *dm_new_crtc_state =
|
|
|
|
to_dm_crtc_state(new_crtc_state);
|
|
|
|
|
|
|
|
dm_new_crtc_state->update_type = (int)overall_update_type;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Must be success */
|
|
|
|
WARN_ON(ret);
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
fail:
|
|
|
|
if (ret == -EDEADLK)
|
2017-11-09 17:38:09 +00:00
|
|
|
DRM_DEBUG_DRIVER("Atomic check stopped to avoid deadlock.\n");
|
2017-08-10 17:29:07 +00:00
|
|
|
else if (ret == -EINTR || ret == -EAGAIN || ret == -ERESTARTSYS)
|
2017-11-09 17:38:09 +00:00
|
|
|
DRM_DEBUG_DRIVER("Atomic check stopped due to signal.\n");
|
2017-08-10 17:29:07 +00:00
|
|
|
else
|
2017-11-09 17:38:09 +00:00
|
|
|
DRM_DEBUG_DRIVER("Atomic check failed with err: %d \n", ret);
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2017-10-10 21:44:52 +00:00
|
|
|
static bool is_dp_capable_without_timing_msa(struct dc *dc,
|
|
|
|
struct amdgpu_dm_connector *amdgpu_dm_connector)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
uint8_t dpcd_data;
|
|
|
|
bool capable = false;
|
|
|
|
|
2017-09-05 18:16:09 +00:00
|
|
|
if (amdgpu_dm_connector->dc_link &&
|
2017-08-10 17:29:07 +00:00
|
|
|
dm_helpers_dp_read_dpcd(
|
|
|
|
NULL,
|
2017-09-05 18:16:09 +00:00
|
|
|
amdgpu_dm_connector->dc_link,
|
2017-08-10 17:29:07 +00:00
|
|
|
DP_DOWN_STREAM_PORT_COUNT,
|
|
|
|
&dpcd_data,
|
|
|
|
sizeof(dpcd_data))) {
|
|
|
|
capable = (dpcd_data & DP_MSA_TIMING_PAR_IGNORED) ? true:false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return capable;
|
|
|
|
}
|
2018-08-21 19:40:28 +00:00
|
|
|
void amdgpu_dm_update_freesync_caps(struct drm_connector *connector,
|
|
|
|
struct edid *edid)
|
2017-08-10 17:29:07 +00:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
bool edid_check_required;
|
|
|
|
struct detailed_timing *timing;
|
|
|
|
struct detailed_non_pixel *data;
|
|
|
|
struct detailed_data_monitor_range *range;
|
2017-09-05 18:16:09 +00:00
|
|
|
struct amdgpu_dm_connector *amdgpu_dm_connector =
|
|
|
|
to_amdgpu_dm_connector(connector);
|
2018-10-04 17:03:30 +00:00
|
|
|
struct dm_connector_state *dm_con_state = NULL;
|
2017-08-10 17:29:07 +00:00
|
|
|
|
|
|
|
struct drm_device *dev = connector->dev;
|
|
|
|
struct amdgpu_device *adev = dev->dev_private;
|
2018-10-04 17:03:30 +00:00
|
|
|
bool freesync_capable = false;
|
2017-07-27 01:03:22 +00:00
|
|
|
|
2017-10-17 16:02:01 +00:00
|
|
|
if (!connector->state) {
|
|
|
|
DRM_ERROR("%s - Connector has no state", __func__);
|
2018-10-04 17:03:30 +00:00
|
|
|
goto update;
|
2017-10-17 16:02:01 +00:00
|
|
|
}
|
|
|
|
|
2018-08-21 19:40:28 +00:00
|
|
|
if (!edid) {
|
|
|
|
dm_con_state = to_dm_connector_state(connector->state);
|
|
|
|
|
|
|
|
amdgpu_dm_connector->min_vfreq = 0;
|
|
|
|
amdgpu_dm_connector->max_vfreq = 0;
|
|
|
|
amdgpu_dm_connector->pixel_clock_mhz = 0;
|
|
|
|
|
2018-10-04 17:03:30 +00:00
|
|
|
goto update;
|
2018-08-21 19:40:28 +00:00
|
|
|
}
|
|
|
|
|
2017-10-17 16:02:01 +00:00
|
|
|
dm_con_state = to_dm_connector_state(connector->state);
|
|
|
|
|
2017-08-10 17:29:07 +00:00
|
|
|
edid_check_required = false;
|
2017-09-05 18:16:09 +00:00
|
|
|
if (!amdgpu_dm_connector->dc_sink) {
|
2017-08-10 17:29:07 +00:00
|
|
|
DRM_ERROR("dc_sink NULL, could not add free_sync module.\n");
|
2018-10-04 17:03:30 +00:00
|
|
|
goto update;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
if (!adev->dm.freesync_module)
|
2018-10-04 17:03:30 +00:00
|
|
|
goto update;
|
2017-08-10 17:29:07 +00:00
|
|
|
/*
|
|
|
|
* if edid non zero restrict freesync only for dp and edp
|
|
|
|
*/
|
|
|
|
if (edid) {
|
2017-09-05 18:16:09 +00:00
|
|
|
if (amdgpu_dm_connector->dc_sink->sink_signal == SIGNAL_TYPE_DISPLAY_PORT
|
|
|
|
|| amdgpu_dm_connector->dc_sink->sink_signal == SIGNAL_TYPE_EDP) {
|
2017-08-10 17:29:07 +00:00
|
|
|
edid_check_required = is_dp_capable_without_timing_msa(
|
|
|
|
adev->dm.dc,
|
2017-09-05 18:16:09 +00:00
|
|
|
amdgpu_dm_connector);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
if (edid_check_required == true && (edid->version > 1 ||
|
|
|
|
(edid->version == 1 && edid->revision > 1))) {
|
|
|
|
for (i = 0; i < 4; i++) {
|
|
|
|
|
|
|
|
timing = &edid->detailed_timings[i];
|
|
|
|
data = &timing->data.other_data;
|
|
|
|
range = &data->data.range;
|
|
|
|
/*
|
|
|
|
* Check if monitor has continuous frequency mode
|
|
|
|
*/
|
|
|
|
if (data->type != EDID_DETAIL_MONITOR_RANGE)
|
|
|
|
continue;
|
|
|
|
/*
|
|
|
|
* Check for flag range limits only. If flag == 1 then
|
|
|
|
* no additional timing information provided.
|
|
|
|
* Default GTF, GTF Secondary curve and CVT are not
|
|
|
|
* supported
|
|
|
|
*/
|
|
|
|
if (range->flags != 1)
|
|
|
|
continue;
|
|
|
|
|
2017-09-05 18:16:09 +00:00
|
|
|
amdgpu_dm_connector->min_vfreq = range->min_vfreq;
|
|
|
|
amdgpu_dm_connector->max_vfreq = range->max_vfreq;
|
|
|
|
amdgpu_dm_connector->pixel_clock_mhz =
|
2017-08-10 17:29:07 +00:00
|
|
|
range->pixel_clock_mhz * 10;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2017-09-05 18:16:09 +00:00
|
|
|
if (amdgpu_dm_connector->max_vfreq -
|
2018-08-21 19:40:28 +00:00
|
|
|
amdgpu_dm_connector->min_vfreq > 10) {
|
|
|
|
|
2018-10-04 17:03:30 +00:00
|
|
|
freesync_capable = true;
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
}
|
2018-10-04 17:03:30 +00:00
|
|
|
|
|
|
|
update:
|
|
|
|
if (dm_con_state)
|
|
|
|
dm_con_state->freesync_capable = freesync_capable;
|
|
|
|
|
|
|
|
if (connector->vrr_capable_property)
|
|
|
|
drm_connector_set_vrr_capable_property(connector,
|
|
|
|
freesync_capable);
|
2017-08-10 17:29:07 +00:00
|
|
|
}
|
|
|
|
|
2019-09-20 23:03:17 +00:00
|
|
|
static void amdgpu_dm_set_psr_caps(struct dc_link *link)
|
|
|
|
{
|
|
|
|
uint8_t dpcd_data[EDP_PSR_RECEIVER_CAP_SIZE];
|
|
|
|
|
|
|
|
if (!(link->connector_signal & SIGNAL_TYPE_EDP))
|
|
|
|
return;
|
|
|
|
if (link->type == dc_connection_none)
|
|
|
|
return;
|
|
|
|
if (dm_helpers_dp_read_dpcd(NULL, link, DP_PSR_SUPPORT,
|
|
|
|
dpcd_data, sizeof(dpcd_data))) {
|
2020-03-31 13:31:16 +00:00
|
|
|
link->dpcd_caps.psr_caps.psr_version = dpcd_data[0];
|
|
|
|
|
|
|
|
if (dpcd_data[0] == 0) {
|
2020-04-22 02:01:30 +00:00
|
|
|
link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
|
2020-03-31 13:31:16 +00:00
|
|
|
link->psr_settings.psr_feature_enabled = false;
|
|
|
|
} else {
|
2020-04-22 02:01:30 +00:00
|
|
|
link->psr_settings.psr_version = DC_PSR_VERSION_1;
|
2020-03-31 13:31:16 +00:00
|
|
|
link->psr_settings.psr_feature_enabled = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
DRM_INFO("PSR support:%d\n", link->psr_settings.psr_feature_enabled);
|
2019-09-20 23:03:17 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* amdgpu_dm_link_setup_psr() - configure psr link
|
|
|
|
* @stream: stream state
|
|
|
|
*
|
|
|
|
* Return: true if success
|
|
|
|
*/
|
|
|
|
static bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
|
|
|
|
{
|
|
|
|
struct dc_link *link = NULL;
|
|
|
|
struct psr_config psr_config = {0};
|
|
|
|
struct psr_context psr_context = {0};
|
|
|
|
bool ret = false;
|
|
|
|
|
|
|
|
if (stream == NULL)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
link = stream->link;
|
|
|
|
|
2020-03-31 13:31:16 +00:00
|
|
|
psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
|
2019-09-20 23:03:17 +00:00
|
|
|
|
|
|
|
if (psr_config.psr_version > 0) {
|
|
|
|
psr_config.psr_exit_link_training_required = 0x1;
|
|
|
|
psr_config.psr_frame_capture_indication_req = 0;
|
|
|
|
psr_config.psr_rfb_setup_time = 0x37;
|
|
|
|
psr_config.psr_sdp_transmit_line_num_deadline = 0x20;
|
|
|
|
psr_config.allow_smu_optimizations = 0x0;
|
|
|
|
|
|
|
|
ret = dc_link_setup_psr(link, stream, &psr_config, &psr_context);
|
|
|
|
|
|
|
|
}
|
2020-03-31 13:31:16 +00:00
|
|
|
DRM_DEBUG_DRIVER("PSR link: %d\n", link->psr_settings.psr_feature_enabled);
|
2019-09-20 23:03:17 +00:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* amdgpu_dm_psr_enable() - enable psr f/w
|
|
|
|
* @stream: stream state
|
|
|
|
*
|
|
|
|
* Return: true if success
|
|
|
|
*/
|
|
|
|
bool amdgpu_dm_psr_enable(struct dc_stream_state *stream)
|
|
|
|
{
|
|
|
|
struct dc_link *link = stream->link;
|
2019-12-09 22:26:34 +00:00
|
|
|
unsigned int vsync_rate_hz = 0;
|
|
|
|
struct dc_static_screen_params params = {0};
|
|
|
|
/* Calculate number of static frames before generating interrupt to
|
|
|
|
* enter PSR.
|
|
|
|
*/
|
|
|
|
// Init fail safe of 2 frames static
|
|
|
|
unsigned int num_frames_static = 2;
|
2019-09-20 23:03:17 +00:00
|
|
|
|
|
|
|
DRM_DEBUG_DRIVER("Enabling psr...\n");
|
|
|
|
|
2019-12-09 22:26:34 +00:00
|
|
|
vsync_rate_hz = div64_u64(div64_u64((
|
|
|
|
stream->timing.pix_clk_100hz * 100),
|
|
|
|
stream->timing.v_total),
|
|
|
|
stream->timing.h_total);
|
|
|
|
|
|
|
|
/* Round up
|
|
|
|
* Calculate number of frames such that at least 30 ms of time has
|
|
|
|
* passed.
|
|
|
|
*/
|
2020-01-14 18:56:08 +00:00
|
|
|
if (vsync_rate_hz != 0) {
|
|
|
|
unsigned int frame_time_microsec = 1000000 / vsync_rate_hz;
|
2019-12-09 22:26:34 +00:00
|
|
|
num_frames_static = (30000 / frame_time_microsec) + 1;
|
2020-01-14 18:56:08 +00:00
|
|
|
}
|
2019-12-09 22:26:34 +00:00
|
|
|
|
|
|
|
params.triggers.cursor_update = true;
|
|
|
|
params.triggers.overlay_update = true;
|
|
|
|
params.triggers.surface_update = true;
|
|
|
|
params.num_frames = num_frames_static;
|
2019-09-20 23:03:17 +00:00
|
|
|
|
2019-12-09 22:26:34 +00:00
|
|
|
dc_stream_set_static_screen_params(link->ctx->dc,
|
2019-09-20 23:03:17 +00:00
|
|
|
&stream, 1,
|
2019-12-09 22:26:34 +00:00
|
|
|
¶ms);
|
2019-09-20 23:03:17 +00:00
|
|
|
|
|
|
|
return dc_link_set_psr_allow_active(link, true, false);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* amdgpu_dm_psr_disable() - disable psr f/w
|
|
|
|
* @stream: stream state
|
|
|
|
*
|
|
|
|
* Return: true if success
|
|
|
|
*/
|
|
|
|
static bool amdgpu_dm_psr_disable(struct dc_stream_state *stream)
|
|
|
|
{
|
|
|
|
|
|
|
|
DRM_DEBUG_DRIVER("Disabling psr...\n");
|
|
|
|
|
|
|
|
return dc_link_set_psr_allow_active(stream->link, false, true);
|
|
|
|
}
|