2018-10-11 15:57:42 +00:00
|
|
|
/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
|
|
|
|
/* Copyright (C) 2016-2018 Netronome Systems, Inc. */
|
2016-09-21 10:44:00 +00:00
|
|
|
|
|
|
|
#ifndef __NFP_BPF_H__
|
|
|
|
#define __NFP_BPF_H__ 1
|
|
|
|
|
|
|
|
#include <linux/bitfield.h>
|
|
|
|
#include <linux/bpf.h>
|
2017-10-12 17:34:16 +00:00
|
|
|
#include <linux/bpf_verifier.h>
|
2018-01-12 04:29:11 +00:00
|
|
|
#include <linux/kernel.h>
|
2016-09-21 10:44:00 +00:00
|
|
|
#include <linux/list.h>
|
2018-05-04 01:37:09 +00:00
|
|
|
#include <linux/rhashtable.h>
|
2018-01-12 04:29:11 +00:00
|
|
|
#include <linux/skbuff.h>
|
2016-09-21 10:44:00 +00:00
|
|
|
#include <linux/types.h>
|
2018-01-12 04:29:11 +00:00
|
|
|
#include <linux/wait.h>
|
2016-09-21 10:44:00 +00:00
|
|
|
|
2019-04-12 03:27:07 +00:00
|
|
|
#include "../ccm.h"
|
2017-10-09 04:04:05 +00:00
|
|
|
#include "../nfp_asm.h"
|
2018-01-12 04:29:11 +00:00
|
|
|
#include "fw.h"
|
2017-05-31 15:06:50 +00:00
|
|
|
|
2018-07-26 02:53:34 +00:00
|
|
|
#define cmsg_warn(bpf, msg...) nn_dp_warn(&(bpf)->app->ctrl->dp, msg)
|
|
|
|
|
2018-01-10 12:26:01 +00:00
|
|
|
/* For relocation logic use up-most byte of branch instruction as scratch
|
2016-09-21 10:44:00 +00:00
|
|
|
* area. Remember to clear this before sending instructions to HW!
|
|
|
|
*/
|
2018-01-10 12:26:01 +00:00
|
|
|
#define OP_RELO_TYPE 0xff00000000000000ULL
|
|
|
|
|
|
|
|
enum nfp_relo_type {
|
|
|
|
RELO_NONE = 0,
|
|
|
|
/* standard internal jumps */
|
|
|
|
RELO_BR_REL,
|
|
|
|
/* internal jumps to parts of the outro */
|
|
|
|
RELO_BR_GO_OUT,
|
|
|
|
RELO_BR_GO_ABORT,
|
nfp: bpf: add main logics for BPF-to-BPF calls support in nfp driver
This is the main patch for the logics of BPF-to-BPF calls in the nfp
driver.
The functions called on BPF_JUMP | BPF_CALL and BPF_JUMP | BPF_EXIT were
used to call helpers and exit from the program, respectively; make them
usable for calling into, or returning from, a BPF subprogram as well.
For all calls, push the return address as well as the callee-saved
registers (R6 to R9) to the stack, and pop them upon returning from the
calls. In order to limit the overhead in terms of instruction number,
this is done through dedicated subroutines. Jumping to the callee
actually consists in jumping to the subroutine, that "returns" to the
callee: this will require some fixup for passing the address in a later
patch. Similarly, returning consists in jumping to the subroutine, which
pops registers and then return directly to the caller (but no fixup is
needed here).
Return to the caller is performed with the RTN instruction newly added
to the JIT.
For the few steps where we need to know what subprogram an instruction
belongs to, the struct nfp_insn_meta is extended with a new subprog_idx
field.
Note that checks on the available stack size, to take into account the
additional requirements associated to BPF-to-BPF calls (storing R6-R9
and return addresses), are added in a later patch.
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2018-10-07 11:56:52 +00:00
|
|
|
RELO_BR_GO_CALL_PUSH_REGS,
|
|
|
|
RELO_BR_GO_CALL_POP_REGS,
|
2018-01-10 12:26:01 +00:00
|
|
|
/* external jumps to fixed addresses */
|
|
|
|
RELO_BR_NEXT_PKT,
|
2018-01-12 04:29:15 +00:00
|
|
|
RELO_BR_HELPER,
|
|
|
|
/* immediate relocation against load address */
|
|
|
|
RELO_IMMED_REL,
|
2016-09-21 10:44:00 +00:00
|
|
|
};
|
|
|
|
|
2018-01-10 12:26:03 +00:00
|
|
|
/* To make absolute relocated branches (branches other than RELO_BR_REL)
|
|
|
|
* distinguishable in user space dumps from normal jumps, add a large offset
|
|
|
|
* to them.
|
|
|
|
*/
|
|
|
|
#define BR_OFF_RELO 15000
|
|
|
|
|
2016-09-21 10:44:00 +00:00
|
|
|
enum static_regs {
|
2018-03-29 00:48:34 +00:00
|
|
|
STATIC_REG_IMMA = 20, /* Bank AB */
|
2017-10-09 04:04:13 +00:00
|
|
|
STATIC_REG_IMM = 21, /* Bank AB */
|
2017-10-23 18:58:11 +00:00
|
|
|
STATIC_REG_STACK = 22, /* Bank A */
|
2017-10-09 04:04:13 +00:00
|
|
|
STATIC_REG_PKT_LEN = 22, /* Bank B */
|
|
|
|
};
|
|
|
|
|
|
|
|
enum pkt_vec {
|
|
|
|
PKT_VEC_PKT_LEN = 0,
|
|
|
|
PKT_VEC_PKT_PTR = 2,
|
2018-05-09 02:37:07 +00:00
|
|
|
PKT_VEC_QSEL_SET = 4,
|
|
|
|
PKT_VEC_QSEL_VAL = 6,
|
2016-09-21 10:44:00 +00:00
|
|
|
};
|
|
|
|
|
2018-05-09 02:37:07 +00:00
|
|
|
#define PKT_VEL_QSEL_SET_BIT 4
|
|
|
|
|
2017-10-09 04:04:13 +00:00
|
|
|
#define pv_len(np) reg_lm(1, PKT_VEC_PKT_LEN)
|
|
|
|
#define pv_ctm_ptr(np) reg_lm(1, PKT_VEC_PKT_PTR)
|
2018-05-09 02:37:07 +00:00
|
|
|
#define pv_qsel_set(np) reg_lm(1, PKT_VEC_QSEL_SET)
|
|
|
|
#define pv_qsel_val(np) reg_lm(1, PKT_VEC_QSEL_VAL)
|
2017-10-09 04:04:13 +00:00
|
|
|
|
2017-10-23 18:58:11 +00:00
|
|
|
#define stack_reg(np) reg_a(STATIC_REG_STACK)
|
|
|
|
#define stack_imm(np) imm_b(np)
|
2017-10-09 04:04:13 +00:00
|
|
|
#define plen_reg(np) reg_b(STATIC_REG_PKT_LEN)
|
|
|
|
#define pptr_reg(np) pv_ctm_ptr(np)
|
|
|
|
#define imm_a(np) reg_a(STATIC_REG_IMM)
|
|
|
|
#define imm_b(np) reg_b(STATIC_REG_IMM)
|
2018-03-29 00:48:34 +00:00
|
|
|
#define imma_a(np) reg_a(STATIC_REG_IMMA)
|
|
|
|
#define imma_b(np) reg_b(STATIC_REG_IMMA)
|
2017-10-09 04:04:13 +00:00
|
|
|
#define imm_both(np) reg_both(STATIC_REG_IMM)
|
nfp: bpf: add main logics for BPF-to-BPF calls support in nfp driver
This is the main patch for the logics of BPF-to-BPF calls in the nfp
driver.
The functions called on BPF_JUMP | BPF_CALL and BPF_JUMP | BPF_EXIT were
used to call helpers and exit from the program, respectively; make them
usable for calling into, or returning from, a BPF subprogram as well.
For all calls, push the return address as well as the callee-saved
registers (R6 to R9) to the stack, and pop them upon returning from the
calls. In order to limit the overhead in terms of instruction number,
this is done through dedicated subroutines. Jumping to the callee
actually consists in jumping to the subroutine, that "returns" to the
callee: this will require some fixup for passing the address in a later
patch. Similarly, returning consists in jumping to the subroutine, which
pops registers and then return directly to the caller (but no fixup is
needed here).
Return to the caller is performed with the RTN instruction newly added
to the JIT.
For the few steps where we need to know what subprogram an instruction
belongs to, the struct nfp_insn_meta is extended with a new subprog_idx
field.
Note that checks on the available stack size, to take into account the
additional requirements associated to BPF-to-BPF calls (storing R6-R9
and return addresses), are added in a later patch.
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2018-10-07 11:56:52 +00:00
|
|
|
#define ret_reg(np) imm_a(np)
|
2016-09-21 10:44:00 +00:00
|
|
|
|
2017-10-09 04:04:09 +00:00
|
|
|
#define NFP_BPF_ABI_FLAGS reg_imm(0)
|
2016-09-21 10:44:04 +00:00
|
|
|
#define NFP_BPF_ABI_FLAG_MARK 1
|
2016-09-21 10:44:00 +00:00
|
|
|
|
2017-12-15 05:29:16 +00:00
|
|
|
/**
|
|
|
|
* struct nfp_app_bpf - bpf app priv structure
|
|
|
|
* @app: backpointer to the app
|
2019-04-12 03:27:07 +00:00
|
|
|
* @ccm: common control message handler data
|
2017-12-15 05:29:18 +00:00
|
|
|
*
|
2018-07-17 17:53:25 +00:00
|
|
|
* @bpf_dev: BPF offload device handle
|
|
|
|
*
|
2018-10-02 01:30:34 +00:00
|
|
|
* @cmsg_key_sz: size of key in cmsg element array
|
|
|
|
* @cmsg_val_sz: size of value in cmsg element array
|
|
|
|
*
|
2018-01-12 04:29:10 +00:00
|
|
|
* @map_list: list of offloaded maps
|
2018-01-12 04:29:17 +00:00
|
|
|
* @maps_in_use: number of currently offloaded maps
|
|
|
|
* @map_elems_in_use: number of elements allocated to offloaded maps
|
2018-01-12 04:29:10 +00:00
|
|
|
*
|
2018-05-04 01:37:09 +00:00
|
|
|
* @maps_neutral: hash table of offload-neutral maps (on pointer)
|
|
|
|
*
|
2018-10-02 01:30:32 +00:00
|
|
|
* @abi_version: global BPF ABI version
|
|
|
|
*
|
2017-12-15 05:29:18 +00:00
|
|
|
* @adjust_head: adjust head capability
|
2018-02-05 23:29:27 +00:00
|
|
|
* @adjust_head.flags: extra flags for adjust head
|
|
|
|
* @adjust_head.off_min: minimal packet offset within buffer required
|
|
|
|
* @adjust_head.off_max: maximum packet offset within buffer required
|
|
|
|
* @adjust_head.guaranteed_sub: negative adjustment guaranteed possible
|
|
|
|
* @adjust_head.guaranteed_add: positive adjustment guaranteed possible
|
2018-01-12 04:29:13 +00:00
|
|
|
*
|
|
|
|
* @maps: map capability
|
2018-02-05 23:29:27 +00:00
|
|
|
* @maps.types: supported map types
|
|
|
|
* @maps.max_maps: max number of maps supported
|
|
|
|
* @maps.max_elems: max number of entries in each map
|
|
|
|
* @maps.max_key_sz: max size of map key
|
|
|
|
* @maps.max_val_sz: max size of map value
|
|
|
|
* @maps.max_elem_sz: max size of map entry (key + value)
|
2018-01-12 04:29:13 +00:00
|
|
|
*
|
|
|
|
* @helpers: helper addressess for various calls
|
2018-02-05 23:29:27 +00:00
|
|
|
* @helpers.map_lookup: map lookup helper address
|
2018-03-29 00:48:31 +00:00
|
|
|
* @helpers.map_update: map update helper address
|
2018-03-29 00:48:32 +00:00
|
|
|
* @helpers.map_delete: map delete helper address
|
2018-05-04 01:37:12 +00:00
|
|
|
* @helpers.perf_event_output: output perf event to a ring buffer
|
2018-03-29 00:48:37 +00:00
|
|
|
*
|
|
|
|
* @pseudo_random: FW initialized the pseudo-random machinery (CSRs)
|
2018-05-09 02:37:07 +00:00
|
|
|
* @queue_select: BPF can set the RX queue ID in packet vector
|
2018-08-04 05:06:00 +00:00
|
|
|
* @adjust_tail: BPF can simply trunc packet size for adjust tail
|
2017-12-15 05:29:16 +00:00
|
|
|
*/
|
|
|
|
struct nfp_app_bpf {
|
|
|
|
struct nfp_app *app;
|
2019-04-12 03:27:07 +00:00
|
|
|
struct nfp_ccm ccm;
|
2017-12-15 05:29:18 +00:00
|
|
|
|
2018-07-17 17:53:25 +00:00
|
|
|
struct bpf_offload_dev *bpf_dev;
|
|
|
|
|
2018-10-02 01:30:34 +00:00
|
|
|
unsigned int cmsg_key_sz;
|
|
|
|
unsigned int cmsg_val_sz;
|
|
|
|
|
2018-01-12 04:29:10 +00:00
|
|
|
struct list_head map_list;
|
2018-01-12 04:29:17 +00:00
|
|
|
unsigned int maps_in_use;
|
|
|
|
unsigned int map_elems_in_use;
|
2018-01-12 04:29:10 +00:00
|
|
|
|
2018-05-04 01:37:09 +00:00
|
|
|
struct rhashtable maps_neutral;
|
|
|
|
|
2018-10-02 01:30:32 +00:00
|
|
|
u32 abi_version;
|
|
|
|
|
2017-12-15 05:29:18 +00:00
|
|
|
struct nfp_bpf_cap_adjust_head {
|
|
|
|
u32 flags;
|
|
|
|
int off_min;
|
|
|
|
int off_max;
|
2017-12-15 05:29:19 +00:00
|
|
|
int guaranteed_sub;
|
|
|
|
int guaranteed_add;
|
2017-12-15 05:29:18 +00:00
|
|
|
} adjust_head;
|
2018-01-12 04:29:13 +00:00
|
|
|
|
|
|
|
struct {
|
|
|
|
u32 types;
|
|
|
|
u32 max_maps;
|
|
|
|
u32 max_elems;
|
|
|
|
u32 max_key_sz;
|
|
|
|
u32 max_val_sz;
|
|
|
|
u32 max_elem_sz;
|
|
|
|
} maps;
|
|
|
|
|
|
|
|
struct {
|
|
|
|
u32 map_lookup;
|
2018-03-29 00:48:31 +00:00
|
|
|
u32 map_update;
|
2018-03-29 00:48:32 +00:00
|
|
|
u32 map_delete;
|
2018-05-04 01:37:12 +00:00
|
|
|
u32 perf_event_output;
|
2018-01-12 04:29:13 +00:00
|
|
|
} helpers;
|
2018-03-29 00:48:37 +00:00
|
|
|
|
|
|
|
bool pseudo_random;
|
2018-05-09 02:37:07 +00:00
|
|
|
bool queue_select;
|
2018-08-04 05:06:00 +00:00
|
|
|
bool adjust_tail;
|
2017-12-15 05:29:16 +00:00
|
|
|
};
|
|
|
|
|
2018-03-29 00:48:34 +00:00
|
|
|
enum nfp_bpf_map_use {
|
|
|
|
NFP_MAP_UNUSED = 0,
|
|
|
|
NFP_MAP_USE_READ,
|
|
|
|
NFP_MAP_USE_WRITE,
|
|
|
|
NFP_MAP_USE_ATOMIC_CNT,
|
|
|
|
};
|
|
|
|
|
nfp: bpf: protect against mis-initializing atomic counters
Atomic operations on the NFP are currently always in big endian.
The driver keeps track of regions of memory storing atomic values
and byte swaps them accordingly. There are corner cases where
the map values may be initialized before the driver knows they
are used as atomic counters. This can happen either when the
datapath is performing the update and the stack contents are
unknown or when map is updated before the program which will
use it for atomic values is loaded.
To avoid situation where user initializes the value to 0 1 2 3
and then after loading a program which uses the word as an atomic
counter starts reading 3 2 1 0 - only allow atomic counters to be
initialized to endian-neutral values.
For updates from the datapath the stack information may not be
as precise, so just allow initializing such values to 0.
Example code which would break:
struct bpf_map_def SEC("maps") rxcnt = {
.type = BPF_MAP_TYPE_HASH,
.key_size = sizeof(__u32),
.value_size = sizeof(__u64),
.max_entries = 1,
};
int xdp_prog1()
{
__u64 nonzeroval = 3;
__u32 key = 0;
__u64 *value;
value = bpf_map_lookup_elem(&rxcnt, &key);
if (!value)
bpf_map_update_elem(&rxcnt, &key, &nonzeroval, BPF_ANY);
else
__sync_fetch_and_add(value, 1);
return XDP_PASS;
}
$ offload bpftool map dump
key: 00 00 00 00 value: 00 00 00 03 00 00 00 00
should be:
$ offload bpftool map dump
key: 00 00 00 00 value: 03 00 00 00 00 00 00 00
Reported-by: David Beckett <david.beckett@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
2018-10-16 22:19:09 +00:00
|
|
|
struct nfp_bpf_map_word {
|
|
|
|
unsigned char type :4;
|
|
|
|
unsigned char non_zero_update :1;
|
|
|
|
};
|
|
|
|
|
2018-01-12 04:29:10 +00:00
|
|
|
/**
|
|
|
|
* struct nfp_bpf_map - private per-map data attached to BPF maps for offload
|
|
|
|
* @offmap: pointer to the offloaded BPF map
|
|
|
|
* @bpf: back pointer to bpf app private structure
|
|
|
|
* @tid: table id identifying map on datapath
|
|
|
|
* @l: link on the nfp_app_bpf->map_list list
|
2018-03-29 00:48:34 +00:00
|
|
|
* @use_map: map of how the value is used (in 4B chunks)
|
2018-01-12 04:29:10 +00:00
|
|
|
*/
|
|
|
|
struct nfp_bpf_map {
|
|
|
|
struct bpf_offloaded_map *offmap;
|
|
|
|
struct nfp_app_bpf *bpf;
|
|
|
|
u32 tid;
|
|
|
|
struct list_head l;
|
nfp: bpf: protect against mis-initializing atomic counters
Atomic operations on the NFP are currently always in big endian.
The driver keeps track of regions of memory storing atomic values
and byte swaps them accordingly. There are corner cases where
the map values may be initialized before the driver knows they
are used as atomic counters. This can happen either when the
datapath is performing the update and the stack contents are
unknown or when map is updated before the program which will
use it for atomic values is loaded.
To avoid situation where user initializes the value to 0 1 2 3
and then after loading a program which uses the word as an atomic
counter starts reading 3 2 1 0 - only allow atomic counters to be
initialized to endian-neutral values.
For updates from the datapath the stack information may not be
as precise, so just allow initializing such values to 0.
Example code which would break:
struct bpf_map_def SEC("maps") rxcnt = {
.type = BPF_MAP_TYPE_HASH,
.key_size = sizeof(__u32),
.value_size = sizeof(__u64),
.max_entries = 1,
};
int xdp_prog1()
{
__u64 nonzeroval = 3;
__u32 key = 0;
__u64 *value;
value = bpf_map_lookup_elem(&rxcnt, &key);
if (!value)
bpf_map_update_elem(&rxcnt, &key, &nonzeroval, BPF_ANY);
else
__sync_fetch_and_add(value, 1);
return XDP_PASS;
}
$ offload bpftool map dump
key: 00 00 00 00 value: 00 00 00 03 00 00 00 00
should be:
$ offload bpftool map dump
key: 00 00 00 00 value: 03 00 00 00 00 00 00 00
Reported-by: David Beckett <david.beckett@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
2018-10-16 22:19:09 +00:00
|
|
|
struct nfp_bpf_map_word use_map[];
|
2018-01-12 04:29:10 +00:00
|
|
|
};
|
|
|
|
|
2018-05-04 01:37:09 +00:00
|
|
|
struct nfp_bpf_neutral_map {
|
|
|
|
struct rhash_head l;
|
|
|
|
struct bpf_map *ptr;
|
2018-07-26 02:53:34 +00:00
|
|
|
u32 map_id;
|
2018-05-04 01:37:09 +00:00
|
|
|
u32 count;
|
|
|
|
};
|
|
|
|
|
|
|
|
extern const struct rhashtable_params nfp_bpf_maps_neutral_params;
|
|
|
|
|
2016-09-21 10:44:00 +00:00
|
|
|
struct nfp_prog;
|
|
|
|
struct nfp_insn_meta;
|
|
|
|
typedef int (*instr_cb_t)(struct nfp_prog *, struct nfp_insn_meta *);
|
|
|
|
|
|
|
|
#define nfp_prog_first_meta(nfp_prog) \
|
|
|
|
list_first_entry(&(nfp_prog)->insns, struct nfp_insn_meta, l)
|
|
|
|
#define nfp_prog_last_meta(nfp_prog) \
|
|
|
|
list_last_entry(&(nfp_prog)->insns, struct nfp_insn_meta, l)
|
|
|
|
#define nfp_meta_next(meta) list_next_entry(meta, l)
|
|
|
|
#define nfp_meta_prev(meta) list_prev_entry(meta, l)
|
|
|
|
|
2018-03-29 00:48:29 +00:00
|
|
|
/**
|
|
|
|
* struct nfp_bpf_reg_state - register state for calls
|
|
|
|
* @reg: BPF register state from latest path
|
|
|
|
* @var_off: for stack arg - changes stack offset on different paths
|
|
|
|
*/
|
|
|
|
struct nfp_bpf_reg_state {
|
|
|
|
struct bpf_reg_state reg;
|
|
|
|
bool var_off;
|
|
|
|
};
|
|
|
|
|
2018-10-07 11:56:51 +00:00
|
|
|
#define FLAG_INSN_IS_JUMP_DST BIT(0)
|
|
|
|
#define FLAG_INSN_IS_SUBPROG_START BIT(1)
|
2018-10-07 11:56:57 +00:00
|
|
|
#define FLAG_INSN_PTR_CALLER_STACK_FRAME BIT(2)
|
2019-01-23 06:45:26 +00:00
|
|
|
/* Instruction is pointless, noop even on its own */
|
|
|
|
#define FLAG_INSN_SKIP_NOOP BIT(3)
|
|
|
|
/* Instruction is optimized out based on preceding instructions */
|
|
|
|
#define FLAG_INSN_SKIP_PREC_DEPENDENT BIT(4)
|
2019-01-23 06:45:29 +00:00
|
|
|
/* Instruction is optimized by the verifier */
|
|
|
|
#define FLAG_INSN_SKIP_VERIFIER_OPT BIT(5)
|
2019-01-23 06:45:26 +00:00
|
|
|
|
|
|
|
#define FLAG_INSN_SKIP_MASK (FLAG_INSN_SKIP_NOOP | \
|
2019-01-23 06:45:29 +00:00
|
|
|
FLAG_INSN_SKIP_PREC_DEPENDENT | \
|
|
|
|
FLAG_INSN_SKIP_VERIFIER_OPT)
|
2017-12-01 05:32:51 +00:00
|
|
|
|
2016-09-21 10:44:00 +00:00
|
|
|
/**
|
|
|
|
* struct nfp_insn_meta - BPF instruction wrapper
|
|
|
|
* @insn: BPF instruction
|
2017-10-12 17:34:16 +00:00
|
|
|
* @ptr: pointer type for memory operations
|
2017-12-01 05:32:58 +00:00
|
|
|
* @ldst_gather_len: memcpy length gathered from load/store sequence
|
|
|
|
* @paired_st: the paired store insn at the head of the sequence
|
2017-10-23 18:58:13 +00:00
|
|
|
* @ptr_not_const: pointer is not always constant
|
2018-03-29 00:48:25 +00:00
|
|
|
* @pkt_cache: packet data cache information
|
|
|
|
* @pkt_cache.range_start: start offset for associated packet data cache
|
|
|
|
* @pkt_cache.range_end: end offset for associated packet data cache
|
|
|
|
* @pkt_cache.do_init: this read needs to initialize packet data cache
|
2018-03-29 00:48:36 +00:00
|
|
|
* @xadd_over_16bit: 16bit immediate is not guaranteed
|
|
|
|
* @xadd_maybe_16bit: 16bit immediate is possible
|
2017-12-01 05:32:50 +00:00
|
|
|
* @jmp_dst: destination info for jump instructions
|
2018-04-25 04:22:39 +00:00
|
|
|
* @jump_neg_op: jump instruction has inverted immediate, use ADD instead of SUB
|
2018-10-07 11:56:54 +00:00
|
|
|
* @num_insns_after_br: number of insns following a branch jump, used for fixup
|
2018-01-12 04:29:15 +00:00
|
|
|
* @func_id: function id for call instructions
|
|
|
|
* @arg1: arg1 for call instructions
|
|
|
|
* @arg2: arg2 for call instructions
|
2018-07-06 22:13:19 +00:00
|
|
|
* @umin_src: copy of core verifier umin_value for src opearnd.
|
|
|
|
* @umax_src: copy of core verifier umax_value for src operand.
|
2018-07-06 22:13:20 +00:00
|
|
|
* @umin_dst: copy of core verifier umin_value for dst opearnd.
|
|
|
|
* @umax_dst: copy of core verifier umax_value for dst operand.
|
2016-09-21 10:44:00 +00:00
|
|
|
* @off: index of first generated machine instruction (in nfp_prog.prog)
|
|
|
|
* @n: eBPF instruction number
|
2017-12-01 05:32:51 +00:00
|
|
|
* @flags: eBPF instruction extra optimization flags
|
nfp: bpf: add main logics for BPF-to-BPF calls support in nfp driver
This is the main patch for the logics of BPF-to-BPF calls in the nfp
driver.
The functions called on BPF_JUMP | BPF_CALL and BPF_JUMP | BPF_EXIT were
used to call helpers and exit from the program, respectively; make them
usable for calling into, or returning from, a BPF subprogram as well.
For all calls, push the return address as well as the callee-saved
registers (R6 to R9) to the stack, and pop them upon returning from the
calls. In order to limit the overhead in terms of instruction number,
this is done through dedicated subroutines. Jumping to the callee
actually consists in jumping to the subroutine, that "returns" to the
callee: this will require some fixup for passing the address in a later
patch. Similarly, returning consists in jumping to the subroutine, which
pops registers and then return directly to the caller (but no fixup is
needed here).
Return to the caller is performed with the RTN instruction newly added
to the JIT.
For the few steps where we need to know what subprogram an instruction
belongs to, the struct nfp_insn_meta is extended with a new subprog_idx
field.
Note that checks on the available stack size, to take into account the
additional requirements associated to BPF-to-BPF calls (storing R6-R9
and return addresses), are added in a later patch.
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2018-10-07 11:56:52 +00:00
|
|
|
* @subprog_idx: index of subprogram to which the instruction belongs
|
2016-09-21 10:44:00 +00:00
|
|
|
* @double_cb: callback for second part of the instruction
|
|
|
|
* @l: link on nfp_prog->insns list
|
|
|
|
*/
|
|
|
|
struct nfp_insn_meta {
|
|
|
|
struct bpf_insn insn;
|
2017-12-01 05:32:50 +00:00
|
|
|
union {
|
2018-03-29 00:48:36 +00:00
|
|
|
/* pointer ops (ld/st/xadd) */
|
2017-12-01 05:32:50 +00:00
|
|
|
struct {
|
|
|
|
struct bpf_reg_state ptr;
|
2017-12-01 05:32:58 +00:00
|
|
|
struct bpf_insn *paired_st;
|
|
|
|
s16 ldst_gather_len;
|
2017-12-01 05:32:50 +00:00
|
|
|
bool ptr_not_const;
|
2018-03-29 00:48:25 +00:00
|
|
|
struct {
|
|
|
|
s16 range_start;
|
|
|
|
s16 range_end;
|
|
|
|
bool do_init;
|
|
|
|
} pkt_cache;
|
2018-03-29 00:48:36 +00:00
|
|
|
bool xadd_over_16bit;
|
|
|
|
bool xadd_maybe_16bit;
|
2017-12-01 05:32:50 +00:00
|
|
|
};
|
2018-03-29 00:48:36 +00:00
|
|
|
/* jump */
|
2018-04-25 04:22:39 +00:00
|
|
|
struct {
|
|
|
|
struct nfp_insn_meta *jmp_dst;
|
|
|
|
bool jump_neg_op;
|
2018-10-07 11:56:54 +00:00
|
|
|
u32 num_insns_after_br; /* only for BPF-to-BPF calls */
|
2018-04-25 04:22:39 +00:00
|
|
|
};
|
2018-03-29 00:48:36 +00:00
|
|
|
/* function calls */
|
2018-01-12 04:29:15 +00:00
|
|
|
struct {
|
|
|
|
u32 func_id;
|
|
|
|
struct bpf_reg_state arg1;
|
2018-03-29 00:48:29 +00:00
|
|
|
struct nfp_bpf_reg_state arg2;
|
2018-01-12 04:29:15 +00:00
|
|
|
};
|
2018-07-06 22:13:20 +00:00
|
|
|
/* We are interested in range info for operands of ALU
|
|
|
|
* operations. For example, shift amount, multiplicand and
|
|
|
|
* multiplier etc.
|
2018-05-18 19:12:09 +00:00
|
|
|
*/
|
|
|
|
struct {
|
2018-07-06 22:13:19 +00:00
|
|
|
u64 umin_src;
|
|
|
|
u64 umax_src;
|
2018-07-06 22:13:20 +00:00
|
|
|
u64 umin_dst;
|
|
|
|
u64 umax_dst;
|
2018-05-18 19:12:09 +00:00
|
|
|
};
|
2017-12-01 05:32:50 +00:00
|
|
|
};
|
2016-09-21 10:44:00 +00:00
|
|
|
unsigned int off;
|
|
|
|
unsigned short n;
|
2017-12-01 05:32:51 +00:00
|
|
|
unsigned short flags;
|
nfp: bpf: add main logics for BPF-to-BPF calls support in nfp driver
This is the main patch for the logics of BPF-to-BPF calls in the nfp
driver.
The functions called on BPF_JUMP | BPF_CALL and BPF_JUMP | BPF_EXIT were
used to call helpers and exit from the program, respectively; make them
usable for calling into, or returning from, a BPF subprogram as well.
For all calls, push the return address as well as the callee-saved
registers (R6 to R9) to the stack, and pop them upon returning from the
calls. In order to limit the overhead in terms of instruction number,
this is done through dedicated subroutines. Jumping to the callee
actually consists in jumping to the subroutine, that "returns" to the
callee: this will require some fixup for passing the address in a later
patch. Similarly, returning consists in jumping to the subroutine, which
pops registers and then return directly to the caller (but no fixup is
needed here).
Return to the caller is performed with the RTN instruction newly added
to the JIT.
For the few steps where we need to know what subprogram an instruction
belongs to, the struct nfp_insn_meta is extended with a new subprog_idx
field.
Note that checks on the available stack size, to take into account the
additional requirements associated to BPF-to-BPF calls (storing R6-R9
and return addresses), are added in a later patch.
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2018-10-07 11:56:52 +00:00
|
|
|
unsigned short subprog_idx;
|
2016-09-21 10:44:00 +00:00
|
|
|
instr_cb_t double_cb;
|
|
|
|
|
|
|
|
struct list_head l;
|
|
|
|
};
|
|
|
|
|
|
|
|
#define BPF_SIZE_MASK 0x18
|
|
|
|
|
|
|
|
static inline u8 mbpf_class(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return BPF_CLASS(meta->insn.code);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u8 mbpf_src(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return BPF_SRC(meta->insn.code);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u8 mbpf_op(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return BPF_OP(meta->insn.code);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u8 mbpf_mode(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return BPF_MODE(meta->insn.code);
|
|
|
|
}
|
|
|
|
|
2018-07-06 22:13:20 +00:00
|
|
|
static inline bool is_mbpf_alu(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return mbpf_class(meta) == BPF_ALU64 || mbpf_class(meta) == BPF_ALU;
|
|
|
|
}
|
|
|
|
|
2017-12-01 05:32:57 +00:00
|
|
|
static inline bool is_mbpf_load(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return (meta->insn.code & ~BPF_SIZE_MASK) == (BPF_LDX | BPF_MEM);
|
|
|
|
}
|
|
|
|
|
2019-01-26 17:26:12 +00:00
|
|
|
static inline bool is_mbpf_jmp32(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return mbpf_class(meta) == BPF_JMP32;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool is_mbpf_jmp64(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return mbpf_class(meta) == BPF_JMP;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool is_mbpf_jmp(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return is_mbpf_jmp32(meta) || is_mbpf_jmp64(meta);
|
|
|
|
}
|
|
|
|
|
2017-12-01 05:32:57 +00:00
|
|
|
static inline bool is_mbpf_store(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return (meta->insn.code & ~BPF_SIZE_MASK) == (BPF_STX | BPF_MEM);
|
|
|
|
}
|
|
|
|
|
2018-03-29 00:48:27 +00:00
|
|
|
static inline bool is_mbpf_load_pkt(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return is_mbpf_load(meta) && meta->ptr.type == PTR_TO_PACKET;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool is_mbpf_store_pkt(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return is_mbpf_store(meta) && meta->ptr.type == PTR_TO_PACKET;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool is_mbpf_classic_load(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
u8 code = meta->insn.code;
|
|
|
|
|
|
|
|
return BPF_CLASS(code) == BPF_LD &&
|
|
|
|
(BPF_MODE(code) == BPF_ABS || BPF_MODE(code) == BPF_IND);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool is_mbpf_classic_store(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
u8 code = meta->insn.code;
|
|
|
|
|
|
|
|
return BPF_CLASS(code) == BPF_ST && BPF_MODE(code) == BPF_MEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool is_mbpf_classic_store_pkt(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return is_mbpf_classic_store(meta) && meta->ptr.type == PTR_TO_PACKET;
|
|
|
|
}
|
|
|
|
|
2018-03-29 00:48:34 +00:00
|
|
|
static inline bool is_mbpf_xadd(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return (meta->insn.code & ~BPF_SIZE_MASK) == (BPF_STX | BPF_XADD);
|
|
|
|
}
|
|
|
|
|
nfp: bpf: support u16 and u32 multiplications
NFP supports u16 and u32 multiplication. Multiplication is done 8-bits per
step, therefore we need 2 steps for u16 and 4 steps for u32.
We also need one start instruction to initialize the sequence and one or
two instructions to fetch the result depending on either you need the high
halve of u32 multiplication.
For ALU64, if either operand is beyond u32's value range, we reject it. One
thing to note, if the source operand is BPF_K, then we need to check "imm"
field directly, and we'd reject it if it is negative. Because for ALU64,
"imm" (with s32 type) is expected to be sign extended to s64 which NFP mul
doesn't support. For ALU32, it is fine for "imm" be negative though,
because the result is 32-bits and here is no difference on the low halve
of result for signed/unsigned mul, so we will get correct result.
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2018-07-06 22:13:21 +00:00
|
|
|
static inline bool is_mbpf_mul(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return is_mbpf_alu(meta) && mbpf_op(meta) == BPF_MUL;
|
|
|
|
}
|
|
|
|
|
2018-07-06 22:13:22 +00:00
|
|
|
static inline bool is_mbpf_div(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
return is_mbpf_alu(meta) && mbpf_op(meta) == BPF_DIV;
|
|
|
|
}
|
|
|
|
|
2019-01-23 06:45:28 +00:00
|
|
|
static inline bool is_mbpf_cond_jump(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
u8 op;
|
|
|
|
|
2019-01-26 17:26:12 +00:00
|
|
|
if (is_mbpf_jmp32(meta))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
if (!is_mbpf_jmp64(meta))
|
2019-01-23 06:45:28 +00:00
|
|
|
return false;
|
|
|
|
|
2019-01-26 17:26:12 +00:00
|
|
|
op = mbpf_op(meta);
|
2019-01-23 06:45:28 +00:00
|
|
|
return op != BPF_JA && op != BPF_EXIT && op != BPF_CALL;
|
|
|
|
}
|
|
|
|
|
2018-10-07 11:56:50 +00:00
|
|
|
static inline bool is_mbpf_helper_call(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
struct bpf_insn insn = meta->insn;
|
|
|
|
|
|
|
|
return insn.code == (BPF_JMP | BPF_CALL) &&
|
|
|
|
insn.src_reg != BPF_PSEUDO_CALL;
|
|
|
|
}
|
|
|
|
|
nfp: bpf: add main logics for BPF-to-BPF calls support in nfp driver
This is the main patch for the logics of BPF-to-BPF calls in the nfp
driver.
The functions called on BPF_JUMP | BPF_CALL and BPF_JUMP | BPF_EXIT were
used to call helpers and exit from the program, respectively; make them
usable for calling into, or returning from, a BPF subprogram as well.
For all calls, push the return address as well as the callee-saved
registers (R6 to R9) to the stack, and pop them upon returning from the
calls. In order to limit the overhead in terms of instruction number,
this is done through dedicated subroutines. Jumping to the callee
actually consists in jumping to the subroutine, that "returns" to the
callee: this will require some fixup for passing the address in a later
patch. Similarly, returning consists in jumping to the subroutine, which
pops registers and then return directly to the caller (but no fixup is
needed here).
Return to the caller is performed with the RTN instruction newly added
to the JIT.
For the few steps where we need to know what subprogram an instruction
belongs to, the struct nfp_insn_meta is extended with a new subprog_idx
field.
Note that checks on the available stack size, to take into account the
additional requirements associated to BPF-to-BPF calls (storing R6-R9
and return addresses), are added in a later patch.
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2018-10-07 11:56:52 +00:00
|
|
|
static inline bool is_mbpf_pseudo_call(const struct nfp_insn_meta *meta)
|
|
|
|
{
|
|
|
|
struct bpf_insn insn = meta->insn;
|
|
|
|
|
|
|
|
return insn.code == (BPF_JMP | BPF_CALL) &&
|
|
|
|
insn.src_reg == BPF_PSEUDO_CALL;
|
|
|
|
}
|
|
|
|
|
|
|
|
#define STACK_FRAME_ALIGN 64
|
|
|
|
|
2018-10-07 11:56:49 +00:00
|
|
|
/**
|
|
|
|
* struct nfp_bpf_subprog_info - nfp BPF sub-program (a.k.a. function) info
|
|
|
|
* @stack_depth: maximum stack depth used by this sub-program
|
2018-10-07 11:56:56 +00:00
|
|
|
* @needs_reg_push: whether sub-program uses callee-saved registers
|
2018-10-07 11:56:49 +00:00
|
|
|
*/
|
|
|
|
struct nfp_bpf_subprog_info {
|
|
|
|
u16 stack_depth;
|
2018-10-07 11:56:56 +00:00
|
|
|
u8 needs_reg_push : 1;
|
2018-10-07 11:56:49 +00:00
|
|
|
};
|
|
|
|
|
2016-09-21 10:44:00 +00:00
|
|
|
/**
|
|
|
|
* struct nfp_prog - nfp BPF program
|
2017-12-15 05:29:16 +00:00
|
|
|
* @bpf: backpointer to the bpf app priv structure
|
2016-09-21 10:44:00 +00:00
|
|
|
* @prog: machine code
|
|
|
|
* @prog_len: number of valid instructions in @prog array
|
|
|
|
* @__prog_alloc_len: alloc size of @prog array
|
2018-10-16 22:19:10 +00:00
|
|
|
* @stack_size: total amount of stack used
|
2017-11-03 20:56:29 +00:00
|
|
|
* @verifier_meta: temporary storage for verifier's insn meta
|
2017-11-03 20:56:22 +00:00
|
|
|
* @type: BPF program type
|
nfp: bpf: support backward jump
This patch adds support for backward jump on NFP.
- restrictions on backward jump in various functions have been removed.
- nfp_fixup_branches now supports backward jump.
There is one thing to note, currently an input eBPF JMP insn may generate
several NFP insns, for example,
NFP imm move insn A \
NFP compare insn B --> 3 NFP insn jited from eBPF JMP insn M
NFP branch insn C /
---
NFP insn X --> 1 NFP insn jited from eBPF insn N
---
...
therefore, we are doing sanity check to make sure the last jited insn from
an eBPF JMP is a NFP branch instruction.
Once backward jump is allowed, it is possible an eBPF JMP insn is at the
end of the program. This is however causing trouble for the sanity check.
Because the sanity check requires the end index of the NFP insns jited from
one eBPF insn while only the start index is recorded before this patch that
we can only get the end index by:
start_index_of_the_next_eBPF_insn - 1
or for the above example:
start_index_of_eBPF_insn_N (which is the index of NFP insn X) - 1
nfp_fixup_branches was using nfp_for_each_insn_walk2 to expose *next* insn
to each iteration during the traversal so the last index could be
calculated from which. Now, it needs some extra code to handle the last
insn. Meanwhile, the use of walk2 is actually unnecessary, we could simply
use generic single instruction walk to do this, the next insn could be
easily calculated using list_next_entry.
So, this patch migrates the jump fixup traversal method to
*list_for_each_entry*, this simplifies the code logic a little bit.
The other thing to note is a new state variable "last_bpf_off" is
introduced to track the index of the last jited NFP insn. This is necessary
because NFP is generating special purposes epilogue sequences, so the index
of the last jited NFP insn is *not* always nfp_prog->prog_len - 1.
Suggested-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2017-12-01 05:32:49 +00:00
|
|
|
* @last_bpf_off: address of the last instruction translated from BPF
|
2016-09-21 10:44:00 +00:00
|
|
|
* @tgt_out: jump target for normal exit
|
|
|
|
* @tgt_abort: jump target for abort (e.g. access outside of packet buffer)
|
nfp: bpf: add main logics for BPF-to-BPF calls support in nfp driver
This is the main patch for the logics of BPF-to-BPF calls in the nfp
driver.
The functions called on BPF_JUMP | BPF_CALL and BPF_JUMP | BPF_EXIT were
used to call helpers and exit from the program, respectively; make them
usable for calling into, or returning from, a BPF subprogram as well.
For all calls, push the return address as well as the callee-saved
registers (R6 to R9) to the stack, and pop them upon returning from the
calls. In order to limit the overhead in terms of instruction number,
this is done through dedicated subroutines. Jumping to the callee
actually consists in jumping to the subroutine, that "returns" to the
callee: this will require some fixup for passing the address in a later
patch. Similarly, returning consists in jumping to the subroutine, which
pops registers and then return directly to the caller (but no fixup is
needed here).
Return to the caller is performed with the RTN instruction newly added
to the JIT.
For the few steps where we need to know what subprogram an instruction
belongs to, the struct nfp_insn_meta is extended with a new subprog_idx
field.
Note that checks on the available stack size, to take into account the
additional requirements associated to BPF-to-BPF calls (storing R6-R9
and return addresses), are added in a later patch.
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2018-10-07 11:56:52 +00:00
|
|
|
* @tgt_call_push_regs: jump target for subroutine for saving R6~R9 to stack
|
|
|
|
* @tgt_call_pop_regs: jump target for subroutine used for restoring R6~R9
|
2016-09-21 10:44:00 +00:00
|
|
|
* @n_translated: number of successfully translated instructions (for errors)
|
|
|
|
* @error: error code if something went wrong
|
2018-10-07 11:56:48 +00:00
|
|
|
* @stack_frame_depth: max stack depth for current frame
|
2017-12-15 05:29:19 +00:00
|
|
|
* @adjust_head_location: if program has single adjust head call - the insn no.
|
2018-05-04 01:37:09 +00:00
|
|
|
* @map_records_cnt: the number of map pointers recorded for this prog
|
2018-10-07 11:56:49 +00:00
|
|
|
* @subprog_cnt: number of sub-programs, including main function
|
2018-05-04 01:37:09 +00:00
|
|
|
* @map_records: the map record pointers from bpf->maps_neutral
|
2018-10-07 11:56:49 +00:00
|
|
|
* @subprog: pointer to an array of objects holding info about sub-programs
|
2019-01-23 06:45:27 +00:00
|
|
|
* @n_insns: number of instructions on @insns list
|
2016-09-21 10:44:00 +00:00
|
|
|
* @insns: list of BPF instruction wrappers (struct nfp_insn_meta)
|
|
|
|
*/
|
|
|
|
struct nfp_prog {
|
2017-12-15 05:29:16 +00:00
|
|
|
struct nfp_app_bpf *bpf;
|
|
|
|
|
2016-09-21 10:44:00 +00:00
|
|
|
u64 *prog;
|
|
|
|
unsigned int prog_len;
|
|
|
|
unsigned int __prog_alloc_len;
|
|
|
|
|
2018-10-16 22:19:10 +00:00
|
|
|
unsigned int stack_size;
|
|
|
|
|
2017-11-03 20:56:29 +00:00
|
|
|
struct nfp_insn_meta *verifier_meta;
|
|
|
|
|
2017-11-03 20:56:22 +00:00
|
|
|
enum bpf_prog_type type;
|
2016-09-21 10:44:00 +00:00
|
|
|
|
nfp: bpf: support backward jump
This patch adds support for backward jump on NFP.
- restrictions on backward jump in various functions have been removed.
- nfp_fixup_branches now supports backward jump.
There is one thing to note, currently an input eBPF JMP insn may generate
several NFP insns, for example,
NFP imm move insn A \
NFP compare insn B --> 3 NFP insn jited from eBPF JMP insn M
NFP branch insn C /
---
NFP insn X --> 1 NFP insn jited from eBPF insn N
---
...
therefore, we are doing sanity check to make sure the last jited insn from
an eBPF JMP is a NFP branch instruction.
Once backward jump is allowed, it is possible an eBPF JMP insn is at the
end of the program. This is however causing trouble for the sanity check.
Because the sanity check requires the end index of the NFP insns jited from
one eBPF insn while only the start index is recorded before this patch that
we can only get the end index by:
start_index_of_the_next_eBPF_insn - 1
or for the above example:
start_index_of_eBPF_insn_N (which is the index of NFP insn X) - 1
nfp_fixup_branches was using nfp_for_each_insn_walk2 to expose *next* insn
to each iteration during the traversal so the last index could be
calculated from which. Now, it needs some extra code to handle the last
insn. Meanwhile, the use of walk2 is actually unnecessary, we could simply
use generic single instruction walk to do this, the next insn could be
easily calculated using list_next_entry.
So, this patch migrates the jump fixup traversal method to
*list_for_each_entry*, this simplifies the code logic a little bit.
The other thing to note is a new state variable "last_bpf_off" is
introduced to track the index of the last jited NFP insn. This is necessary
because NFP is generating special purposes epilogue sequences, so the index
of the last jited NFP insn is *not* always nfp_prog->prog_len - 1.
Suggested-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2017-12-01 05:32:49 +00:00
|
|
|
unsigned int last_bpf_off;
|
2016-09-21 10:44:00 +00:00
|
|
|
unsigned int tgt_out;
|
|
|
|
unsigned int tgt_abort;
|
nfp: bpf: add main logics for BPF-to-BPF calls support in nfp driver
This is the main patch for the logics of BPF-to-BPF calls in the nfp
driver.
The functions called on BPF_JUMP | BPF_CALL and BPF_JUMP | BPF_EXIT were
used to call helpers and exit from the program, respectively; make them
usable for calling into, or returning from, a BPF subprogram as well.
For all calls, push the return address as well as the callee-saved
registers (R6 to R9) to the stack, and pop them upon returning from the
calls. In order to limit the overhead in terms of instruction number,
this is done through dedicated subroutines. Jumping to the callee
actually consists in jumping to the subroutine, that "returns" to the
callee: this will require some fixup for passing the address in a later
patch. Similarly, returning consists in jumping to the subroutine, which
pops registers and then return directly to the caller (but no fixup is
needed here).
Return to the caller is performed with the RTN instruction newly added
to the JIT.
For the few steps where we need to know what subprogram an instruction
belongs to, the struct nfp_insn_meta is extended with a new subprog_idx
field.
Note that checks on the available stack size, to take into account the
additional requirements associated to BPF-to-BPF calls (storing R6-R9
and return addresses), are added in a later patch.
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2018-10-07 11:56:52 +00:00
|
|
|
unsigned int tgt_call_push_regs;
|
|
|
|
unsigned int tgt_call_pop_regs;
|
2016-09-21 10:44:00 +00:00
|
|
|
|
|
|
|
unsigned int n_translated;
|
|
|
|
int error;
|
|
|
|
|
2018-10-07 11:56:48 +00:00
|
|
|
unsigned int stack_frame_depth;
|
2017-12-15 05:29:19 +00:00
|
|
|
unsigned int adjust_head_location;
|
2017-10-23 18:58:08 +00:00
|
|
|
|
2018-05-04 01:37:09 +00:00
|
|
|
unsigned int map_records_cnt;
|
2018-10-07 11:56:49 +00:00
|
|
|
unsigned int subprog_cnt;
|
2018-05-04 01:37:09 +00:00
|
|
|
struct nfp_bpf_neutral_map **map_records;
|
2018-10-07 11:56:49 +00:00
|
|
|
struct nfp_bpf_subprog_info *subprog;
|
2018-05-04 01:37:09 +00:00
|
|
|
|
2019-01-23 06:45:27 +00:00
|
|
|
unsigned int n_insns;
|
2016-09-21 10:44:00 +00:00
|
|
|
struct list_head insns;
|
|
|
|
};
|
|
|
|
|
2017-12-19 21:32:14 +00:00
|
|
|
/**
|
|
|
|
* struct nfp_bpf_vnic - per-vNIC BPF priv structure
|
|
|
|
* @tc_prog: currently loaded cls_bpf program
|
2018-01-10 12:26:01 +00:00
|
|
|
* @start_off: address of the first instruction in the memory
|
|
|
|
* @tgt_done: jump target to get the next packet
|
2017-12-19 21:32:14 +00:00
|
|
|
*/
|
|
|
|
struct nfp_bpf_vnic {
|
|
|
|
struct bpf_prog *tc_prog;
|
2018-01-10 12:26:01 +00:00
|
|
|
unsigned int start_off;
|
|
|
|
unsigned int tgt_done;
|
2017-12-19 21:32:14 +00:00
|
|
|
};
|
|
|
|
|
nfp: bpf: add main logics for BPF-to-BPF calls support in nfp driver
This is the main patch for the logics of BPF-to-BPF calls in the nfp
driver.
The functions called on BPF_JUMP | BPF_CALL and BPF_JUMP | BPF_EXIT were
used to call helpers and exit from the program, respectively; make them
usable for calling into, or returning from, a BPF subprogram as well.
For all calls, push the return address as well as the callee-saved
registers (R6 to R9) to the stack, and pop them upon returning from the
calls. In order to limit the overhead in terms of instruction number,
this is done through dedicated subroutines. Jumping to the callee
actually consists in jumping to the subroutine, that "returns" to the
callee: this will require some fixup for passing the address in a later
patch. Similarly, returning consists in jumping to the subroutine, which
pops registers and then return directly to the caller (but no fixup is
needed here).
Return to the caller is performed with the RTN instruction newly added
to the JIT.
For the few steps where we need to know what subprogram an instruction
belongs to, the struct nfp_insn_meta is extended with a new subprog_idx
field.
Note that checks on the available stack size, to take into account the
additional requirements associated to BPF-to-BPF calls (storing R6-R9
and return addresses), are added in a later patch.
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2018-10-07 11:56:52 +00:00
|
|
|
bool nfp_is_subprog_start(struct nfp_insn_meta *meta);
|
2019-01-23 06:45:27 +00:00
|
|
|
void nfp_bpf_jit_prepare(struct nfp_prog *nfp_prog);
|
2017-11-03 20:56:29 +00:00
|
|
|
int nfp_bpf_jit(struct nfp_prog *prog);
|
2018-01-16 23:51:50 +00:00
|
|
|
bool nfp_bpf_supported_opcode(u8 code);
|
2016-09-21 10:44:00 +00:00
|
|
|
|
2018-11-09 13:03:24 +00:00
|
|
|
int nfp_verify_insn(struct bpf_verifier_env *env, int insn_idx,
|
|
|
|
int prev_insn_idx);
|
|
|
|
int nfp_bpf_finalize(struct bpf_verifier_env *env);
|
|
|
|
|
2019-01-23 06:45:28 +00:00
|
|
|
int nfp_bpf_opt_replace_insn(struct bpf_verifier_env *env, u32 off,
|
|
|
|
struct bpf_insn *insn);
|
2019-01-23 06:45:29 +00:00
|
|
|
int nfp_bpf_opt_remove_insns(struct bpf_verifier_env *env, u32 off, u32 cnt);
|
2019-01-23 06:45:28 +00:00
|
|
|
|
2018-11-09 13:03:25 +00:00
|
|
|
extern const struct bpf_prog_offload_ops nfp_bpf_dev_ops;
|
2016-09-21 10:44:00 +00:00
|
|
|
|
2017-11-03 20:56:29 +00:00
|
|
|
struct netdev_bpf;
|
|
|
|
struct nfp_app;
|
2017-05-31 15:06:49 +00:00
|
|
|
struct nfp_net;
|
|
|
|
|
2018-01-10 12:26:04 +00:00
|
|
|
int nfp_ndo_bpf(struct nfp_app *app, struct nfp_net *nn,
|
|
|
|
struct netdev_bpf *bpf);
|
2017-11-03 20:56:25 +00:00
|
|
|
int nfp_net_bpf_offload(struct nfp_net *nn, struct bpf_prog *prog,
|
2018-01-20 01:44:50 +00:00
|
|
|
bool old_prog, struct netlink_ext_ack *extack);
|
2017-05-31 15:06:49 +00:00
|
|
|
|
2017-12-01 05:32:50 +00:00
|
|
|
struct nfp_insn_meta *
|
|
|
|
nfp_bpf_goto_meta(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta,
|
2019-01-23 06:45:27 +00:00
|
|
|
unsigned int insn_idx);
|
2018-01-10 12:26:01 +00:00
|
|
|
|
|
|
|
void *nfp_bpf_relo_for_vnic(struct nfp_prog *nfp_prog, struct nfp_bpf_vnic *bv);
|
2018-01-12 04:29:11 +00:00
|
|
|
|
2018-10-02 01:30:34 +00:00
|
|
|
unsigned int nfp_bpf_ctrl_cmsg_mtu(struct nfp_app_bpf *bpf);
|
2018-01-12 04:29:12 +00:00
|
|
|
long long int
|
|
|
|
nfp_bpf_ctrl_alloc_map(struct nfp_app_bpf *bpf, struct bpf_map *map);
|
|
|
|
void
|
|
|
|
nfp_bpf_ctrl_free_map(struct nfp_app_bpf *bpf, struct nfp_bpf_map *nfp_map);
|
|
|
|
int nfp_bpf_ctrl_getfirst_entry(struct bpf_offloaded_map *offmap,
|
|
|
|
void *next_key);
|
|
|
|
int nfp_bpf_ctrl_update_entry(struct bpf_offloaded_map *offmap,
|
|
|
|
void *key, void *value, u64 flags);
|
|
|
|
int nfp_bpf_ctrl_del_entry(struct bpf_offloaded_map *offmap, void *key);
|
|
|
|
int nfp_bpf_ctrl_lookup_entry(struct bpf_offloaded_map *offmap,
|
|
|
|
void *key, void *value);
|
|
|
|
int nfp_bpf_ctrl_getnext_entry(struct bpf_offloaded_map *offmap,
|
|
|
|
void *key, void *next_key);
|
|
|
|
|
2018-07-26 02:53:32 +00:00
|
|
|
int nfp_bpf_event_output(struct nfp_app_bpf *bpf, const void *data,
|
|
|
|
unsigned int len);
|
2018-05-04 01:37:12 +00:00
|
|
|
|
2018-01-12 04:29:11 +00:00
|
|
|
void nfp_bpf_ctrl_msg_rx(struct nfp_app *app, struct sk_buff *skb);
|
2018-07-26 02:53:33 +00:00
|
|
|
void
|
|
|
|
nfp_bpf_ctrl_msg_rx_raw(struct nfp_app *app, const void *data,
|
|
|
|
unsigned int len);
|
2016-09-21 10:44:00 +00:00
|
|
|
#endif
|