2015-01-22 13:34:22 +00:00
|
|
|
#define _GNU_SOURCE
|
2013-02-20 15:32:30 +00:00
|
|
|
#include <errno.h>
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <string.h>
|
2015-02-02 19:35:06 +00:00
|
|
|
#include <unistd.h>
|
2013-02-20 15:32:30 +00:00
|
|
|
#include <stdbool.h>
|
|
|
|
#include <sys/vfs.h>
|
2015-02-02 19:35:06 +00:00
|
|
|
#include <sys/types.h>
|
|
|
|
#include <sys/stat.h>
|
2011-11-16 14:55:59 +00:00
|
|
|
#include <sys/mount.h>
|
2013-02-20 15:32:30 +00:00
|
|
|
#include <linux/kernel.h>
|
|
|
|
|
|
|
|
#include "debugfs.h"
|
tools lib api debugfs: Check for tracefs when reporting errors
Now that we have two mountpoints, one for debugfs and another, for
tracefs, we end up needing to check permissions for both, so, on
a system with default config we were always asking the user to
check the permission of the debugfs mountpoint, even when it was
already sufficient. Fix it.
E.g.:
$ trace -e nanosleep usleep 1
Error: No permissions to read /sys/kernel/debug/tracing/events/raw_syscalls/sys_(enter|exit)
Hint: Try 'sudo mount -o remount,mode=755 /sys/kernel/debug'
$ sudo mount -o remount,mode=755 /sys/kernel/debug
$ trace -e nanosleep usleep 1
Error: No permissions to read /sys/kernel/debug/tracing/events/raw_syscalls/sys_(enter|exit)
Hint: Try 'sudo mount -o remount,mode=755 /sys/kernel/debug/tracing'
$ sudo mount -o remount,mode=755 /sys/kernel/debug/tracing
$ trace -e nanosleep usleep 1
0.326 ( 0.061 ms): usleep/11961 nanosleep(rqtp: 0x7ffef1081c50) = 0
$
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/n/tip-0viljeuhc7q84ic8kobsna43@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2015-07-06 11:51:41 +00:00
|
|
|
#include "tracefs.h"
|
2011-11-16 14:55:59 +00:00
|
|
|
|
2015-02-02 19:35:05 +00:00
|
|
|
#ifndef DEBUGFS_DEFAULT_PATH
|
|
|
|
#define DEBUGFS_DEFAULT_PATH "/sys/kernel/debug"
|
|
|
|
#endif
|
|
|
|
|
|
|
|
char debugfs_mountpoint[PATH_MAX + 1] = DEBUGFS_DEFAULT_PATH;
|
2009-11-08 15:01:37 +00:00
|
|
|
|
2013-02-20 15:32:30 +00:00
|
|
|
static const char * const debugfs_known_mountpoints[] = {
|
2015-02-02 19:35:05 +00:00
|
|
|
DEBUGFS_DEFAULT_PATH,
|
2014-04-26 07:55:12 +00:00
|
|
|
"/debug",
|
2009-11-08 15:01:37 +00:00
|
|
|
0,
|
|
|
|
};
|
|
|
|
|
2013-02-20 15:32:27 +00:00
|
|
|
static bool debugfs_found;
|
2009-11-08 15:01:37 +00:00
|
|
|
|
2015-02-02 19:35:06 +00:00
|
|
|
bool debugfs_configured(void)
|
|
|
|
{
|
|
|
|
return debugfs_find_mountpoint() != NULL;
|
|
|
|
}
|
|
|
|
|
2009-11-08 15:01:37 +00:00
|
|
|
/* find the path to the mounted debugfs */
|
|
|
|
const char *debugfs_find_mountpoint(void)
|
|
|
|
{
|
2015-02-02 19:35:03 +00:00
|
|
|
const char *ret;
|
2009-11-08 15:01:37 +00:00
|
|
|
|
|
|
|
if (debugfs_found)
|
2013-02-20 15:32:30 +00:00
|
|
|
return (const char *)debugfs_mountpoint;
|
2009-11-08 15:01:37 +00:00
|
|
|
|
2015-02-02 19:35:03 +00:00
|
|
|
ret = find_mountpoint("debugfs", (long) DEBUGFS_MAGIC,
|
|
|
|
debugfs_mountpoint, PATH_MAX + 1,
|
|
|
|
debugfs_known_mountpoints);
|
|
|
|
if (ret)
|
|
|
|
debugfs_found = true;
|
2009-11-08 15:01:37 +00:00
|
|
|
|
2015-02-02 19:35:03 +00:00
|
|
|
return ret;
|
2009-11-08 15:01:37 +00:00
|
|
|
}
|
|
|
|
|
2009-12-28 08:47:12 +00:00
|
|
|
/* mount the debugfs somewhere if it's not mounted */
|
|
|
|
char *debugfs_mount(const char *mountpoint)
|
2009-11-08 15:01:37 +00:00
|
|
|
{
|
|
|
|
/* see if it's already mounted */
|
2013-02-20 15:32:27 +00:00
|
|
|
if (debugfs_find_mountpoint())
|
2011-11-16 16:03:07 +00:00
|
|
|
goto out;
|
2009-11-08 15:01:37 +00:00
|
|
|
|
|
|
|
/* if not mounted and no argument */
|
|
|
|
if (mountpoint == NULL) {
|
|
|
|
/* see if environment variable set */
|
|
|
|
mountpoint = getenv(PERF_DEBUGFS_ENVIRONMENT);
|
|
|
|
/* if no environment variable, use default */
|
|
|
|
if (mountpoint == NULL)
|
2015-02-02 19:35:05 +00:00
|
|
|
mountpoint = DEBUGFS_DEFAULT_PATH;
|
2009-11-08 15:01:37 +00:00
|
|
|
}
|
|
|
|
|
2009-12-28 08:47:12 +00:00
|
|
|
if (mount(NULL, mountpoint, "debugfs", 0, NULL) < 0)
|
|
|
|
return NULL;
|
|
|
|
|
2009-11-08 15:01:37 +00:00
|
|
|
/* save the mountpoint */
|
2013-02-20 15:32:27 +00:00
|
|
|
debugfs_found = true;
|
2011-11-16 16:03:07 +00:00
|
|
|
strncpy(debugfs_mountpoint, mountpoint, sizeof(debugfs_mountpoint));
|
|
|
|
out:
|
2009-12-28 08:47:12 +00:00
|
|
|
return debugfs_mountpoint;
|
2009-11-08 15:01:37 +00:00
|
|
|
}
|
2015-01-22 13:34:22 +00:00
|
|
|
|
2015-01-22 13:52:55 +00:00
|
|
|
int debugfs__strerror_open(int err, char *buf, size_t size, const char *filename)
|
2015-01-22 13:34:22 +00:00
|
|
|
{
|
|
|
|
char sbuf[128];
|
|
|
|
|
|
|
|
switch (err) {
|
|
|
|
case ENOENT:
|
2015-01-22 19:35:42 +00:00
|
|
|
if (debugfs_found) {
|
|
|
|
snprintf(buf, size,
|
|
|
|
"Error:\tFile %s/%s not found.\n"
|
|
|
|
"Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
|
|
|
|
debugfs_mountpoint, filename);
|
|
|
|
break;
|
|
|
|
}
|
2015-01-22 13:34:22 +00:00
|
|
|
snprintf(buf, size, "%s",
|
|
|
|
"Error:\tUnable to find debugfs\n"
|
|
|
|
"Hint:\tWas your kernel compiled with debugfs support?\n"
|
|
|
|
"Hint:\tIs the debugfs filesystem mounted?\n"
|
|
|
|
"Hint:\tTry 'sudo mount -t debugfs nodev /sys/kernel/debug'");
|
|
|
|
break;
|
tools lib api debugfs: Check for tracefs when reporting errors
Now that we have two mountpoints, one for debugfs and another, for
tracefs, we end up needing to check permissions for both, so, on
a system with default config we were always asking the user to
check the permission of the debugfs mountpoint, even when it was
already sufficient. Fix it.
E.g.:
$ trace -e nanosleep usleep 1
Error: No permissions to read /sys/kernel/debug/tracing/events/raw_syscalls/sys_(enter|exit)
Hint: Try 'sudo mount -o remount,mode=755 /sys/kernel/debug'
$ sudo mount -o remount,mode=755 /sys/kernel/debug
$ trace -e nanosleep usleep 1
Error: No permissions to read /sys/kernel/debug/tracing/events/raw_syscalls/sys_(enter|exit)
Hint: Try 'sudo mount -o remount,mode=755 /sys/kernel/debug/tracing'
$ sudo mount -o remount,mode=755 /sys/kernel/debug/tracing
$ trace -e nanosleep usleep 1
0.326 ( 0.061 ms): usleep/11961 nanosleep(rqtp: 0x7ffef1081c50) = 0
$
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/n/tip-0viljeuhc7q84ic8kobsna43@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2015-07-06 11:51:41 +00:00
|
|
|
case EACCES: {
|
|
|
|
const char *mountpoint = debugfs_mountpoint;
|
|
|
|
|
|
|
|
if (!access(debugfs_mountpoint, R_OK) && strncmp(filename, "tracing/", 8) == 0) {
|
|
|
|
const char *tracefs_mntpoint = tracefs_find_mountpoint();
|
|
|
|
|
|
|
|
if (tracefs_mntpoint)
|
|
|
|
mountpoint = tracefs_mntpoint;
|
|
|
|
}
|
|
|
|
|
2015-01-22 13:34:22 +00:00
|
|
|
snprintf(buf, size,
|
2015-01-22 13:52:55 +00:00
|
|
|
"Error:\tNo permissions to read %s/%s\n"
|
2015-01-22 13:34:22 +00:00
|
|
|
"Hint:\tTry 'sudo mount -o remount,mode=755 %s'\n",
|
tools lib api debugfs: Check for tracefs when reporting errors
Now that we have two mountpoints, one for debugfs and another, for
tracefs, we end up needing to check permissions for both, so, on
a system with default config we were always asking the user to
check the permission of the debugfs mountpoint, even when it was
already sufficient. Fix it.
E.g.:
$ trace -e nanosleep usleep 1
Error: No permissions to read /sys/kernel/debug/tracing/events/raw_syscalls/sys_(enter|exit)
Hint: Try 'sudo mount -o remount,mode=755 /sys/kernel/debug'
$ sudo mount -o remount,mode=755 /sys/kernel/debug
$ trace -e nanosleep usleep 1
Error: No permissions to read /sys/kernel/debug/tracing/events/raw_syscalls/sys_(enter|exit)
Hint: Try 'sudo mount -o remount,mode=755 /sys/kernel/debug/tracing'
$ sudo mount -o remount,mode=755 /sys/kernel/debug/tracing
$ trace -e nanosleep usleep 1
0.326 ( 0.061 ms): usleep/11961 nanosleep(rqtp: 0x7ffef1081c50) = 0
$
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/n/tip-0viljeuhc7q84ic8kobsna43@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2015-07-06 11:51:41 +00:00
|
|
|
debugfs_mountpoint, filename, mountpoint);
|
|
|
|
}
|
2015-01-22 13:34:22 +00:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
snprintf(buf, size, "%s", strerror_r(err, sbuf, sizeof(sbuf)));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2015-01-22 14:13:43 +00:00
|
|
|
|
|
|
|
int debugfs__strerror_open_tp(int err, char *buf, size_t size, const char *sys, const char *name)
|
|
|
|
{
|
|
|
|
char path[PATH_MAX];
|
|
|
|
|
|
|
|
snprintf(path, PATH_MAX, "tracing/events/%s/%s", sys, name ?: "*");
|
|
|
|
|
|
|
|
return debugfs__strerror_open(err, buf, size, path);
|
|
|
|
}
|