zig/lib/compiler/resinator/errors.zig

1077 lines
55 KiB
Zig
Raw Permalink Blame History

const std = @import("std");
const Token = @import("lex.zig").Token;
const SourceMappings = @import("source_mapping.zig").SourceMappings;
const utils = @import("utils.zig");
const rc = @import("rc.zig");
const res = @import("res.zig");
const ico = @import("ico.zig");
const bmp = @import("bmp.zig");
const parse = @import("parse.zig");
const lang = @import("lang.zig");
const CodePage = @import("code_pages.zig").CodePage;
const builtin = @import("builtin");
const native_endian = builtin.cpu.arch.endian();
pub const Diagnostics = struct {
errors: std.ArrayListUnmanaged(ErrorDetails) = .empty,
/// Append-only, cannot handle removing strings.
/// Expects to own all strings within the list.
strings: std.ArrayListUnmanaged([]const u8) = .empty,
allocator: std.mem.Allocator,
pub fn init(allocator: std.mem.Allocator) Diagnostics {
return .{
.allocator = allocator,
};
}
pub fn deinit(self: *Diagnostics) void {
self.errors.deinit(self.allocator);
for (self.strings.items) |str| {
self.allocator.free(str);
}
self.strings.deinit(self.allocator);
}
pub fn append(self: *Diagnostics, error_details: ErrorDetails) !void {
try self.errors.append(self.allocator, error_details);
}
const SmallestStringIndexType = std.meta.Int(.unsigned, @min(
@bitSizeOf(ErrorDetails.FileOpenError.FilenameStringIndex),
@min(
@bitSizeOf(ErrorDetails.IconReadError.FilenameStringIndex),
@bitSizeOf(ErrorDetails.BitmapReadError.FilenameStringIndex),
),
));
/// Returns the index of the added string as the SmallestStringIndexType
/// in order to avoid needing to `@intCast` it at callsites of putString.
/// Instead, this function will error if the index would ever exceed the
/// smallest FilenameStringIndex of an ErrorDetails type.
pub fn putString(self: *Diagnostics, str: []const u8) !SmallestStringIndexType {
if (self.strings.items.len >= std.math.maxInt(SmallestStringIndexType)) {
return error.OutOfMemory; // ran out of string indexes
}
const dupe = try self.allocator.dupe(u8, str);
const index = self.strings.items.len;
try self.strings.append(self.allocator, dupe);
return @intCast(index);
}
pub fn renderToStdErr(self: *Diagnostics, cwd: std.fs.Dir, source: []const u8, tty_config: std.io.tty.Config, source_mappings: ?SourceMappings) void {
std.debug.lockStdErr();
defer std.debug.unlockStdErr();
const stderr = std.io.getStdErr().writer();
for (self.errors.items) |err_details| {
renderErrorMessage(self.allocator, stderr, tty_config, cwd, err_details, source, self.strings.items, source_mappings) catch return;
}
}
pub fn renderToStdErrDetectTTY(self: *Diagnostics, cwd: std.fs.Dir, source: []const u8, source_mappings: ?SourceMappings) void {
const tty_config = std.io.tty.detectConfig(std.io.getStdErr());
return self.renderToStdErr(cwd, source, tty_config, source_mappings);
}
pub fn contains(self: *const Diagnostics, err: ErrorDetails.Error) bool {
for (self.errors.items) |details| {
if (details.err == err) return true;
}
return false;
}
pub fn containsAny(self: *const Diagnostics, errors: []const ErrorDetails.Error) bool {
for (self.errors.items) |details| {
for (errors) |err| {
if (details.err == err) return true;
}
}
return false;
}
};
/// Contains enough context to append errors/warnings/notes etc
pub const DiagnosticsContext = struct {
diagnostics: *Diagnostics,
token: Token,
};
pub const ErrorDetails = struct {
err: Error,
token: Token,
/// If non-null, should be before `token`. If null, `token` is assumed to be the start.
token_span_start: ?Token = null,
/// If non-null, should be after `token`. If null, `token` is assumed to be the end.
token_span_end: ?Token = null,
type: Type = .err,
print_source_line: bool = true,
extra: union {
none: void,
expected: Token.Id,
number: u32,
expected_types: ExpectedTypes,
resource: rc.Resource,
string_and_language: StringAndLanguage,
file_open_error: FileOpenError,
icon_read_error: IconReadError,
icon_dir: IconDirContext,
bmp_read_error: BitmapReadError,
accelerator_error: AcceleratorError,
statement_with_u16_param: StatementWithU16Param,
menu_or_class: enum { class, menu },
} = .{ .none = {} },
pub const Type = enum {
/// Fatal error, stops compilation
err,
/// Warning that does not affect compilation result
warning,
/// A note that typically provides further context for a warning/error
note,
/// An invisible diagnostic that is not printed to stderr but can
/// provide information useful when comparing the behavior of different
/// implementations. For example, a hint is emitted when a FONTDIR resource
/// was included in the .RES file which is significant because rc.exe
/// does something different than us, but ultimately it's not important
/// enough to be a warning/note.
hint,
};
comptime {
// all fields in the extra union should be 32 bits or less
for (std.meta.fields(std.meta.fieldInfo(ErrorDetails, .extra).type)) |field| {
std.debug.assert(@bitSizeOf(field.type) <= 32);
}
}
pub const StatementWithU16Param = enum(u32) {
fileversion,
productversion,
language,
};
pub const StringAndLanguage = packed struct(u32) {
id: u16,
language: res.Language,
};
pub const FileOpenError = packed struct(u32) {
err: FileOpenErrorEnum,
filename_string_index: FilenameStringIndex,
pub const FilenameStringIndex = std.meta.Int(.unsigned, 32 - @bitSizeOf(FileOpenErrorEnum));
pub const FileOpenErrorEnum = std.meta.FieldEnum(std.fs.File.OpenError);
pub fn enumFromError(err: std.fs.File.OpenError) FileOpenErrorEnum {
return switch (err) {
inline else => |e| @field(ErrorDetails.FileOpenError.FileOpenErrorEnum, @errorName(e)),
};
}
};
pub const IconReadError = packed struct(u32) {
err: IconReadErrorEnum,
icon_type: enum(u1) { cursor, icon },
filename_string_index: FilenameStringIndex,
pub const FilenameStringIndex = std.meta.Int(.unsigned, 32 - @bitSizeOf(IconReadErrorEnum) - 1);
pub const IconReadErrorEnum = std.meta.FieldEnum(ico.ReadError);
pub fn enumFromError(err: ico.ReadError) IconReadErrorEnum {
return switch (err) {
inline else => |e| @field(ErrorDetails.IconReadError.IconReadErrorEnum, @errorName(e)),
};
}
};
pub const IconDirContext = packed struct(u32) {
icon_type: enum(u1) { cursor, icon },
icon_format: ico.ImageFormat,
index: u16,
bitmap_version: ico.BitmapHeader.Version = .unknown,
_: Padding = 0,
pub const Padding = std.meta.Int(.unsigned, 15 - @bitSizeOf(ico.BitmapHeader.Version) - @bitSizeOf(ico.ImageFormat));
};
pub const BitmapReadError = packed struct(u32) {
err: BitmapReadErrorEnum,
filename_string_index: FilenameStringIndex,
pub const FilenameStringIndex = std.meta.Int(.unsigned, 32 - @bitSizeOf(BitmapReadErrorEnum));
pub const BitmapReadErrorEnum = std.meta.FieldEnum(bmp.ReadError);
pub fn enumFromError(err: bmp.ReadError) BitmapReadErrorEnum {
return switch (err) {
inline else => |e| @field(ErrorDetails.BitmapReadError.BitmapReadErrorEnum, @errorName(e)),
};
}
};
pub const BitmapUnsupportedDIB = packed struct(u32) {
dib_version: ico.BitmapHeader.Version,
filename_string_index: FilenameStringIndex,
pub const FilenameStringIndex = std.meta.Int(.unsigned, 32 - @bitSizeOf(ico.BitmapHeader.Version));
};
pub const AcceleratorError = packed struct(u32) {
err: AcceleratorErrorEnum,
_: Padding = 0,
pub const Padding = std.meta.Int(.unsigned, 32 - @bitSizeOf(AcceleratorErrorEnum));
pub const AcceleratorErrorEnum = std.meta.FieldEnum(res.ParseAcceleratorKeyStringError);
pub fn enumFromError(err: res.ParseAcceleratorKeyStringError) AcceleratorErrorEnum {
return switch (err) {
inline else => |e| @field(ErrorDetails.AcceleratorError.AcceleratorErrorEnum, @errorName(e)),
};
}
};
pub const ExpectedTypes = packed struct(u32) {
number: bool = false,
number_expression: bool = false,
string_literal: bool = false,
accelerator_type_or_option: bool = false,
control_class: bool = false,
literal: bool = false,
// Note: This being 0 instead of undefined is arbitrary and something of a workaround,
// see https://github.com/ziglang/zig/issues/15395
_: u26 = 0,
pub const strings = std.StaticStringMap([]const u8).initComptime(.{
.{ "number", "number" },
.{ "number_expression", "number expression" },
.{ "string_literal", "quoted string literal" },
.{ "accelerator_type_or_option", "accelerator type or option [ASCII, VIRTKEY, etc]" },
.{ "control_class", "control class [BUTTON, EDIT, etc]" },
.{ "literal", "unquoted literal" },
});
pub fn writeCommaSeparated(self: ExpectedTypes, writer: anytype) !void {
const struct_info = @typeInfo(ExpectedTypes).@"struct";
const num_real_fields = struct_info.fields.len - 1;
const num_padding_bits = @bitSizeOf(ExpectedTypes) - num_real_fields;
const mask = std.math.maxInt(struct_info.backing_integer.?) >> num_padding_bits;
const relevant_bits_only = @as(struct_info.backing_integer.?, @bitCast(self)) & mask;
const num_set_bits = @popCount(relevant_bits_only);
var i: usize = 0;
inline for (struct_info.fields) |field_info| {
if (field_info.type != bool) continue;
if (i == num_set_bits) return;
if (@field(self, field_info.name)) {
try writer.writeAll(strings.get(field_info.name).?);
i += 1;
if (num_set_bits > 2 and i != num_set_bits) {
try writer.writeAll(", ");
} else if (i != num_set_bits) {
try writer.writeByte(' ');
}
if (num_set_bits > 1 and i == num_set_bits - 1) {
try writer.writeAll("or ");
}
}
}
}
};
pub const Error = enum {
// Lexer
unfinished_string_literal,
string_literal_too_long,
invalid_number_with_exponent,
invalid_digit_character_in_number_literal,
illegal_byte,
illegal_byte_outside_string_literals,
illegal_codepoint_outside_string_literals,
illegal_byte_order_mark,
illegal_private_use_character,
found_c_style_escaped_quote,
code_page_pragma_missing_left_paren,
code_page_pragma_missing_right_paren,
code_page_pragma_invalid_code_page,
code_page_pragma_not_integer,
code_page_pragma_overflow,
code_page_pragma_unsupported_code_page,
// Parser
unfinished_raw_data_block,
unfinished_string_table_block,
/// `expected` is populated.
expected_token,
/// `expected_types` is populated
expected_something_else,
/// `resource` is populated
resource_type_cant_use_raw_data,
/// `resource` is populated
id_must_be_ordinal,
/// `resource` is populated
name_or_id_not_allowed,
string_resource_as_numeric_type,
ascii_character_not_equivalent_to_virtual_key_code,
empty_menu_not_allowed,
rc_would_miscompile_version_value_padding,
rc_would_miscompile_version_value_byte_count,
code_page_pragma_in_included_file,
nested_resource_level_exceeds_max,
too_many_dialog_controls_or_toolbar_buttons,
nested_expression_level_exceeds_max,
close_paren_expression,
unary_plus_expression,
rc_could_miscompile_control_params,
// Compiler
/// `string_and_language` is populated
string_already_defined,
font_id_already_defined,
/// `file_open_error` is populated
file_open_error,
/// `accelerator_error` is populated
invalid_accelerator_key,
accelerator_type_required,
rc_would_miscompile_control_padding,
rc_would_miscompile_control_class_ordinal,
/// `icon_dir` is populated
rc_would_error_on_icon_dir,
/// `icon_dir` is populated
format_not_supported_in_icon_dir,
/// `resource` is populated and contains the expected type
icon_dir_and_resource_type_mismatch,
/// `icon_read_error` is populated
icon_read_error,
/// `icon_dir` is populated
rc_would_error_on_bitmap_version,
/// `icon_dir` is populated
max_icon_ids_exhausted,
/// `bmp_read_error` is populated
bmp_read_error,
/// `number` is populated and contains a string index for which the string contains
/// the bytes of a `u64` (native endian). The `u64` contains the number of ignored bytes.
bmp_ignored_palette_bytes,
/// `number` is populated and contains a string index for which the string contains
/// the bytes of a `u64` (native endian). The `u64` contains the number of missing bytes.
bmp_missing_palette_bytes,
/// `number` is populated and contains a string index for which the string contains
/// the bytes of a `u64` (native endian). The `u64` contains the number of miscompiled bytes.
rc_would_miscompile_bmp_palette_padding,
/// `number` is populated and contains a string index for which the string contains
/// the bytes of two `u64`s (native endian). The first contains the number of missing
/// palette bytes and the second contains the max number of missing palette bytes.
/// If type is `.note`, then `extra` is `none`.
bmp_too_many_missing_palette_bytes,
resource_header_size_exceeds_max,
resource_data_size_exceeds_max,
control_extra_data_size_exceeds_max,
version_node_size_exceeds_max,
fontdir_size_exceeds_max,
/// `number` is populated and contains a string index for the filename
number_expression_as_filename,
/// `number` is populated and contains the control ID that is a duplicate
control_id_already_defined,
/// `number` is populated and contains the disallowed codepoint
invalid_filename,
/// `statement_with_u16_param` is populated
rc_would_error_u16_with_l_suffix,
result_contains_fontdir,
/// `number` is populated and contains the ordinal value that the id would be miscompiled to
rc_would_miscompile_dialog_menu_id,
/// `number` is populated and contains the ordinal value that the value would be miscompiled to
rc_would_miscompile_dialog_class,
/// `menu_or_class` is populated and contains the type of the parameter statement
rc_would_miscompile_dialog_menu_or_class_id_forced_ordinal,
rc_would_miscompile_dialog_menu_id_starts_with_digit,
dialog_menu_id_was_uppercased,
/// `menu_or_class` is populated and contains the type of the parameter statement
duplicate_menu_or_class_skipped,
invalid_digit_character_in_ordinal,
// Literals
/// `number` is populated
rc_would_miscompile_codepoint_byte_swap,
/// `number` is populated
rc_would_miscompile_codepoint_skip,
tab_converted_to_spaces,
// General (used in various places)
/// `number` is populated and contains the value that the ordinal would have in the Win32 RC compiler implementation
win32_non_ascii_ordinal,
// Initialization
/// `file_open_error` is populated, but `filename_string_index` is not
failed_to_open_cwd,
};
pub fn render(self: ErrorDetails, writer: anytype, source: []const u8, strings: []const []const u8) !void {
switch (self.err) {
.unfinished_string_literal => {
return writer.print("unfinished string literal at '{s}', expected closing '\"'", .{self.token.nameForErrorDisplay(source)});
},
.string_literal_too_long => {
return writer.print("string literal too long (max is currently {} characters)", .{self.extra.number});
},
.invalid_number_with_exponent => {
return writer.print("base 10 number literal with exponent is not allowed: {s}", .{self.token.slice(source)});
},
.invalid_digit_character_in_number_literal => switch (self.type) {
.err, .warning => return writer.writeAll("non-ASCII digit characters are not allowed in number literals"),
.note => return writer.writeAll("the Win32 RC compiler allows non-ASCII digit characters, but will miscompile them"),
.hint => return,
},
.illegal_byte => {
return writer.print("character '{s}' is not allowed", .{std.fmt.fmtSliceEscapeUpper(self.token.slice(source))});
},
.illegal_byte_outside_string_literals => {
return writer.print("character '{s}' is not allowed outside of string literals", .{std.fmt.fmtSliceEscapeUpper(self.token.slice(source))});
},
.illegal_codepoint_outside_string_literals => {
// This is somewhat hacky, but we know that:
// - This error is only possible with codepoints outside of the Windows-1252 character range
// - So, the only supported code page that could generate this error is UTF-8
// Therefore, we just assume the token bytes are UTF-8 and decode them to get the illegal
// codepoint.
//
// FIXME: Support other code pages if they become relevant
const bytes = self.token.slice(source);
const codepoint = std.unicode.utf8Decode(bytes) catch unreachable;
return writer.print("codepoint <U+{X:0>4}> is not allowed outside of string literals", .{codepoint});
},
.illegal_byte_order_mark => {
return writer.writeAll("byte order mark <U+FEFF> is not allowed");
},
.illegal_private_use_character => {
return writer.writeAll("private use character <U+E000> is not allowed");
},
.found_c_style_escaped_quote => {
return writer.writeAll("escaping quotes with \\\" is not allowed (use \"\" instead)");
},
.code_page_pragma_missing_left_paren => {
return writer.writeAll("expected left parenthesis after 'code_page' in #pragma code_page");
},
.code_page_pragma_missing_right_paren => {
return writer.writeAll("expected right parenthesis after '<number>' in #pragma code_page");
},
.code_page_pragma_invalid_code_page => {
return writer.writeAll("invalid or unknown code page in #pragma code_page");
},
.code_page_pragma_not_integer => {
return writer.writeAll("code page is not a valid integer in #pragma code_page");
},
.code_page_pragma_overflow => {
return writer.writeAll("code page too large in #pragma code_page");
},
.code_page_pragma_unsupported_code_page => {
// We know that the token slice is a well-formed #pragma code_page(N), so
// we can skip to the first ( and then get the number that follows
const token_slice = self.token.slice(source);
var number_start = std.mem.indexOfScalar(u8, token_slice, '(').? + 1;
while (std.ascii.isWhitespace(token_slice[number_start])) {
number_start += 1;
}
var number_slice = token_slice[number_start..number_start];
while (std.ascii.isDigit(token_slice[number_start + number_slice.len])) {
number_slice.len += 1;
}
const number = std.fmt.parseUnsigned(u16, number_slice, 10) catch unreachable;
const code_page = CodePage.getByIdentifier(number) catch unreachable;
// TODO: Improve or maybe add a note making it more clear that the code page
// is valid and that the code page is unsupported purely due to a limitation
// in this compiler.
return writer.print("unsupported code page '{s} (id={})' in #pragma code_page", .{ @tagName(code_page), number });
},
.unfinished_raw_data_block => {
return writer.print("unfinished raw data block at '{s}', expected closing '}}' or 'END'", .{self.token.nameForErrorDisplay(source)});
},
.unfinished_string_table_block => {
return writer.print("unfinished STRINGTABLE block at '{s}', expected closing '}}' or 'END'", .{self.token.nameForErrorDisplay(source)});
},
.expected_token => {
return writer.print("expected '{s}', got '{s}'", .{ self.extra.expected.nameForErrorDisplay(), self.token.nameForErrorDisplay(source) });
},
.expected_something_else => {
try writer.writeAll("expected ");
try self.extra.expected_types.writeCommaSeparated(writer);
return writer.print("; got '{s}'", .{self.token.nameForErrorDisplay(source)});
},
.resource_type_cant_use_raw_data => switch (self.type) {
.err, .warning => try writer.print("expected '<filename>', found '{s}' (resource type '{s}' can't use raw data)", .{ self.token.nameForErrorDisplay(source), self.extra.resource.nameForErrorDisplay() }),
.note => try writer.print("if '{s}' is intended to be a filename, it must be specified as a quoted string literal", .{self.token.nameForErrorDisplay(source)}),
.hint => return,
},
.id_must_be_ordinal => {
try writer.print("id of resource type '{s}' must be an ordinal (u16), got '{s}'", .{ self.extra.resource.nameForErrorDisplay(), self.token.nameForErrorDisplay(source) });
},
.name_or_id_not_allowed => {
try writer.print("name or id is not allowed for resource type '{s}'", .{self.extra.resource.nameForErrorDisplay()});
},
.string_resource_as_numeric_type => switch (self.type) {
.err, .warning => try writer.writeAll("the number 6 (RT_STRING) cannot be used as a resource type"),
.note => try writer.writeAll("using RT_STRING directly likely results in an invalid .res file, use a STRINGTABLE instead"),
.hint => return,
},
.ascii_character_not_equivalent_to_virtual_key_code => {
// TODO: Better wording? This is what the Win32 RC compiler emits.
// This occurs when VIRTKEY and a control code is specified ("^c", etc)
try writer.writeAll("ASCII character not equivalent to virtual key code");
},
.empty_menu_not_allowed => {
try writer.print("empty menu of type '{s}' not allowed", .{self.token.nameForErrorDisplay(source)});
},
.rc_would_miscompile_version_value_padding => switch (self.type) {
.err, .warning => return writer.print("the padding before this quoted string value would be miscompiled by the Win32 RC compiler", .{}),
.note => return writer.print("to avoid the potential miscompilation, consider adding a comma between the key and the quoted string", .{}),
.hint => return,
},
.rc_would_miscompile_version_value_byte_count => switch (self.type) {
.err, .warning => return writer.print("the byte count of this value would be miscompiled by the Win32 RC compiler", .{}),
.note => return writer.print("to avoid the potential miscompilation, do not mix numbers and strings within a value", .{}),
.hint => return,
},
.code_page_pragma_in_included_file => {
try writer.print("#pragma code_page is not supported in an included resource file", .{});
},
.nested_resource_level_exceeds_max => switch (self.type) {
.err, .warning => {
const max = switch (self.extra.resource) {
.versioninfo => parse.max_nested_version_level,
.menu, .menuex => parse.max_nested_menu_level,
else => unreachable,
};
return writer.print("{s} contains too many nested children (max is {})", .{ self.extra.resource.nameForErrorDisplay(), max });
},
.note => return writer.print("max {s} nesting level exceeded here", .{self.extra.resource.nameForErrorDisplay()}),
.hint => return,
},
.too_many_dialog_controls_or_toolbar_buttons => switch (self.type) {
.err, .warning => return writer.print("{s} contains too many {s} (max is {})", .{ self.extra.resource.nameForErrorDisplay(), switch (self.extra.resource) {
.toolbar => "buttons",
else => "controls",
}, std.math.maxInt(u16) }),
.note => return writer.print("maximum number of {s} exceeded here", .{switch (self.extra.resource) {
.toolbar => "buttons",
else => "controls",
}}),
.hint => return,
},
.nested_expression_level_exceeds_max => switch (self.type) {
.err, .warning => return writer.print("expression contains too many syntax levels (max is {})", .{parse.max_nested_expression_level}),
.note => return writer.print("maximum expression level exceeded here", .{}),
.hint => return,
},
.close_paren_expression => {
try writer.writeAll("the Win32 RC compiler would accept ')' as a valid expression, but it would be skipped over and potentially lead to unexpected outcomes");
},
.unary_plus_expression => {
try writer.writeAll("the Win32 RC compiler may accept '+' as a unary operator here, but it is not supported in this implementation; consider omitting the unary +");
},
.rc_could_miscompile_control_params => switch (self.type) {
.err, .warning => return writer.print("this token could be erroneously skipped over by the Win32 RC compiler", .{}),
.note => return writer.print("to avoid the potential miscompilation, consider adding a comma after the style parameter", .{}),
.hint => return,
},
.string_already_defined => switch (self.type) {
.err, .warning => {
const language_id = self.extra.string_and_language.language.asInt();
const language_name = language_name: {
if (std.meta.intToEnum(lang.LanguageId, language_id)) |lang_enum_val| {
break :language_name @tagName(lang_enum_val);
} else |_| {}
if (language_id == lang.LOCALE_CUSTOM_UNSPECIFIED) {
break :language_name "LOCALE_CUSTOM_UNSPECIFIED";
}
break :language_name "<UNKNOWN>";
};
return writer.print("string with id {d} (0x{X}) already defined for language {s} (0x{X})", .{ self.extra.string_and_language.id, self.extra.string_and_language.id, language_name, language_id });
},
.note => return writer.print("previous definition of string with id {d} (0x{X}) here", .{ self.extra.string_and_language.id, self.extra.string_and_language.id }),
.hint => return,
},
.font_id_already_defined => switch (self.type) {
.err => return writer.print("font with id {d} already defined", .{self.extra.number}),
.warning => return writer.print("skipped duplicate font with id {d}", .{self.extra.number}),
.note => return writer.print("previous definition of font with id {d} here", .{self.extra.number}),
.hint => return,
},
.file_open_error => {
try writer.print("unable to open file '{s}': {s}", .{ strings[self.extra.file_open_error.filename_string_index], @tagName(self.extra.file_open_error.err) });
},
.invalid_accelerator_key => {
try writer.print("invalid accelerator key '{s}': {s}", .{ self.token.nameForErrorDisplay(source), @tagName(self.extra.accelerator_error.err) });
},
.accelerator_type_required => {
try writer.print("accelerator type [ASCII or VIRTKEY] required when key is an integer", .{});
},
.rc_would_miscompile_control_padding => switch (self.type) {
.err, .warning => return writer.print("the padding before this control would be miscompiled by the Win32 RC compiler (it would insert 2 extra bytes of padding)", .{}),
.note => return writer.print("to avoid the potential miscompilation, consider removing any 'control data' blocks from the controls in this dialog", .{}),
.hint => return,
},
.rc_would_miscompile_control_class_ordinal => switch (self.type) {
.err, .warning => return writer.print("the control class of this CONTROL would be miscompiled by the Win32 RC compiler", .{}),
.note => return writer.print("to avoid the potential miscompilation, consider specifying the control class using a string (BUTTON, EDIT, etc) instead of a number", .{}),
.hint => return,
},
.rc_would_error_on_icon_dir => switch (self.type) {
.err, .warning => return writer.print("the resource at index {} of this {s} has the format '{s}'; this would be an error in the Win32 RC compiler", .{ self.extra.icon_dir.index, @tagName(self.extra.icon_dir.icon_type), @tagName(self.extra.icon_dir.icon_format) }),
.note => {
// The only note supported is one specific to exactly this combination
if (!(self.extra.icon_dir.icon_type == .icon and self.extra.icon_dir.icon_format == .riff)) unreachable;
try writer.print("animated RIFF icons within resource groups may not be well supported, consider using an animated icon file (.ani) instead", .{});
},
.hint => return,
},
.format_not_supported_in_icon_dir => {
try writer.print("resource with format '{s}' (at index {}) is not allowed in {s} resource groups", .{ @tagName(self.extra.icon_dir.icon_format), self.extra.icon_dir.index, @tagName(self.extra.icon_dir.icon_type) });
},
.icon_dir_and_resource_type_mismatch => {
const unexpected_type: rc.Resource = if (self.extra.resource == .icon) .cursor else .icon;
// TODO: Better wording
try writer.print("resource type '{s}' does not match type '{s}' specified in the file", .{ self.extra.resource.nameForErrorDisplay(), unexpected_type.nameForErrorDisplay() });
},
.icon_read_error => {
try writer.print("unable to read {s} file '{s}': {s}", .{ @tagName(self.extra.icon_read_error.icon_type), strings[self.extra.icon_read_error.filename_string_index], @tagName(self.extra.icon_read_error.err) });
},
.rc_would_error_on_bitmap_version => switch (self.type) {
.err => try writer.print("the DIB at index {} of this {s} is of version '{s}'; this version is no longer allowed and should be upgraded to '{s}'", .{
self.extra.icon_dir.index,
@tagName(self.extra.icon_dir.icon_type),
self.extra.icon_dir.bitmap_version.nameForErrorDisplay(),
ico.BitmapHeader.Version.@"nt3.1".nameForErrorDisplay(),
}),
.warning => try writer.print("the DIB at index {} of this {s} is of version '{s}'; this would be an error in the Win32 RC compiler", .{
self.extra.icon_dir.index,
@tagName(self.extra.icon_dir.icon_type),
self.extra.icon_dir.bitmap_version.nameForErrorDisplay(),
}),
.note => unreachable,
.hint => return,
},
.max_icon_ids_exhausted => switch (self.type) {
.err, .warning => try writer.print("maximum global icon/cursor ids exhausted (max is {})", .{std.math.maxInt(u16) - 1}),
.note => try writer.print("maximum icon/cursor id exceeded at index {} of this {s}", .{ self.extra.icon_dir.index, @tagName(self.extra.icon_dir.icon_type) }),
.hint => return,
},
.bmp_read_error => {
try writer.print("invalid bitmap file '{s}': {s}", .{ strings[self.extra.bmp_read_error.filename_string_index], @tagName(self.extra.bmp_read_error.err) });
},
.bmp_ignored_palette_bytes => {
const bytes = strings[self.extra.number];
const ignored_bytes = std.mem.readInt(u64, bytes[0..8], native_endian);
try writer.print("bitmap has {d} extra bytes preceding the pixel data which will be ignored", .{ignored_bytes});
},
.bmp_missing_palette_bytes => {
const bytes = strings[self.extra.number];
const missing_bytes = std.mem.readInt(u64, bytes[0..8], native_endian);
try writer.print("bitmap has {d} missing color palette bytes which will be padded with zeroes", .{missing_bytes});
},
.rc_would_miscompile_bmp_palette_padding => {
const bytes = strings[self.extra.number];
const miscompiled_bytes = std.mem.readInt(u64, bytes[0..8], native_endian);
try writer.print("the missing color palette bytes would be miscompiled by the Win32 RC compiler (the added padding bytes would include {d} bytes of the pixel data)", .{miscompiled_bytes});
},
.bmp_too_many_missing_palette_bytes => switch (self.type) {
.err, .warning => {
const bytes = strings[self.extra.number];
const missing_bytes = std.mem.readInt(u64, bytes[0..8], native_endian);
const max_missing_bytes = std.mem.readInt(u64, bytes[8..16], native_endian);
try writer.print("bitmap has {} missing color palette bytes which exceeds the maximum of {}", .{ missing_bytes, max_missing_bytes });
},
// TODO: command line option
.note => try writer.writeAll("the maximum number of missing color palette bytes is configurable via <<TODO command line option>>"),
.hint => return,
},
.resource_header_size_exceeds_max => {
try writer.print("resource's header length exceeds maximum of {} bytes", .{std.math.maxInt(u32)});
},
.resource_data_size_exceeds_max => switch (self.type) {
.err, .warning => return writer.print("resource's data length exceeds maximum of {} bytes", .{std.math.maxInt(u32)}),
.note => return writer.print("maximum data length exceeded here", .{}),
.hint => return,
},
.control_extra_data_size_exceeds_max => switch (self.type) {
.err, .warning => try writer.print("control data length exceeds maximum of {} bytes", .{std.math.maxInt(u16)}),
.note => return writer.print("maximum control data length exceeded here", .{}),
.hint => return,
},
.version_node_size_exceeds_max => switch (self.type) {
.err, .warning => return writer.print("version node tree size exceeds maximum of {} bytes", .{std.math.maxInt(u16)}),
.note => return writer.print("maximum tree size exceeded while writing this child", .{}),
.hint => return,
},
.fontdir_size_exceeds_max => switch (self.type) {
.err, .warning => return writer.print("FONTDIR data length exceeds maximum of {} bytes", .{std.math.maxInt(u32)}),
.note => return writer.writeAll("this is likely due to the size of the combined lengths of the device/face names of all FONT resources"),
.hint => return,
},
.number_expression_as_filename => switch (self.type) {
.err, .warning => return writer.writeAll("filename cannot be specified using a number expression, consider using a quoted string instead"),
.note => return writer.print("the Win32 RC compiler would evaluate this number expression as the filename '{s}'", .{strings[self.extra.number]}),
.hint => return,
},
.control_id_already_defined => switch (self.type) {
.err, .warning => return writer.print("control with id {d} already defined for this dialog", .{self.extra.number}),
.note => return writer.print("previous definition of control with id {d} here", .{self.extra.number}),
.hint => return,
},
.invalid_filename => {
const disallowed_codepoint = self.extra.number;
if (disallowed_codepoint < 128 and std.ascii.isPrint(@intCast(disallowed_codepoint))) {
try writer.print("evaluated filename contains a disallowed character: '{c}'", .{@as(u8, @intCast(disallowed_codepoint))});
} else {
try writer.print("evaluated filename contains a disallowed codepoint: <U+{X:0>4}>", .{disallowed_codepoint});
}
},
.rc_would_error_u16_with_l_suffix => switch (self.type) {
.err, .warning => return writer.print("this {s} parameter would be an error in the Win32 RC compiler", .{@tagName(self.extra.statement_with_u16_param)}),
.note => return writer.writeAll("to avoid the error, remove any L suffixes from numbers within the parameter"),
.hint => return,
},
.result_contains_fontdir => return,
.rc_would_miscompile_dialog_menu_id => switch (self.type) {
.err, .warning => return writer.print("the id of this menu would be miscompiled by the Win32 RC compiler", .{}),
.note => return writer.print("the Win32 RC compiler would evaluate the id as the ordinal/number value {d}", .{self.extra.number}),
.hint => return,
},
.rc_would_miscompile_dialog_class => switch (self.type) {
.err, .warning => return writer.print("this class would be miscompiled by the Win32 RC compiler", .{}),
.note => return writer.print("the Win32 RC compiler would evaluate it as the ordinal/number value {d}", .{self.extra.number}),
.hint => return,
},
.rc_would_miscompile_dialog_menu_or_class_id_forced_ordinal => switch (self.type) {
.err, .warning => return,
.note => return writer.print("to avoid the potential miscompilation, only specify one {s} per dialog resource", .{@tagName(self.extra.menu_or_class)}),
.hint => return,
},
.rc_would_miscompile_dialog_menu_id_starts_with_digit => switch (self.type) {
.err, .warning => return,
.note => return writer.writeAll("to avoid the potential miscompilation, the first character of the id should not be a digit"),
.hint => return,
},
.dialog_menu_id_was_uppercased => return,
.duplicate_menu_or_class_skipped => {
return writer.print("this {s} was ignored; when multiple {s} statements are specified, only the last takes precedence", .{
@tagName(self.extra.menu_or_class),
@tagName(self.extra.menu_or_class),
});
},
.invalid_digit_character_in_ordinal => {
return writer.writeAll("non-ASCII digit characters are not allowed in ordinal (number) values");
},
.rc_would_miscompile_codepoint_byte_swap => switch (self.type) {
.err, .warning => return writer.print("codepoint U+{X} within a string literal would be miscompiled by the Win32 RC compiler (the bytes of the UTF-16 code unit would be swapped)", .{self.extra.number}),
.note => return writer.print("to avoid the potential miscompilation, an integer escape sequence in a wide string literal could be used instead: L\"\\x{X}\"", .{self.extra.number}),
.hint => return,
},
.rc_would_miscompile_codepoint_skip => switch (self.type) {
.err, .warning => return writer.print("codepoint U+{X} within a string literal would be miscompiled by the Win32 RC compiler (the codepoint would be missing from the compiled resource)", .{self.extra.number}),
.note => return writer.print("to avoid the potential miscompilation, an integer escape sequence in a wide string literal could be used instead: L\"\\x{X}\"", .{self.extra.number}),
.hint => return,
},
.tab_converted_to_spaces => switch (self.type) {
.err, .warning => return writer.writeAll("the tab character(s) in this string will be converted into a variable number of spaces (determined by the column of the tab character in the .rc file)"),
.note => return writer.writeAll("to include the tab character itself in a string, the escape sequence \\t should be used"),
.hint => return,
},
.win32_non_ascii_ordinal => switch (self.type) {
.err, .warning => unreachable,
.note => return writer.print("the Win32 RC compiler would accept this as an ordinal but its value would be {}", .{self.extra.number}),
.hint => return,
},
.failed_to_open_cwd => {
try writer.print("failed to open CWD for compilation: {s}", .{@tagName(self.extra.file_open_error.err)});
},
}
}
pub const VisualTokenInfo = struct {
before_len: usize,
point_offset: usize,
after_len: usize,
};
pub fn visualTokenInfo(self: ErrorDetails, source_line_start: usize, source_line_end: usize) VisualTokenInfo {
// Note: A perfect solution here would involve full grapheme cluster
// awareness, but oh well. This will give incorrect offsets
// if there are any multibyte codepoints within the relevant span,
// and even more inflated for grapheme clusters.
//
// We mitigate this slightly when we know we'll be pointing at
// something that displays as 1 character.
return switch (self.err) {
// These can technically be more than 1 byte depending on encoding,
// but they always refer to one visual character/grapheme.
.illegal_byte,
.illegal_byte_outside_string_literals,
.illegal_codepoint_outside_string_literals,
.illegal_byte_order_mark,
.illegal_private_use_character,
=> .{
.before_len = 0,
.point_offset = self.token.start - source_line_start,
.after_len = 0,
},
else => .{
.before_len = before: {
const start = @max(source_line_start, if (self.token_span_start) |span_start| span_start.start else self.token.start);
break :before self.token.start - start;
},
.point_offset = self.token.start - source_line_start,
.after_len = after: {
const end = @min(source_line_end, if (self.token_span_end) |span_end| span_end.end else self.token.end);
// end may be less than start when pointing to EOF
if (end <= self.token.start) break :after 0;
break :after end - self.token.start - 1;
},
},
};
}
};
pub fn renderErrorMessage(allocator: std.mem.Allocator, writer: anytype, tty_config: std.io.tty.Config, cwd: std.fs.Dir, err_details: ErrorDetails, source: []const u8, strings: []const []const u8, source_mappings: ?SourceMappings) !void {
if (err_details.type == .hint) return;
const source_line_start = err_details.token.getLineStartForErrorDisplay(source);
// Treat tab stops as 1 column wide for error display purposes,
// and add one to get a 1-based column
const column = err_details.token.calculateColumn(source, 1, source_line_start) + 1;
const corresponding_span: ?SourceMappings.CorrespondingSpan = if (source_mappings) |mappings|
mappings.getCorrespondingSpan(err_details.token.line_number)
else
null;
const corresponding_file: ?[]const u8 = if (source_mappings != null and corresponding_span != null)
source_mappings.?.files.get(corresponding_span.?.filename_offset)
else
null;
const err_line = if (corresponding_span) |span| span.start_line else err_details.token.line_number;
try tty_config.setColor(writer, .bold);
if (corresponding_file) |file| {
try writer.writeAll(file);
} else {
try tty_config.setColor(writer, .dim);
try writer.writeAll("<after preprocessor>");
try tty_config.setColor(writer, .reset);
try tty_config.setColor(writer, .bold);
}
try writer.print(":{d}:{d}: ", .{ err_line, column });
switch (err_details.type) {
.err => {
try tty_config.setColor(writer, .red);
try writer.writeAll("error: ");
},
.warning => {
try tty_config.setColor(writer, .yellow);
try writer.writeAll("warning: ");
},
.note => {
try tty_config.setColor(writer, .cyan);
try writer.writeAll("note: ");
},
.hint => unreachable,
}
try tty_config.setColor(writer, .reset);
try tty_config.setColor(writer, .bold);
try err_details.render(writer, source, strings);
try writer.writeByte('\n');
try tty_config.setColor(writer, .reset);
if (!err_details.print_source_line) {
try writer.writeByte('\n');
return;
}
const source_line = err_details.token.getLineForErrorDisplay(source, source_line_start);
const visual_info = err_details.visualTokenInfo(source_line_start, source_line_start + source_line.len);
// Need this to determine if the 'line originated from' note is worth printing
var source_line_for_display_buf = try std.ArrayList(u8).initCapacity(allocator, source_line.len);
defer source_line_for_display_buf.deinit();
try writeSourceSlice(source_line_for_display_buf.writer(), source_line);
// TODO: General handling of long lines, not tied to this specific error
if (err_details.err == .string_literal_too_long) {
const before_slice = source_line[0..@min(source_line.len, visual_info.point_offset + 16)];
try writeSourceSlice(writer, before_slice);
try tty_config.setColor(writer, .dim);
try writer.writeAll("<...truncated...>");
try tty_config.setColor(writer, .reset);
} else {
try writer.writeAll(source_line_for_display_buf.items);
}
try writer.writeByte('\n');
try tty_config.setColor(writer, .green);
const num_spaces = visual_info.point_offset - visual_info.before_len;
try writer.writeByteNTimes(' ', num_spaces);
try writer.writeByteNTimes('~', visual_info.before_len);
try writer.writeByte('^');
if (visual_info.after_len > 0) {
var num_squiggles = visual_info.after_len;
if (err_details.err == .string_literal_too_long) {
num_squiggles = @min(num_squiggles, 15);
}
try writer.writeByteNTimes('~', num_squiggles);
}
try writer.writeByte('\n');
try tty_config.setColor(writer, .reset);
if (corresponding_span != null and corresponding_file != null) {
var corresponding_lines = try CorrespondingLines.init(allocator, cwd, err_details, source_line_for_display_buf.items, corresponding_span.?, corresponding_file.?);
defer corresponding_lines.deinit(allocator);
if (!corresponding_lines.worth_printing_note) return;
try tty_config.setColor(writer, .bold);
if (corresponding_file) |file| {
try writer.writeAll(file);
} else {
try tty_config.setColor(writer, .dim);
try writer.writeAll("<after preprocessor>");
try tty_config.setColor(writer, .reset);
try tty_config.setColor(writer, .bold);
}
try writer.print(":{d}:{d}: ", .{ err_line, column });
try tty_config.setColor(writer, .cyan);
try writer.writeAll("note: ");
try tty_config.setColor(writer, .reset);
try tty_config.setColor(writer, .bold);
try writer.writeAll("this line originated from line");
if (corresponding_span.?.start_line != corresponding_span.?.end_line) {
try writer.print("s {}-{}", .{ corresponding_span.?.start_line, corresponding_span.?.end_line });
} else {
try writer.print(" {}", .{corresponding_span.?.start_line});
}
try writer.print(" of file '{s}'\n", .{corresponding_file.?});
try tty_config.setColor(writer, .reset);
if (!corresponding_lines.worth_printing_lines) return;
if (corresponding_lines.lines_is_error_message) {
try tty_config.setColor(writer, .red);
try writer.writeAll(" | ");
try tty_config.setColor(writer, .reset);
try tty_config.setColor(writer, .dim);
try writer.writeAll(corresponding_lines.lines.items);
try tty_config.setColor(writer, .reset);
try writer.writeAll("\n\n");
return;
}
try writer.writeAll(corresponding_lines.lines.items);
try writer.writeAll("\n\n");
}
}
const CorrespondingLines = struct {
worth_printing_note: bool = true,
worth_printing_lines: bool = true,
lines: std.ArrayListUnmanaged(u8) = .empty,
lines_is_error_message: bool = false,
pub fn init(allocator: std.mem.Allocator, cwd: std.fs.Dir, err_details: ErrorDetails, lines_for_comparison: []const u8, corresponding_span: SourceMappings.CorrespondingSpan, corresponding_file: []const u8) !CorrespondingLines {
var corresponding_lines = CorrespondingLines{};
// We don't do line comparison for this error, so don't print the note if the line
// number is different
if (err_details.err == .string_literal_too_long and err_details.token.line_number == corresponding_span.start_line) {
corresponding_lines.worth_printing_note = false;
return corresponding_lines;
}
// Don't print the originating line for this error, we know it's really long
if (err_details.err == .string_literal_too_long) {
corresponding_lines.worth_printing_lines = false;
return corresponding_lines;
}
var writer = corresponding_lines.lines.writer(allocator);
if (utils.openFileNotDir(cwd, corresponding_file, .{})) |file| {
defer file.close();
var buffered_reader = std.io.bufferedReader(file.reader());
writeLinesFromStream(writer, buffered_reader.reader(), corresponding_span.start_line, corresponding_span.end_line) catch |err| switch (err) {
error.LinesNotFound => {
corresponding_lines.lines.clearRetainingCapacity();
try writer.print("unable to print line(s) from file: {s}", .{@errorName(err)});
corresponding_lines.lines_is_error_message = true;
return corresponding_lines;
},
else => |e| return e,
};
} else |err| {
corresponding_lines.lines.clearRetainingCapacity();
try writer.print("unable to print line(s) from file: {s}", .{@errorName(err)});
corresponding_lines.lines_is_error_message = true;
return corresponding_lines;
}
// If the lines are the same as they were before preprocessing, skip printing the note entirely
if (std.mem.eql(u8, lines_for_comparison, corresponding_lines.lines.items)) {
corresponding_lines.worth_printing_note = false;
}
return corresponding_lines;
}
pub fn deinit(self: *CorrespondingLines, allocator: std.mem.Allocator) void {
self.lines.deinit(allocator);
}
};
fn writeSourceSlice(writer: anytype, slice: []const u8) !void {
for (slice) |c| try writeSourceByte(writer, c);
}
inline fn writeSourceByte(writer: anytype, byte: u8) !void {
switch (byte) {
'\x00'...'\x08', '\x0E'...'\x1F', '\x7F' => try writer.writeAll("<EFBFBD>"),
// \r is seemingly ignored by the RC compiler so skipping it when printing source lines
// could help avoid confusing output (e.g. RC\rDATA if printed verbatim would show up
// in the console as DATA but the compiler reads it as RCDATA)
//
// NOTE: This is irrelevant when using the clang preprocessor, because unpaired \r
// characters get converted to \n, but may become relevant if another
// preprocessor is used instead.
'\r' => {},
'\t', '\x0B', '\x0C' => try writer.writeByte(' '),
else => try writer.writeByte(byte),
}
}
pub fn writeLinesFromStream(writer: anytype, input: anytype, start_line: usize, end_line: usize) !void {
var line_num: usize = 1;
var last_byte: u8 = 0;
while (try readByteOrEof(input)) |byte| {
switch (byte) {
'\n', '\r' => {
if (!utils.isLineEndingPair(last_byte, byte)) {
if (line_num == end_line) return;
if (line_num >= start_line) try writeSourceByte(writer, byte);
line_num += 1;
} else {
// reset last_byte to a non-line ending so that
// consecutive CRLF pairs don't get treated as one
// long line ending 'pair'
last_byte = 0;
continue;
}
},
else => {
if (line_num >= start_line) try writeSourceByte(writer, byte);
},
}
last_byte = byte;
}
if (line_num != end_line) {
return error.LinesNotFound;
}
}
pub fn readByteOrEof(reader: anytype) !?u8 {
return reader.readByte() catch |err| switch (err) {
error.EndOfStream => return null,
else => |e| return e,
};
}