Nixyri/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2024-11-15 08:33:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

macho: do not leave file descriptors open if unused

Browse Source 
This manifested in different `AccessDenied` errors on Windows when
trying to do an atomic file copying in the compiler/linker.
This commit is contained in:
Jakub Konka 2022-08-20 17:34:34 +02:00
parent e5e6eb9831
commit 4a98385b0a
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/link/MachO.zig
View File

@ -273,7 +273,7 @@ pub fn openPath(allocator: Allocator, options: link.Options) !*MachO {
assert(options.target.ofmt == .macho);
const use_stage1 = build_options.have_stage1 and options.use_stage1;
if (use_stage1 or options.emit == null) {
if (use_stage1 or options.emit == null or options.module == null) {
return createEmpty(allocator, options);
}
@ -293,11 +293,11 @@ pub fn openPath(allocator: Allocator, options: link.Options) !*MachO {
});
}
if (options.output_mode == .Lib and
options.link_mode == .Static and self.base.intermediary_basename != null)
{
return self;
}
if (self.base.intermediary_basename != null) switch (options.output_mode) {
.Obj => return self,
.Lib => if (options.link_mode == .Static) return self,
else => {},
};
const file = try emit.directory.handle.createFile(emit.sub_path, .{
.truncate = false,