Nixyri/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2024-11-15 00:26:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_runner: workaround #1923, isolating error traces in tests

Browse Source 
Essentially #1923 means "caught" errors still show up in error return traces.
The correct fix would require the compiler to fix this, but that could affect performance.

For now, simply workaround this issue by clearing the return traces
between tests.

This means that "caught" errors in one test will not show up in the
error traces of other tests.
This commit is contained in:
Techcable 2022-08-22 04:38:03 -07:00 committed by GitHub
parent 8667d6d61e
commit 1a32f2a7f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/test_runner.zig
View File

@ -96,6 +96,13 @@ pub fn main() void {
test_node.end();
},
}
// Workaround issue #1923 by clearing error stack traces between tests
//
// This is not a true fix, but helps isolate errors to the tests where they
// originate instead of confusing them all together
if (@errorReturnTrace()) |trace| {
trace.index = 0;
}
}
root_node.end();
if (ok_count == test_fn_list.len) {