Godot Engine – Multi-platform 2D and 3D game engine
Go to file
Rémi Verschelde fd6453c45e Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED"
This reverts commit 4b817a565c.

Fixes #64988.
Fixes #64997.

This caused several regressions (#64988, #64997,
https://github.com/godotengine/godot/issues/64997#issuecomment-1229970605)
which point at a flaw in the current logic:

- `Control::NOTIFICATION_ENTER_TREE` triggers a *deferred* notification with
  `NOTIFCATION_THEME_CHANGED` as introduced in #62845.
- Some classes use their `THEME_CHANGED` to cache theme items in
  member variables (e.g. `style_normal`, etc.), and use those member
  variables in `ENTER_TREE`, `READY`, `DRAW`, etc. Since the `THEME_CHANGE`
  notification is now deferred, they end up accessing invalid state and this
  can lead to not applying theme properly (e.g. for EditorHelp) or crashing
  (e.g. for EditorLog or CodeEdit).

So we need to go back to the drawing board and see if `THEME_CHANGED` can be
called earlier so that the previous logic still works?

Or can we refactor all engine code to make sure that:
- `ENTER_TREE` and similar do not depend on theme properties cached in member
  variables.
- Or `THEME_CHANGE` does trigger a general UI update to make sure that any
  bad theme handling in `ENTER_TREE` and co. gets fixed when `THEME_CHANGE`
  does arrive for the first time. But that means having a temporary invalid
  (and possibly still crashing) state, and doing some computations twice
  which might be heavy (e.g. `EditorHelp::_update_doc()`).
2022-08-29 11:11:29 +02:00
.github Add dotnet format to CI to check C# style 2022-08-27 10:11:35 +02:00
core [Windows] Improve build environment detection, add support for Windows on ARM. 2022-08-27 16:10:53 +03:00
doc Improve documentation for get_animation() 2022-08-29 14:54:57 +08:00
drivers Merge pull request #64367 from Mickeon/rename-var-to-str 2022-08-26 23:04:06 +02:00
editor Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED" 2022-08-29 11:11:29 +02:00
main Fix forwarding of CLI arguments taking an option 2022-08-25 08:42:59 +02:00
misc Add dotnet format to CI to check C# style 2022-08-27 10:11:35 +02:00
modules Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED" 2022-08-29 11:11:29 +02:00
platform Merge pull request #64943 from MatthewZelriche/FixUnMappedAncestor 2022-08-29 08:19:50 +02:00
scene Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED" 2022-08-29 11:11:29 +02:00
servers Fix updating OccluderPolygon shapes 2022-08-29 03:51:53 +02:00
tests Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED" 2022-08-29 11:11:29 +02:00
thirdparty [Windows] Improve build environment detection, add support for Windows on ARM. 2022-08-27 16:10:53 +03:00
.clang-format Style: Workaround clang-format 14 bug with Inline oneliner functions 2022-08-03 12:20:23 +02:00
.clang-tidy Style: Partially apply clang-tidy's cppcoreguidelines-pro-type-member-init 2022-05-02 16:28:25 +02:00
.editorconfig Add a simple C# .editorconfig 2021-07-23 17:04:53 -04:00
.gitattributes File: Re-add support to skip CR (\r) in File::get_as_text 2022-08-01 00:40:35 +02:00
.gitignore HTML5: Run npm audit fix 2022-05-25 14:56:43 +02:00
.lgtm.yml Create a basic .lgtm.yml file. 2020-09-03 14:49:14 +01:00
.mailmap Update AUTHORS and DONORS list 2022-07-25 16:27:42 +02:00
AUTHORS.md Update AUTHORS and DONORS list 2022-07-25 16:27:42 +02:00
CHANGELOG.md Merge pull request #56286 from Calinou/changelog-shaders-depth-texture 2022-01-05 10:49:18 +01:00
CONTRIBUTING.md Unify bits, arch, and android_arch into env["arch"] 2022-08-25 11:19:20 +02:00
COPYRIGHT.txt etcpak: Update to upstream release 1.0 (June 4, 2022) 2022-06-10 12:36:45 +02:00
DONORS.md Update AUTHORS and DONORS list 2022-07-25 16:27:42 +02:00
gles3_builders.py ci: add basic test pipeline for shader builders 2022-08-19 20:32:13 +09:00
glsl_builders.py ci: add basic test pipeline for shader builders 2022-08-19 20:32:13 +09:00
icon_outlined.png Add an outlined version of logo.png and icon.png and put it in README.md 2020-12-14 06:42:51 +01:00
icon_outlined.svg Add an outlined version of logo.png and icon.png and put it in README.md 2020-12-14 06:42:51 +01:00
icon.png Remove two very slightly displaced duplicate vertices on Gobot's face 2020-12-11 07:05:54 +01:00
icon.svg Remove two very slightly displaced duplicate vertices on Gobot's face 2020-12-11 07:05:54 +01:00
LICENSE.txt Update copyright statements to 2022 2022-01-03 21:27:34 +01:00
LOGO_LICENSE.md Relicense Godot logo from CC-BY-3.0 to CC-BY-4.0 2020-12-03 14:30:06 +01:00
logo_outlined.png Add an outlined version of logo.png and icon.png and put it in README.md 2020-12-14 06:42:51 +01:00
logo_outlined.svg Add an outlined version of logo.png and icon.png and put it in README.md 2020-12-14 06:42:51 +01:00
logo.png Remove two very slightly displaced duplicate vertices on Gobot's face 2020-12-11 07:05:54 +01:00
logo.svg Remove two very slightly displaced duplicate vertices on Gobot's face 2020-12-11 07:05:54 +01:00
methods.py Correct output file names for Visual Studio project generation 2022-08-27 18:51:13 +01:00
platform_methods.py Unify bits, arch, and android_arch into env["arch"] 2022-08-25 11:19:20 +02:00
README.md README updates and improvements, link license page 2021-11-02 02:28:25 +01:00
SConstruct Unify bits, arch, and android_arch into env["arch"] 2022-08-25 11:19:20 +02:00
version.py Bump version to 4.0-alpha 2022-01-23 00:09:08 +01:00

Godot Engine

Godot Engine logo

2D and 3D cross-platform game engine

Godot Engine is a feature-packed, cross-platform game engine to create 2D and 3D games from a unified interface. It provides a comprehensive set of common tools, so that users can focus on making games without having to reinvent the wheel. Games can be exported with one click to a number of platforms, including the major desktop platforms (Linux, macOS, Windows), mobile platforms (Android, iOS), as well as Web-based platforms (HTML5) and consoles.

Free, open source and community-driven

Godot is completely free and open source under the very permissive MIT license. No strings attached, no royalties, nothing. The users' games are theirs, down to the last line of engine code. Godot's development is fully independent and community-driven, empowering users to help shape their engine to match their expectations. It is supported by the Software Freedom Conservancy not-for-profit.

Before being open sourced in February 2014, Godot had been developed by Juan Linietsky and Ariel Manzur (both still maintaining the project) for several years as an in-house engine, used to publish several work-for-hire titles.

Screenshot of a 3D scene in the Godot Engine editor

Getting the engine

Binary downloads

Official binaries for the Godot editor and the export templates can be found on the homepage.

Compiling from source

See the official docs for compilation instructions for every supported platform.

Community and contributing

Godot is not only an engine but an ever-growing community of users and engine developers. The main community channels are listed on the homepage.

The best way to get in touch with the core engine developers is to join the Godot Contributors Chat.

To get started contributing to the project, see the contributing guide.

Documentation and demos

The official documentation is hosted on ReadTheDocs. It is maintained by the Godot community in its own GitHub repository.

The class reference is also accessible from the Godot editor.

We also maintain official demos in their own GitHub repository as well as a list of awesome Godot community resources.

There are also a number of other learning resources provided by the community, such as text and video tutorials, demos, etc. Consult the community channels for more information.

Code Triagers Badge Translate on Weblate Total alerts on LGTM TODOs