Rémi Verschelde
a0bbd398ee
Merge pull request #93008 from aaronp64/container_queue_sort
...
Fix `Container::pending_sort` tracking
2024-06-11 11:53:42 +02:00
Rémi Verschelde
972839d12a
Merge pull request #92968 from bruvzg/rtl_list_indent
...
[RTL] Fix list item prefix width not taken into account.
2024-06-11 11:22:52 +02:00
Rémi Verschelde
7359423b16
Merge pull request #92991 from smix8/navregion_canvas_clear
...
Fix NavigationRegion2D debug not clearing canvas item
2024-06-11 10:49:04 +02:00
Rémi Verschelde
d3c1eb009e
Merge pull request #92908 from bruvzg/fix_main_window_initial_mouseover
...
[Window] Fix mouse hover state of the main window when mouse enter event was sent before setting callbacks.
2024-06-11 10:48:58 +02:00
aaronp64
5a25637ca9
Fix Container::pending_sort tracking
...
When Container::queue_sort() is called, pending_sort is set to true to indicate when a call to _sort_children() is queued, to avoid queueing multiple calls. Container::_sort_children() sets pending_sort back to false when finished, but did not do this when the container was not inside the tree. This would allow cases where queue_sort() could be called just before removing from the tree, causing _sort_children() to never reset pending_sort, preventing any future queue_sort() calls from queueing again.
One case where this happened was with the "Saving Scene" progress bar in the editor - when saving for the first time (or the first time the progress bar popup otherwise appeared in the editor), _sort_children() would be called successfully. After the progress bar popup was hidden, then shown again on future saves, _sort_children() would not be called again, resulting in the progress bar not taking up as much space as it should.
This issue used to be avoided by setting pending_sort to false immediately on NOTIFICATION_ENTER_TREE - however, this would allow multiple calls to be queued at the same time when entering the tree (#92644 ). The multiple calls was fixed recently by removing this assignment, but this also made possible the case where pending_sort is never reset.
This change sets pending_sort back to false in _sort_children() whether or not it's in the tree. Since this is done in a deferred call, it should still avoid the previous issue of multiple calls being queued at once on entering the tree.
Fixes #92971
2024-06-10 20:17:47 -04:00
smix8
6b85bc9de2
Fix NavigationRegion2D debug not clearing canvas item
...
Fixes NavigationRegion2D debug not clearing canvas item on navigation mesh change.
2024-06-10 19:07:57 +02:00
bruvzg
768fd1eacb
[Window] Fix mouse hover state of the main window when mouse enter event was sent before setting callbacks.
2024-06-10 18:43:01 +03:00
bruvzg
721a663aa3
[Button] Adds theme option to align button text and icon to either largest or current stylebox.
2024-06-10 18:40:52 +03:00
Rémi Verschelde
7128667959
Merge pull request #92943 from anniryynanen/less-file-dialogs
...
Fix native file dialogs being shown on `set_visible(false)`
2024-06-10 16:12:11 +02:00
Rémi Verschelde
821338c0d1
Merge pull request #92925 from TokageItLab/concatenated-bone-names
...
Add `get_concatenated_bone_names()` to `Skeleton3D` for `SkeletonModifier3D`'s enum hints
2024-06-10 16:12:08 +02:00
Rémi Verschelde
76b1a1f834
Merge pull request #92896 from TokageItLab/skeleton-mod-get-skeleton
...
Expose `get_skeleton()` from `SkeletonModifier3D`
2024-06-10 16:12:02 +02:00
Rémi Verschelde
3d170c56d6
Merge pull request #92861 from TokageItLab/fix-animation-player-just-after-started
...
Fix seeking Animation immediate after playback for Discrete track
2024-06-10 16:11:55 +02:00
Rémi Verschelde
95b84f1239
Merge pull request #92787 from groud/tilemap_x_sort
...
Implement X-draw-order switch in TileMapLayer
2024-06-10 16:11:48 +02:00
Rémi Verschelde
b7ea8415c2
Merge pull request #91997 from aaronp64/tooltip_transforms
...
Fix tooltip mouse position conversion for scaled controls
2024-06-10 16:11:39 +02:00
Gilles Roudière
c283db2130
Implement X-draw-order switch in TileMapLayer
2024-06-10 15:53:58 +02:00
bruvzg
fff71db5b1
[RTL] Fix list item prefix width not taken into account.
2024-06-10 13:14:56 +03:00
Silc Lizard (Tokage) Renew
a57f9f863d
Add get_concatenated_bone_names() to Skeleton3D for Modifier's hint
2024-06-10 10:19:36 +09:00
Silc Lizard (Tokage) Renew
e92a453840
Expose get_skeleton() from SkeletonModifier3D
2024-06-09 23:58:05 +09:00
Anni Ryynänen
b14b222e9d
Fix native file dialogs being shown on set_visible(false)
2024-06-09 17:54:18 +03:00
Silc Lizard (Tokage) Renew
bea47d877b
Fix seeking Animation immediate after playback for Discrete track
2024-06-08 22:09:37 +09:00
Rémi Verschelde
a6bb8b00d7
Merge pull request #92664 from KoBeWi/ultimate_final_solution_for_containers
...
Add visibilty mode to `as_sortable_control()`
2024-06-07 23:29:48 +02:00
Rémi Verschelde
2c01573fdf
Merge pull request #92645 from WhalesState/container-resort
...
Fix `NOTIFICATION_SORT_CHILDREN` is called twice on startup
2024-06-07 23:29:44 +02:00
Rémi Verschelde
1ee953030e
Merge pull request #92271 from kitbdev/fix-max-line-size
...
Fix TextEdit HScroll hiding after wrapping
2024-06-07 23:29:28 +02:00
Rémi Verschelde
c2d983553b
Merge pull request #91390 from kitbdev/add-selection-unhide-carets
...
Unhide carets in add selection for occurrence and fix error
2024-06-07 23:29:23 +02:00
Rémi Verschelde
5fcd9803cd
Merge pull request #90850 from AlexeyBond/patch-1
...
Handle Vector4 default input values in visual shaders
2024-06-07 23:29:19 +02:00
jsjtxietian
8d888807f7
Sync visual shader's distance fade using circular fade
2024-06-07 11:32:27 +08:00
bruvzg
864a93fdbf
Fix excessive canvas items updates.
2024-06-05 21:01:30 +03:00
Rémi Verschelde
7c2d65ff66
Merge pull request #92745 from bruvzg/rtl_list_fix
...
[RTL] Fix nested ordered lists inside unordered lists.
2024-06-04 10:10:34 +02:00
Rémi Verschelde
0242e3ca9f
Merge pull request #92740 from bruvzg/subvp_ime_activation
...
Fix IME activation in subviewports.
2024-06-04 10:10:30 +02:00
Rémi Verschelde
228564c64b
Merge pull request #92739 from TokageItLab/fix-blend2d-sync
...
Fix BlendSpace2D sync flagging line
2024-06-04 10:10:26 +02:00
Rémi Verschelde
241d45d063
Merge pull request #92731 from bruvzg/vp_oversmpling_upd
...
Force canvas item update on oversampling change.
2024-06-04 10:10:17 +02:00
bruvzg
5e616cedd4
[RTL] Fix nested ordered lists inside unordered lists.
2024-06-04 08:08:16 +03:00
bruvzg
d45b896673
Fix IME activation in subviewports.
2024-06-04 00:03:02 +03:00
Silc Lizard (Tokage) Renew
eacc122f32
Fix BlendSpace2D sync flagging line
2024-06-04 05:52:39 +09:00
kobewi
02e1e6d1ec
Add visibilty mode to as_sortable_control()
2024-06-03 20:01:31 +02:00
bruvzg
9fb9660912
Force canvas item update on oversampling change.
2024-06-03 19:46:49 +03:00
kobewi
be111004dd
Fix default NodePaths saved in scene
2024-06-03 13:10:23 +02:00
Rémi Verschelde
9b4cfcba5f
Merge pull request #92669 from Hilderin/fix-huge-tscn-icon-in-background-of-file-system-panel
...
Fix huge .tscn icon and icon in background of File System panel
2024-06-03 10:36:02 +02:00
Rémi Verschelde
353f7bf6af
Merge pull request #92605 from aaronp64/richtextlabel_table_overlap
...
Fix `RichTextLabel` table overlapping with next line
2024-06-03 10:35:54 +02:00
Rémi Verschelde
41e762ca29
Merge pull request #91454 from akien-mga/coverity-checks
...
Fix Steam input "crc" errors, and some other Coverity reports of uninitialized scalar variable
2024-06-03 10:35:38 +02:00
Hilderin
81395cf9bd
Fix Huge .tscn Icon and icon in background of File System panel
2024-06-02 09:11:56 -04:00
Mounir Tohami
62a58c5538
Fix NOTIFICATION_SORT_CHILDREN is called twice on startup
2024-06-01 15:49:43 +00:00
aaronp64
6ecccd6085
Fix RichTextLabel table overlapping with next line
...
When calculating table height, RichTextLabel::_shape_line would increase the height when it reached the end of a complete row, or the final cell of the table. RichTextLabel::_resize_line would only increase the height at the end of a complete row, causing the height to ignore the final row if not all cells were populated. This would cause the final row to overlap with the following line in the RichTextLabel if it was the last visible line in the RichTextLabel, as _resize_line is called when updating scrolling properties.
This change moves the common table size calculations to a separate function to reuse the code between _shape_line and _resize_line, keeping the final cell check that was used in _shape_line.
Fixes #92603
2024-05-31 16:21:17 -04:00
Rémi Verschelde
3e01ef56f9
Merge pull request #92577 from bruvzg/win_preview_resize
...
Update editor `Window` preview position when resizing window.
2024-05-31 14:16:52 +02:00
Rémi Verschelde
07e6d0c702
Merge pull request #92138 from YeldhamDev/scrollcontainer_fixes
...
Fix scrollbar issues in `ScrollContainer`
2024-05-31 14:16:10 +02:00
Rémi Verschelde
9c87e8c7b4
Merge pull request #91953 from AThousandShips/use_normal_sname
...
Use `CoreStringNames::normal` in more places
2024-05-31 14:16:05 +02:00
Rémi Verschelde
b201c087ab
Merge pull request #91950 from AThousandShips/panel_sname
...
[Scene] Add `SceneStringNames::panel`
2024-05-31 14:16:02 +02:00
Rémi Verschelde
ea4db5c3e1
Merge pull request #91949 from AThousandShips/id_pressed_sname
...
[Scene] Add `SceneStringNames::id_pressed`
2024-05-31 14:15:58 +02:00
Flyn San
67b16f261f
Fix code style for generated shader code from ParticleProcessMaterial
...
The results now match what our clang-format config would do.
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2024-05-31 14:12:41 +02:00
Rémi Verschelde
62120c7841
Fix Steam input "crc" errors, and some other Coverity reports of uninitialized scalar variable
...
- Fixes #88630 .
- Fixes #92578 .
2024-05-31 09:55:02 +02:00
