Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-10 14:12:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix playback position label update in Audio Stream Importer

Browse Source 
The current playback position label doesn't get updated if the playhead is not visible. The label is updated in `_draw_indicator()` at the end of the function, but we return early if the calculated offset falls outside the valid range. This fix moves the label updating above this check, ensuring that the label always gets updated regardless of the visibility of the playhead.

Fixes #86550.

(cherry picked from commit 155bebfdf2)
This commit is contained in:
Alessandro Famà 2024-01-05 12:24:56 +01:00 committed by Rémi Verschelde
parent 3ebb5ea482
commit fddd0a5098
No known key found for this signature in database
GPG Key ID: C3336907360768E1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
editor/import/audio_stream_import_settings.cpp
View File

@ -277,6 +277,8 @@ void AudioStreamImportSettings::_draw_indicator() {
rect.size.height -= y_ofs;
}
_current_label->set_text(String::num(_current, 2).pad_decimals(2) + " /");
float ofs_x = (_current - zoom_bar->get_value()) * rect.size.width / zoom_bar->get_page();
if (ofs_x < 0 || ofs_x >= rect.size.width) {
return;
@ -310,8 +312,6 @@ void AudioStreamImportSettings::_draw_indicator() {
}
}
}
_current_label->set_text(String::num(_current, 2).pad_decimals(2) + " /");
}
void AudioStreamImportSettings::_on_indicator_mouse_exited() {